From: Bernd Schubert <bschubert@ddn.com>
To: Hillf Danton <hdanton@sina.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Miklos Szeredi <miklos@szeredi.hu>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Andrei Vagin <avagin@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: fuse uring / wake_up on the same core
Date: Fri, 5 May 2023 13:10:26 +0000 [thread overview]
Message-ID: <7bc9fdd6-a1b5-505e-3a0b-71a18084cc57@ddn.com> (raw)
In-Reply-To: <20230504021656.3823-1-hdanton@sina.com>
On 5/4/23 04:16, Hillf Danton wrote:
>
>> + time_after(jiffies, p->seesaw_jiffies + 10),
>> + cpumask_test_cpu(cpu, p->cpus_ptr))
>> + return cpu;
Above is a big typo, I don't even see on the first glance how this
compiled at all.
This was supposed to be
if (p->seesaw_req && current->seesaw_proc &&
time_after(jiffies, p->seesaw_jiffies + 10) &&
cpumask_test_cpu(cpu, p->cpus_ptr))
Anyway, I now understand that the WF_TTWU flag is related to waitq - we
don't need the timeout at all. But then if the main issue is about waitq
migration, I don't understand yet why Andrei's WF_CURRENT_CPU is not
sufficient. I'm going to investigate that next. Probably much easier to
get that accepted that a rather fuse specific seesaw.
Thanks,
Bernd
prev parent reply other threads:[~2023-05-05 13:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d0ed1dbd-1b7e-bf98-65c0-7f61dd1a3228@ddn.com>
[not found] ` <20230327102845.GB7701@hirez.programming.kicks-ass.net>
[not found] ` <20230427122417.2452-1-hdanton@sina.com>
[not found] ` <3c0facd0-e3c7-0aa1-8b2e-961120d4f43d@ddn.com>
2023-04-28 1:44 ` Hillf Danton
2023-04-28 21:54 ` Bernd Schubert
2023-04-28 23:37 ` Hillf Danton
2023-05-01 21:44 ` Bernd Schubert
[not found] ` <20230502003335.3253-1-hdanton@sina.com>
2023-05-03 17:04 ` Bernd Schubert
2023-05-04 2:16 ` Hillf Danton
2023-05-05 13:10 ` Bernd Schubert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bc9fdd6-a1b5-505e-3a0b-71a18084cc57@ddn.com \
--to=bschubert@ddn.com \
--cc=avagin@gmail.com \
--cc=hdanton@sina.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox