From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56350C48BF6 for ; Mon, 4 Mar 2024 01:56:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E49816B009F; Sun, 3 Mar 2024 20:56:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF9C96B00A0; Sun, 3 Mar 2024 20:56:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0FF76B00A1; Sun, 3 Mar 2024 20:56:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C2E806B009F for ; Sun, 3 Mar 2024 20:56:05 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5DBDAC096E for ; Mon, 4 Mar 2024 01:56:05 +0000 (UTC) X-FDA: 81857691090.01.8884E09 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf19.hostedemail.com (Postfix) with ESMTP id 1E06E1A0006 for ; Mon, 4 Mar 2024 01:56:01 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709517363; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BBwwS6dpirybJ/C2xiWx1p054rxNJndNCjyA/YO/j7k=; b=ybq2XplWlDXixFE04g/qQ0Hdgm3GwXbWQwAl9/NuoRzsNmBy0LPf901uGH+NtjW0yz/4rS 6StpRNiKAiM1viBScJcLkRZrKHylDeVN2lOTE2c0I6WqX606C5OtmOaC7olzZLqKX50Rr7 z2pgDWnPQajtSWSzB/aTVLggr4rBQU8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709517363; a=rsa-sha256; cv=none; b=ePzcxUIkbRe7IGQ2oScljGr3gII8qsCbopbbiyGJpFBfYEF7/QT0SpVeBr7sXvG/3kgcnq L8TslSy1hJh7A7vuHwiO5oRbQhntgwacpGjOKw3aKRkrHWt+xhg6m5b4Cq4Vv5nC1ERPaY 83uqyKH8QAP+3Gkl92tCSGnzdgVqUZA= Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Tp1v66bHWz1h1FL; Mon, 4 Mar 2024 09:53:38 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id C3D451404F1; Mon, 4 Mar 2024 09:55:57 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 4 Mar 2024 09:55:55 +0800 Subject: Re: [PATCH 0/8] Some cleanups for memory-failure To: Muhammad Usama Anjum CC: , Naoya Horiguchi , Andrew Morton , "Matthew Wilcox (Oracle)" References: <20240229212036.2160900-1-willy@infradead.org> From: Miaohe Lin Message-ID: <7bc457cc-86e6-4d53-22a5-c861edb991f3@huawei.com> Date: Mon, 4 Mar 2024 09:55:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Queue-Id: 1E06E1A0006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jgyr9h3ii8w7ttkmdqpoo1w7kwu95kz5 X-HE-Tag: 1709517361-625128 X-HE-Meta: U2FsdGVkX18rPDvQekJEbo2K1ymVyWbO/FkuwcxnXoEKF7nbTx56CsuecBvMgzoMn0pcJCX/QnTaMYSrYy0J8+N5Cbf8EFoIzFxXSVEF2sfkeE0qCpudQuSnRlkM1nXW1dF2qw/62CtPkL3nWdGYF9W5J9yd7d3QruXoC30H73wztTnKwkCpnX8OIaLorZ6p6mfqJvLd+jQueYKhi5v+UELzON7nrk03qrU2EKQvD3tFiJBujO2f30WjPlfrrBdL20/bVZyYsh5zc/ru7EtQISW0ocVyoTyyT1PePRqKX2sikIedBc2AeRbhTE8x5KPz09G8/Dwmk+QzODYEagX4CgLpvh8BsqCQONpt7UfvrKa4dMS6jbjAgxJhBD/WvAyKcBbG48K7l/xbXzsDQD8REOj01+qGxl3w554z8A16GAUz88V0eMIXg2oNOtJlxITH4SOF1gSj8Hw88dsVPf9j5IBObHuuyCNyP8sXloLVxfIBh1rwQefwPBKSV7TWLhw6upx4/DM0AJdIBqAUu0QHEksp8Mpgp36vFsqGb/LCy4H1ZvsoE1q6Y/3y0SdLl4QbOUni/SIOPXINGe2jVB1Vn50mQQrevM57FKSHWAWbLWy3uxMRSWtfSniN5gCUlyUV8dPyERZO5a5DYfu+Wr+JmSoyE8u/ycu+h+pnFByLG9WMdF7qg6FEDAoVIsZ3d1JtEQHJGl4pe9QSeuarVuqb6m9N0nL8h9n9xKKCFZZ3Sbl0p3hX1zvtIe26hCySYjAiPRJLJzNIrIq6Q1ofpKZOq9shu91gO16Wq8/uwmFTsIododWu/iuonBOJmyesua2Yh0QhLkYoMv9qARKn3nBD7+aJDItDahhEDFyWE0XzB2UVN6dlYzrO3w+N57hta58Sdp7wPjPaYeHgZ9mUdSJqKxsxCPFZq3D1E8VTRGFB5VK4Qn9oWsSu0Q+Oz7+y9+KfJv+VVSUkCPILJ1oQizn 8K2HxeV7 IX/q2Lz+jp4KgLN4BXZ3PCnNtHAIOH5PzA5xfNXn7TihwK/a2QOfHbRRWJBMlZWNyRS4sMXaD6G1Li0fQ9kJ1YVUbYKV2ajwkJBWOjvtxqAv+IVPizule8xTDSpsOZVS/wuSTOEH04OuoD12Cr72hvkN9tg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/1 20:40, Muhammad Usama Anjum wrote: > On 3/1/24 11:28 AM, Miaohe Lin wrote: >> On 2024/3/1 5:20, Matthew Wilcox (Oracle) wrote: >>> This isn't my complete collection of patches to memory-failure, but >>> they're the ones I have the most confidence in. I haven't done any real >>> testing of this beyond compiling & running on a system without trying to >>> do any memory failure injections. Is there a good test-suite I should >>> run before submitting these kinds of patches? >> >> mm_regression[1] should be a good alternative test-suite to run. It's written by >> Naoya Horiguchi and available at https://github.com/nhoriguchi/mm_regression. > Any idea why these tests haven't been added to selftests or ltp? I would try to add some of them to selftests after I have learnt these testcases. Thanks. > >> >>> >>> Matthew Wilcox (Oracle) (8): >>> mm/memory-failure: Remove fsdax_pgoff argument from __add_to_kill >>> mm/memory-failure: Pass addr to __add_to_kill() >>> mm: Return the address from page_mapped_in_vma() >>> mm/memory-failure: Convert shake_page() to shake_folio() >>> mm: Convert hugetlb_page_mapping_lock_write to folio >>> mm/memory-failure: Convert memory_failure() to use a folio >>> mm/memory-failure: Convert hwpoison_user_mappings to take a folio >>> mm/memory-failure: Add some folio conversions to unpoison_memory >> >> Thanks for your patches. I will review them as soon as possible. >> >>> >>> include/linux/hugetlb.h | 6 +- >>> include/linux/mm.h | 1 - >>> include/linux/rmap.h | 2 +- >>> mm/hugetlb.c | 6 +- >>> mm/hwpoison-inject.c | 11 +-- >>> mm/internal.h | 1 + >>> mm/memory-failure.c | 144 +++++++++++++++++++++------------------- >>> mm/migrate.c | 2 +- >>> mm/page_vma_mapped.c | 14 ++-- >>> 9 files changed, 97 insertions(+), 90 deletions(-) >>> >> >> >