From: Rik van Riel <riel@fb.com>
To: Song Liu <songliubraving@fb.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "matthew.wilcox@oracle.com" <matthew.wilcox@oracle.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"Kernel Team" <Kernel-team@fb.com>,
"william.kucharski@oracle.com" <william.kucharski@oracle.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH v5 6/6] mm,thp: avoid writes to file with THP in pagecache
Date: Fri, 21 Jun 2019 00:52:48 +0000 [thread overview]
Message-ID: <7bbcb43070c5b07e5862e2dbdc7155efcae3eb4a.camel@fb.com> (raw)
In-Reply-To: <20190620205348.3980213-7-songliubraving@fb.com>
On Thu, 2019-06-20 at 13:53 -0700, Song Liu wrote:
> In previous patch, an application could put part of its text section
> in
> THP via madvise(). These THPs will be protected from writes when the
> application is still running (TXTBSY). However, after the application
> exits, the file is available for writes.
>
> This patch avoids writes to file THP by dropping page cache for the
> file
> when the file is open for write. A new counter nr_thps is added to
> struct
> address_space. In do_last(), if the file is open for write and
> nr_thps
> is non-zero, we drop page cache for the whole file.
>
> Signed-off-by: Song Liu <songliubraving@fb.com>
Acked-by: Rik van Riel <riel@surriel.com>
The comment for release_file_thp() is a little implementation
specific, which is normally a bad thing (for code we expect
to stick around for years), but probably the right thing for
code that is just a step in the direction we want to go.
Thank you for reworking these patches so quickly.
next prev parent reply other threads:[~2019-06-21 0:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 20:53 [PATCH v5 0/6] Enable THP for text section of non-shmem files Song Liu
2019-06-20 20:53 ` [PATCH v5 1/6] filemap: check compound_head(page)->mapping in filemap_fault() Song Liu
2019-06-20 20:53 ` [PATCH v5 2/6] filemap: update offset check " Song Liu
2019-06-20 20:53 ` [PATCH v5 3/6] mm,thp: stats for file backed THP Song Liu
2019-06-20 20:53 ` [PATCH v5 4/6] khugepaged: rename collapse_shmem() and khugepaged_scan_shmem() Song Liu
2019-06-20 20:53 ` [PATCH v5 5/6] mm,thp: add read-only THP support for (non-shmem) FS Song Liu
2019-06-20 20:53 ` [PATCH v5 6/6] mm,thp: avoid writes to file with THP in pagecache Song Liu
2019-06-21 0:52 ` Rik van Riel [this message]
2019-06-21 13:07 ` Kirill A. Shutemov
2019-06-21 13:10 ` Song Liu
2019-06-21 13:39 ` Kirill A. Shutemov
2019-06-21 13:43 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bbcb43070c5b07e5862e2dbdc7155efcae3eb4a.camel@fb.com \
--to=riel@fb.com \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=songliubraving@fb.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox