From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0254FEED618 for ; Thu, 12 Sep 2024 16:19:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79B376B0092; Thu, 12 Sep 2024 12:19:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74A9B6B0093; Thu, 12 Sep 2024 12:19:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6130D6B0095; Thu, 12 Sep 2024 12:19:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 445E46B0092 for ; Thu, 12 Sep 2024 12:19:30 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EBDA9121062 for ; Thu, 12 Sep 2024 16:19:29 +0000 (UTC) X-FDA: 82556596458.27.155AD96 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf11.hostedemail.com (Postfix) with ESMTP id 0216E40016 for ; Thu, 12 Sep 2024 16:19:27 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="aS/XB4Qo"; spf=pass (imf11.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726157914; a=rsa-sha256; cv=none; b=fuHsGSTSTD6we1qQyAmY6NFIWi8czTS7NbR0/j39L9EVqxFEWlUm78se2xafOrtv6cilMH jLOKFCXuLYc8wjsubK/E2vgSp8N1hB2e0F/BpPjF284dkL6M+ONYMLNYBT4NNsnvKTyYWA 9Gpc0N9Cmp1uMDSPJtYsDp0dwy0JBos= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="aS/XB4Qo"; spf=pass (imf11.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726157914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5heCI+47xmlupHUQF1kgwwyCSmQenWvUXPcC78p5pdc=; b=68heCo3FtnJdZLcWn/H/Y10ohaXGBTKOIsWXnw18pjS0yWvv5UJ+x55eP7XJHDFnMC6kbD 3m4QrjP9pJHo6J7k78v7Pp5R0+v3hPjRzE7djdljONUKcUW99MltCOl6BMzJUZdWgaj+OI UDeo6L5JSIEWNqvbBtnZAVCCwL5SewI= Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3787f30d892so2567f8f.0 for ; Thu, 12 Sep 2024 09:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726157966; x=1726762766; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5heCI+47xmlupHUQF1kgwwyCSmQenWvUXPcC78p5pdc=; b=aS/XB4Qoex2HSqg3WaJ0DlQF2dTcEs85Li5JgJUr9IHx/6NG/Vis0oyFjm68q8/u92 Wy1uZMe6YUK7pF0sX2B8wCj00B8AZGex7DJD8zv8hmhf/S8GX9aCynonjBKRDU20xqtv rIe0IrswSQHtuuH8hEDIPDOUnEdFLvFuIq3b7zPkDbY6S+oUn9pMY5LM4UDj/436/7Kf HzB+JfBgAA6cb/tdHSh03/oDNu94vicD7MtA0TnDYV7Rjsux0oPba8FloRoo5BhdlEsH b3FEY7W+FMhawcC6fOHOdkqQs63RZZf1EjTAH3gJwstc6oYOOOR/MzhKbaeEcha3hy70 2bag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726157966; x=1726762766; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5heCI+47xmlupHUQF1kgwwyCSmQenWvUXPcC78p5pdc=; b=cu/Cz2eVtOc1+c0GA0LfBpPySRJ1RFfRvN758JV95ycwIFSaKM6XwOyc8pFJLweFS0 0/dForSVkYIY1KOD1cRukAgWIk/JaCVDgimz35DgqVrTiGOjuPSzBOcTuqc08v1pF4hD Fo6Kcgthj/d7HR9yyeJohhSFqEKL99g2t2EuKzZrZ7KZe3svG04tBz9LSUtULG3/a77y dsGItQ9L/bDdpYDcoOqC83Y4uJxYX/Cz9ex96Vu2zKn6UThAp8Af5B4iQCknAlFvTZ8L L0bm6AezFnCVdFfOdheaJ5fGs3Ss2lg0c7nyeyuE4V9SOIu2x8nETYlTJS7xlc2jyVtt 4+4A== X-Forwarded-Encrypted: i=1; AJvYcCWoAdCrjJz03f59nQtnb1OoR2aTKzClhNzsIR3azr5XDdfdtdX6hXJubBsMEKepsCrKxNP6Urh6vQ==@kvack.org X-Gm-Message-State: AOJu0YyV5tbntuGg8OfM2QrfHrgUOv5vmQs3GEBTFmVmpwe95frRiadP BUZaKm+5MLPbi/Y6qNN8PvvVUoY0qzPEXXnVoLMa81usY/yqfHzb X-Google-Smtp-Source: AGHT+IFvm2FOZl5cxdrq8pfCTuBirVZOyvXOWUIy89T3v/6lVbbJuXfPYO7xnI5fLM+68x9TxMwJ7Q== X-Received: by 2002:a05:6000:cca:b0:371:9377:975f with SMTP id ffacd0b85a97d-378c2d02124mr1870902f8f.25.1726157965515; Thu, 12 Sep 2024 09:19:25 -0700 (PDT) Received: from [192.168.42.65] ([148.252.141.246]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42caeb44473sm177952655e9.26.2024.09.12.09.19.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 09:19:25 -0700 (PDT) Message-ID: <7bba622a-b530-4f00-8dad-78504e51737b@gmail.com> Date: Thu, 12 Sep 2024 17:19:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/8] block: implement async io_uring discard cmd To: Christoph Hellwig Cc: io-uring@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, linux-mm@kvack.org, Conrad Meyer References: <2b5210443e4fa0257934f73dfafcc18a77cd0e09.1726072086.git.asml.silence@gmail.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 83dk48oaey7ggcuwqs75cpqa3bz1q6wd X-Rspamd-Queue-Id: 0216E40016 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726157967-361525 X-HE-Meta: U2FsdGVkX19A70PfmF5knHfu+jv5BSVu7leQNvs+YzBZlENHKYEN3GyexztK6gH4CF91+VK1K5jTumgYzUppQuEvtB9tMfLyQTVayLLo7L/DmIURcbrUyA4QooDBkND1LebhVq7pdsIrFVv9puhwTkqADfeOZ+57G9FlNt8uR+YPGyLTqsSplzH+5gx8KwxyZITjiMIYmyOiotkZdpR6WEftbt8DZwv4eAbbySNzvrmlrZWlh6SJmeOmI6rMGmS4zKswu+1UR03t16kmVX9s0BTIP7xbY2I/o5yQqe5VipsFl+YW5nopJg2znV6okibfgJwFd5ggukNOqTtVCpm7SMhIkSvBsGW8C+SMSdg+VZWnbW8hB6iLlrpkQygQoU+j6zy1/u8WBfvW+brWQ0xhr9yu2Y45RILABycHJwsB3Y2lVi9gkjfSWIpQ7gQNddyzBNSbNZNfUNkOv9Qr+bFfMm00+R1aSH9h1K7a8jR0lFYi0Wkpd1ctAXZIJe1yNu4SxL0+Ipr3Om7k8kGOMqLzHUqchSIL2jKgNiu3tff3y/3pKqXsXEuUR7OpTPSyuJHgsD3zszFevXjLLrZX5Sl31jZVtYiCR0gPsaOc35dAFupHzwDw7FSiaIS2xXNONNIr+QdcifX/luYstpfqShAXGs1KRhFXulK7n+4jiNiynKSzxb3QVcSFSu/j6HArdgN/cd5MyCf7ax1hPhKCpBgB/ChlT/m94f5n6JkFyJXuPX4FL4gyd+sz8HIuUv9XPrrTDZpaZ0dauBevME8siGvJwvdiwfZbCn2ReH7060LA93Fcv0rqYHoaFIAqXsUNxYXUe/PiMm7tgRz+k9CyiqdXe/eWsXy3n8NWCQoT9w2AtV5LC78rMnPnmr75ygPKeiil2CJTZ0OkTxvZe1WbZTHgjgQTrKpNIEle+MxUHo/YHLCtDSxGlO+69D0kpDi42nHuI+d84pxE/xF6SHq/KTv sZq6quaG u4G7nTbv+UL4yaqIGSwPmMFmPVI2tjndzVbkLWaypsEiBMf5vDafhD3qYHy4icnUerKufp231QVmcqmloeIOZOdM7U2MMvnh/X+x04OdCw0pT1wJJP6Ul1PgxYZKkbmXLvmJ4btJFpwF+fxxmF14VycSN4L7eu7Lnx2r1+o0cjRpq12ODLkTIfgo3Zr5dn2T1TN8AFAD3U4ZjkO/atxseJH1S8wYAoGutf9lVwONsXbVvgCXwRgbhW/63+p+6t1x8lRK/tBDI0Ssr81csOwlmM0zU0JsAnoFSdyF3NorxXkek8pL04UOYrmWuNlz4LPN5SAC4kPBzJqOqj7D+pFuwi+3SdzFnNawKxSPTFfUIzBXKXHRn5lomXg5tLWXrn8XUwhKkomrW6g7vKRKd56jOAKnjou5yRXMnQAVdZG0mgDtGShHRl4y5G1NP3Lm2GOJnno9lyNsJV3vuunw5cbvXUkxcoWAr0bkOo+Iz X-Bogosity: Ham, tests=bogofilter, spamicity=0.016364, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/12/24 10:31, Christoph Hellwig wrote: >> + * io_uring block file commands, see IORING_OP_URING_CMD. >> + * It's a different number space from ioctl(), reuse the block's code 0x12. >> + */ >> +#define BLOCK_URING_CMD_DISCARD _IO(0x12, 0) > > Please just start out at some arbitrary boundary, but don't reuse > the ioctl code from an ioctl that does something vaguely similar for > no good reason. It's a entirely different number space, it shouldn't care about ioctl numbering. Regardless, BLK* in fs.h start with 93. I don't even have a clue where is the rest. Code Seq# Include File Comments 0x12 all linux/fs.h BLK* ioctls linux/blkpg.h -- Pavel Begunkov