linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [akpm-mm:mm-new 422/440] arch/sparc/include/asm/pgtable_32.h:423:9: error: implicit declaration of function 'remap_pfn_range_prepare'; did you mean 'io_remap_pfn_range_prepare'?
Date: Fri, 12 Sep 2025 10:14:26 +0100	[thread overview]
Message-ID: <7b7bbf4c-e4db-497b-8ee4-eae5b64c712b@lucifer.local> (raw)
In-Reply-To: <202509120538.KccGKzFg-lkp@intel.com>

On Fri, Sep 12, 2025 at 06:04:19AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
> head:   31690ac95cb30fd036eeda36844c6e2820685e7c
> commit: 04ff8d62985b8be5f5fc8547a828fbb051c2f927 [422/440] mm: introduce io_remap_pfn_range_[prepare, complete]()
> config: sparc-allnoconfig (https://download.01.org/0day-ci/archive/20250912/202509120538.KccGKzFg-lkp@intel.com/config)
> compiler: sparc-linux-gcc (GCC) 15.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250912/202509120538.KccGKzFg-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202509120538.KccGKzFg-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    In file included from arch/sparc/include/asm/pgtable.h:7,
>                     from arch/sparc/include/asm/viking.h:13,
>                     from arch/sparc/include/asm/mbus.h:12,
>                     from arch/sparc/include/asm/elf_32.h:94,
>                     from arch/sparc/include/asm/elf.h:7,
>                     from include/linux/elf.h:6,
>                     from include/linux/module.h:20,
>                     from init/main.c:18:
>    arch/sparc/include/asm/pgtable_32.h: In function 'io_remap_pfn_range_prepare':
> >> arch/sparc/include/asm/pgtable_32.h:423:9: error: implicit declaration of function 'remap_pfn_range_prepare'; did you mean 'io_remap_pfn_range_prepare'? [-Wimplicit-function-declaration]
>      423 |         remap_pfn_range_prepare(desc, calc_io_remap_pfn(pfn));
>          |         ^~~~~~~~~~~~~~~~~~~~~~~

OK I guess it makes sense it'd need to declare this _before_ mm, and mm declares
remap_pfn_page_prepare().

seems we deal with this by putting the decl in the header for remap_pfn_rage(0,
so will do the same for remap_pfn_range_prepare().

>          |         io_remap_pfn_range_prepare
>    arch/sparc/include/asm/pgtable_32.h: In function 'io_remap_pfn_range_complete':
> >> arch/sparc/include/asm/pgtable_32.h:431:16: error: implicit declaration of function 'remap_pfn_range_complete'; did you mean 'io_remap_pfn_range_complete'? [-Wimplicit-function-declaration]
>      431 |         return remap_pfn_range_complete(vma, addr, calc_io_remap_pfn(pfn),
>          |                ^~~~~~~~~~~~~~~~~~~~~~~~
>          |                io_remap_pfn_range_complete
>    In file included from include/linux/ring_buffer.h:5,
>                     from include/linux/trace_events.h:6,
>                     from include/trace/syscall.h:7,
>                     from include/linux/syscalls.h:95,
>                     from init/main.c:22:
>    include/linux/mm.h: At top level:
>    include/linux/mm.h:3643:6: warning: conflicting types for 'remap_pfn_range_prepare'; have 'void(struct vm_area_desc *, long unsigned int)'
>     3643 | void remap_pfn_range_prepare(struct vm_area_desc *desc, unsigned long pfn);
>          |      ^~~~~~~~~~~~~~~~~~~~~~~
>    arch/sparc/include/asm/pgtable_32.h:423:9: note: previous implicit declaration of 'remap_pfn_range_prepare' with type 'void(struct vm_area_desc *, long unsigned int)'
>      423 |         remap_pfn_range_prepare(desc, calc_io_remap_pfn(pfn));
>          |         ^~~~~~~~~~~~~~~~~~~~~~~
>
>
> vim +423 arch/sparc/include/asm/pgtable_32.h
>
>    419
>    420	static inline void io_remap_pfn_range_prepare(struct vm_area_desc *desc, unsigned long pfn,
>    421			unsigned long size)
>    422	{
>  > 423		remap_pfn_range_prepare(desc, calc_io_remap_pfn(pfn));
>    424	}
>    425	#define io_remap_pfn_range_prepare io_remap_pfn_range_prepare
>    426
>    427	static inline int io_remap_pfn_range_complete(struct vm_area_struct *vma,
>    428			unsigned long addr, unsigned long pfn, unsigned long size,
>    429			pgprot_t prot)
>    430	{
>  > 431		return remap_pfn_range_complete(vma, addr, calc_io_remap_pfn(pfn),
>    432				size, prot);
>    433	}
>    434	#define io_remap_pfn_range_complete io_remap_pfn_range_complete
>    435
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

Cheers, Lorenzo


      reply	other threads:[~2025-09-12  9:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 22:04 kernel test robot
2025-09-12  9:14 ` Lorenzo Stoakes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b7bbf4c-e4db-497b-8ee4-eae5b64c712b@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox