From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC8D7E77184 for ; Thu, 19 Dec 2024 17:26:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 435786B007B; Thu, 19 Dec 2024 12:26:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BCE26B0082; Thu, 19 Dec 2024 12:26:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 236406B0083; Thu, 19 Dec 2024 12:26:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F17E86B007B for ; Thu, 19 Dec 2024 12:26:45 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6E2941A0F88 for ; Thu, 19 Dec 2024 17:26:45 +0000 (UTC) X-FDA: 82912386774.03.2256CE6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id C3ABF1C000A for ; Thu, 19 Dec 2024 17:26:27 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ggzw0vb4; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734629168; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ub53tEKKpHaLHLGfmva6TU5Ud7A86uCEkz+GUzGkGRg=; b=yFin5H/40jIt38hj8t6zVP1Al2OpaBCrf+XCPqr5UsX7cptJe+YWKKMymaiFhPe6hUaz9g 3eLUeVkXs//iC1nhssctW0wgcxkegHA62zCiH10I1qj0autb/qvTqCD9bzkbGlqKbBjgFx FoQb8fpu+y+E5V1ghc57RxVMun2BP2g= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ggzw0vb4; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734629168; a=rsa-sha256; cv=none; b=y8etBT3Tm87NIVHoHxjxLI5GmdlfbV/Z7xlEyA6oyTB0tKSU5ZARc2wLbXlwdPbeft8tfw pmsK1LeHbmkpyYc/cQqS0/uXUjCbi8K8f2w5O2ReXiBT/SXA0J29U+0qAyjwGApR/ZHlan 7oT+OVyDLUK4pkyWvYSx0LNsfy5mrqQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734629202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ub53tEKKpHaLHLGfmva6TU5Ud7A86uCEkz+GUzGkGRg=; b=Ggzw0vb4V8xVG9wtFYC5Ex+nKgwTC+2Z7yiPgFf70TneMWHlpyOHsC9YlAFRgUMpbLAynh /q8n5ng7ORcmm/26/ILOj3YohSXRWX1dAtwnEr8CrZM0w8v53C+ATFzbd6yqVA1lXgf5vH yq61vCftGFC0TIY380N8NTFJifik2AA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-Fazx3ssqPlm0dOth6ttphg-1; Thu, 19 Dec 2024 12:26:40 -0500 X-MC-Unique: Fazx3ssqPlm0dOth6ttphg-1 X-Mimecast-MFC-AGG-ID: Fazx3ssqPlm0dOth6ttphg Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4361efc9d1fso8520965e9.2 for ; Thu, 19 Dec 2024 09:26:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734629200; x=1735234000; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ub53tEKKpHaLHLGfmva6TU5Ud7A86uCEkz+GUzGkGRg=; b=UljjUHeJP8XO4rYJb7TKnrUVl/p5UppZ2aTAg+QYjmgyP988rIe52gYVOjhaj7utpV rV+eoF3pAc5Dm/uK7RIC4YBYrPpofHm61ttJzW2PWhQo7rtxwkIT4joy+F/xRyqVWwxU iiHRGvthcIE3paUhaTSaH3leUoZaj7Y0f6CSuX9KOtbRFLA2qitqFq2z77IpsSA+T4LH mSpGTL5lOH46IVIRy+S1UCJz2OoUCXRGqwaT4Jdpgzxi8Um/PiFgh9jMz6QxOkp2AQrq mEczESxCZB/zwIw/BxK4WwMvnACs4DZxQZpiTZAtPVFXe3rNa0nA0+2lnzkgldncSWjZ amig== X-Forwarded-Encrypted: i=1; AJvYcCVyHn+ocZY8PJjKh5eBzJJ9xdVmnLUTKArcJOl/O/jJblGHmMqAPsRPPt8SNz8D/MkPOwFb1UxKmA==@kvack.org X-Gm-Message-State: AOJu0Yw0IYDxE2drPltmoLNmRylHn00/xVhgZ0SzWq2cMsbcTLuz9uGJ 6lzmVkBTGSq5HtO8aaDFzYcU5o3+0KWr8/5AJk5xJM/i19zwnQ+abdQBAa6AoJk2TwT2GxOAbvD 5Btj2EJm2Pd2ZmZWLlljFdZywJibMyqruObISJM+Ey7DLQT9/ X-Gm-Gg: ASbGncstgesS7apQ/8zPqJ+QFP4bovWx5/Oa6m5lsastVmsKjb9aqegMQJ40HuemgXN IP21ajQXQi76b4n5Q9GMXdNco1w86NHYuK1mUQSy+25tVx7qBo8O5VlNXWDuD1Zu4MV31u9PN+L WKcheMHLjcLgZlUNFcXFJaZdyv1Ds6auzJjMl01zXuzG5C/o22DnPPi0G6s7JczDfleMUmXOkB4 Omnz811fo5xcxqLKTDa4zvrAfckneMSZ40fm7w+p0Hovct/pZPMa9u5ciK6mLzJMmxNWaco4zmD o38yKWuJhtCsEx/7iiuqK/iRdDSRN9lJEJZ6fijV7LB2t41WZOl1IoJzv+ot0Obs4u4IIVm3p2Z NmpV9sQ== X-Received: by 2002:a05:600c:5251:b0:434:a10f:9b with SMTP id 5b1f17b1804b1-4365536f03amr77621485e9.14.1734629199851; Thu, 19 Dec 2024 09:26:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFCx/KYS5Pg5NMgelVTndJVSDJ5mimCuJ0unXzXJyfKUE5VSlM6AhylRd9pHhmuQ8lqU17F1Q== X-Received: by 2002:a05:600c:5251:b0:434:a10f:9b with SMTP id 5b1f17b1804b1-4365536f03amr77621255e9.14.1734629199505; Thu, 19 Dec 2024 09:26:39 -0800 (PST) Received: from ?IPV6:2003:cb:c749:6600:b73a:466c:e610:686? (p200300cbc7496600b73a466ce6100686.dip0.t-ipconnect.de. [2003:cb:c749:6600:b73a:466c:e610:686]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b3b214sm58787145e9.28.2024.12.19.09.26.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 09:26:38 -0800 (PST) Message-ID: <7b6b8143-d7a4-439f-ae35-a91055f9d62a@redhat.com> Date: Thu, 19 Dec 2024 18:26:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/5] mm/migrate: skip migrating folios under writeback with AS_WRITEBACK_INDETERMINATE mappings To: Shakeel Butt Cc: Zi Yan , Joanne Koong , miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, jefflexu@linux.alibaba.com, josef@toxicpanda.com, bernd.schubert@fastmail.fm, linux-mm@kvack.org, kernel-team@meta.com, Matthew Wilcox , Oscar Salvador , Michal Hocko References: <20241122232359.429647-5-joannelkoong@gmail.com> <43e13556-18a4-4250-b4fe-7ab736ceba7d@redhat.com> <968d3543-d8ac-4b5a-af8e-e6921311d5cf@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2R1ev_ZFjmsuVqtYYHNyfOHz0XtFAA-UI6gPd2q7y_c_1734629200 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C3ABF1C000A X-Rspam-User: X-Stat-Signature: sqssqa977mfhj5ahaoqa7g1xrsyebcr5 X-HE-Tag: 1734629187-494510 X-HE-Meta: U2FsdGVkX18UmtmOKac2/Ubz45lqqps7p2u3mEGKlKrv3cM8wM+U/qjc6OKzK8Hj7hVb58FcZoFgSTrnz79dwjlHRKixxpNe0bxIY9E6qBPSBcH8V2isWxaqe5cAQyVRuLnLJZc3J4TBI43a0blajD4hnH7tpvAGNKHeYIXPevxEgyihQmQrqZszlqcbLECFI659opjS0Yy8pRlmZjunMMMp3AnPYpm9conwdK/FD0sq4JpMaAVRHSo72zxqDcAHDiRuzIc+rAGCjJr92mxN0fvNCh/wtbIhGXWAsD0wiwjdeoP0El6hE0IHAljGRls7rKVvUrSJdhuKkvnARf3z5IAqN5+anxu1ymWky3AzGP5ofLpP1WmPhq9L1KAwc4X5vJnhD3eEqdznpI/z51hfOwbeJDO9h5OpIx23v2G8DWQKXJ2IoOsu959Oc2X/6CllR6FZEOE41HWCcttnXn4/GPajVlo2Xl7UMHvuIbmCdSTG88kpOY9SlLNWatiBIouQvNgio79TJEGmEBuPVjf9n+xb4tDMkYEayvfpVcHBizOSq4sI29B+FMHGwb41okumv2u0jWAYcUYzZHBoL5t/4pvXpJ2fgweQya4LbsUVuDXiRO26G37ZSbKPkYUes2N6lG06ol7pvtjynQbYuaIzFOnfkP5VkzhvDVEUNZIEDnBFejiszjyv/rhn6Gy4zaaBhnyWvcdwu0pVpkLbGr9CouiBOnO3t0/iuffeY7DfgfxzSts64WIqAvRhmhWiSUwvDdifBGnGLa5gHA+SSFviYZjIPGi9lJEDl2ONg46gEsPWGlUWwZNcrNL/4KlAu7zkZjvLo8ao7MzFcMxUStcHjMzySY0sgLs+v28kdzKl/+LaV25ivPWmuKIAatqxmPojwdEhVaENAp9T6r6Gsk5xFhatHus9hWh2hLI74TNRKN/ieucG9Sqb1uiz/gh/UZPqA4wa5mSkjSuHAlVD8nc zgH2taWP w01rfY2afiwhqfvTlMeovcvFvm+RIEu1xTWQGTi+XleNOjrwSxO3QaRkPhkZhOSFz/QgplO3tSucDL5g2pGxC2e3Rh8/mPR8Ljy+JQhMdHOcfd87GHH+I4rxMztWlameEye1gHUXym00kOW3Frhjl1EtTV/dwz61D19AWMmAFDe5z2Uv/tHkLY00BcPDJrA8+BmJHfoC31k8qE/boHmLlEjLa7K8JjAyyxTx48c30PQMHX9mZi0AVnh9P64vH0M0AX2bQSz9muszz7Xwv/A+tFrpcVnwQEzEUz/lJt9Hb9sQXlkTxnHm2tv+2+bk6PompqgdQzrQNuIvlyl2CrBoA7YjFAKs1a96xSDxmrO0SWs80zbreOAV+GOhr+JJ1rjztzt8x2b2BuG65NEkoU6OMagjvoxONFMi88ARqJufWPTCOhKWyvX7ivOdxPognvAZBfXaQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.017509, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.12.24 18:14, Shakeel Butt wrote: > On Thu, Dec 19, 2024 at 05:41:36PM +0100, David Hildenbrand wrote: >> On 19.12.24 17:40, Shakeel Butt wrote: >>> On Thu, Dec 19, 2024 at 05:29:08PM +0100, David Hildenbrand wrote: >>> [...] >>>>> >>>>> If you check the code just above this patch, this >>>>> mapping_writeback_indeterminate() check only happen for pages under >>>>> writeback which is a temp state. Anyways, fuse folios should not be >>>>> unmovable for their lifetime but only while under writeback which is >>>>> same for all fs. >>>> >>>> But there, writeback is expected to be a temporary thing, not possibly: >>>> "AS_WRITEBACK_INDETERMINATE", that is a BIG difference. >>>> >>>> I'll have to NACK anything that violates ZONE_MOVABLE / ALLOC_CMA >>>> guarantees, and unfortunately, it sounds like this is the case here, unless >>>> I am missing something important. >>>> >>> >>> It might just be the name "AS_WRITEBACK_INDETERMINATE" is causing >>> the confusion. The writeback state is not indefinite. A proper fuse fs, >>> like anyother fs, should handle writeback pages appropriately. These >>> additional checks and skips are for (I think) untrusted fuse servers. >> >> Can unprivileged user space provoke this case? > > Let's ask Joanne and other fuse folks about the above question. > > Let's say unprivileged user space can start a untrusted fuse server, > mount fuse, allocate and dirty a lot of fuse folios (within its dirty > and memcg limits) and trigger the writeback. To cause pain (through > fragmentation), it is not clearing the writeback state. Is this the > scenario you are envisioning? Yes, for example causing harm on a shared host (containers, ...). If it cannot happen, we should make it very clear in documentation and patch descriptions that it can only cause harm with privileged user space, and that this harm can make things like CMA allocations, memory onplug, ... fail, which is rather bad and against concepts like ZONE_MOVABLE/MIGRATE_CMA. Although I wonder what would happen if the privileged user space daemon crashes (e.g., OOM killer?) and simply no longer replies to any messages. -- Cheers, David / dhildenb