From: Mike Kravetz <mike.kravetz@oracle.com>
To: Barry Song <song.bao.hua@hisilicon.com>, akpm@linux-foundation.org
Cc: guro@fb.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH 1/2] mm: cma: fix the name of CMA areas
Date: Wed, 3 Jun 2020 10:27:03 -0700 [thread overview]
Message-ID: <7b533da9-f321-cb2d-b960-37dc7b8885a9@oracle.com> (raw)
In-Reply-To: <20200603084025.62740-2-song.bao.hua@hisilicon.com>
On 6/3/20 1:40 AM, Barry Song wrote:
> if users give a name saved in stack, the current code will generate magic
> pointer.
> if users don't give a name(NULL), kasprintf() will always return NULL as
> we are at the early stage. that means cma_init_reserved_mem() will return
> -ENOMEM if users set name parameter as NULL.
>
> Cc: Roman Gushchin <guro@fb.com>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Thank you
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
next prev parent reply other threads:[~2020-06-03 17:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 8:40 [PATCH 0/2] mm: fix the names of general cma and hugetlb cma Barry Song
2020-06-03 8:40 ` [PATCH 1/2] mm: cma: fix the name of CMA areas Barry Song
2020-06-03 14:12 ` Roman Gushchin
2020-06-03 17:27 ` Mike Kravetz [this message]
2020-06-03 8:40 ` [PATCH 2/2] mm: hugetlb: fix the name of hugetlb CMA Barry Song
2020-06-03 14:13 ` Roman Gushchin
2020-06-03 17:28 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b533da9-f321-cb2d-b960-37dc7b8885a9@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox