From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: Samuel Holland <samuel.holland@sifive.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
David Hildenbrand <david@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Anshuman Khandual <anshuman.khandual@arm.com>,
Gavin Shan <gshan@redhat.com>, Zi Yan <ziy@nvidia.com>
Subject: Re: [PATCH 2/2] mm/madvise: Use set_pte() to write page tables
Date: Tue, 16 Dec 2025 10:16:52 +0000 [thread overview]
Message-ID: <7b37618b-74ae-4806-9b3c-3ecfedeb257c@lucifer.local> (raw)
In-Reply-To: <6c76b8e6-3e39-41a0-a4fe-9012c3eb8446@arm.com>
On Mon, Dec 15, 2025 at 10:57:31AM +0000, Ryan Roberts wrote:
> >>
> >> I agree that it's extremely confusing. Perhaps, at a minimum, we should come up
> >> with some kind of naming convention for this and update this and the other
> >> couple of places that pass pointers to stack-based pXX_t around?
> >>
> >> e.g. instead of calling it "ptep", call it "ptevalp" or something like that?
> >
> > Not sure that'd clarify, we already have a bit of an inconsistent mess with all
> > this :(
> >
> > Given it's a stack variable I'm not sure using a helper is in any way helpful
> > other than I suppose to account for people grepping around for incorrect page
> > table manipulation code?
>
> I've proposed an approach to clean all of this up. I'd appreciate your opinion
> if you get a few mins:
>
> https://lore.kernel.org/all/a063f6c5-2785-4a9f-8079-25edb3e54cef@arm.com/
Sure will take a look!
Cheers, Lorenzo
next prev parent reply other threads:[~2025-12-16 10:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 8:11 [PATCH 0/2] mm: Always use set_pXX() helpers " Samuel Holland
2025-12-11 8:11 ` [PATCH 1/2] mm/debug_vm_pgtable: Use set_pXd() " Samuel Holland
2025-12-11 9:36 ` Ryan Roberts
2025-12-15 10:33 ` Lorenzo Stoakes
2025-12-12 0:48 ` kernel test robot
2025-12-12 12:11 ` kernel test robot
2025-12-11 8:11 ` [PATCH 2/2] mm/madvise: Use set_pte() " Samuel Holland
2025-12-11 9:43 ` Ryan Roberts
2025-12-15 10:37 ` Lorenzo Stoakes
2025-12-15 10:57 ` Ryan Roberts
2025-12-16 10:16 ` Lorenzo Stoakes [this message]
2025-12-11 23:40 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b37618b-74ae-4806-9b3c-3ecfedeb257c@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@kernel.org \
--cc=gshan@redhat.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=samuel.holland@sifive.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox