From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AAFAC48BE5 for ; Wed, 16 Jun 2021 08:43:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 003D9610EA for ; Wed, 16 Jun 2021 08:43:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 003D9610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 740FD6B006C; Wed, 16 Jun 2021 04:43:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 717BF6B006E; Wed, 16 Jun 2021 04:43:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B7D56B0070; Wed, 16 Jun 2021 04:43:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 279886B006C for ; Wed, 16 Jun 2021 04:43:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BE2AD180AD806 for ; Wed, 16 Jun 2021 08:43:48 +0000 (UTC) X-FDA: 78258948936.28.CB3D895 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf25.hostedemail.com (Postfix) with ESMTP id AE4FD6000144 for ; Wed, 16 Jun 2021 08:43:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623833027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u0D0zKBMgXmr3PxBETIUkf21lHYAOb1XEe52ea0rLjs=; b=TzA1wYxxqYX8YJip/jb12ybBKda5mw6+nzFkX83hD0L8ooKMJs9LQJH/x7Jexyb4HMvExF idS1Ks8uGwpjEpXhxaLcoF/5F4KTGUF90yInrdAfKXMPnZ+VaWSTXO9C5pRsyNQHsVm7Ki k7+3qJhoFp3vCFaZuexjiiuPMFMmM1s= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-qbf1FWxBN_CZq9i8VFlVGg-1; Wed, 16 Jun 2021 04:43:46 -0400 X-MC-Unique: qbf1FWxBN_CZq9i8VFlVGg-1 Received: by mail-wr1-f69.google.com with SMTP id k25-20020a5d52590000b0290114dee5b660so773686wrc.16 for ; Wed, 16 Jun 2021 01:43:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=u0D0zKBMgXmr3PxBETIUkf21lHYAOb1XEe52ea0rLjs=; b=T2//XlR7dQ+DErjni05k6mnCrUFazVJ4WpwTGyIFdM+L7YfrIgCpr1LWjqKsGZUbkH YWKV0Se0+UhRf5jVukgZJNOrvQtx9RRfioEuJWX3CaTdhlDJVM7oFFfj2y+t4jmNXND5 iwSMD1v0R8NTFX/qVIMqDOGY8HQ2ifV1WQeXyYIR3wSFvKsjLckMQ7gK7+uw0I0iNiql ZRbzlnKiAuyzPlmqYRgWuXMhYPMyi3/9bbiNG2Qa+5puPCbYrK1v4gbbA/LgOIRAiWrt vLorIGXikvPcXGUfdw7uWF8IJ8Knb5NLWfEsRmXt7C3Fc27FN2Y6g/vpUhatFUPYSZ/k u4Zw== X-Gm-Message-State: AOAM531zQJuJnE5X6cefcp5TfZrqaOrc67Bw4uUBGE0wxVdcP8rFAsV0 VIfewu49j16+H6ezr5mMt9PnEPIYQSqIp0WfEMGNPA0Q8Ce//EP/QqEOy/waWd7JarIr8WjMExs TgFZjtFdZfrA= X-Received: by 2002:a05:600c:251:: with SMTP id 17mr10090779wmj.137.1623833025524; Wed, 16 Jun 2021 01:43:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrQI0NGG0nHStz1ZZl8nnM8GdVNtj/jcA9AJyt+U7dcUjZnGXrTxahill+aRsLN7ZoqYYnmg== X-Received: by 2002:a05:600c:251:: with SMTP id 17mr10090753wmj.137.1623833025310; Wed, 16 Jun 2021 01:43:45 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6524.dip0.t-ipconnect.de. [91.12.101.36]) by smtp.gmail.com with ESMTPSA id g83sm1177886wma.10.2021.06.16.01.43.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 01:43:45 -0700 (PDT) Subject: Re: [PATCH] mm: Mark idle page tracking as BROKEN To: Vlastimil Babka , Yu Zhao Cc: akpm@linuxfoundation.org, Linux-MM , Heiko Carstens , Rafael Aquini , Vladimir Davydov , "Kirill A . Shutemov" , Andrea Arcangeli , Donald Dutile , Matthew Wilcox References: <20210612000714.775825-1-willy@infradead.org> From: David Hildenbrand Organization: Red Hat Message-ID: <7b35885b-1413-5e08-3930-c8c4b66bcfe7@redhat.com> Date: Wed, 16 Jun 2021 10:43:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AE4FD6000144 X-Stat-Signature: qw4ux9w8oegr8qs4bsa5phrnea3xbo5u Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TzA1wYxx; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf25.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1623833018-627136 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.06.21 10:36, Vlastimil Babka wrote: > On 6/16/21 8:22 AM, Yu Zhao wrote: >> On Tue, Jun 15, 2021 at 8:55 PM Matthew Wilcox wrote: >>> >>> >>> I don't know. I asked the others on the call and the answer I got was >>> essentially "Just delete it". >>> >>> I'm kind of hoping the others speak up. >> >> I listed a couple of things when acking this patch. Being broken is >> not a problem as long as there are users who care about it. What made >> me think such users may not exist is that nobody ever complained about >> those things until we stumbled on them -- I'm not insisting on >> deleting this feature, just clarifying why I thought so. > > Similar feelings here. On the call it looked like the feature was abandoned by > its creators, and it wasn't clear if the distros that had it enabled did so due > to reasons that still apply for future versions. Sending the proposal and > getting a feedback that there are users is one of the expected valid outcomes. For us (RH) it will be very interesting to know the exact things that are "suboptimal" (I'm avoiding the terminology "broken" here), so we can actually evaluate if this might affect customers and might be worth "improving". That's why I was asking for more information (either to document, or to optimize). Because even if we (upstream) might decide to abandon the feature at some point, distros will still have it enabled. Thanks all! -- Thanks, David / dhildenb