From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F118C433F5 for ; Sun, 13 Mar 2022 20:09:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E1F76B0072; Sun, 13 Mar 2022 16:09:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 690E96B0073; Sun, 13 Mar 2022 16:09:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 559196B0074; Sun, 13 Mar 2022 16:09:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 46E926B0072 for ; Sun, 13 Mar 2022 16:09:48 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EE299181CAECA for ; Sun, 13 Mar 2022 20:09:47 +0000 (UTC) X-FDA: 79240453614.18.EE705D6 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf31.hostedemail.com (Postfix) with ESMTP id 9833020033 for ; Sun, 13 Mar 2022 20:09:47 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id p8so12511079pfh.8 for ; Sun, 13 Mar 2022 13:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=s/L2c/ExU2lRRbbGeHNM0fTyvtWmir/JMQ4lIG+dqPQ=; b=NHshDFyEJcyEiGKm2Xt+OMjFtjqs/nqg17/NmX/5+10JbigfEW7kQoEZs2E80Ezkni ggQQvpqP3G5meFEDXYywi1a1lM6SbmZh+ji46GJy67WZpvfM+oEuVWgP44qAUqNbjYuL JbwTN3qzOElmXWdiGV4hS5/tRu+qsdub3eoBIOl8ZToV6v75mtsqHxCJftMBaBpCLroc G7BAzGXa8O8HkPYJdXLVcYLdvJmNpPLGrIEmJ+y6oThvL1DlxSWFMb9X681aMVkikej/ WlW/MhZvXtVGO9CO9b8CNlf4VAwxOc62FXTztBnwKuIkjqxdOhXpMaWiHPP2GhE7HZXq hPZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=s/L2c/ExU2lRRbbGeHNM0fTyvtWmir/JMQ4lIG+dqPQ=; b=LccNBG15RhO9BSPnDxBvmbZj7ne9HJimiDf36NfvLxT5k1V7G47AoAEy5M5UmGL54c nB+w1tCdGtDsQvhOcpNyVRZLJqP3eOi1pHnAQjQ6xInGHdU9H6M7mp47VnVWNCFEMSHF DOB/8/HtnqPnJvSo5PTx/Sr3ADlQ9mCdAl6GjtHTtJZIai+uGs+a5OyQoVNew0+TEFxx 0OJLw6s9nAyvEYBK/qjkRFmqm8+ruNmhdy95SV714q6L6kdTfYBgs88GUFft8vp9v7Lv r1cB6EQbZLqSgulKSDZnoYcDyvNzDpFLZoFnOuXHB8U/yScWxBqhQCkuk+Nru39i5GV4 +8jQ== X-Gm-Message-State: AOAM532WxaAieGCUi7qHpqT4Rbj5Dlmf3P+LIVCi4hPdvWLHiUG9hL+1 8Bg7zeCLfidtoln58lnvUtSOng== X-Google-Smtp-Source: ABdhPJxCg27sMKMp7nSUM8vluoc736QFCgbEPPs5y8MHcFa4rKL7ROWWo0QzvAc4iwxsjxHh8X/1hA== X-Received: by 2002:a05:6a02:208:b0:372:c366:8ff4 with SMTP id bh8-20020a056a02020800b00372c3668ff4mr17009152pgb.76.1647202186271; Sun, 13 Mar 2022 13:09:46 -0700 (PDT) Received: from [2620:15c:29:204:1b89:dc90:772c:f65f] ([2620:15c:29:204:1b89:dc90:772c:f65f]) by smtp.gmail.com with ESMTPSA id b2-20020a056a000a8200b004e1414f0bb1sm18849705pfl.135.2022.03.13.13.09.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Mar 2022 13:09:45 -0700 (PDT) Date: Sun, 13 Mar 2022 13:09:45 -0700 (PDT) From: David Rientjes To: Mel Gorman cc: Andrew Morton , Eric Dumazet , Eric Dumazet , linux-kernel , linux-mm , Vlastimil Babka , Michal Hocko , Shakeel Butt , Wei Xu , Greg Thelen , Hugh Dickins Subject: Re: [PATCH] mm/page_alloc: check high-order pages for corruption during PCP operations In-Reply-To: <20220310092456.GJ15701@techsingularity.net> Message-ID: <7b288234-84ef-db82-3b85-7f921dd3c2f@google.com> References: <20220310092456.GJ15701@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NHshDFyE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf31.hostedemail.com: domain of rientjes@google.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=rientjes@google.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9833020033 X-Stat-Signature: 8aoguycbchdqgcs3hhx9kw6ycqkgujfi X-HE-Tag: 1647202187-969370 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 10 Mar 2022, Mel Gorman wrote: > Eric Dumazet pointed out that commit 44042b449872 ("mm/page_alloc: allow > high-order pages to be stored on the per-cpu lists") only checks the head > page during PCP refill and allocation operations. This was an oversight > and all pages should be checked. This will incur a small performance > penalty but it's necessary for correctness. > > Fixes: 44042b449872 ("mm/page_alloc: allow high-order pages to be stored on the per-cpu lists") > Reported-by: Eric Dumazet > Signed-off-by: Mel Gorman > Acked-by: Eric Dumazet Acked-by: David Rientjes