Re: [Patch mm-stable-fixup 0/2] mm_slot: fix the usage of mm_slot_entry()

[David Hildenbrand <david@redhat.com>]

On 01.10.25 10:39, Wei Yang wrote:
> On Wed, Oct 01, 2025 at 10:34:52AM +0200, David Hildenbrand wrote:
>> On 01.10.25 03:06, Wei Yang wrote:
>>> This is the fixup based on mm-stable.
>>>
>>> The base commit:
>>>
>>>      mm: swap: check for stable address space before operating on the VMA
>>>
>>> The reviewed version is at [1].
>>
>> I'm confused: why "fixup"?
>>
>> Usually fixups are applied on top of other patches (to be squashed in).
>>
> 
> Andrew mention he has merged v2 into mm-stable and ask for a fixup.

Ah, now I understand, some part is already in mm-stable.

In that case the patch descriptions+subjects have to be updated to 
clarify that these are only cleanups on top of the existing commits.

Then, also mention the merged commit in mm-stable.

E.g., for Patch #1

"
mm/ksm: cleanup mm_slot_entry() invocation

We got some late review commits during review of commit XXX ("XXX"). 
Let's reduce the indentation level and make the code easier to follow by
using gotos to a new label.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
"

E.g., for Patch #2

"
mm/khugepaged: use KMEM_CACHE()

We got some late review commits during review of commit XXX ("XXX"). No 
need to keep the old cache name "khugepaged_mm_slot", let's simply
use KMEM_CACHE().

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
"

-- 
Cheers

David / dhildenb