From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA901C25B78 for ; Tue, 4 Jun 2024 19:38:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B67B6B0093; Tue, 4 Jun 2024 15:38:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 265A96B0099; Tue, 4 Jun 2024 15:38:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B9C26B0093; Tue, 4 Jun 2024 15:38:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D446E6B0098 for ; Tue, 4 Jun 2024 15:38:49 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7D4161612D2 for ; Tue, 4 Jun 2024 19:38:49 +0000 (UTC) X-FDA: 82194218778.09.E5180E2 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf27.hostedemail.com (Postfix) with ESMTP id BD7DF40018; Tue, 4 Jun 2024 19:38:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=asb3qJGh; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=axehwktQ; dmarc=pass (policy=quarantine) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf27.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717529926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3+9N5opK3GPTcTNhBvrKS1VlErtOWLae+WqkrzcgNhQ=; b=MjL8NtBlrGXZryAHkQ2MHYzPxO2ldf/gxz8ZWy649x/eLIMOkVtrvIJKdk74wbZ+P0Kdw+ Zf/qasHVNvUQmRURXs74+F++kWB+1opl841HGewEHhcPdEpJwk7Z26kkm7waUzr1PYGlxa 2ncOVrZGH0FDGM37jVjlVayxCDhZESo= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=asb3qJGh; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=axehwktQ; dmarc=pass (policy=quarantine) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf27.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1717529926; a=rsa-sha256; cv=pass; b=sCfv1oIqM50TZzmYzmM/3coHGKMVkRZCP6usr1pXabUy8bu52kThhoJM8u6RtDTcRiwbqq L/UBn0CnHVy0LFZ1MLZVpL5vvjTF4/TZzHi2MzZu80gfY4I+pVNpdzWAU8Uo6tBLQQZ1qm 480g02lITs3KHuQxW/vILzLXwYrN2Rc= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 454JNmLB024287; Tue, 4 Jun 2024 19:38:29 GMT DKIM-Signature: =?UTF-8?Q?v=3D1;_a=3Drsa-sha256;_c=3Drelaxed/relaxed;_d=3Doracle.com;_h?= =?UTF-8?Q?=3Dcc:content-transfer-encoding:content-type:date:from:in-reply?= =?UTF-8?Q?-to:message-id:mime-version:references:subject:to;_s=3Dcorp-202?= =?UTF-8?Q?3-11-20;_bh=3D3+9N5opK3GPTcTNhBvrKS1VlErtOWLae+WqkrzcgNhQ=3D;_b?= =?UTF-8?Q?=3Dasb3qJGhM+ZY93fBTmrybTZN3pwoq0+9183dx8YzdlpORrGi6MJKsDKEYJR6?= =?UTF-8?Q?3nYTKx1N_tdhOWoouxujvr7RN9YukmQCNU+e8zySR/RNXEQK/RPB21Ne235mcVH?= =?UTF-8?Q?qrdsv8r23nZs8L_O1EG3/F9sul+OBz0Jx+fiHRP2j6w6Kx6J2croN3WWl1eGi3Q?= =?UTF-8?Q?ZRkJtFKF217kNJGQ4wyk_cElhxwlYfHqDs/FYzuao4u8w2B7KCPyBI4W8/Gs7N6?= =?UTF-8?Q?U+8x8Zbm8RtrmD75g4FxTk0tbX_9aEw8yAaSInBi4G+yt0KzGrDTeJbV9pkx1Kz?= =?UTF-8?Q?NrSnpDT2uMwiN2lYH2I3C2FjY30bNnOV_hg=3D=3D_?= Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3yfv3nwryj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 04 Jun 2024 19:38:28 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 454HwQ65015565; Tue, 4 Jun 2024 19:38:28 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ygrjcsngj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 04 Jun 2024 19:38:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aojXPwzsz/Uki/VouQNeVyyuPW7n6WUEz0BcMaycMWtx5dUjQitg0zo0Lhw6pFoz6V3TJN7q+IDJtZKV+bn/njKp/1w3HpoIrF+/ip4VJNVnLxhqulNQXLrI98ZGM41xH8ODus4Qxj5v2Nc+WiLwnhNwlj6Iu11I4b1uQ2q3QpomJuE2/zIJ6kFk5NonXKUM6rtRhF6CGJCnj3DZNzbcxmmyKf/nIzrRVf2mtubCk9nzZY2nPoseNvOWiAPNY7blNGisyw85O3YVTFwbbAV4nkiflMvSzNKypbvv6i4NBMEuV8CitUX95SBOiDkYUZA4ocm2Lb5m4ua9CiDSjLni1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3+9N5opK3GPTcTNhBvrKS1VlErtOWLae+WqkrzcgNhQ=; b=i3dkKeHTd40hWc1KcN17hUO2u07K1VoxnZhsxujJeoRs9/bocM0H2hya4mK28KENkwlafFovGA7BAquZ1CAvYD5282tfJphn80NXIHxxcr+812PoNdwkxKED7HCYD1wtJ9dEXeAGAGA+V1cEilZmyCbDqVxNmPJUuXrBP5CT0oFkp2MOUpMskf/CtMX/CGlA9xAos8smnlODye6XoUdnzbWUR5s2S+DYuRkM3Nk1bHHbRId+kVtA0grYNIRf556bmlzLLlwj+cO+AoJe3MRz2fEHTyQy5QBqMkfUFE07dV/MgfwWX9Zzb/NHemD+9VFv4elPzLz6MKX3Na+keP51vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3+9N5opK3GPTcTNhBvrKS1VlErtOWLae+WqkrzcgNhQ=; b=axehwktQStdQ535Z6Mpe26Sse95k0VPQC8UNeZsRQtxwVFDotM1TYqYj8Lq7GZ7ouIIaQGe2JyaoE2VUH0RNP5G8FB8qE8AcYEW2b7V0if+RyZtWwuT/pT9U6LOcx/zlSMfYl8su4ueCZiQ7V4oToCp/B7LnM5cfppF84XKoi7w= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by CY5PR10MB6189.namprd10.prod.outlook.com (2603:10b6:930:33::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.24; Tue, 4 Jun 2024 19:38:18 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::3db0:ec21:1957:f1b3]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::3db0:ec21:1957:f1b3%6]) with mapi id 15.20.7633.021; Tue, 4 Jun 2024 19:38:18 +0000 Message-ID: <7b1783da-511d-4287-bb22-fe972c5cb792@oracle.com> Date: Tue, 4 Jun 2024 12:38:06 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/6] mm: move memory_failure_queue() into copy_mc_[user]_highpage() To: Kefeng Wang , akpm@linux-foundation.org, linux-mm@kvack.org Cc: Tony Luck , Miaohe Lin , nao.horiguchi@gmail.com, Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , jglisse@redhat.com, Jiaqi Yan , Hugh Dickins , Vishal Moola , Alistair Popple , Oscar Salvador , Lance Yang References: <20240603092439.3360652-1-wangkefeng.wang@huawei.com> <20240603092439.3360652-2-wangkefeng.wang@huawei.com> Content-Language: en-US From: Jane Chu In-Reply-To: <20240603092439.3360652-2-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO0P123CA0003.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:354::11) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|CY5PR10MB6189:EE_ X-MS-Office365-Filtering-Correlation-Id: ab2223be-e78c-4b4c-ce2d-08dc84cde29d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|7416005|1800799015; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SXFIYVVzWFc3cVBCOGkrZy9aM2IyNWdYbzRkUWQ2MzlvWm94bExiQzd4djVK?= =?utf-8?B?RHZyU2lSdXQ3aEY0WlZjRDlWTjJJdHg5UFBqTy9tR1lYbXZqb0k1ZEo5ZU1Z?= =?utf-8?B?RXVlVG1taHI2cURHcloydG90M1RMYzgyaFgwRVA2Wk5VSTE0NWJiQjJXejlF?= =?utf-8?B?L1lRUU54VjJWQjEvR0hKNkp1NnFlSjE0emN1SXFVT3A3b1B0YXVFaTRDTzh6?= =?utf-8?B?bURFMG5zUjZITmZOUmNsMTNlaldMZkFLODYzWU1ZSHIyTFhtaTdkVjRGc2t0?= =?utf-8?B?aW05M2tRN2lDdjFqS2RGUWRBYWhadFBiNmJMLyswNnhzY0tKN2MrN294eXdN?= =?utf-8?B?RlpINWgzdUNiRTNiN09Zb3l2QnJ3cUtzdGwyRkd5dEVmV1F1QXBiMHpGc2xi?= =?utf-8?B?VmpVcFpXQlFaaTdTWmxoZkJSaXljV1hhemdaV2VmMzB0WmJaWTM4Tk1WMGdq?= =?utf-8?B?NlBGRzYwZ2J5clZMK1BleHpBNjdDSFVxNjRvM3ZvWGpGcTlKRmtlbmJITzNo?= =?utf-8?B?RGswVkgvWnptVXA2RlhBN0toaUJBcVQwWHlYUHBVYm04M2NNRjhMVUtVb2ZB?= =?utf-8?B?SU9JczFDNG5Vc0dUdHV4UnZNU05GZ3VXK3NMRXNSVndNTXFMZUQyRlMvTHNZ?= =?utf-8?B?MXhPWk5yL1JacFRnTzcvbWFtTXczVTFkTitJeVFhOUFFdWtGOGRqdW5Kbkpy?= =?utf-8?B?UnhQaXRzZWN2OCtoQ3h0TWxsTmhua2NEU2NUSmxGREk5YUpoVVJyd01zK2pr?= =?utf-8?B?V3RmVUhIS0N1ZFAxQlRwZEFGeUg5VGlPSEFVUldOMHhXMjdLUk1JU1ZUWm1z?= =?utf-8?B?YTV0d0Q3WDB2WS9lZnd3dEk1U3JldmY1L1FzTlFoeE5qTDNDMUhkR0lUMmdG?= =?utf-8?B?UHBtQWRZQkprSkJHVlFmeld3Vlg1ankwanRYcit0eUs4eTQrU29iWGRHQzZp?= =?utf-8?B?RUZpS0h1bTdLQ09oaDhiTk1RTmFxbU50Y1FSSWl1MlFmTlRGSEIybEN5VnQ5?= =?utf-8?B?VjhrQVZCVGFxeUZyYUZGTlIzSzJuOTJCOWMxU2dUamp0K0RaRVlackdYZWRS?= =?utf-8?B?RTdsOEgyWVYwcGx6Z0pJRWVOUXIzeXhQNGd6elAwZmNyMFJ4dmdqaHNWYWQz?= =?utf-8?B?NkZXMVhZRWJiVlExRm84d2JMOVRQZGJ0S1pYdEZaTGF4dklhc1FQV1EyTEVs?= =?utf-8?B?WmEyamhlc1hJVllwRVJQemxtWUxGQ1dtKzY4NjRNYlNxb1pHRHUvZW1BLzRt?= =?utf-8?B?c0ozMDh3QldNYWxPM0U2NjJneTY3YzR1N0V6NWNsaFY1TUhwdjU4SEpUbDE1?= =?utf-8?B?dVRYU3M0ZzVtUE82cys5ZjNvM04ydzVBNStnbzNaMWt0WEVObzJMSUhKVzh4?= =?utf-8?B?WklBS0M3RCt0OHUrdWdQd2w0b1VRUkFaTXFKTUJGV0VRVHZhVmJqOG5jL012?= =?utf-8?B?Q3BoMllaZ1dqM1pWRm9sck15alZWSVpvU2R2d2hnRmVnQVBWeUFaZW5vZEM3?= =?utf-8?B?MitmbmdqMUE1YTlHc1dzT3Ric1ErbENWb1ZQcS9XWW93Sm9UWkxQc3lEamIr?= =?utf-8?B?T0t0d2k1dWJBVWRnQk0rbnZWSW5XVnNGUUNwZFFFa3pXbXRpaE8wUDhWZ0dO?= =?utf-8?B?WTl5QkZrNjZTdHNSRHA2TU1RR0ZrM1p2Z0ZDVEFuTU9kT0hiSkxENFN0d3Vq?= =?utf-8?B?L0xIVmZkZ2xYRlc3MGNJTi9KOVZDNSttR0NzMFJRaXFISkNYT0JlMGZ6WXp3?= =?utf-8?Q?Etjsx8/zWM0xg6egDsJMC22RY/ChM917XG9WG/m?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(7416005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFZYWGxoUDNEQmVZMTNaNmlNVzdQVnpKZ3picW96TUZzOUdacTNBbjVTOFBG?= =?utf-8?B?K0plUWZaa1I2bjFqbXZHdFlaa0tWekpMTWNaZEEzSFdUekJQenpkMHJ0RVRY?= =?utf-8?B?NFNiOUhxclRpV0xaTkUvNWZINVA1NlRaN1hKaGh1UWxKODlLeThPQkc5ZEUv?= =?utf-8?B?a2VHME9wQ0Fpd1lNRVI4bVFkVGxBTmcwWkdXWFo5WlJqdUFmc1ZMWmFyMHFI?= =?utf-8?B?N0tURWJaclZhRUFaVGVPNUxCcnhKOXVrUTZQSXNCTnlQUk5aWXN3eXpWdlVE?= =?utf-8?B?eHM4R0tqYnRmK2Z4MDIvdnV0eSt4Zlp5dnZOWFZlRWNvL3czc1V2dDUwb0FL?= =?utf-8?B?cGZLM0g4amZyTGt4c2xMRUJnYU1nUWlTV1A2RkZYYksyQnhRUi9wMm1KT3pO?= =?utf-8?B?VFFZREl1SmNWMGZnZkRtdE1DSEpYRzVSemxSbXROVjBxWWFXRFgvcjRwRXpD?= =?utf-8?B?SkhNT3RYbGxHbFFTVExpY0dWUEF5SVB0RmhHWm5IRlA5TTh0Y01TcmtmR0dG?= =?utf-8?B?cjhaSllhVHNZSnhDMzN0SFRuTWt3K0RTbkR0clhQMTdWMG9vRWd3ejVOMjE4?= =?utf-8?B?Zm1QU25Ca0ZLSmVRSUVkdFNCemhUQmM0bEw4bXZnSWpRUnVJQ29OMVJrK0gy?= =?utf-8?B?U3hCMkZaNnl2bnE5TG9aWTllVktkMlZkWGxvTkxDRlhkZ0pwQUZZTjl4aEhE?= =?utf-8?B?RFAxODk3MWFJVlZzWlJrZ3RlM3BRVHk2YTgxWTNtV1NSdVNBb3dlRFJ2RVFO?= =?utf-8?B?ZE5xaHJIaUFGZ3VUdWlCbkZIVFBJOWMyM1pZN2MrdU1XZUVURzFjK0Z4S3dG?= =?utf-8?B?RTBZNFQ3dmRJZUE4dnNyNERiUE81QmU2T0wrVnV4bHg5K2ZKVy8vSHB4djVq?= =?utf-8?B?TmJJelhtZDI3T3JTMUxxQng5czMvYm9PS0VObVA5ODVNQzJoNy9VenpMTTRL?= =?utf-8?B?U2YvRVRTaVVVQUZldGU0ZVZnTFdyNXJPYWdFUUtaSTdiSHlFSlZvTmkxUldJ?= =?utf-8?B?OWo3N29FM253Y2tSR3NLaXBxZHE3QjBhdXg0NFo4QmMxT2xUb0h3Z1ZhTitJ?= =?utf-8?B?L2NoSEtrTE00Y0dHYWtUNzdNZzFucDY5c0M2dy93clhOU3hScTlqaTZKRnA4?= =?utf-8?B?dm9nMUZrcW5wT0dZS2U2TUpLOVdPbVhPNERUNlhxZTlYVlVRR2NoNE5zeGFC?= =?utf-8?B?MXBIM0xCRzYxZ202R0F3Zi84VXlTcFh3ZWhQK3VBZXp4dVpueG9UUEMzUU8z?= =?utf-8?B?L0lHVDM5MHIxcXBNTmxQT0FOODBINU9EZnJwRG01WVFMVy9BcG5JM1F0Mld5?= =?utf-8?B?VDZ2My9GeGo4S0R5b1NlbktPakRtV1NvRTd3ZDJQRmlORFEyMzQraExmbVdY?= =?utf-8?B?VE1SWmVmUnBleWpFTG1ZcGNTbmpkUDdoYmg0K0lDRlh0cGw2dVVSTDQxY215?= =?utf-8?B?YmMxbmRIMEFwYWhqb3NMNUhrZ1FBNUgvQVRDNlhlSy8zTlJEdXdJaG1GOFY2?= =?utf-8?B?aVF3NlR6RE0xRSt2ME5ZckxBdzlmVmg4bnA1aEJCUWFrMGhiMXF1THc1dWNL?= =?utf-8?B?OEJOaGRkNUk4KzBLL1d2Y1FzQzRoODJWNDdtUFdNYzBVL280VGQ3TFdKK0N0?= =?utf-8?B?R0tiOHlNRG9yQWRFR09QMW45d0ZCTUoxcDZ2STJJZ3JYTmZDSXUwSjdDOTMw?= =?utf-8?B?bzdYK293M3dPN3VSNXpHZEZuVzhpUGtWS3dOSXZNdUhqcTlmZHBScXl4d3NP?= =?utf-8?B?aEdwdm9NdTdJWnkzaHQ0R3ozcXB1dFQ1OCt1VG1qWFhyRDY4VzNlbitQU1Ni?= =?utf-8?B?am5NSEZueVVEQWtPMndybUlWam0xaG90R2hJQmNSOUpSZXcySGR5TlJRcXk2?= =?utf-8?B?TFpyNDNiUjgzcktNYWNTOHU1UWJrc1lFVjBySFptT1BoTDlyTWtrSU5uYjNn?= =?utf-8?B?ZXE2czQrLzlHMjFSVzZXK05LdzBGNXBackxkaWtSeHQ2d3dNSkJUZlY1UVpE?= =?utf-8?B?NkN0ODRYSVVVTklReTF2UUFQZWF2eU9OSjc4anA2SUpqZU85WUwrWDZ2ZCtD?= =?utf-8?B?OWlUTFVXSmw4QW9IVDcrVTY3Wk1jSVRzYklXWDJ1TWduanRrTFZjVzlaWDF4?= =?utf-8?Q?ytivp85OLrSkw6eskSLfCC2Ol?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: viFg7daSv/ioxtA+b6vokmZm8SaiaWv0Gb0FdYlcvB0Jd0ESMZYLotKUiRb9ML395FoSRWUqVpjTLTIUZhOZN6pHETpSDuhatuGE+HX1zGN7m7B61pU9fC2b8koYzxSgMZ4v/dG++uc2syOdqD2gMGuW988KvgCr70WltWf5t11MQf5fbceTXI01ojzK1fkvH6txJXfbXaxRDfsHzUVGMzZtnipZPCjQgLdn1fWIpo7wqTxQaqO/QZHM+rwWvQPHKIBR6ENQBJn+ePY7MoTS9WQrass4EsrHso1ng5Srwqg26gX28yn0uE1E0G0ASk75WX7l1FjA0GW/te5BfuCMfi0l+CR8fsOkqiRipTd0RdUyj7ZLhNJyAj2z3n+NNs5eCQL7h2JgarYFzYjn+QAqpNcCx1wGdNPYvoYtbQugRDF1hFSKar55YJl7CZ4kF9QNJ02PWW3d1HS37VZdrWq8utDVPXKoS5SXs4WLoMTdDli76rLeMJYHseZG+tlpt/HcsenZHkbbq4/HcSseCWWOGQhSUCmZ5bJnPsMEknR/hIFcU4aIegz/BuK8LiKgbz5BjscnumGmWSMtMYAC+3GBi5iicEbB5yL1tFYKyRmLmbg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab2223be-e78c-4b4c-ce2d-08dc84cde29d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 19:38:18.8118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CSGX5Yl2wfQaASOv4oIo7uu3+uA8PkTyisCa7CgWtB/dlKnKTzu85o2wx7wTk+J1I9ExwLnRkRMRNMDjZl1M6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6189 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-04_09,2024-06-04_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406040158 X-Proofpoint-ORIG-GUID: TlMj2HjupqrbYVhwX8RS-1u9gGBJjf5O X-Proofpoint-GUID: TlMj2HjupqrbYVhwX8RS-1u9gGBJjf5O X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BD7DF40018 X-Stat-Signature: z3inkwair9qf36akwrhyumyoixn7pynr X-HE-Tag: 1717529925-213076 X-HE-Meta: U2FsdGVkX19vKgyZPAeuB3xewBpew6uL1HP6XIus1Yp60WjezWaPx3nIuUItxATN2SGcLQf502brtMQtdw/5nKhMXNVpMW+R7cf2+zisM9yhrBWOvRAQtw2PiMTvPNfLOQU0GweMMwHCTxEnR2dT5Ro03LkqU9FYi3+S0hOzfPLxcMNKK6qOmSu28YCyQt8h5IViutbUUe2KcqijRtlrPPWqWKO3Bktvh6WDkgXmG+MGKSZYaNJ6BtyWXk5/c23+MM6gtqxnZmcIDDrxqk1xTrn2XiaemFcnY624zdzKJtP+2p6sOvu6ZLBUDyHG3dkYp4eneLmptzfBuQe+NB22k2tomt3I9eCtn4q1MmqbScoE5UsbA/xS2g7fPb/3w8zexx5KnkAXeRQINEThSl2SIePNftuXM17iiy5p9mPwbkwrA54cBCj96tzCoZKVn9LR3WBAksmCBUu5GKyrmbjnUNhZh/YsQThTH9vjdQ4HXqmzlWEtwIwhD2fq7po5Upfg1VzNffGRKLkpUMcSyfnweQEAAaRLnwNTeNbP71FuzoGcLJoJD76vdw3YGcmOTePo8SSrSTZfdAb2BdeTSOqmzWgNvwn9qSViVLC05ZEZ1lKEzXse9kzRjQ86MAF83AytKOCGEmgEqoR5YFdGRNH2x47U7PGk887hABdNlY5L94lzwe0Tr8q+Ri+kB0lW1TgD/ttG3PtqKub3fqYLad5CyFCJTvMKG8jzZ5WiuFMLSQNj+mSu7HchKJO1mrSwk95+oiET2H0Ms1saxYT8nzkQb5tmBOaEkUzOPgG9Lh/XLHofxovEQrlkjBKCPI0NdOdZTgVuhMw0x4dmjPCuaEO4i9YvAB/1fSpJQ4wJbDnm2G2eMUd5GUIvD0VTiejm7gxjvtt4jsI0Bikd5VCyz3oJoB+rRksiy5vJmJuerW4+rcFfkJEfHCKBm9GB5gk1XdkpebNtNAGRO9bObCJ84uL IaSPs+ty gMLQ+wQLp64GfRLYOZxJ1NTfonc4rGWW5vZ2ZHbQx0HzbNf3RiVxG3MiyM5yIS/f4N53Yl/xig6kHh6QC7d01MRMBkZZU50+UVb0AEyHIVNpD0XEn8jDPk2EmzdFqOHBj9MYwS/gv/6ZqO/AAipHrMCYh2A+3wn8BvXz6Z5wUX1j3mugUkDeMv3Sei6lJIsCss5UO6MJaMBHHbvKt4vjf0Hd8dtT5wIydIDftNxOq/R8j45joyYuVeZriPvgaMd7kKu4BvP1fyPfOzhuifvDSsnGljejr3vegR9O85pfXikI6FQhs5Txem4O92fbR0TZId6DSrqJqT1O3hVdkDHHWS2IYy3MbXi/jnciQL53oQi6u7DYO5MT3m2exajg9YwQGS0IUtRky521KGERGmeQNgK3mQ/ivRQUKOAlFIYLJL/tjrYrl3z62JUCPz555Ampb89on+wZUwbbk1FoPahiJO7wN/XMKQ0Z2JhEEc+YJsk8PKdYTXlsqNtLB1xt0JoR/PaHTUbkc9RLhqKfIsCKyRPgCSbDo3P2w+zm0Cxzq0488y0WZIJO+QQ0NjPXOyWoAy9VMgP/xYriFT0IFlumvmKEeI6dN5Ku2+3nUbVOprvJ2YQY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/3/2024 2:24 AM, Kefeng Wang wrote: > There is a memory_failure_queue() call after copy_mc_[user]_highpage(), > see callers, eg, CoW/KSM page copy, it is used to mark the source page > as h/w poisoned and unmap it from other tasks, and the upcomming poison > recover from migrate folio will do the similar thing, so let's move the > memory_failure_queue() into the copy_mc_[user]_highpage() instead of > adding it into each user, this should also enhance the handling of > poisoned page in khugepaged. > > Signed-off-by: Kefeng Wang > --- > include/linux/highmem.h | 6 ++++++ > mm/ksm.c | 1 - > mm/memory.c | 12 +++--------- > 3 files changed, 9 insertions(+), 10 deletions(-) > > diff --git a/include/linux/highmem.h b/include/linux/highmem.h > index 00341b56d291..6b0d6f3c8580 100644 > --- a/include/linux/highmem.h > +++ b/include/linux/highmem.h > @@ -352,6 +352,9 @@ static inline int copy_mc_user_highpage(struct page *to, struct page *from, > kunmap_local(vto); > kunmap_local(vfrom); > > + if (ret) > + memory_failure_queue(page_to_pfn(from), 0); > + > return ret; > } > > @@ -368,6 +371,9 @@ static inline int copy_mc_highpage(struct page *to, struct page *from) > kunmap_local(vto); > kunmap_local(vfrom); > > + if (ret) > + memory_failure_queue(page_to_pfn(from), 0); > + > return ret; > } > #else > diff --git a/mm/ksm.c b/mm/ksm.c > index 452ac8346e6e..3d95e5a9f301 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -3091,7 +3091,6 @@ struct folio *ksm_might_need_to_copy(struct folio *folio, > if (copy_mc_user_highpage(folio_page(new_folio, 0), page, > addr, vma)) { > folio_put(new_folio); > - memory_failure_queue(folio_pfn(folio), 0); > return ERR_PTR(-EHWPOISON); > } > folio_set_dirty(new_folio); > diff --git a/mm/memory.c b/mm/memory.c > index 63f9f98b47bd..e06de844eaba 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3034,10 +3034,8 @@ static inline int __wp_page_copy_user(struct page *dst, struct page *src, > unsigned long addr = vmf->address; > > if (likely(src)) { > - if (copy_mc_user_highpage(dst, src, addr, vma)) { > - memory_failure_queue(page_to_pfn(src), 0); > + if (copy_mc_user_highpage(dst, src, addr, vma)) > return -EHWPOISON; > - } > return 0; > } > > @@ -6417,10 +6415,8 @@ static int copy_user_gigantic_page(struct folio *dst, struct folio *src, > > cond_resched(); > if (copy_mc_user_highpage(dst_page, src_page, > - addr + i*PAGE_SIZE, vma)) { > - memory_failure_queue(page_to_pfn(src_page), 0); > + addr + i*PAGE_SIZE, vma)) > return -EHWPOISON; > - } > } > return 0; > } > @@ -6437,10 +6433,8 @@ static int copy_subpage(unsigned long addr, int idx, void *arg) > struct page *dst = nth_page(copy_arg->dst, idx); > struct page *src = nth_page(copy_arg->src, idx); > > - if (copy_mc_user_highpage(dst, src, addr, copy_arg->vma)) { > - memory_failure_queue(page_to_pfn(src), 0); > + if (copy_mc_user_highpage(dst, src, addr, copy_arg->vma)) > return -EHWPOISON; > - } > return 0; > } > Reviewed-by: Jane Chu Thanks! -jane