From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66617E7719F for ; Mon, 13 Jan 2025 10:07:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F05796B0099; Mon, 13 Jan 2025 05:07:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB5F16B009A; Mon, 13 Jan 2025 05:07:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2FAD6B009B; Mon, 13 Jan 2025 05:07:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AE9C96B0099 for ; Mon, 13 Jan 2025 05:07:54 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 58FAB1C81E5 for ; Mon, 13 Jan 2025 10:07:54 +0000 (UTC) X-FDA: 83002002468.29.94505C2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id BEBEF180006 for ; Mon, 13 Jan 2025 10:07:51 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jO9pEbIb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736762872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7rNTD193vSMTXyhHZ9NkXUwKUZO7hlen2I95MxpzwQI=; b=xV0gi5Hp10/nBdvlsUJXwltIj5haPiJqiUZw+fNWRp0HgR2h00CbkmbY+wgMJpNwt1FgdK BWPVl6YpzRWKc9J3V4bz60OkBgM+1ZDgeLC/cHtfbkdr46er9CDuDR52fgOn2qp2C+FJIf 4nWtu5pLpKtRSTwM61UMozLbX1Dm5PE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736762872; a=rsa-sha256; cv=none; b=OBnJr+QKOVwsoYwqaZYXPrGF/e7gpaIcxhLeDVUiFK4uFpBzLw9FqLwQQqI/XBRfX263Bf 7+miPWho1Z2BkeFkTKzt2OsHknZlCk0RPa2pYx9yM2nv4KxsS9YNyl0WE/q6WAglSAEylM 5VJSi3r1SXgIzo4IkY7oeCe+LXCGuoo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jO9pEbIb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736762871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7rNTD193vSMTXyhHZ9NkXUwKUZO7hlen2I95MxpzwQI=; b=jO9pEbIbdpCevaqeEd8NOl1lykINa+oFstIU/oTRBKD8xeNsYFs1E/VdxIbGxp8NFD/IAP DOd8zgGY1HLKn50Qll5QPrgRYHR0ubtcQGMVcczg4IYOTFO91z741cE166kLZdCJ1/FycC 9JGTFMsI99OsULss7vAtPeqIlAOo0HY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-412-IlCibhL6MZ6iJsyY56oidg-1; Mon, 13 Jan 2025 05:07:49 -0500 X-MC-Unique: IlCibhL6MZ6iJsyY56oidg-1 X-Mimecast-MFC-AGG-ID: IlCibhL6MZ6iJsyY56oidg Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4361ac607b6so32867965e9.0 for ; Mon, 13 Jan 2025 02:07:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736762868; x=1737367668; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7rNTD193vSMTXyhHZ9NkXUwKUZO7hlen2I95MxpzwQI=; b=Nn2yw178slh3247l/HDTaohJ4qD6Sz48Udn9lm7KNLr67qbtNg+vWMrMSj4qHkOfa1 K2OTVN5kLhFz0QEn9sfZdyLLBDyuR9a/2hhFg3cpa7gXW95ZQHHVtaHz9bNGjfuGNmoF c0ULbG0sAK3m79ZmEIlaZwoXnYAimEz29P/Q9NKaTGo9asESngSaXXOwNf7CTE5a6eti 8A/+PxAhWVCG4IAi+KzcS5BJ14u3c9ZXjxI1Su53XuUaTKnsY+Sym9ecc9HClc3c1aAo Lf/y143MYfxvGryYTzkAwCFfzwui1BOGlZndQUBwAVdSLYhK7erBbEIfYKqYN0o7y+Bc qTIw== X-Forwarded-Encrypted: i=1; AJvYcCVdxtBuCO+TD4ZtPsruvpYlzhJDZISkYu0QTQfTxaAacHIzb2X9TsRVXKsa+ewcHvgL58Q0az/23w==@kvack.org X-Gm-Message-State: AOJu0YxinHkWGIdHUN9Gv2Lv+T83LdMSTkuCjOgj1ye5rQoYN+KSF9s1 7Pma1zFxMXKOdu4h4z/AXjC2iuMxM0fsZrSrk2+P8dtPx87+YPgkWTK+f+LfHhl9gTVnA4O4chj K0LLUh9yoceZBCgnzLSb5FW5zhham3Rq0R1lKbWMTmT9Xv22E X-Gm-Gg: ASbGncvj9U4HsSOGsCYvbc1dn6EDc8KKyqnWtWUMH5a/bRWRxW3zJGCMtyjFBSj0+S7 GkXK2kjRMWow2P/96n2Ql3ZqFWmZa5l0ctBo72jqHxZq951vBLS31ZGbz35+OkhAAi9m6fyuaW5 IIJOM+r1exwkfuhpQGxOhL/oNN7wYiFwq4il4FiMDGkd9ySIVpsuvQsW5FiSnVgWViW7weYrTju UgVsA4UnihpwPAyaGI5s5EsRhCbo3sWoPHEramiuJPh5efGvk8S/ChLLCMdrlOSptN/D1ICxcNu G7jgAyUDZXFio48= X-Received: by 2002:a05:6000:1a8c:b0:382:4ab4:b428 with SMTP id ffacd0b85a97d-38a872d071cmr16565945f8f.8.1736762868194; Mon, 13 Jan 2025 02:07:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFJTLbl+/pB0wum17vS/yuTvKnH/YKlZ6n4UVMWStkQVhvf7Kl5evkXclZ+YVPK5imx38HFEw== X-Received: by 2002:a05:6000:1a8c:b0:382:4ab4:b428 with SMTP id ffacd0b85a97d-38a872d071cmr16565909f8f.8.1736762867827; Mon, 13 Jan 2025 02:07:47 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bdc0d8e4bsm2730484f8f.42.2025.01.13.02.07.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 02:07:46 -0800 (PST) Message-ID: <7b0e384b-6d42-48b7-ade0-f5a699bc369d@redhat.com> Date: Mon, 13 Jan 2025 11:07:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] mm/vmscan: Use PG_dropbehind instead of PG_reclaim To: "Kirill A. Shutemov" , Andrew Morton , "Matthew Wilcox (Oracle)" , Jens Axboe Cc: "Jason A. Donenfeld" , Andi Shyti , Chengming Zhou , Christian Brauner , Christophe Leroy , Dan Carpenter , David Airlie , Hao Ge , Jani Nikula , Johannes Weiner , Joonas Lahtinen , Josef Bacik , Masami Hiramatsu , Mathieu Desnoyers , Miklos Szeredi , Nhat Pham , Oscar Salvador , Ran Xiaokai , Rodrigo Vivi , Simona Vetter , Steven Rostedt , Tvrtko Ursulin , Vlastimil Babka , Yosry Ahmed , Yu Zhao , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20250113093453.1932083-1-kirill.shutemov@linux.intel.com> <20250113093453.1932083-6-kirill.shutemov@linux.intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250113093453.1932083-6-kirill.shutemov@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hUqs5btUQvkd5gIdxXYfNJuCyTpi1zQzpJvrGF11faE_1736762868 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: jwz8j9bj6stpubqoixiy9bgqf7yd45mo X-Rspamd-Queue-Id: BEBEF180006 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736762871-510055 X-HE-Meta: U2FsdGVkX19JjdJDjk3ETqYCWDab5cGuXr0bNmq88QQ+8AU7BhbwUdW8nRLCE0BHwoXo/PigTOYmz1O4lHWJ/m8chiYCWdRg2H488uNfHcZgre1KUiuY8sB1Rg7QNrL8WAHMPFwHf4fPMMvA4nGoV5N6JPRCuzoZmgmzhDZI1Qb/2egNDDRl8zEKisDIoLxsXJVYAvqrqElwnPGR4MJmOIgrPjENH6rYt2u0wzc3IB6niyy8fLx1f+S3Lzhc6sGqA21/xsSKbYeOfclRInia6esH7pUQ6QxQNjqkPLh3CaNcYiGE4QxsCHDlNkttyAJgaOKLl6Pw4rdKBVjnuMTf5wj16aZ4eWknga4U3fDD+XM8+abuQ0c+WJRdIJTznaGl8TC6gH7lAepIoCdsOR1EMexder4b1XqRUXU24tAejLXm9sorAJZqNNM3+aRTBtDf4uizpbPtiv/hMb0Z24Gge4yf8H2jDxqwk53KIAFz/Xe7u8F2AQBAElz9zIOdxMcX/Qu7y+xpJuabVHq/onfZ0NQs84xCGsbz5lUQNJrAKE2/Wk4VvKVSbQfBXvUSEP2F57vuNedByT+dVMiBXo3vvHi3DHMcOpPoa26iE4upzw0Asw+w1beOpKyc8M6OrnF7HzXjrMN2nDZn9yiQXcWVi8oFdBo5uoQcS2R3wtUlzHZyHwjNcTb+zBGNdNPsa8IxwtUFziKfLBQHSZb+eKH/9N9GAZkPm61m6KwLdt712PvF6TPyaa5Xd5fH+lBV5Ua0xlhXf/gqnJTzl/aSyOAX7cXZJPZsgDIm1sc/Xh4mf8bU7yg0Io5NEtBrsLcXtF4mjHOqTxnjZTJwI6mjCczfQ5EU0jhnJRWj1iHdklQfgXIBswmHVG50dw5iq5kovI8GnK71RlNkve1AyQGUYf1vK/hKQCJsl4oUqPhF3r6I6xtW8FC87zJ0kve4WZW1QM9FyKGLTsJqxPgC5lb76un sYWfunhE WgjJxYdF6zGYktYHFF+ZzM5myKorKt6cJNOr3mWbRERQMGGvtIjxmbsqCIfiQQfcAVvBXzs66xvyikGyKG+usiddY1y22VhvnlbWBi0+U/qFccRIZHt9wW1FFZGz1JSTU7L2EQ84fXpTWnd4YpmvZ+eZ8ACnRHhFP6kGHzjEzicSxKzWP4CSjBQ95b80NhGwe/1YrJ7PmSu6ILXIHwDVg/bffB7bQSsAOwsdplqsmCsO0J2UPdgibgqumCexAFK+iwdqkUcGZQCe41t66G6YbBrV+22rfVmCrRzYk2OLDNuOC3UKLSvYFAhiqZuzXnOmd+UolQSTzIm2B7ykvJfsc/iIWqEzhXKvQ7ZBn68VE9ZofJSENy6cOu/wjuqYNAmvJj78Bg+TZ+i0x/Fm35Mw/Zao+fvUjfc8vVQVSBbvN1tZU3szrmDCB63r4dOAawrwVNxoKxF4oehiIp/97V38H28txaoimVWA6d/7mt0Cuv7Wt/6XbrtuHLc/lU5ihdDs8doTPQ1I+gX/zezA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.01.25 10:34, Kirill A. Shutemov wrote: > The recently introduced PG_dropbehind allows for freeing folios > immediately after writeback. Unlike PG_reclaim, it does not need vmscan > to be involved to get the folio freed. > > Instead of using folio_set_reclaim(), use folio_set_dropbehind() in > pageout(). > > It is safe to leave PG_dropbehind on the folio if, for some reason > (bug?), the folio is not in a writeback state after ->writepage(). > In these cases, the kernel had to clear PG_reclaim as it shared a page > flag bit with PG_readahead. > > Signed-off-by: Kirill A. Shutemov > --- > mm/vmscan.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index a099876fa029..d15f80333d6b 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -692,19 +692,16 @@ static pageout_t pageout(struct folio *folio, struct address_space *mapping, > if (shmem_mapping(mapping) && folio_test_large(folio)) > wbc.list = folio_list; > > - folio_set_reclaim(folio); > + folio_set_dropbehind(folio); > + > res = mapping->a_ops->writepage(&folio->page, &wbc); > if (res < 0) > handle_write_error(mapping, folio, res); > if (res == AOP_WRITEPAGE_ACTIVATE) { > - folio_clear_reclaim(folio); > + folio_clear_dropbehind(folio); > return PAGE_ACTIVATE; > } > > - if (!folio_test_writeback(folio)) { > - /* synchronous write or broken a_ops? */ > - folio_clear_reclaim(folio); > - } > trace_mm_vmscan_write_folio(folio); > node_stat_add_folio(folio, NR_VMSCAN_WRITE); > return PAGE_SUCCESS; Acked-by: David Hildenbrand -- Cheers, David / dhildenb