From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14B47C71155 for ; Fri, 20 Jun 2025 13:49:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 763ED6B007B; Fri, 20 Jun 2025 09:49:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73B786B0089; Fri, 20 Jun 2025 09:49:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62B056B008A; Fri, 20 Jun 2025 09:49:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 540116B007B for ; Fri, 20 Jun 2025 09:49:36 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D1F4D1D7354 for ; Fri, 20 Jun 2025 13:49:35 +0000 (UTC) X-FDA: 83575911510.01.79EC07E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 5EE3CC0002 for ; Fri, 20 Jun 2025 13:49:33 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lCUxN6Ly; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Idb3ZSY7; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lCUxN6Ly; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Idb3ZSY7; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750427373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aY8KveTtkVaitUtryZn4N+/URSNBx+XDU9OFTbFeT/0=; b=UmLXP0icKRoG1GBPqNfFztKa29jrkm+d/i2VtabLMz7OMrdhmzSYAihH3ur5dMJN5bYypW M4w8FOUCVmqrj65irNCLxpoEEpAaOyoYBp+/X/3Xr9OjPJ//gV9CSrOr9KdPhNJUliRTFp 5W4/QQhAUNu/6JtNiV/K4WINbC5NQhY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lCUxN6Ly; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Idb3ZSY7; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lCUxN6Ly; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Idb3ZSY7; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750427373; a=rsa-sha256; cv=none; b=GhIADXpOuyUhmXI2dupgvqGCU8z1Nz1e/ltC+fGojwynfF2qfKvTWisTmbrBia8bfTAKFh TngLCgIWcMjXezD4clR3gSx8c134+sJx68IVGQpau7uiBCVAqZ21Bc1O69CTdBPZXJRTg6 c17ufI5xuvCWIP3gHZQgzTQQGjI7kM8= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B19341F38D; Fri, 20 Jun 2025 13:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750427371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aY8KveTtkVaitUtryZn4N+/URSNBx+XDU9OFTbFeT/0=; b=lCUxN6LyVqMmlp2Xq/RY+LsPRVYQprf2oVPUsBLAzfZX0nSCz0f4oTw3QqV+H8zBFAe995 9Yv0GAMOA/Y+7YcN4HvEHEgsdiXlbWHhzcPu+6KBuSPS1dQfN058cptwOWhqpTWmBROeWg bpzoSDXb3AuOefMVc7oajV+/I50bWOY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750427371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aY8KveTtkVaitUtryZn4N+/URSNBx+XDU9OFTbFeT/0=; b=Idb3ZSY7RUytIDT4fQGkN6FtVLuNSnDwS5ARhZWA6XjhhVmU9+othhjSsebTCM9Yme8nuG HApfGLn3VUcuqoBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750427371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aY8KveTtkVaitUtryZn4N+/URSNBx+XDU9OFTbFeT/0=; b=lCUxN6LyVqMmlp2Xq/RY+LsPRVYQprf2oVPUsBLAzfZX0nSCz0f4oTw3QqV+H8zBFAe995 9Yv0GAMOA/Y+7YcN4HvEHEgsdiXlbWHhzcPu+6KBuSPS1dQfN058cptwOWhqpTWmBROeWg bpzoSDXb3AuOefMVc7oajV+/I50bWOY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750427371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aY8KveTtkVaitUtryZn4N+/URSNBx+XDU9OFTbFeT/0=; b=Idb3ZSY7RUytIDT4fQGkN6FtVLuNSnDwS5ARhZWA6XjhhVmU9+othhjSsebTCM9Yme8nuG HApfGLn3VUcuqoBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8CBEE13736; Fri, 20 Jun 2025 13:49:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id omnAIetmVWgJQAAAD6G6ig (envelope-from ); Fri, 20 Jun 2025 13:49:31 +0000 Message-ID: <7b08cd65-6797-4678-9c24-a3ffad7acb53@suse.cz> Date: Fri, 20 Jun 2025 15:49:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] mm/madvise: thread VMA range state through madvise_behavior Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lance Yang , SeongJae Park , Suren Baghdasaryan References: From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 5EE3CC0002 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: mz65t1sozdaq7ek58j499o43syr8r7hx X-HE-Tag: 1750427373-788138 X-HE-Meta: U2FsdGVkX19N/sAR0g7u08euLFjo+Fr8sk8RZ8YnEdTSpGpZdjg0qMJdBqCUjxo5QdFtzy10F8LET1n2c9FjtQeL205G4FdY0ApM/UIYFh6plDTv4V5K0ybJSYpOdTzG3cvRP7Bl5LvVZ+1vDxhrr+6BYEttrO4aZ6xLS2rnY8Q/Mx13+ZTIvnhXBNSQcHSh3Iuc22iueIA1t192u/eFFSoSFZj1PfGbsKWJ+je97iWrD4j+uQda9nI3p7PQSI3oFouPqD7hIQ6hesagt/MsRXVerRUtoeNQLoK63NOnz1q2cZLaMjxvXWuZnRe/I4y/DTQKADhWwM3Monsab301qDschFrIY3ZHxuVEAN7cjkfRQ8FNYD/lBewCA11QLq3MDT9Hf3I72XaNkdj6jiBI3iz1FD6MSE4JttaCdWgJC5Jitogu5fBYnUVpFqZb9Bi19KPZ9WvX99xoenOoAXx5cU3eHTx0IwatgWUwu+g8jxyCdAUXTkAc4dctwgaP46c2QwHjdnovB6P/6mnFPWUxSr2lvpOcyNm92W9Gejoj8JcctoFjfL+JY7d1G3czhKPc2bU1BC7OVInG+WI0N6fxU2Pw6nd+KUX2gyNUNHRWRqqyjhVD+PNbSjYcrSFb7YWMab8BH9QmXZTDkGp9J1uN6gis3HqBYb/sBCLbmLsBXBc0LtJm7gSfSGEADPyHJ3KOwcvQKqGfBjeQiY18xdsruMHNW34Ua6FEqdwH+LI/MOf0zSlNZKxR0eM7oOf4iEytYsCK3Jyy2kfSK/y7Z1Ah0JuRrKyRS6RqEWO/CGmvqDO/USHD8Isx/6I4fZQpyWsmXtg30YKYhLOyUiwFORoLkx/fA3nqnFtB08ijNH0lXdpvUSPrRy8cpEgE/WGka9Jf63bODIRHBK4H7HGDoQE5+BucCxR0hTZw376a57M3a07U+uWeKyY3KKdN41+K7TJYAl5SBCXSg1+dfmIDEtY 66JECLLP s+wfGXv82rznKoUInkvWHaqF/KKSTPFso+q+Z7morBsEBGSzHGHiuEv5o4MXcAZx0Tm4H6+yZyOPs1SEKRvdPBA54hvQ64vdZcZlfh9R9ZI7ixg22cTKm5nZd+mlEtnpbu1iRs/WnmBeKXWxfAbU9FgHtVoYGJ1aCoMaATuK+HmJyOWpyQKBdIBziWS/9GB1iWOnQaog7HxK2cHUFd9gq/LkW9Dzdubg5Tq8e0Z8OcU3iNbdYUV8sa5iIURRFPkVc9JXnxBKJBtI/9RA20OCQsK9J/SVY/rBYLgmBsosfWooDIIoqkzjg9ko1x1Ti8u713ujbDIFTdMMFqrEOQIowfUCRb/cNW6YFabD+hpfEDCZNTHQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/19/25 22:26, Lorenzo Stoakes wrote: > Rather than updating start and a confusing local parameter 'tmp' in > madvise_walk_vmas(), instead store the current range being operated upon in > the struct madvise_behavior helper object in a range pair and use this > consistently in all operations. Yeah much better but it still took me a bit to understand that "end" is now the original range->end that doesn't change during the iterations. Maybe make it const and comment? > This makes it clearer what is going on and opens the door to further > cleanup now we store state regarding what is currently being operated upon > here. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka > --- > mm/madvise.c | 101 ++++++++++++++++++++++++++++----------------------- > 1 file changed, 55 insertions(+), 46 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 47485653c2a1..6faa38b92111 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -58,17 +58,26 @@ enum madvise_lock_mode { > MADVISE_VMA_READ_LOCK, > }; > > +struct madvise_behavior_range { > + unsigned long start, end; I also thought multiple names on one line is only done for local variables, but always separate declarations in structs. But I don't know if it's documented as such or if there are pre-existing counter examples. Consider it a non-binding agreement with Zi :) Thanks!