From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47875C71136 for ; Thu, 12 Jun 2025 14:16:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBEA86B0089; Thu, 12 Jun 2025 10:16:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C95E46B008A; Thu, 12 Jun 2025 10:16:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAB516B0093; Thu, 12 Jun 2025 10:16:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9C83D6B0089 for ; Thu, 12 Jun 2025 10:16:33 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3FCDA810C5 for ; Thu, 12 Jun 2025 14:16:33 +0000 (UTC) X-FDA: 83546949066.10.0CE5CF2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 34173C0007 for ; Thu, 12 Jun 2025 14:16:30 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QcVqEPs+; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749737790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vn5KxC01xvmiFp/syyWqBt2AJ+Zmvl3pjCQmiPB8670=; b=3qksCrL63vcYQJuHLDYuuh79nCgDg+Xu1NHGrUIgwvNCcwpui/nuOZnT97dSHcLUAN2puL 24QuR+aKi2xFwYwIirmvFzrzKrzwPLUgx7vy2joT2/Xj5ULoquUeblpRygVSYsI7u8PdE/ rqDuwDaxDWKsbG1M+rGh0CaTeAPMCKk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QcVqEPs+; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749737790; a=rsa-sha256; cv=none; b=OectlD7dnDpG7o3trz1VHY63ght70qrN2Fd/ButIhtJLnrcxKrGNbGusl/8TwnDfWqdxKT 5yGWATVku5+VjWRS7Yl8IwxozwzWsdgqz8cSnGiwt9l8B+g+Q5P69TJBVD6PAwWaM//WnL K1rfBHjgoEkKNgIcd+/IcQn6dMR1eY8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749737789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vn5KxC01xvmiFp/syyWqBt2AJ+Zmvl3pjCQmiPB8670=; b=QcVqEPs+KHA4uORZEP2eWsav8R8RRIVAZMdpDJHavn8h9IQw64gArtfcgzu4L2vu4dOXmp RzK+UVaiIYyyTg1SPHl1le8zge6U5ZaeELw9MyD8MtueHenaeGf+2Zxjt1/vPJttLpf8cM MB6ASEFb+xyYiKLlxfrAdLg32Uz0/bw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-QIHQ1y0SO0Kvj9j9PfbSWg-1; Thu, 12 Jun 2025 10:16:27 -0400 X-MC-Unique: QIHQ1y0SO0Kvj9j9PfbSWg-1 X-Mimecast-MFC-AGG-ID: QIHQ1y0SO0Kvj9j9PfbSWg_1749737787 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a50049f8eeso525758f8f.3 for ; Thu, 12 Jun 2025 07:16:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749737786; x=1750342586; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vn5KxC01xvmiFp/syyWqBt2AJ+Zmvl3pjCQmiPB8670=; b=v/T8PkS3nAM5HfA7lUytXbQiNEp0b2V93HliOBSGS03qbt7ZK8H1hAH9Bqm6E9iuZM lwY12m3shfWbieNHyG1Q1Gi4KTUX12HfEuy6p0ma3neuDvywZZSQzo9NRHhF/egvu9YQ nMUPukdGwzl29Z2eAjmo5JW83cCFSyyMnK5ekGMwHtPVW/DpP4m/ny20a+EDBYA6kn3w u4Hen1MH37L0cx9MBKYfYKftyUMI2H6FtYXjW8j7iroUfl7yemW3EL+9op9c1Q6y8Bw0 7HDy8roweYpYW53w0liTO74IkbUCj3bx/FPmt4gat0W2gHqsYcs7jOc3CxYvykZ6Q168 MGTA== X-Forwarded-Encrypted: i=1; AJvYcCXTYrSsHl/y0WcsEs7LuT3/0SNBfwTZoF0kGCIipko6QJpaOysre3/w6pZZNg+q+j1xulvYrd5tjg==@kvack.org X-Gm-Message-State: AOJu0Yz/dp0uqvu41UsviwqYUTmb+DmEkYq4oan4Yk9ZiQATVcdzPlt+ ciFCWHkhDdetDin9E5+zLq9Vfnx6OjoWS6Z0SoIl1yK67nFDgv7x3y3T59eNXJ9wY1KhnKRrwBp S/6BHiw7MXgZuKvu7RdPSx+7cWWuUVwe9i4l8ZetjKuff8VxSL4Sw X-Gm-Gg: ASbGncsEOCIwznd5xMseC2Zk4UolUz0wX6G4/cndGjM+WFINm/APfgj2i8f8iLnAMo0 Kfo/tQXtiWhhrxXmVO9DXCrSX+Rch8mXAv1Wc/Swphb5ULbc1RH9ptEjbxU4X4A+a585a9P9WQN VVMi/oYGGNdYJ8o1hFtEFYAqlLuH0cy5S0y7iyJc10MtC0R0dK6Ntz8g/ohDUJ6thv26ZTWu6oh avvWdOgkmuzo+35PrEXwLpes56fEh28tH8C/BzmqppmbjAT9Y2OW31+B8lwl8r4Qa+EmyQlhzla IImFk98iUWCIBh5XOo4wmWNbPflkw4qeYnTRn/qqfW5ORUuxdS88U2Jk5Jv9LJiKZU7s+7VDn4p GtLYRSEHucwz9njyM4yZ5scWMO/p0iroT01bFbC0jxBwqsCgLdQ== X-Received: by 2002:a05:6000:4305:b0:3a4:f7ae:77cc with SMTP id ffacd0b85a97d-3a5603b08ddmr3034680f8f.0.1749737786448; Thu, 12 Jun 2025 07:16:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1A7mp073xZaNS9y1PabnR7Iw/E97SE3d2SGCKiHbtPjJ5G/l1yk4DbgQ6shodPe4sIJT/DA== X-Received: by 2002:a05:6000:4305:b0:3a4:f7ae:77cc with SMTP id ffacd0b85a97d-3a5603b08ddmr3034625f8f.0.1749737785911; Thu, 12 Jun 2025 07:16:25 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:1e00:1e1e:7a32:e798:6457? (p200300d82f2c1e001e1e7a32e7986457.dip0.t-ipconnect.de. [2003:d8:2f2c:1e00:1e1e:7a32:e798:6457]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e13c187sm22369795e9.23.2025.06.12.07.16.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jun 2025 07:16:25 -0700 (PDT) Message-ID: <7b03ba9d-5ace-4c1e-a415-544b471f19d7@redhat.com> Date: Thu, 12 Jun 2025 16:16:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs settings are disabled To: Baolin Wang , Lorenzo Stoakes Cc: akpm@linux-foundation.org, hughd@google.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <8eefb0809c598fadaa4a022634fba5689a4f3257.1749109709.git.baolin.wang@linux.alibaba.com> <1ec368c4-c4d8-41ea-b8a3-7d1fdb3ec358@redhat.com> <2ff65f37-efa9-4e96-9cdf-534d63ff154e@linux.alibaba.com> <953596b2-8749-493d-97eb-a5d8995d9ef8@redhat.com> <97a67b74-d473-455e-a05e-c85fe45da008@linux.alibaba.com> <201a1cc4-93fc-48e3-aeab-759ba8c8a47c@lucifer.local> <519c59e6-20ef-4edf-88b8-a71f38cbd2de@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <519c59e6-20ef-4edf-88b8-a71f38cbd2de@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Ay8FjGc0FNu-UfIXDECelfYvGXtJPA63uNexZnKBP6U_1749737787 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 34173C0007 X-Stat-Signature: bu3cgrcnku3h4dqg5wk4swwnofcyp5dc X-Rspam-User: X-HE-Tag: 1749737790-367316 X-HE-Meta: U2FsdGVkX18qsR1iN5H/lVT+LJvXhOKz0nCucQD+yv8FOqgM983Nqy5vruUWr6unNpWMZH8CzQFbxRbJGDUTr/yKQp6D3WlNsZM50jpZEIU0l5Zu2sk3TcLtCZeqZrduJPCABi2PWxTOEU7WG2nQsuNzi8eVivG+LTVI3i4VKcboj1Hp11wvkpVwTHx9B9DYgQYCohLu9MAV0eEivnBu4+qNIzTFAp96oTaueHHkiNkC2U+NVk/Av4adr1yLA3iWw8kxNUE2VNDDllRIpwhznFPwPo4fNkkUDQjzC0o76YkRDq6/WpIPHJKfS95Eqrd8lrza+mAWa8zaiIUjhbRCnJMBVB23lWh0+BiLFcdkID240hCk4mp8TSDvlIhpL7195ItOgaLqtRp/sPi0GFXDp5Cksh2vP0kYxQhLPurxUn5jRir8pzuW1lWMhK+8FJ0JjFvVlkeMhE0dmHhjl35MeA7Ev/ICaOdG3I/KyRpwOuoJgX0RJHOmAzsuMXG5GNK42rRIqA02k6KmPJFGT3ehWF1LXvpkLFbmCuIxhc4gAcbDF/j8dIbHRV27Jj0s3s6l8QrcG5J2xkOFAJysnM2WHO0ziM2Inyb+k320zPVjsIfHcwBzh3oUwmyW+E7/iA4FpKBr0Y67ru8JbKMrhybSRrfavttYBadoOqSf0tWRTdjBps1zZ1qf6hoz1ZTVK2QHHF1upQSpYeUg22nm7FTMU7ic7TTqVPKPzfqb1ip7i5X17vnjU5SOSxbqxV4Cz9wUd59AOB67Fgq8pbdnLmg+TvDAZjI6Pj5nIUtC0HhUNhUxeebopv6XA93ISteR2XOaIihsuApuem3Pz96tJNunrg2G7M41LZGW+so60j+/1E4p63zZH2zDcxJOvpsh8LdRH7o0byOvPmejCmSlba5L06LPR66FtmthLtjarQVt2uE5CZH6meexzL73X/JPl6RlWagjZ8rOctnKt47UxNN B3CfNRhP NpL8G4hTcbPxXbbidXHO8koZj2T8XRMl67XiYqOhk2Y3pBy88e0TeCWivfkNJXn+dgWcuEHglF8ktkTrWW6jL5kxtnqmndT8PtsHGgzW7d7s4bQ/CjtKMaOwOwo3lb1IrWq2EqRhXit1YPFco/kgeXn7cH/smWoWCJCJbQcCg++7qBErdDO/Lkcv3n0oJFVCQ4rQBsB9Cgt1k8+WYh7bo6TFRNDs0jUI97JfE/OrMU8h7e/kg9pXt/gn9zJwlSUC6QxSeEHvYvsx3AAHTj8XRG7OJujpDLMd0MyzD/nnPS+6ODrEAFAOKPATu11oR340iBdF8sXDMF+XX8UONjM0/l9jW/espbjnvoZkN3iIaI/Mfumflxz67hq6bp52945HVsXUiQkwRQCIHm/vLNO79eux+MiukpWZ4vfiotcADDW48F0aLwIisNgfMx8NYa7NTMA/5gDdv5nDWj/8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.06.25 16:13, Baolin Wang wrote: > > > On 2025/6/12 21:29, Lorenzo Stoakes wrote: >> On Thu, Jun 12, 2025 at 02:27:06PM +0100, Lorenzo Stoakes wrote: >> [snip] >> >>> I propose a compromise as I rather like your 'exclude never' negation bit. >>> >>> So: >>> >>> /* Strictly mask requested anonymous orders according to sysfs settings. */ >>> static inline unsigned long __thp_mask_anon_orders(unsigned long vm_flags, >>> unsigned long tva_flags, unsigned long orders) >>> { >>> const unsigned long always = READ_ONCE(huge_anon_orders_always); >>> const unsigned long madvise = READ_ONCE(huge_anon_orders_madvise); >>> const unsigned long inherit = READ_ONCE(huge_anon_orders_inherit);; >>> const unsigned long never = ~(always | madvise | inherit); >>> const bool inherit_enabled = hugepage_global_enabled(); >>> >>> /* Disallow orders that are set to NEVER directly ... */ >>> orders &= ~never; >>> >>> /* ... or through inheritance (global == NEVER). */ >>> if (!inherit_enabled) >>> orders &= ~inherit; >>> >>> /* >>> * Otherwise, we only enforce sysfs settings if asked. In addition, >>> * if the user sets a sysfs mode of madvise and if TVA_ENFORCE_SYSFS >>> * is not set, we don't bother checking whether the VMA has VM_HUGEPAGE >>> * set. >>> */ >>> if (!(tva_flags & TVA_ENFORCE_SYSFS)) >>> return orders; >>> >>> if (hugepage_global_always()) >>> return orders & (always | inherit); >>> >>> /* We already excluded never inherit above. */ >>> if (vm_flags & VM_HUGEPAGE) >>> return orders & (always | madvise | inherit); >> >> Of course... I immediately made a mistake... swap these two statements around. I >> thought it'd be 'neater' to do the first one first, but of course it means >> madvise (rather than inherit) orders don't get selected. >> >> This WHOLE THING needs refactoring. > > Personally, I think the 'exclude never' logic becomes more complicated. > I made a simpler change without adding a new helper. What do you think? > > static inline > unsigned long thp_vma_allowable_orders(struct vm_area_struct *vma, > unsigned long vm_flags, > unsigned long tva_flags, > unsigned long orders) > { > /* Optimization to check if required orders are enabled early. */ > if (vma_is_anonymous(vma)) { > unsigned long mask = READ_ONCE(huge_anon_orders_always); > bool huge_enforce = !(tva_flags & TVA_ENFORCE_SYSFS); > bool has_madvise = vm_flags & VM_HUGEPAGE; > > /* > * if the user sets a sysfs mode of madvise and if > TVA_ENFORCE_SYSFS > * is not set, we don't bother checking whether the VMA > has VM_HUGEPAGE > * set. > */ > if (huge_enforce || has_madvise) > mask |= READ_ONCE(huge_anon_orders_madvise); > if (hugepage_global_always() || > ((has_madvise || huge_enforce) && > hugepage_global_enabled())) OMG is that ugly. -- Cheers, David / dhildenb