From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F6DCC77B7E for ; Sat, 27 May 2023 21:50:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D341C900003; Sat, 27 May 2023 17:50:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE3D8900002; Sat, 27 May 2023 17:50:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BACE7900003; Sat, 27 May 2023 17:50:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AC986900002 for ; Sat, 27 May 2023 17:50:28 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6B2891C6A83 for ; Sat, 27 May 2023 21:50:28 +0000 (UTC) X-FDA: 80837379336.19.F52C54D Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf03.hostedemail.com (Postfix) with ESMTP id 8C9912000F for ; Sat, 27 May 2023 21:50:26 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=CQgaY0bm; spf=pass (imf03.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685224226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HTsVdUYETUvQYhUsw1vPQ/A3pGTfainUln+I/qbbldc=; b=YkXC9ILZaz7ovbu7OPD9lVPoNUKbOA/N7vSBsqIx4wChEaFbrz3ZFEEFezlJqDUq2netUJ WtfmzsZAqJcIw6wdhEBxM+c4Dtr5nAMurfZRPPpVtwtSPiaojgji97e7uKfBHokqF9qw4g 2PoKhgMf11eb51VVHrGXSuS/e6v8glo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685224226; a=rsa-sha256; cv=none; b=UiVLnE8T+pTGxDpyx2QgXp4I55YYIY4XMa/Owubjt8S2Nr6spAG+D0vMp1TlK7vxtgaR57 0yZV8YxuRuYo3XgyzYdy9O6uCDx25+j7IJewfBeqBWxYiUUYUQLPX8OWImMF0sJ3To/i+x naflgk6gTFaCN2uuze6F8ukXSFMMkR0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=CQgaY0bm; spf=pass (imf03.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-3f6e1394060so13138985e9.3 for ; Sat, 27 May 2023 14:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685224225; x=1687816225; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HTsVdUYETUvQYhUsw1vPQ/A3pGTfainUln+I/qbbldc=; b=CQgaY0bmsaNbweVhEC0EK6GXufe06allmuKFEgeGlfGP9QY+P6tncaRLlow9wr+dJm Mx+iiysTQEZnoWlNMRz8e5xU2nCLr0d3HfcGL+HtuRCabqOOtFALGjticDrsVQQrD+0y +0lySbjFg+qZmklNrU+6HS6Sg4UOu9DIgyoTAX+NRrQ+Wrb++UfBGrMeyb4JGsu6uAd9 zwuKp4uT3YUh4Jjque+4SRcMj9WhJCQlVPpODZbNZhRW38+/28OUVW3sWLSnWeHJ22jk zN96CH7Z6W1C5DdBb9hM2HpZRWkORsdGHGmLxICUk00a1Up7mAXkAc+K3rcU94B4EXdQ W9fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685224225; x=1687816225; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HTsVdUYETUvQYhUsw1vPQ/A3pGTfainUln+I/qbbldc=; b=DspshHRvjYOyRQHh3/2KXqsLKr/0NAiyXYr6TbOuixOL+qBiMJSWe8HEope8d40H8z Wy4dEtFARznV8zK0fRNURQ3rZ8F5UU5v4lNAULrIHykQbSpwzMsmbmo9ubN3fJbEoYSI 90ripbmFI0XoheaS51HcurqUvKJt5FUxvYtf+0KQwWrFJRMJmZV+UyWg9gYLz09vDpQD z8EpPYwkvqCKDMlmsV6puFjbc5j/c6cIzNkHtjoqiSA31L6g9xLyfXDqfHFjOi0OM4Je VRv3Rz2f+UP5R7HuXpb+yRo+7IHg/iOz239yv9vTKVfIr+VPC2Q6fejoOubBnnjs8KrH HLow== X-Gm-Message-State: AC+VfDzTwVi1qnvbxICM4Defz88GVS0gkrOkdJnmfY443ifIdzhuL4np f2H2IEcA6PFMLGhz95il+kw= X-Google-Smtp-Source: ACHHUZ6iYmBy5nvwNicNEHak52BAfb3Xn61RNndtwukSHqCQVlO+DGtBHKytR6CyIp8smldrBn3WzA== X-Received: by 2002:a7b:cd8e:0:b0:3f6:113a:2023 with SMTP id y14-20020a7bcd8e000000b003f6113a2023mr5496015wmj.12.1685224224699; Sat, 27 May 2023 14:50:24 -0700 (PDT) Received: from localhost (host81-154-179-160.range81-154.btcentralplus.com. [81.154.179.160]) by smtp.gmail.com with ESMTPSA id r8-20020adfdc88000000b003077f3dfcc8sm8977794wrj.32.2023.05.27.14.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 May 2023 14:50:23 -0700 (PDT) Date: Sat, 27 May 2023 22:50:22 +0100 From: Lorenzo Stoakes To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 2/9] mm: vmalloc: Rename adjust_va_to_fit_type() function Message-ID: <7afd7647-15c2-4398-89a6-ed50b4115b84@lucifer.local> References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-3-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522110849.2921-3-urezki@gmail.com> X-Stat-Signature: p641ufmeidkpmodcman3p86umbcf7ror X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8C9912000F X-Rspam-User: X-HE-Tag: 1685224226-836242 X-HE-Meta: U2FsdGVkX1/jrQrbUKo5NhLwBr+999ih6sXCwvwBjJVZwmSyFjxOcZDECr7WJkDq0yBqtpluo5S5Xtawt53iDJsaTkE5D25H6X017PmN2mQIoFVP06gSghcKRtgKEF1H6snyCnrOFtc6e5UsJ7iW334wjBtOAT5D5rjXWy5Z3Jx4E6Ptkw4DfXnKpq4lM3alS+Tdxkqq3e9KwgmIKBF7xX01HxypUG81FG1N6HZhwzgV6jj0C/TbvnYuL8yjY/VjYDaEl7Qd0kqKhUG+Tl6qgCWi7UhMwCEcebkeT5wGJhgSgw9zfYKfhH5A8B7pQ0l7U6tUV+Ag+o/LC2UsjDSBtCGuU8tKnBPOTNSl2PHF5xquuA4SeIcc9zDDAk0IixOBEl/s7NsZgxsdq+EkLON6pohIBvHgpU16uRqclx/j4Tbw4+DVoEpjDFbSnP1dMa3jxl5yNlhY85jEDbB/9QZ8xBjveJRz2/3QnvDjxJqI60VhSNS4vFkYEzz9ml1ICUlypC97xlC8eOGBYoKyTIdn9pJrig+JB/osYTmFF4W8gLiMSiiNGGD+br2290mKnK5WmSrUnxhne7ThSliyHylLMeqyAiILEM5iYz/jkZzB6/6Ptu2kaKUBmR6UKjKqg/SiHWxjnNqBPaWA0u+lCXPzumWYWCyd2+IaryX7kcyuzThRVGCBKAdBSO/QBYCnVdOzI9FVXakz+ICKcBBTW8bTm54q7qjOMcdEI6RvyPakn5aO8NA1Vv7Y48EcruR/euOAgGAIRv3tYx7h2DLfuXhFciRb9n6EbwYArH4oVWgdGa+Q7cFF5iRwxR+4OemC9V1dz5kYU/1ZWsrb2Wo8BnLyEuAFe8fF/z8KguslJjSqKBrym95LgbuHShdENJQ8D/achOg3rHf+gBGrG1jHhHxQKqGou+fKz8XaieYwZlX2Us2bFjQrDQeWpHkn2lXU/AOlUTZWjaG8gg36po4B0TG i2lRhj/H Ic7JUXw8T2RH3NCrA6lhDule2GJApWNFKm2nEmBloFvXYjistQvVjOvZ01qx2wGvme/7gFzqXr+mpMHq0quPZijUoP2/XY3b31BxHRXwxX+osjvXokhMFRiBwirng6ZEK1Dm2NldbsUo+FE+mQKZPp9z2tcl0tar5HRtktR/zZZSp38wnZmkdKAefYUN+5VbBb/sWN2MoG5S6exffGJ1H7fS2THB6UI2n8cVCUnDMk19K5Gatc9pXICFImjHsorUgWMUN+2mp+yZ84y7ihuLRFg7c4BYadrTSx4YlfHwre5ri5F0gy8JT9/npTgp3na/vsDF5PBjjKjREPwWSbIYjd/Q5td8kG0xzLOYA8zuSA8cDSkI6WoFtc3Cj+HwBVpsPx5E+HiTmqux3L+h+bblV7/lxfeY0KEfmB+L7KWq5sP78eCOC+2uG+W9d2VyY2VjdylelnwqYa2vl4Lfjiab+2XiSFg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 01:08:42PM +0200, Uladzislau Rezki (Sony) wrote: > This patch renames the adjust_va_to_fit_type() function > to a shorter variant and more expressive. A new name is > va_clip(). > > There is no a functional change as a result of this patch. Small nit - I think:- 'This patch renames the adjust_va_to_fit_type() function to va_clip() which is shorter and more expressive.' Reads better here. > > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 409285b68a67..5f900efec6a9 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1383,9 +1383,9 @@ classify_va_fit_type(struct vmap_area *va, > } > > static __always_inline int > -adjust_va_to_fit_type(struct rb_root *root, struct list_head *head, > - struct vmap_area *va, unsigned long nva_start_addr, > - unsigned long size) > +va_clip(struct rb_root *root, struct list_head *head, > + struct vmap_area *va, unsigned long nva_start_addr, > + unsigned long size) > { > struct vmap_area *lva = NULL; > enum fit_type type = classify_va_fit_type(va, nva_start_addr, size); > @@ -1501,7 +1501,7 @@ va_alloc(struct vmap_area *va, > return vend; > > /* Update the free vmap_area. */ > - ret = adjust_va_to_fit_type(root, head, va, nva_start_addr, size); > + ret = va_clip(root, head, va, nva_start_addr, size); > if (WARN_ON_ONCE(ret)) > return vend; > > @@ -3979,9 +3979,8 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets, > /* It is a BUG(), but trigger recovery instead. */ > goto recovery; > > - ret = adjust_va_to_fit_type(&free_vmap_area_root, > - &free_vmap_area_list, > - va, start, size); > + ret = va_clip(&free_vmap_area_root, > + &free_vmap_area_list, va, start, size); > if (WARN_ON_ONCE(unlikely(ret))) > /* It is a BUG(), but trigger recovery instead. */ > goto recovery; > -- > 2.30.2 > Otherwise, Reviewed-by: Lorenzo Stoakes