From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96836C27C4F for ; Tue, 18 Jun 2024 20:17:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B54D6B026A; Tue, 18 Jun 2024 16:17:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 716126B026C; Tue, 18 Jun 2024 16:17:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5199C6B025E; Tue, 18 Jun 2024 16:17:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2D9E56B0255 for ; Tue, 18 Jun 2024 16:17:51 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CF94C40A6A for ; Tue, 18 Jun 2024 20:17:50 +0000 (UTC) X-FDA: 82245120300.01.24B2F0C Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by imf19.hostedemail.com (Postfix) with ESMTP id EBA061A001D for ; Tue, 18 Jun 2024 20:17:47 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=E+ZnJbf5; spf=pass (imf19.hostedemail.com: domain of m.szyprowski@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=m.szyprowski@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718741863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dB0AWSkQTUOU9QyCV/W0Hl3ec8vt1AE5YCai3dZxvxE=; b=JDKwgAj0QEoqBxIig730zKv+fAteEkCE8MBUxIZEKZprrqFxGnM2bUko7qXNaiIt/j8rSF rfSqWMtJd0IvivnCKZnFAm1waf72r2ZgG7c5SyfsEJtJ+xmUeTHxZUe6t7VERNn1SUzpJz lKDMENAvWm3t/UdVptjgjmWsWYqZPiY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=E+ZnJbf5; spf=pass (imf19.hostedemail.com: domain of m.szyprowski@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=m.szyprowski@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718741863; a=rsa-sha256; cv=none; b=YwKnhfyIE4CSdune0Woo2uXAOIEDCwPh5HzIADKtvPpCGvZNR/qv7VsKYt/tMw1s1nmJ/2 7F1f6fyMifo6jSI4wB7ShQavu4CvJdTAylgS93BR7gNFZ3vMVSYXvMQm6d2StHNtv9ll1/ pHmhkeLOdWeeR4IMe8AHET/Uz/k7Nm0= Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20240618201745euoutp027dd18413fab2fbe54d588107a9f9c354~aMp7CcwdD1697916979euoutp02a for ; Tue, 18 Jun 2024 20:17:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20240618201745euoutp027dd18413fab2fbe54d588107a9f9c354~aMp7CcwdD1697916979euoutp02a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1718741865; bh=dB0AWSkQTUOU9QyCV/W0Hl3ec8vt1AE5YCai3dZxvxE=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=E+ZnJbf56qX8YDIZQAfxnrF5IKiXc2wLCJcGlqRtS5nNlpRD9L7N4nS4rAwevEmVU YGf14SwPeLV7F3et75LHiHaH62umUjmZsqTC+mGTM4J5gT24z+UqpMkZLDPG5EYLQ5 KkKX/MsQ6Fbu3D1yE/aQZNTR0tqXGGLY4ygSt/9Q= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20240618201745eucas1p2325c1b00dbb107b983278aff464c5ddf~aMp69O3iV2058020580eucas1p2W; Tue, 18 Jun 2024 20:17:45 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 12.EE.09620.96BE1766; Tue, 18 Jun 2024 21:17:45 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20240618201744eucas1p1d5ea63c6b776e2e1770a6d0ba9c86ae4~aMp6tkffr0594905949eucas1p1L; Tue, 18 Jun 2024 20:17:44 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240618201744eusmtrp2ee4b83c956fdf522fec86d97c74046b4~aMp6tHBih0178501785eusmtrp25; Tue, 18 Jun 2024 20:17:44 +0000 (GMT) X-AuditID: cbfec7f5-d31ff70000002594-ae-6671eb6994d3 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id A5.B2.08810.86BE1766; Tue, 18 Jun 2024 21:17:44 +0100 (BST) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20240618201744eusmtip153bb8ff0d0e262733b53e0f3787050f0~aMp6SvKOr0174501745eusmtip1c; Tue, 18 Jun 2024 20:17:44 +0000 (GMT) Message-ID: <7afd05e8-21bb-42c0-8c11-ff2108a74880@samsung.com> Date: Tue, 18 Jun 2024 22:17:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 -next] mm/hugetlb_cgroup: register lockdep key for cftype To: Xiu Jianfeng , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Language: en-US From: Marek Szyprowski In-Reply-To: <20240618071922.2127289-1-xiujianfeng@huawei.com> Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupileLIzCtJLcpLzFFi42LZduzned3M14VpBnP+slrMWb+GzeLyrjls FvfW/Ge12D5rB6MDi0fLkbesHps+TWL3ODHjN4vH501yASxRXDYpqTmZZalF+nYJXBlndq9m LtigUDF72USmBsafUl2MnBwSAiYSd1/fZepi5OIQEljBKLFo7XpGCOcLo8ThbY1Qmc+MEuvn fGWGafm06w8bRGI5o8TeuUfYIZyPjBKX309l7WLk4OAVsJP4/jYFpIFFQFVi17LzbCA2r4Cg xMmZT1hAbFEBeYn7t2awg9jCAkESh08sYwWxRQRcJNqOzwSrYQZadr/1ISuELS5x68l8JhCb TcBQouttF9hMTqBVu2Y2sUPUyEtsfzuHGeQeCYE9HBK71u1kgbjaRWJZ82I2CFtY4tXxLewQ tozE/53zmSAa2hklFvy+D+VMYJRoeH6LEaLKWuLOuV9sIJ8xC2hKrN+lDxF2lGj/fRXsYQkB PokbbwUhjuCTmLRtOjNEmFeio00IolpNYtbxdXBrD164xDyBUWkWUrDMQvLmLCTvzELYu4CR ZRWjeGppcW56arFxXmq5XnFibnFpXrpecn7uJkZgcjn97/jXHYwrXn3UO8TIxMF4iFGCg1lJ hNdpWl6aEG9KYmVValF+fFFpTmrxIUZpDhYlcV7VFPlUIYH0xJLU7NTUgtQimCwTB6dUA1Nt f9DKyZMaAv/daE5unmZ/oUT7S4/E7n0pYn8nP7zYXizL6Z9801vIgu/NZOWpfPcnljarnw54 UnkncXoJ/5aDDNEHt83PnGjftTN4zcI7QvulZr2s7ru6/N3LDre2K6UX+N5YxrztupK2qmzD 5Sd2ttUz3+SLlipG823iuvG8XTvKaI3+SQ91H77rS9w5N5n9lIqvf1IhMdvsk9gyw+Ue6a0c Nn4GQZ8Xd1zJ0hfRDVO4z/rk51LRZI2qnoVG7wzSAtgmTYt7UrE6eJYve/PPCa4/Dj3aZLt1 1qIeZeNXzdOMo7j6Bf5t2f3qbm7aPrtZrzo2Tmt+bFPUn3RMvWW92qGb71Yw+SueOlH9UVOJ pTgj0VCLuag4EQD6WVh+nQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsVy+t/xu7oZrwvTDO7dM7CYs34Nm8XlXXPY LO6t+c9qsX3WDkYHFo+WI29ZPTZ9msTucWLGbxaPz5vkAlii9GyK8ktLUhUy8otLbJWiDS2M 9AwtLfSMTCz1DI3NY62MTJX07WxSUnMyy1KL9O0S9DLO7F7NXLBBoWL2solMDYw/pboYOTkk BEwkPu36w9bFyMUhJLCUUaJh1l42iISMxMlpDawQtrDEn2tdYHEhgfeMEkt6yrsYOTh4Bewk vr9NAQmzCKhK7Fp2HqyEV0BQ4uTMJywgtqiAvMT9WzPYQWxhgSCJwyeWgY0UEXCRaDs+E6yG GeiG+60PWSHG20o0tu9mhoiLS9x6Mp8JxGYTMJToegtxAifQ2l0zm9ghaswkurZ2MULY8hLb 385hnsAoNAvJGbOQjJqFpGUWkpYFjCyrGEVSS4tz03OLDfWKE3OLS/PS9ZLzczcxAiNp27Gf m3cwznv1Ue8QIxMH4yFGCQ5mJRFep2l5aUK8KYmVValF+fFFpTmpxYcYTYFhMZFZSjQ5HxjL eSXxhmYGpoYmZpYGppZmxkrivJ4FHYlCAumJJanZqakFqUUwfUwcnFINTEVd0bxz9A7Zm8Sv CPldUCuTnZm3iHfKx0DeXcFtR86zf2jN8TreJbduj5uMYfit6St2/DPpSVk1/Y1Gau3F+b3H FjTL/BbQsOadK3pcx+Rzylqlaw3OOhzhtzJFfkZYds+eO8+gfELwkU+J6TVc2Tp5MoYCR5Ss z3ButWD6yirq5xSUe9Bz3y/e/zz3/gQYuswXtuWVmdrjy/fi/Z2bkktnp7CYzm9TjM1bdmKx Er8L/zUb9l0WRv9X/FcwiPb4/+uY9U+JXz9OVGYd0axq28q/J3/H7yM56dtNt3H+WaYo5zJp qUjp8n0nuRj5GZ5ql8QyGs3pe/JwycKmd4+1VHgq/2lY6137/tbNoMBZiaU4I9FQi7moOBEA 3WT5by0DAAA= X-CMS-MailID: 20240618201744eucas1p1d5ea63c6b776e2e1770a6d0ba9c86ae4 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20240618201744eucas1p1d5ea63c6b776e2e1770a6d0ba9c86ae4 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20240618201744eucas1p1d5ea63c6b776e2e1770a6d0ba9c86ae4 References: <20240618071922.2127289-1-xiujianfeng@huawei.com> X-Stat-Signature: unwb17sstc6e8outug9988b8jyntd6w8 X-Rspam-User: X-Rspamd-Queue-Id: EBA061A001D X-Rspamd-Server: rspam02 X-HE-Tag: 1718741867-794456 X-HE-Meta: U2FsdGVkX1/yxwynHIe807A/qjSX1gPHaQg2pje23fxHhXg5IZ+9KWq4IrH7/UGwBZCTV5MT99wLroN2DvpJfJ+bPGcJFtEQEN0xjTcQMBkU0mORo4BFvhtATA7WMAajKzLoRP82X6ANpm1wZ2dL4wDv9Qb7kWP+AFbI5DoFVD2+rlqg6gTJSza0RdpHJLszemle9ENJOjd0Ln3FxXxoTbXZ6ISVk+Nsmq6q0mOuhWqExnVjGjcGL/HH+22Uxpsb1ehWxncjzSAMBNSSh6H7j/Iqy+1cWQ9tJKGTBVDj1BqU3BjTxrAlAucK+YMhA0tAl24cS3G3Ke+AJQRB4LpG2nDo0/GSZWuE/GKZ2QweJFYTm3UTJaPE+MNbqjq6B9gr2MIYDesvAdLvrEwA3qDRqSWwgcO3GmG8qtyVcUkyK3wb2728QZm0IeSefDaFsmKnodA5oh2zlEqUwX2RRXlAzAqzWLUngAeEQu3/+uBMf96EAEvVac89O3gqeLboaZ7Et90kvtkStiEpeFaV2l+hEQ/ZoJuiYlY62p1HC3o9qhkATp0t5d7ajdcPK2+9Z7ktDRwW9aJUVxOg5x8lRqZBpc9j5ZJpxFZJDU1b11afutccSF03W30DNbPMGsNYrbB6XPmcXa4qAM9tSrcc012qfuGoasEwdD6rKRES0WuKBaNjEBHqs2pG6cvbV8xTQ/ZwVTvSWFeKzI0xw+vJUgFUsMm/BmLNNoqGTGlT6zTmzRUttnw2rvMIkgXuDvd/v1PK6lZdMhmxLBC4u+3RcmYAkyKGswOE6uB77z5XBdDyGTd29L5Ull8WfnbJhsXExQt9ax9csBz3iH2HI7FDyQ/b6RTZl/iG28drXFq9jJqOg15zksjRN3XqTwVfpPiq42g1T0/JPwksbeF/LMj4lIlHd6138curfKk68jCeMu2rLeZwz+cCUzJK4W8NXd7ZFWGKz2QaPt//K5Shqxbtcat tmDdeH+Z SU7kbn9loFDfh/sMwbzTERID9CUMtIoZpMEudQNg6PMS+q/PbKkJcLIXv4ndI2SDS7gLmuClDioIxMV1ZICGYGUaliAafTLFyalwrViRjgmAR+vUw1aAUPLrTBH40bxf+t/f21LztFIMYdy0xG/KzaTvWiGirMytdbkp7dEXrhxK5bpc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.06.2024 09:19, Xiu Jianfeng wrote: > When CONFIG_DEBUG_LOCK_ALLOC is enabled, the following commands can > trigger a bug, > > mount -t cgroup2 none /sys/fs/cgroup > cd /sys/fs/cgroup > echo "+hugetlb" > cgroup.subtree_control > > The log is as below: > > BUG: key ffff8880046d88d8 has not been registered! > ------------[ cut here ]------------ > DEBUG_LOCKS_WARN_ON(1) > WARNING: CPU: 3 PID: 226 at kernel/locking/lockdep.c:4945 lockdep_init_map_type+0x185/0x220 > Modules linked in: > CPU: 3 PID: 226 Comm: bash Not tainted 6.10.0-rc4-next-20240617-g76db4c64526c #544 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014 > RIP: 0010:lockdep_init_map_type+0x185/0x220 > Code: 00 85 c0 0f 84 6c ff ff ff 8b 3d 6a d1 85 01 85 ff 0f 85 5e ff ff ff 48 c7 c6 21 99 4a 82 48 c7 c7 60 29 49 82 e8 3b 2e f5 > RSP: 0018:ffffc9000083fc30 EFLAGS: 00000282 > RAX: 0000000000000000 RBX: ffffffff828dd820 RCX: 0000000000000027 > RDX: ffff88803cd9cac8 RSI: 0000000000000001 RDI: ffff88803cd9cac0 > RBP: ffff88800674fbb0 R08: ffffffff828ce248 R09: 00000000ffffefff > R10: ffffffff8285e260 R11: ffffffff828b8eb8 R12: ffff8880046d88d8 > R13: 0000000000000000 R14: 0000000000000000 R15: ffff8880067281c0 > FS: 00007f68601ea740(0000) GS:ffff88803cd80000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00005614f3ebc740 CR3: 000000000773a000 CR4: 00000000000006f0 > Call Trace: > > ? __warn+0x77/0xd0 > ? lockdep_init_map_type+0x185/0x220 > ? report_bug+0x189/0x1a0 > ? handle_bug+0x3c/0x70 > ? exc_invalid_op+0x18/0x70 > ? asm_exc_invalid_op+0x1a/0x20 > ? lockdep_init_map_type+0x185/0x220 > __kernfs_create_file+0x79/0x100 > cgroup_addrm_files+0x163/0x380 > ? find_held_lock+0x2b/0x80 > ? find_held_lock+0x2b/0x80 > ? find_held_lock+0x2b/0x80 > css_populate_dir+0x73/0x180 > cgroup_apply_control_enable+0x12f/0x3a0 > cgroup_subtree_control_write+0x30b/0x440 > kernfs_fop_write_iter+0x13a/0x1f0 > vfs_write+0x341/0x450 > ksys_write+0x64/0xe0 > do_syscall_64+0x4b/0x110 > entry_SYSCALL_64_after_hwframe+0x76/0x7e > RIP: 0033:0x7f68602d9833 > Code: 8b 15 61 26 0e 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 64 8b 04 25 18 00 00 00 85 c0 75 14 b8 01 00 00 00 08 > RSP: 002b:00007fff9bbdf8e8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 > RAX: ffffffffffffffda RBX: 0000000000000009 RCX: 00007f68602d9833 > RDX: 0000000000000009 RSI: 00005614f3ebc740 RDI: 0000000000000001 > RBP: 00005614f3ebc740 R08: 000000000000000a R09: 0000000000000008 > R10: 00005614f3db6ba0 R11: 0000000000000246 R12: 0000000000000009 > R13: 00007f68603bd6a0 R14: 0000000000000009 R15: 00007f68603b8880 > > For lockdep, there is a sanity check in lockdep_init_map_type(), the > lock-class key must either have been allocated statically or must > have been registered as a dynamic key. However the commit e18df2889ff9 > ("mm/hugetlb_cgroup: prepare cftypes based on template") has changed > the cftypes from static allocated objects to dynamic allocated objects, > so the cft->lockdep_key must be registered proactively. > > Fixes: e18df2889ff9 ("mm/hugetlb_cgroup: prepare cftypes based on template") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202406181046.8d8b2492-oliver.sang@intel.com > Signed-off-by: Xiu Jianfeng Tested-by: Marek Szyprowski > --- > v2: add bug log to commit message > --- > mm/hugetlb_cgroup.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > index 2b899c4ae968..4ff238ba1250 100644 > --- a/mm/hugetlb_cgroup.c > +++ b/mm/hugetlb_cgroup.c > @@ -836,6 +836,8 @@ hugetlb_cgroup_cfttypes_init(struct hstate *h, struct cftype *cft, > cft->file_offset = MEMFILE_OFFSET0(offset) + > MEMFILE_FIELD_SIZE(offset) * idx; > } > + > + lockdep_register_key(&cft->lockdep_key); > } > } > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland