From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B2AC433F5 for ; Wed, 1 Dec 2021 08:25:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E0F56B0073; Wed, 1 Dec 2021 03:24:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3697B6B0074; Wed, 1 Dec 2021 03:24:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20A176B0075; Wed, 1 Dec 2021 03:24:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 0DBAE6B0073 for ; Wed, 1 Dec 2021 03:24:54 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C60F31810F5EA for ; Wed, 1 Dec 2021 08:24:43 +0000 (UTC) X-FDA: 78868539246.06.AC38CCB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 4635FB00018A for ; Wed, 1 Dec 2021 08:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638347080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fkzPDiWFZ0xPHB730aPwxoy6RLUvNRKztlsGB8SnQLU=; b=XGz9owLv9CcaM8gWVKdfapHSq0/2gCiee4mmwu0sI84S5UfjiU+1bHq35w/I66Nlk+Itk9 vRawN2czYBHvYLKsfHNZGONkT8PQoK+HKs1vgBRPCfVvwU4zj9HezkoQxpriVKPETwvYaA Ljlb7xuHhgNCbZXZRhotENAhoI/nHXY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-473-ke3R_ZKjNgWgjQtSc81vIw-1; Wed, 01 Dec 2021 03:24:39 -0500 X-MC-Unique: ke3R_ZKjNgWgjQtSc81vIw-1 Received: by mail-wm1-f70.google.com with SMTP id j193-20020a1c23ca000000b003306ae8bfb7so11831923wmj.7 for ; Wed, 01 Dec 2021 00:24:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=fkzPDiWFZ0xPHB730aPwxoy6RLUvNRKztlsGB8SnQLU=; b=u7X5ZGqmb8bRs8W3MYEwx35tDvprMF2sdlVF9ZEt2I3N86kxF2OVB1RR3SHHY5kLZK B19xnY6WRrrEH8bk/1bP2F5GIGvtjg7sx1U7NjMU5zFIEb3vuSpvC6U5gxUFHCtU+APq PhG1bIYfpMRLjeT1L2yoclpZqafRcQkvIU1tklbrXDg1fHocoip5CN2tPKghUe1UpsB+ Eo0+eUYDuFY2v9B7asxrTMCgUma/cxuoDABr1BZgHB/rBnxjJ9C0ZpyskhZLMywZBW1d EkZJvSA7KPgXJGmq01Xif4bpYyhYo1OVrEQv5vxM/Z5WyQac+RSljVMmEcOMZ+CKQhIv TjrA== X-Gm-Message-State: AOAM532FiEpUZHMyZ5XjBrPP0VaaCTQ8eC6W5QvAQz0yyXMzeGgT/nhl DhRpdir+qFHr31D4hlk8zk9Ij9SYlqE61vj14A6ycXkchDVFLcVaGAqQY1bdENyLIDa6oosAs/f emoHRMtqaY6Q= X-Received: by 2002:a05:600c:4ec7:: with SMTP id g7mr5186351wmq.138.1638347078780; Wed, 01 Dec 2021 00:24:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJxL7t5c38ZspM03DxqSzGkOrDykj7ybqwhfbHfItmliidB3NvPI6hvo5nRFdkz+zbZAl2dzrw== X-Received: by 2002:a05:600c:4ec7:: with SMTP id g7mr5186333wmq.138.1638347078608; Wed, 01 Dec 2021 00:24:38 -0800 (PST) Received: from [192.168.3.132] (p5b0c65f1.dip0.t-ipconnect.de. [91.12.101.241]) by smtp.gmail.com with ESMTPSA id u23sm268279wmc.7.2021.12.01.00.24.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Dec 2021 00:24:38 -0800 (PST) Message-ID: <7afa01ef-9048-4636-6059-efed7fadc452@redhat.com> Date: Wed, 1 Dec 2021 09:24:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v1 0/2] virtio-mem: prepare for granularity smaller than MAX_ORDER - 1 To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Jason Wang , Zi Yan , Gavin Shan , Hui Zhu , Eric Ren , Sebastien Boeuf , Pankaj Gupta , Wei Yang , virtualization@lists.linux-foundation.org, linux-mm@kvack.org References: <20211126134209.17332-1-david@redhat.com> <20211130185612-mutt-send-email-mst@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20211130185612-mutt-send-email-mst@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 6hc6d5saf5bwqprcskdi4f7z996or4jn Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XGz9owLv; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf25.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4635FB00018A X-HE-Tag: 1638347082-259375 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.12.21 00:56, Michael S. Tsirkin wrote: > On Fri, Nov 26, 2021 at 02:42:07PM +0100, David Hildenbrand wrote: >> The virtio-mem driver currently supports logical hot(un)plug in >> MAX_ORDER - 1 granularity (4MiB on x86-64) or bigger. We want to support >> pageblock granularity (2MiB on x86-64), to make hot(un)plug even more >> flexible, and to improve hotunplug when using ZONE_NORMAL. >> >> With pageblock granularity, we then have a granularity comparable to >> hugepage ballooning. Further, there are ideas to increase MAX_ORDER, so >> we really want to decouple it from MAX_ORDER. >> >> While ZONE_MOVABLE should mostly work already, alloc_contig_range() still >> needs work to be able to properly handle pageblock granularity on >> ZONE_NORMAL. This support is in the works [1], so let's prepare >> virtio-mem for supporting smaller granularity than MAX_ORDER - 1. > > is there value to merging this seprately? or should this just > be part of that patchset? > The value would be to give it additional testing ahead of time. But we could just carry it along. Whatever you prefer. (I'd suggest merging it right away) -- Thanks, David / dhildenb