From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA7EAC5AD49 for ; Thu, 29 May 2025 10:40:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC1F66B0127; Thu, 29 May 2025 06:40:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4AEC6B0128; Thu, 29 May 2025 06:40:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEB426B0129; Thu, 29 May 2025 06:40:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8C9EE6B0127 for ; Thu, 29 May 2025 06:40:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3CCD41D44F2 for ; Thu, 29 May 2025 10:40:26 +0000 (UTC) X-FDA: 83495601252.25.9541F02 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf24.hostedemail.com (Postfix) with ESMTP id C042D180019 for ; Thu, 29 May 2025 10:40:23 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=y2qUOu2H; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ILzNOkNL; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1sDt1FjS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Gxu1aK9Q; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748515224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Q0qAyacn7IXieWLl/Fo9hYbAToU4ZnD/0sY9H63rGI=; b=i32N3YfrgaSsDQ12cS7/CLHMnKdpxtGvbYiWg6gIPN/882a5g4K2x3uw8pa4JSKZcOPILY nMZp3GoFGnND6SqyQ22DEpi4raKe2gKZ6LFhX8nL9vX6ujUL12it+bTXLvEN8lzL3r5FGv In3dOwPntdd0WTSlMpW09moFZ44WQ10= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=y2qUOu2H; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ILzNOkNL; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1sDt1FjS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Gxu1aK9Q; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748515224; a=rsa-sha256; cv=none; b=7D30F4qS7Jwz1RLDp1zDcfFGUgmvyZnD9urp7zyK0DknlGElVJ4voK5t3/JBbe+5VDQpEa iRHGTgBvc0fhTe6rewAb+EVdJvDg40DlNBubPVsqpKuwVKd0BcXk06PyvwO5LtjahN+VF/ jgpR2KOqzPuXUOl8rnWlEwRa9qUWoRc= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DBDD01F38A; Thu, 29 May 2025 10:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748515222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3Q0qAyacn7IXieWLl/Fo9hYbAToU4ZnD/0sY9H63rGI=; b=y2qUOu2HZA2QRbJc8k0kTNa0VYThs/emrgT34wc3LnIvvA3R20YBQpCW1d6DGN0SYd/VDk 0lrF21Wzse870TQ68VcihWCuhPIPDf/oI5u//t0IQsBfBQC6aaeJGB5yTTL6lTf5iJGzIx SM4qCiG/ywHGQbY/+XWLEhfn6qxdW1w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748515222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3Q0qAyacn7IXieWLl/Fo9hYbAToU4ZnD/0sY9H63rGI=; b=ILzNOkNLCJyqESHmxwpi4gzeADl+2/ggbbvMdR5v6r+rqUlnPN+JeXsdbeWfXTdvLra7is BEHayPoJvMscbcAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748515221; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3Q0qAyacn7IXieWLl/Fo9hYbAToU4ZnD/0sY9H63rGI=; b=1sDt1FjSZsT2Yj3CkTPfEmIMwPT64I98Dmoa7iCGpVDH3/m0GAUsFF8tTAjvQE5Gmgj3rs EW7gmKV/GMo84IJagdZWx1ilEmGTL9bZijBgti86hTPUxwSzbaTt9WfvIYZohNlgixnlUC grUHSP04xfY/k374s9T4ezwgj1G6UiY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748515221; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3Q0qAyacn7IXieWLl/Fo9hYbAToU4ZnD/0sY9H63rGI=; b=Gxu1aK9Qk6hsjLduzPufHG7maO+DZNaYMLebdyQtLAvRUavVlAU1StrEq9V+guwcwmxS9m tCzoVPDil5vQ1MAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B13A9136E0; Thu, 29 May 2025 10:40:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id H/2sKpU5OGimBwAAD6G6ig (envelope-from ); Thu, 29 May 2025 10:40:21 +0000 Message-ID: <7ae9e9f9-80e7-4285-83f0-a0946d238243@suse.cz> Date: Thu, 29 May 2025 12:40:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Fix vmstat after removing NR_BOUNCE To: "Kirill A. Shutemov" , Andrew Morton , David Hildenbrand Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongyu Ning , stable@vger.kernel.org, Christoph Hellwig , Hannes Reinecke , Johannes Thumshirn , Jens Axboe References: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C042D180019 X-Stat-Signature: t9owfi83jyjo6p6ci5m7yedbwt5n8h1j X-Rspam-User: X-HE-Tag: 1748515223-971622 X-HE-Meta: U2FsdGVkX1/XJyiJ0/pn+kw+i757PK/yD9awbltHkFgOHcP3xyw5A+wrTtsCWSesXwOnZrUqTyATto+3cMP38WFwhZepvbVaKtRCBQt09u9qVcJYbI/mhzUTJvoQCWjVceGBsJNpiiLTRgkZRra6Q2W/6QzDnVgrjf7H4z+tOBWoufoEOsP6Gh2j77WWkiZnNux8S5ZdOrRpOR8y3msMKNzsYiURHnq+mozDnGa+cuhyjQXQgfuOaqoni3RdmHgv+UQQwUfb9zvOX1MlM0BURhK+w0QF4igrI16jyvQCYcYKWgiuQBGv6VDvGJm0o/ROiFKzEQDHq2Yz/Z7iTib0GRgln8/he6a0zhoELo41EjzpTRdeTgzLKIQBgip7dgY5DuFvhGip6NFzu/moAsBX2OktyfUMcs8NFXseQ5aAEJIXwPqXUE1o9imhFuV+16ZOqC6kvGQH9v7Hv7nr1QaVb7ULGIxx0CCycTAo+XBLyH7QxBBvQtfCSx4/MIOzLPksgkP9Mmbssf9go8Nd/aJFU3fNZe9oipffgFgj1gaSRcr0SgFQL+R0924I7oFxTt1QTfD/PdS0IsaTKsIVa/0l1R1Ia2YV02zPoDwqTYQr+ZEdAo0u/+0q0+f3tKC2HTsLH6HL10+4qDyygKTljGa+Ni4tF9OWKBo0ponpDva8kV5H5n/qCp5gbaDjAktDgIJLB6UULIjwqwwAwIY1yXGtItLHixC2fL3GOEJEB1g6pHNOiUgz7sgz0qPP9BFMvwASVV46ijHJCdPRVCV+WanbEmFHHoverKAL0SqlFsnKTVIKiSutoyVa3GGHsIMH5bi4ynsTqkAtUF/NCH4j2RwMA57r9L5Zt7MrzhQtbtnJLV4F/NJGjoJWg5p2VoAOEd3vj5eRtY4OR6dDB9hoqpiHFnuawnuaQNBb75cn+yYprvup4Ai3bNupFS2Xwg3cp8714+H7yqf/A/n4z/kyeD/ aUEB9yZh L+UgRp86g6nIcPyQbaSH2GkLQf9ulh/xVPYSw6uGbSz4h6fQfO9AKzv7BjncAGyGC9V93kJrotw1l4SO6+CTNyugoJuN3GhHckxsud5SIQd4V9IIsO5KKd9oU67r291ETVpK+SphDAZdilVmr4WRuE/lKUGubZoWz1ueWLioHXmJsAXIdqhF4WMAtWReft30QMhAh9lLbu6KEXtKVVOkHHV8L/P4MPzTX6GpfsBxz0bnzkdCrwOOHYAn8S7lE7H/+g+jXYRhGjC04lRZBnv2X0zSv8BBSPGZ15WDHh7r9vict6wvUJLos51OjIMUZAQUEyhseJGXsRyGbFlGeQ0PFfbxG3+aFFbF1Xek7FN/RWlWmoHn+N5momIF8vLZI7zA76+BNqIeZR3/xbsfQ5zkQy8Dv0I0534LP+RQR+nWVYFZaMRKy/CXAv1v3rWLkiZ/WcyBX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/29/25 12:38, Kirill A. Shutemov wrote: > Hongyu noticed that the nr_unaccepted counter kept growing even in the > absence of unaccepted memory on the machine. > > This happens due to a commit that removed NR_BOUNCE: it removed the > counter from the enum zone_stat_item, but left it in the vmstat_text > array. > > As a result, all counters below nr_bounce in /proc/vmstat are > shifted by one line, causing the numa_hit counter to be labeled as > nr_unaccepted. > > To fix this issue, remove nr_bounce from the vmstat_text array. > > Signed-off-by: Kirill A. Shutemov > Reported-by: Hongyu Ning > Fixes: 194df9f66db8 ("mm: remove NR_BOUNCE zone stat") > Cc: stable@vger.kernel.org > Cc: Christoph Hellwig > Cc: Hannes Reinecke > Cc: Johannes Thumshirn > Cc: Jens Axboe Is there a way to add a BUILD_BUG_ON to catch a future case like this one? > --- > mm/vmstat.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 4c268ce39ff2..ae9882063d89 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1201,7 +1201,6 @@ const char * const vmstat_text[] = { > "nr_zone_unevictable", > "nr_zone_write_pending", > "nr_mlock", > - "nr_bounce", > #if IS_ENABLED(CONFIG_ZSMALLOC) > "nr_zspages", > #endif