From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FDB2C433ED for ; Wed, 12 May 2021 10:28:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A47B61423 for ; Wed, 12 May 2021 10:28:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A47B61423 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7BC936B0070; Wed, 12 May 2021 06:28:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 792CB6B0071; Wed, 12 May 2021 06:28:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 633F76B0072; Wed, 12 May 2021 06:28:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id 464926B0070 for ; Wed, 12 May 2021 06:28:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 081298249980 for ; Wed, 12 May 2021 10:28:37 +0000 (UTC) X-FDA: 78132205074.28.C5F098E Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf28.hostedemail.com (Postfix) with ESMTP id 39A65200024E for ; Wed, 12 May 2021 10:28:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 703E6B02E; Wed, 12 May 2021 10:28:35 +0000 (UTC) Subject: Re: [PATCH v5 1/3] kunit: make test->lock irq safe To: glittao@gmail.com, brendanhiggins@google.com, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-mm@kvack.org, elver@google.com, dlatypov@google.com References: <20210511150734.3492-1-glittao@gmail.com> From: Vlastimil Babka Message-ID: <7ae6e0a1-8a4c-02b0-e26d-2d6a5f107506@suse.cz> Date: Wed, 12 May 2021 12:28:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210511150734.3492-1-glittao@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 39A65200024E Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.15 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam04 X-Stat-Signature: k3bne9ui9k8jsskcknikpx78uk6qiu6t Received-SPF: none (suse.cz>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1620815315-705777 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/11/21 5:07 PM, glittao@gmail.com wrote: > From: Vlastimil Babka > > The upcoming SLUB kunit test will be calling kunit_find_named_resource() from > a context with disabled interrupts. That means kunit's test->lock needs to be > IRQ safe to avoid potential deadlocks and lockdep splats. > > This patch therefore changes the test->lock usage to spin_lock_irqsave() > and spin_unlock_irqrestore(). > > Signed-off-by: Vlastimil Babka > Signed-off-by: Oliver Glitta Note v4 had Reviewed-by: Brendan Higgins and it's unchanged AFAIK.