From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D23E1C433F5 for ; Wed, 11 May 2022 08:22:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 522A46B0073; Wed, 11 May 2022 04:22:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AB996B0075; Wed, 11 May 2022 04:22:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 325726B0078; Wed, 11 May 2022 04:22:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1DE1D6B0073 for ; Wed, 11 May 2022 04:22:13 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id E5EC681E57 for ; Wed, 11 May 2022 08:22:12 +0000 (UTC) X-FDA: 79452769704.19.B043ECD Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf16.hostedemail.com (Postfix) with ESMTP id D63371800C4 for ; Wed, 11 May 2022 08:22:02 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id x12so1159243pgj.7 for ; Wed, 11 May 2022 01:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ok9rm5eSTA5NSL17Rhwq9EtRVWax1XY2Vi3Ds9AAgoI=; b=1kOoitGokYdgXjsF0flRyn8o7fugnSK/+ThmSsEeyuc8Enzq/2hd03m5qRiq9Ddz3J D1C5Ojry6Yl5nxjnZxEcZwN8oPaZrWH/tzk6KJZx0uKnrpvGOyteBoMwR17maxPhuDRw NffRsYiQHTkoTmRR9n8SOQ8eK5jk+5TQL5rrvPque8hUwxph2iJq5AY7LJyFEfyezb9D KaK2IaqLfcA4jSN+AE8+vPh71imDXpesFT5ZM9xoUlwFWTnymsWlhfWb5LdJUj3Lgv3F /3HGDMUPcz8RhIYOm3lVGBBQmQ9Ij4OE7H9TVztToRykZSK6Ekyssd71dyPgZdV+wCud r6XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ok9rm5eSTA5NSL17Rhwq9EtRVWax1XY2Vi3Ds9AAgoI=; b=DE1tvfDTEr87vrmhYlUlDIpysxtiqHRTak3snxyBWiZeMBlpACxND9Hib3uzSSHk+A dZk3BC6Mf6aSCk+LcPe0M65EKm8CuJuJbVFh6gBdW/0T5KjG/JfwgjyCNbzbudngWzXG m8pz8b45v7n9f7lKBIB2YojYxe+mSzpYx8tvi0lkXYYTrMIThs+/vLwtqASuGYbkFo0w W+G3pJ+xIzmcwwmYgDnOgpMpLvoqkmtEBzCHlGx/eiMZSTCo/yMNM6jLwEJT196uyWW5 eLm/jPviVtgIq/lU3wdJN49T09fG/PFqOAV2Yyzfw0SEkLHJQFwHLPtB9IeIHWO9O7Rg rEJw== X-Gm-Message-State: AOAM533fmWs9ae2LhqWLL55wRqJ4If30UhfdphjJ+6xbDJBWDdmFQe6m zTmU9BpNqteTCvpYqNwkXT+9sA== X-Google-Smtp-Source: ABdhPJyI3XwnQck5yj0j+Fts4bxAMxiOgAF+ugKSbXj5JQ/HxpiYyfhMeBXr1WNEXRZRkmxuF6q2Xw== X-Received: by 2002:a65:6e9b:0:b0:3c5:f761:2d94 with SMTP id bm27-20020a656e9b000000b003c5f7612d94mr19725021pgb.79.1652257330292; Wed, 11 May 2022 01:22:10 -0700 (PDT) Received: from [10.255.89.252] ([139.177.225.239]) by smtp.gmail.com with ESMTPSA id c20-20020a62e814000000b0050dc7628130sm1035498pfi.10.2022.05.11.01.22.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 01:22:09 -0700 (PDT) Message-ID: <7aceb944-4c53-8cc8-473d-fc8a9da0ef11@bytedance.com> Date: Wed, 11 May 2022 16:18:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: Re: [PATCH v2 5/5] mm/memory-failure.c: simplify num_poisoned_pages_inc/dec Content-Language: en-US To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= Cc: "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: <20220509105641.491313-1-pizhenwei@bytedance.com> <20220509105641.491313-6-pizhenwei@bytedance.com> <20220511082011.GC211620@hori.linux.bs1.fc.nec.co.jp> From: zhenwei pi In-Reply-To: <20220511082011.GC211620@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D63371800C4 X-Stat-Signature: semhy55wrp356r65tx1itd4t1zqd6gey X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=1kOoitGo; spf=pass (imf16.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam09 X-HE-Tag: 1652257322-813121 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/11/22 16:20, HORIGUCHI NAOYA(堀口 直也) wrote: > On Mon, May 09, 2022 at 06:56:41PM +0800, zhenwei pi wrote: >> Originally, do num_poisoned_pages_inc() in memory failure routine, >> use num_poisoned_pages_dec() to rollback the number if filtered/ >> cancelled. >> >> Suggested by Naoya, do num_poisoned_pages_inc() only in >> action_result(), this make this clear and simple. >> >> Signed-off-by: zhenwei pi > > I found that action_result(MF_MSG_UNKNOWN) in try_memory_failure_hugetlb() > does not follow the rule, so that could break the counter. > I don't think this is the issue in your patch, so I'm fine with this patch. > > I'll submit a fix later for this, which will add hugetlb_set_page_hwpoison() > in the path. That will have a bit non-trivial change because we need do > this in hugeltb_lock. > > Anyway, thank you for this work. > > Acked-by: Naoya Horiguchi A million thanks to you! -- zhenwei pi