linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, "Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Matthew Wilcox <willy@infradead.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	Eric Biederman <ebiederm@xmission.com>,
	Kees Cook <kees@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	SeongJae Park <sj@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Brendan Higgins <brendanhiggins@google.com>,
	David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>
Subject: Re: [PATCH v3 6/7] tools: separate out shared radix-tree components
Date: Thu, 25 Jul 2024 11:20:27 +0100	[thread overview]
Message-ID: <7aae7eb2-6170-4ed6-bee5-6a0c35294381@lucifer.local> (raw)
In-Reply-To: <d5905fa6f25b159a156a5a6a87c5b1ac25568c5b.1721648367.git.lorenzo.stoakes@oracle.com>

On Mon, Jul 22, 2024 at 12:50:24PM GMT, Lorenzo Stoakes wrote:
> The core components contained within the radix-tree tests which provide
> shims for kernel headers and access to the maple tree are useful for
> testing other things, so separate them out and make the radix tree tests
> dependent on the shared components.
>
> This lays the groundwork for us to add VMA tests of the newly introduced
> vma.c file.
>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---

[snip]

Andrew - we double-include a header, it has header guards so this has no impact, but
obviously should be fixed for neatness.

----8<----
from 1bbb39c83aaee80b32d7ab0f26caff0def2dd969 Mon Sep 17 00:00:00 2001
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Date: Thu, 25 Jul 2024 10:47:40 +0100
Subject: [PATCH] tools: fix double header include

We already imported the stubbed-out linux/types.h. This has no impact as it
has a header guards but let's clean this up.

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
 tools/testing/shared/shared.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/shared/shared.h b/tools/testing/shared/shared.h
index 495602e60b65..f08f683812ad 100644
--- a/tools/testing/shared/shared.h
+++ b/tools/testing/shared/shared.h
@@ -6,7 +6,6 @@
 #include <linux/bitops.h>

 #include <linux/gfp.h>
-#include <linux/types.h>
 #include <linux/rcupdate.h>

 #ifndef module_init
--
2.45.2


  parent reply	other threads:[~2024-07-25 10:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 11:50 [PATCH v3 0/7] Make core VMA operations internal and testable Lorenzo Stoakes
2024-07-22 11:50 ` [PATCH v3 1/7] userfaultfd: move core VMA manipulation logic to mm/userfaultfd.c Lorenzo Stoakes
2024-07-22 11:50 ` [PATCH v3 2/7] mm: move vma_modify() and helpers to internal header Lorenzo Stoakes
2024-07-22 11:50 ` [PATCH v3 3/7] mm: move vma_shrink(), vma_expand() " Lorenzo Stoakes
2024-07-22 11:50 ` [PATCH v3 4/7] mm: move internal core VMA manipulation functions to own file Lorenzo Stoakes
2024-07-23 16:58   ` SeongJae Park
2024-07-23 17:15     ` Lorenzo Stoakes
2024-07-22 11:50 ` [PATCH v3 5/7] MAINTAINERS: Add entry for new VMA files Lorenzo Stoakes
2024-07-22 11:50 ` [PATCH v3 6/7] tools: separate out shared radix-tree components Lorenzo Stoakes
2024-07-23  9:25   ` Mike Rapoport
2024-07-23  9:35     ` Lorenzo Stoakes
2024-07-25 10:20   ` Lorenzo Stoakes [this message]
2024-07-28 20:15   ` Andrew Morton
2024-07-22 11:50 ` [PATCH v3 7/7] tools: add skeleton code for userland testing of VMA logic Lorenzo Stoakes
2024-07-23 17:20 ` [PATCH v3 0/7] Make core VMA operations internal and testable Lorenzo Stoakes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7aae7eb2-6170-4ed6-bee5-6a0c35294381@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=brauner@kernel.org \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=ebiederm@xmission.com \
    --cc=jack@suse.cz \
    --cc=kees@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rmoar@google.com \
    --cc=shuah@kernel.org \
    --cc=sj@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox