From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E8AC369AB for ; Tue, 15 Apr 2025 07:30:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A44A7280154; Tue, 15 Apr 2025 03:30:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F4CB2800D5; Tue, 15 Apr 2025 03:30:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86C43280154; Tue, 15 Apr 2025 03:30:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 68A072800D5 for ; Tue, 15 Apr 2025 03:30:44 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8CAEBB1EE3 for ; Tue, 15 Apr 2025 07:30:44 +0000 (UTC) X-FDA: 83335456008.21.95B347C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id CF156140008 for ; Tue, 15 Apr 2025 07:30:42 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744702242; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M+2iA+phHUBf6PKT5zb2mQ4dZSgaRQNZ0QIVbRsoUJs=; b=oCH78mT5667NnK6UmOgNLYSkWsBsL2Ax2HjQKNg3xXEMUNS4qiYrbjrdDTjDUYd9QLDlyu LUbcgLhbj65epngg1QtsUdZu2QISN9RwqzXXjZxTl+PV/Q0uvWKPXsBDv5KNYJYFMhAfoa 5Dw2LIFOC5Coyji+LYk2UPBNhqVEVbY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744702242; a=rsa-sha256; cv=none; b=PYVDZ2h6AdPtwH7Bk4NHpoFSU86Plph80EyJE811RgYWir4bz7opy7dKcE+cHVStdF3yqj 9fs7oDt9bhzLCzrh6yM81s0tGXMh/Ji6BL9Y/7WyZy5UDqqYNIzjBNmicXSouISk/ewjXn LY+SedlJ6VX0mz6Mwm4UIb+2n1O4uw8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 727B915A1; Tue, 15 Apr 2025 00:30:40 -0700 (PDT) Received: from [10.163.73.130] (unknown [10.163.73.130]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B22E43F66E; Tue, 15 Apr 2025 00:30:38 -0700 (PDT) Message-ID: <7aa6ff41-6ec4-4750-8a0f-f43fe2c1b549@arm.com> Date: Tue, 15 Apr 2025 13:00:35 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Restore default nr_hugepages value during cleanup in hugetlb_reparenting_test.sh To: Anshuman Khandual , Donet Tom , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shuah Khan Cc: Ritesh Harjani , longman@redhat.com, Li Wang References: <20250410100748.2310-1-donettom@linux.ibm.com> <098f5acc-f367-4188-acbd-2c91c52d57f4@arm.com> Content-Language: en-US From: Dev Jain In-Reply-To: <098f5acc-f367-4188-acbd-2c91c52d57f4@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CF156140008 X-Stat-Signature: jgsfkxmfuj3iezdgwdeokyp5u8fagi13 X-HE-Tag: 1744702242-115835 X-HE-Meta: U2FsdGVkX19Ao00utj1I68VDtwyVl0wv+6W1hbCjTMqL6RQhpNc8/51L/6jJsqEqCfAKGVDjyufgKmzjmqevpQ43JXMe/VM0NoITso1TEWNIsjw4RxIbPP4IjpPZkmD4tKmM9eJn0K1dycuEnuoluALuOaZUIUctUOLq4zWqfx3jEc4zGEfRyjIq8kX0YBjzx0Ns5PDmwom1W2emROx5O2RW6KXfZqg9r+3KqIAJvD9L57tz+7mdBBNwZeGYBw1cx5ytYOaQUFgHXEfTETzU4QJse8dcQcbPxIrcw0u1YWCk/kEae4si7+zvoaWNjt1MA35WrqLAmG9NyMiGabLmppAk58FCpCos5HCU2cwDlLGUS365LTOEaqXX712BqaKSVS8osHR5Ewk6mzgZwsLZaBQDRrhO1P5WpiKIqhBHmhw+T0Pa0EvxKgWKa/jNgdl01PKxjb/ZuNXYDulW8DSfH84W2TCgPNt4ci9ndLp30WSHFIJH23muU1iyl8L240CudMce81J0VhpxlhjPiYUfwfGH4j43ey7WrkGmU0umSWk65dkXGUdV20gx43L3IXCPh5BGA3eTLdc15aCfvREsnKvt9j6hj2bFq6YW5jdZc8tajnbn/ANla5Eb+uNTxycwksSxmyISRZNL5eOdP4ybN1UkCuC8eL8A4lfja1TzMKuQQVf2a1G4yProHseZCR2buY6tgO9FGrh0vWjnU8MupP356cmhouV0ate+fFbOiLWLMpskAYQAgVVb1nFyMFZznFCb9k5z+DqvHOlSBuML2l34yMWhVfjslXaxgMNzih4tDbvgvmpH/zhdnhlZYrleUSQ+DFjl7jrXmShUo88GrN9+071eUfAQ07OqVMyhpfcBsJ8rJMcPm96o0QUBLt4hgM74A6n4IBeVuHTIzSRVXrNgRPuJUcMQAAIKbKzHaw3ZoJo2wf4GjtkVE1gJMVTsjFi6aNwSOZgcTXSZcto 8mZbu7gV G33itXbns9WQGaDAsnibOnKbzr63+ZPZNYTsBZLXdVS+g/m9B9UeZ+2d6mRSrn8scOkR9bzRNOO2ky/W6OUi2DJRI45TBVu4pTAdC8Yqq2F3rrbph5iRwpiULiDh3YBsUB08X5HN4BN54Hvwq483VzcCXZqpGrrn5hb96Hw6k2R1TixmdhkS5ukUtTTuLMMqZclLthMzf7t/NbI8QThR0IkFtt07DtFr/izmf1smwR+Rl977tUBVZgMx2BiJUGS0+ZR3UqZtCDdywy8PtieDkyXGfSoEW/1Y2sY+f X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15/04/25 12:28 pm, Anshuman Khandual wrote: > > > On 4/10/25 15:37, Donet Tom wrote: >> During cleanup, the value of /proc/sys/vm/nr_hugepages is currently >> being set to 0. At the end of the test, if all tests pass, the >> original nr_hugepages value is restored. However, if any test fails, >> it remains set to 0. >> >> With this patch, we ensure that the original nr_hugepages value is >> restored during cleanup, regardless of whether the test passes or fails. >> >> Fixes: 29750f71a9b4 ("hugetlb_cgroup: add hugetlb_cgroup reservation tests") > Although this change makes sense as an improvement or a cleanup but > not sure if this also deserves a Fixes: tag as well. IMHO it deserves a Fixes tag, the tests should always cleanly exit without changing system state. It may or may not cause an actual problem, so let's be proactive : ) > >> Signed-off-by: Donet Tom >> --- >> tools/testing/selftests/mm/hugetlb_reparenting_test.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh >> index 11f9bbe7dc22..114875a2b018 100755 >> --- a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh >> +++ b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh >> @@ -56,7 +56,7 @@ function cleanup() { >> rmdir "$CGROUP_ROOT"/a/b 2>/dev/null >> rmdir "$CGROUP_ROOT"/a 2>/dev/null >> rmdir "$CGROUP_ROOT"/test1 2>/dev/null >> - echo 0 >/proc/sys/vm/nr_hugepages >> + echo $nr_hugepgs >/proc/sys/vm/nr_hugepages >> set -e >> } >> >