From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E24C47077 for ; Fri, 12 Jan 2024 01:28:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FCA06B0093; Thu, 11 Jan 2024 20:28:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ACBA6B0096; Thu, 11 Jan 2024 20:28:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E68386B0098; Thu, 11 Jan 2024 20:28:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D771A6B0093 for ; Thu, 11 Jan 2024 20:28:13 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4FF0180D57 for ; Fri, 12 Jan 2024 01:28:13 +0000 (UTC) X-FDA: 81668923266.02.0E1C152 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2094.outbound.protection.outlook.com [40.107.215.94]) by imf25.hostedemail.com (Postfix) with ESMTP id 0DB47A0002 for ; Fri, 12 Jan 2024 01:28:09 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=vivo.com header.s=selector2 header.b=DsxV2dYf; spf=pass (imf25.hostedemail.com: domain of justinjiang@vivo.com designates 40.107.215.94 as permitted sender) smtp.mailfrom=justinjiang@vivo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=vivo.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1705022890; a=rsa-sha256; cv=pass; b=hJs04aizV4ZRBRAHV38Rce77NAD7y3WK5AL1uW7xGt/1lp/XgvADryhoh40NeNKaqcF0tz 4xzwKZwPcSmrx/ryXaCKN/Q2O7EIQjovCgRjO1L/jUxLRAquw3d+bjnRNpBLlKeSBE3g34 B7Fj26tiFMyVfnfcfUwerkoFwmOHRjM= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=vivo.com header.s=selector2 header.b=DsxV2dYf; spf=pass (imf25.hostedemail.com: domain of justinjiang@vivo.com designates 40.107.215.94 as permitted sender) smtp.mailfrom=justinjiang@vivo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=vivo.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705022890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cS0L/rN/lD7Y/VA/xuHHqv9vThD20R5iM/4oVdPiHwo=; b=peIB2zMLVAg05FkoH1PT0xgWbvdeNdrGNrM6B32NKxvwAF/BsFSvC3QmmU26g7WAP7IqCY QoICH7e7CDot+dVrkz9HqWhvBOt9abBC9021GD9QYnyjbgKIryeXcCGFhCgyUySJCh3c3B OktwfyRNGFqj/RsR4kWQWz1+Skw+Was= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k6+iOkR7lCL02cKXtUSAYlYL1sq4EWKEVykpP4CZdL3LIYZDQTix9+PJFrQfgZMfzbrh/Gam3VSc0NAc+bRfCHdu5CmPwsdfym/qtlH3l0aTzhLP4D3TCAWqiclvKIWfcEvopV+LsngBwcp+pocYa2SFD3DsAceRtS9qa2oFrcsAJfyW9ipwtUBETSzGDkJUVl/GAlBT54h0jvLVwzMOonIBVn76znFZUPIhmtm57NK5XaNdk6VmTjGeVWxDJEpqVyR9uFbQg2oPymHcfznxqF2S9zGu2Z14g5EyolR/dwI2aCzxxSyZdpHYLqn/MU6HlMbzCBkL8VUaYK4Knuoxcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cS0L/rN/lD7Y/VA/xuHHqv9vThD20R5iM/4oVdPiHwo=; b=CNmDZtv8jgI03wjeRkQU1n5hdX1I2ELXuigz5fgielb/uY5NB/sMwmHChkzhcTPvYAA1eXh3IsiVnNRoBj3apNMebDyKk3ab5pTou+p2ZAWcSAsjzYPjou81HewIMqxP8K4yvanKG8FYS3QbTMNFjX6AfUE44mkKLcYmKKV2PybjgzVFds8OxEXnVMu4E/nVrm6FcHyinML07/RgWa1TGEJc9m26JtlXYsJyjt/JwPf0I3FF4MjWWYbyZ4uBBHfH9c5A8oyaVl6ZCWxGByW9wdLf+V3klfI65qz7QK0M40R6A0eeXF74bu4I1d6DtBTfbbuBgxeSsf6ulbMPRDZ03g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cS0L/rN/lD7Y/VA/xuHHqv9vThD20R5iM/4oVdPiHwo=; b=DsxV2dYfyd/i/EjiBmELKUNoK4LIemkrgdrD231Q/JDegROqXsXyiJnFtTr2bEZMpOwTG+Zc4ravMnukhQbuRvcnBT2qXa0bxnrORP3VYZPUfXhs0bBoQQAYlaSQnJnGd2BWQDv7tmJK0Zz9llBYFzfQv2Lrn6skWSdoQSD3O0HUTDa0nJhZlCB9qBkzjYAVWly+O0n04H6qnUz66wr4d11m9YljjiJouF346t1IQywN/nAHTqAK3eC3rSvTLRS21LV3uKIDycSGpojMuCDqfoJcXfBLhOW5cG6Wx2Py3hPIsrRr3BOYVDQAuJEcL78EFkklU7kp3NgVvIJS2BDg6g== Received: from JH0PR06MB6849.apcprd06.prod.outlook.com (2603:1096:990:47::12) by TYZPR06MB6640.apcprd06.prod.outlook.com (2603:1096:400:44c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.17; Fri, 12 Jan 2024 01:28:02 +0000 Received: from JH0PR06MB6849.apcprd06.prod.outlook.com ([fe80::1be0:ebf0:eb04:6bd3]) by JH0PR06MB6849.apcprd06.prod.outlook.com ([fe80::1be0:ebf0:eb04:6bd3%4]) with mapi id 15.20.7181.020; Fri, 12 Jan 2024 01:28:02 +0000 Message-ID: <7a94c962-6137-47c1-be4c-ef2a0614bfd2@vivo.com> Date: Fri, 12 Jan 2024 09:27:58 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] mm:vmscan: fix shrink sc parameters issue To: Johannes Weiner Cc: Andrew Morton , David Hildenbrand , Matthew Wilcox , Chris Li , Michal Hocko , Kefeng Wang , Dan Schatzberg , Yosry Ahmed , Yue Zhao , Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, opensource.kernel@vivo.com References: <20240111122451.682-1-justinjiang@vivo.com> <20240111122451.682-3-justinjiang@vivo.com> <20240111134338.GB390292@cmpxchg.org> From: zhiguojiang In-Reply-To: <20240111134338.GB390292@cmpxchg.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SI1PR02CA0015.apcprd02.prod.outlook.com (2603:1096:4:1f7::18) To JH0PR06MB6849.apcprd06.prod.outlook.com (2603:1096:990:47::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: JH0PR06MB6849:EE_|TYZPR06MB6640:EE_ X-MS-Office365-Filtering-Correlation-Id: 71d04986-4971-4bbc-4c8d-08dc130db7c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eld9HvTCUsqjSqNiTS04w69spWDyqz0njITDSs15hqI5udWqG4skGxVqm5PCyT10V1DhK+9sHIirhHP18iHFdM4tw0BopTRkzWTZ5sF7t4IBPPPvGZ9sbvrKa5PkNftE00PFW8pPXJXyMn9d6VVlh7MY8RQk061QjO1EhjjCmhWFSumj63K0PXdi2K4ZtTJEKk4MFOm1rDa5FKuIQNlk6b/ja0qzf47n9jucFbr8v7k1usBr7aIxlImlrdN6IULHdOWmeZ5je5wNueMT60tpiyjVp3qLu3cviSkbhQwyRnz/crP55jkstiwEqs3A67TwAqHLufSM5dOo9rHw9UALbZFU1Ffz8bwN4pSGBc0KmV2WkzT7PkuwRZM36rkYpOWQH4kAG66X+Q0KXU9fIjineeAKeTubGuYivmeGsCGa1OwIKtNuXpfePfMbRZNMApcOJf6MVC67Tqe86iyr61XTDweDSy8OA+oMZFLHfIu4Gp56Aw8XGGSP2pdY8rFCRw/BKe5TPaI8AYaOsqXG3oSUEQwIJoLXJlHbuF/WKgx+3489zNlHKwEKp3pSKDTDHOKegVwENyVlbH3RnAYWlrHmNfU7jx+LVBsrzK3ZPWvttf2COGeL78byu/MKX9lMqiaCLOOPxicxUyZrdr+yTBQ37rZP9PXEDEVMwa9jPvVWBZKQDgLD8eXtFX9dcXozAvi1Kptcw6Z9VcbP4y8BQ79/sg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:JH0PR06MB6849.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(366004)(136003)(396003)(39860400002)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(31686004)(6666004)(83380400001)(26005)(52116002)(6512007)(86362001)(36756003)(31696002)(38350700005)(38100700002)(4326008)(5660300002)(6486002)(7416002)(107886003)(54906003)(66556008)(6916009)(66946007)(66476007)(316002)(8676002)(4744005)(2906002)(41300700001)(6506007)(478600001)(2616005)(8936002)(43062005)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3dwTGoyOFNpMTNRMkg2UGNZNmFRbjZYN1owZlVQNFVldVB3bXdRK2U3RnVz?= =?utf-8?B?MkZBVEZzRUFzUWR0VEFXTndTRzBxNFBaT0JPY0tIU3gzWU5EUkNXYnpmN3VY?= =?utf-8?B?RmxNZ0hacloxU3ZEZUxGMWZXMzlWcmpmeGVMVUJldjhDeEQxcnhRaFRxVkxD?= =?utf-8?B?eGdlN05UY0RNOFIrU2lQbTVGbjZRN3BadU9wQUdrZStycjdkOTRzcEVNbjAv?= =?utf-8?B?VDZINUlacVlWeDJqeUFzcnBBQlA5L0g0SHJDaGJIRStVYmFhNlIvQUcxMnJP?= =?utf-8?B?VEhZR25ibE5QWWkrQ20zOEt2NER4TVJ5UXFuRFp2SWlCcUM2QjBvMDZMQzBC?= =?utf-8?B?UFo4OWUvNS9Gd25pb3BianM4d0ltTmhjUC84THVqNmhYWHZ5NzJzQWV6NitZ?= =?utf-8?B?emJzZ2MwdGNxeEs5eTZGdVdhNDRhbGFMYTR1TEhLNmpxYURWZmZQU25KV3Zx?= =?utf-8?B?aVh0ZmdYa1pBOXRZWnYvNnQxK1U1NG80YVZkajBxcFVlQWVoNENVVEhTSlNh?= =?utf-8?B?bUtzMUYveGI5a25BeWZOdEpqbS94RkVXaElJV1FOTE56L0ROdzBQUWUyRldm?= =?utf-8?B?SkxWSW9EVmkrRk1yVXlGK2xTajAybXAyOWExOUpPYWptYmpCOVBBYXJaTWpy?= =?utf-8?B?bHdxSk5vVHNmditjaWEzZlp4RHo3WExvcGdESDVlbkd1ZEF4TW53d1F4ZlZn?= =?utf-8?B?c2pNSWExeWRhbU5mQ2NqNHIvaUlPOElxNk9JN212U0tTUEQvTnc3QWVHYlQy?= =?utf-8?B?RUhnR3FMdi9KNDJTQ2RSS1diUG1xclIwbENCWHhFYjlqYUtzZmwweXdXMnZ6?= =?utf-8?B?M2dHY0o0TDkxV3JJWnBiMVhVQ1hzbjEvVzFZaSs2UkdGYmJyRmo4YldEYVBh?= =?utf-8?B?WUpOMzNJdEg1ZlowQ2pkMlM3Qi9mNHVMd1pCemk5TVhoOWJyVy9pL0h0K1pi?= =?utf-8?B?Mlora3lzQUtINWxUNXlMcVA2aXROdFNzTUNvejlpLzFqWVUzbXdOL09rZC96?= =?utf-8?B?UzlnejRpNkZkaWtIK2dyTEl5L3M2MUh1VjBYVm1kOHRaMjdBRlhEUVBMQmRs?= =?utf-8?B?aVBhSzRiSmVxRFBGVEdLQ2VXOG9yS3Rnclp2anR0ajdmTTBkV2ErQm9HRWVr?= =?utf-8?B?Rkt6WnRTMDQzRDhVQ0ZUaDVzNU1teUZZcEJGYzd4UFdDVkFaNVJIaFVXVmZu?= =?utf-8?B?TjRhWlFrdzNtOHBTa2ZaKzdhZE9Xc1pyZWJzUmxWdGRqbjFlK0ZWRnRXOXhv?= =?utf-8?B?Q2pDN1AzSFE1Z09xLzRXSGxjbDgrWm9BUUdkUjNQcGdFRVZWZC9xM2NRUXZP?= =?utf-8?B?T3FBZXo0aE9LOE1LMlNxUUlZNlZ4dkp0TjdydWpHeDcwSnlSaVBYSjFDR3du?= =?utf-8?B?TUUybkVpWVhkb01ZUktlSmxmQlRQa05iR1VPNFFQdUdSdUVHMmlEK1BNZkxs?= =?utf-8?B?eVZRdy9jWEdPeS9LaHhIbUJoYVJFZ1hPaVBRVTd5K2pQUm1Tb3RmeTRMaFRp?= =?utf-8?B?OHozU2pPVUY4WFh5a29pb1ZVRW4vVHRlV0c2ZVFrZ294Wmhub1ZWcjhDa0Rp?= =?utf-8?B?UU5lb2hBbkx2K2kyL1BPOWh4L2RnUklqQWd6Qkx0REpiUWJiaExhSXNUT3V2?= =?utf-8?B?bW1mVVA2RTJ5WFVJYzloUWI5ZXd3bU4xdGgxR1FpWWJHTStGOHk4NXB3M0pk?= =?utf-8?B?ZXdiZGtNQU9EMXE3aEF3WEIrdVhmbStQUHJieDdzeS9TVm9YajRVenA4Mkpx?= =?utf-8?B?bXN6VnZ2dFBZNUNYSHRaZndGejZacml4eWhtUGRQSk5CQzFOdCtGcjc0OVRG?= =?utf-8?B?VlphS2NraExFaTIvbndhNUgzQ0IzMDZkSG9VcTZiNVd0M2FOUmhieFA1SzRx?= =?utf-8?B?cjZuK3pyMElka05RSGxvQkJXMTkwSnR1S0x3Qm1iVThxUEdWaVNVVSs2c0M3?= =?utf-8?B?T0oycDNLSGJVN2tvenIwZERWZEQ2WUNvU0tOTmF5RUxLaVB2UkdONHRITjlw?= =?utf-8?B?c1BNMUU1MlJnQ3BHWVA0ck1uRmFpaktIMUNzRVI3VkpBMmZNZnhBNGptNjlB?= =?utf-8?B?RnFYZ2krd2FFdm5QbWM4K0UzSHQybjNKcnpjZlRKQ2oxcG1xVkRmWUEwb3pH?= =?utf-8?Q?J+WbWrFrJuJQrJp3E7gemZZAR?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71d04986-4971-4bbc-4c8d-08dc130db7c9 X-MS-Exchange-CrossTenant-AuthSource: JH0PR06MB6849.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 01:28:01.9841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U3gDWE4HjLtZ31anlUoZD4pqu/+O95SNaH7mOplE+H9JJk5iMFabG453+mlV3zBZoS6nqLEL5IsDEbRl640ajQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6640 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0DB47A0002 X-Stat-Signature: nqh69df3x85tmc5g6ydpxo58brw5my4k X-Rspam-User: X-HE-Tag: 1705022889-215472 X-HE-Meta: U2FsdGVkX18sSUII/gMZe38viqxewqPKpxP2XoTu0a/yzCKxhIWWvJ38cu6Fer1S6swzj9/wk7OGCr/aTjWoNahiReabxjx71diSfLh/eBepdXUV9SLEoINhvMgugslh32qNkDNa8ibo9no+uFIiCHpp6k/monNNit8054+CHlxIJBg9i+VVptY2FWEm3G26pM3Y9+17rhtv/a1DDg87JSDq3lNqocGcSjvFzQtyCppH08YO246DLj1QSBGAmJCms71PQHlu1c9+JskWefuSRnreqrfOEFn6gS+U8e364y8W+39gClBcHt/8PO4kIrgHJQWCycTb9FhvgwptttToiIJ1o4wniUm1wYr01wv6AFq30yXr3oZiXeVw80dZJq1BvLo+jqy1yVItcyf95wG+Zd6K8njJ0XIaVs3gp7r30sHGKjBFE8ZngKHEBWF7tNwjHmAW35aG6JMw9qJ9vp60+am4tpn/LNfpwgYa7UXlW8dnhuVMXVKsDBR6mFw+nEElDKXQUO0f7tza69QhvGP0HJ0wmO2p0C7ihgiOEaqFq67Ra8kYW1vZkWaBiMH6kPlZ9x8+Di69+6uvNrd+6cIC566K73iRCQtNUbdhNsMhqzLgrhEuHQmPG0IhhuH+Q5spnmssaTlqxUYwDzHRmWu4gzRLUtIhIjgZKv2OlLWd3pJqgROqSzrvKP/wtSvyL0/2zN2Vin4d8i245JV0gIl+YDQnTgrMW63YL9ccabd9CeTL1Uekl3B4TMKVxWz5s+ArG/uAtHHCuppi85Xvzo+neyRz/HGdKIDGgTrfcD10OhaPlJgsDsMsKByWQHgtapvi0CHiBFTOI2dCSGRh3WOmgjOg7grJ5/4wfFOiY7mWOLOWVH+G6fb5wDDNYyy842pr2V+kwd6+CaOqo//WCpghCrEDWUOs/mIhJxQGt7bsK2cxM8rm/x2oP57buetGz/Pe+fM7Sk5UELtLmXAmY9f j3LBFEPy 9rub5VDQ96Ny76NQpDCFpUAP5e0++OMsjVWyov8z1T4XxgMdiQiILnt2ua1xKqNK7N5K0JQsO0STX7tNN9p2d1KGFMZWvqarupdM4C9RhIHtmHKxPBFbcypQHoIdv/CqBH7EvBpUkqYr80ukzCWkcKL6KVX+e6pGrN9oQC0UfV1xrAwceAhKwu31iZOwNPFf/A3bk61hMQ6mv9kgMoHlwCKzeyhhzj7Sxe/x6DdW0GXQoZaWbA6KhR59+Itzu2oSupHvujM/ZCIuESRsFeo/HhJ3Iw/VNqLEI0AFuMGu3WH+ZSdGa3dLuckol/85SOT2Zk52LSId7wPk0p1h8acY8jupipN2PFbAtX4vuMJfBy7l7Z6K9joXGocSLFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/1/11 21:43, Johannes Weiner 写道: > On Thu, Jan 11, 2024 at 08:24:51PM +0800, Zhiguo Jiang wrote: >> The values of struct scan_control's members obtained by >> prepare_scan_control() are always from root_mem_cgroup, rather than >> the memcg where the shrinked folio is actually located, such as >> sc->anon_cost, sc->file_cost, sc->may_deactivate and so on. This is >> an inaccurate sc values for the actual situation of the current >> shrinking memcg. so we need fix the values of struct scan_control's >> members are corresponding to the current shrinking memcg. > You don't seem to understand how cgroup reclaim works. It seems that the actual memcg's lruvec->anon_cost/file_cost values are not used in code exclude target_memcg ? > > Nacked-by: Johannes Weiner