From: zhiguojiang <justinjiang@vivo.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Chris Li <chrisl@kernel.org>, Michal Hocko <mhocko@suse.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Dan Schatzberg <schatzberg.dan@gmail.com>,
Yosry Ahmed <yosryahmed@google.com>,
Yue Zhao <findns94@gmail.com>, Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v1 2/2] mm:vmscan: fix shrink sc parameters issue
Date: Fri, 12 Jan 2024 09:27:58 +0800 [thread overview]
Message-ID: <7a94c962-6137-47c1-be4c-ef2a0614bfd2@vivo.com> (raw)
In-Reply-To: <20240111134338.GB390292@cmpxchg.org>
在 2024/1/11 21:43, Johannes Weiner 写道:
> On Thu, Jan 11, 2024 at 08:24:51PM +0800, Zhiguo Jiang wrote:
>> The values of struct scan_control's members obtained by
>> prepare_scan_control() are always from root_mem_cgroup, rather than
>> the memcg where the shrinked folio is actually located, such as
>> sc->anon_cost, sc->file_cost, sc->may_deactivate and so on. This is
>> an inaccurate sc values for the actual situation of the current
>> shrinking memcg. so we need fix the values of struct scan_control's
>> members are corresponding to the current shrinking memcg.
> You don't seem to understand how cgroup reclaim works.
It seems that the actual memcg's lruvec->anon_cost/file_cost values are
not used in code exclude target_memcg ?
>
> Nacked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2024-01-12 1:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 12:24 [PATCH v1 0/2] *** SUBJECT HERE *** Zhiguo Jiang
2024-01-11 12:24 ` [PATCH v1 1/2] mm:vmscan: fix workingset eviction memcg issue Zhiguo Jiang
2024-01-11 13:41 ` Johannes Weiner
2024-01-11 14:15 ` zhiguojiang
2024-01-11 12:24 ` [PATCH v1 2/2] mm:vmscan: fix shrink sc parameters issue Zhiguo Jiang
2024-01-11 13:43 ` Johannes Weiner
2024-01-12 1:27 ` zhiguojiang [this message]
2024-01-11 12:51 ` [PATCH v1 0/2] *** SUBJECT HERE *** Christophe Leroy
2024-01-11 13:10 ` zhiguojiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a94c962-6137-47c1-be4c-ef2a0614bfd2@vivo.com \
--to=justinjiang@vivo.com \
--cc=akpm@linux-foundation.org \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=findns94@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=opensource.kernel@vivo.com \
--cc=schatzberg.dan@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox