From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00933E7718B for ; Fri, 20 Dec 2024 18:43:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 852026B0088; Fri, 20 Dec 2024 13:43:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 802956B008A; Fri, 20 Dec 2024 13:43:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F0386B008C; Fri, 20 Dec 2024 13:43:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 519536B0088 for ; Fri, 20 Dec 2024 13:43:32 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C7F6144EAC for ; Fri, 20 Dec 2024 18:43:31 +0000 (UTC) X-FDA: 82916209320.13.D3CA00D Received: from sxb1plsmtpa01-13.prod.sxb1.secureserver.net (sxb1plsmtpa01-13.prod.sxb1.secureserver.net [92.204.81.237]) by imf03.hostedemail.com (Postfix) with ESMTP id 4764020003 for ; Fri, 20 Dec 2024 18:43:14 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of phillip@squashfs.org.uk designates 92.204.81.237 as permitted sender) smtp.mailfrom=phillip@squashfs.org.uk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734720193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9BEXE2cnHNf8ritGErHpyV9g4N5jPXEC+5E/Vm2TmkE=; b=RTjjrQmlTBkElgY79w6no8WV+wvqAwXbPx2sXVmCHKWTJ3RkKP2gjC59P2nbSWUU4l5gjW WcU0OaXa4fOXjYofo6zDOcDdzuCmMmmdaY27hyn1p/NdtwckwsMwUJHTlvl6uxlXh2pBzz +rQVRhExCxSTsV2VzbEqi5nWGjabCO0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734720193; a=rsa-sha256; cv=none; b=w55HWfpg83MXyC0rv02s/ZAp+RgYk/JTRXTvgVfZ55BoiGXfscMEz8R1DXa/r/wm+LA3u9 u0yg1echqXbjWTGQO5vK5pSLXJRQRc6SpF6gtfjwMgj2RKlHJFeYBHbw2b6t3TNMPRleqx XjLaR4lIodZ2QR1Cu/zQVWGgoUis2mY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of phillip@squashfs.org.uk designates 92.204.81.237 as permitted sender) smtp.mailfrom=phillip@squashfs.org.uk; dmarc=none Received: from [192.168.178.95] ([82.69.79.175]) by :SMTPAUTH: with ESMTPSA id Ohy2t3NRDsKJaOhy4t3nDS; Fri, 20 Dec 2024 11:43:20 -0700 X-SECURESERVER-ACCT: phillip@squashfs.org.uk Message-ID: <7a9355eb-810d-4f5b-90ed-bf4f4ae7e161@squashfs.org.uk> Date: Fri, 20 Dec 2024 18:42:57 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] squashfs: Convert squashfs_fill_page() to take a folio To: Matthew Wilcox , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20241216162701.57549-1-willy@infradead.org> <20241216162701.57549-5-willy@infradead.org> Content-Language: en-US From: Phillip Lougher In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfNY0SypDjKq+msefzXXDnKtirnRkNAvJhWWiV276jvbZ4vG82fbsFNs5uk+ZZSClx+Br8phl6nzuaxTSFv3+EsAO+SNbG+zy3/9lOEk027RXhqEZtoXz U2BSqFrJR8J5n2tq3EWDVxPQt7vZeUynYcEs0QtTcDkCOhjNmbzANjvO9v0tsBP6Vq6BGf1p2xxMsCQ2sHuKpJrZr4wQ6c6ElMbAwnbTicwmMnk/hgQZgXk9 RYewiNG+palSjDqiMTSbz5iKlWTuwtcxkeTbQPBYBtt+lf5SyiK2gNDzA1FXJwCCwktzL0Qlqh4K+LBWe0hPnXfZUX3oaC4taI1amXlIl/qaqoViuStzyaum sk66vwQq X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4764020003 X-Stat-Signature: yzcrctjdh9xkwrzh51z94gw7nxxu1hac X-Rspam-User: X-CMAE-Analysis: v=2.4 cv=VfvxPkp9 c=1 sm=1 tr=0 ts=6765bad2 a=rzG3t2PYufEJF+g/NaN45g==:117 a=84ok6UeoqCVsigPHarzEiQ==:17 a=sbqGhzo7vaogXqIfg0wwtJZuoPc=:19 a=IkcTkHD0fZMA:10 a=RZcAm9yDv7YA:10 a=feLtDDcTkb7NPGqLxvQA:9 a=QEXdDO2ut3YA:10 X-HE-Tag: 1734720194-573015 X-HE-Meta: U2FsdGVkX19Zdsq/MTOZE33c21AfOEdkaqntqgAfDGdsJsEJphEwc6kqBbBMYREyi+Xa02cpheXcbzD0likv8Msp5Dc8XUjibqwLe0pL+sOxX1cb11+lHgrufbdmOS2Mm94X3xfGb9QwsfY/hWUMmohCB3nE88QXVIjWmlMsivvJft6K4ZrgqfhhakKeCs9XAtio51hF6srYH1Qdm8maEiKlU3qz8fF2k54Vk3MPHSLB1LYII8r/6IF1h867lfTC8P8/zCCzXXnko9XSrGSa/PBppN8o1Q8edVTJHbbEOfrjQZgukX3PcdfX7yVML0fjaW2+tRhywDRyzFDe6hnSKTF+/LkoCNsF0+2oqkqteierGw5lan8nSuuez5GczwkMmlV9hbJrYXHvBDT7H0a256xHhqMPRV3gxtIepP3215AvHZ9XSTOaM1OahYVAI3cQzZdncYDxqVONR3KKrcMEf475rTBIfRNZzjmhftQbDY/y4QwLj4C74dG9Iy3r/kmFRwpuQfdESx4TZCUH/4wJlSVdqMtqZuSrJYDjKoZ9iPkEj1TP9sKGzX7xeIPGY8g3dwt0vFHxOSjKrF3g0sgzA9k9Bqj/QcWsX7BgcFSFYTDZp7F5dGoLrdbJ0UopcAdOE88zjmjjcbqcAjeHQOFe6LM63/iK5FNuKqAmFtv/0I4Ub0P57Z7CPd1RJMzndzgIHmsDr9eC5aulF3Pi4gH+JHYSucsbrJtD0q6XebiQ+PhDTboAllbb7yjhF0e//wxWfRu9FW9ZFc9OX6/7HUKagc9+iyzwwuUkTBMVytlngGAh6sUDFHe3ToEnfYHLvjdKHZuadkQ05q33OaVbmRnuVMYQ1eQIto6Y2iBz0hMGZfu5KomKLBWQM/+e6hZwuZx2qBU9m6+WVbHqE0W8XuMV937PLgyvsR/oJ8gFOiLDhAtyqyTFRlZYkL6faVPwDurz4cATvSa1C37DyXz7hTU EGiyQUk/ d2s/KrGNtg+OaMIZkOG9vW5jioNgXz6UE3ZKYtZJqgv+c9yRmFB/uiHZZq1NpVMCfbhok8dYqLQDJHtRHfT1haBo+8hqZGNmsprxzpbi2CmTCi9tk+odx0DPUxGc6Zv8vHkd+FplotcuCUOfRZCim5ab1SkYPacNPUethO9viB+wx7ITgMlXJt/V1MNQ8+ZJKAdUPLZfYZ1negPzZQ5IP8YkSX2RfoMkcMbFjBrOcTmv7hqwvzsmA9Fx1DwqKOcMVufz5ewxlyHPS9zZneOkIcOzY/5dibWGXy55m37GoAqwMjI1x93HdsNa4Os3K8Bo7oV2Il+PkquYv3jmlu/4jZAgmUF+ZnqECQQZG9kc6OVGwlMCPSK/9a6f900Cgmv6Cuhb0mfJLc3NrFgt9lSyQYBPZ7wMZtFQ+Mibhx5feGPepz2ahPZugC3bH/aXmaqcroqTYObPZqK2t0NCh6v6Jyznm9Ozt/Kn5+7Pvsx+LmpKg2Zs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20/12/2024 18:24, Matthew Wilcox wrote: > On Fri, Dec 20, 2024 at 06:19:35PM +0000, Phillip Lougher wrote: >>> @@ -398,6 +400,7 @@ void squashfs_copy_cache(struct folio *folio, >>> bytes -= PAGE_SIZE, offset += PAGE_SIZE) { >>> struct folio *push_folio; >>> size_t avail = buffer ? min(bytes, PAGE_SIZE) : 0; >>> + bool filled = false; > > ahh, this should have been filled = true (if the folio is already > uptodate, then it has been filled). Or maybe it'd be less confusing if > we named the bool 'uptodate'. > > Would you like me to submit a fresh set of patches, or will you fix > these two bugs up? > > Thanks for testing! Np. Andrew Morton is kindly handling Squashfs patch submission to Linus for me, and so I can't easily fix them up. Andrew what you like done here please? Thanks Phillip