From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AE21C5478C for ; Fri, 1 Mar 2024 08:22:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 691BB6B0085; Fri, 1 Mar 2024 03:22:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 642066B0087; Fri, 1 Mar 2024 03:22:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50A356B0088; Fri, 1 Mar 2024 03:22:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4263A6B0085 for ; Fri, 1 Mar 2024 03:22:18 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E15291203CD for ; Fri, 1 Mar 2024 08:22:17 +0000 (UTC) X-FDA: 81847777914.01.77BD985 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf10.hostedemail.com (Postfix) with ESMTP id 5B739C000F for ; Fri, 1 Mar 2024 08:22:15 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="gVbThW/o"; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf10.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 198.175.65.19) smtp.mailfrom=binbin.wu@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709281336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6i98D26UpCSNNSDNgXZsqSvwfFCEPQl9iPi0t3L+wh8=; b=J2jIOOOsLzwFNIBcFttSck7OZaMkP/gFlZWowXBQMAXZzmqWJ3MgdQruCx24fxlxbpzSSS 6t7AVuDvFCPMDzjmaSxcupYIEfAZlfM6+W6t/J9scnkwfkidWxOnfnnanawRRDsQjiY8XA cK2V5PViXQHyqNpvwWBYNO8HLq9O9bE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="gVbThW/o"; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf10.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 198.175.65.19) smtp.mailfrom=binbin.wu@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709281336; a=rsa-sha256; cv=none; b=sjRtmnSKh9BM3j6wXTfZrYc3Vn4+AOF0hOlh2S/XS+KQn/OMnFVFoLP4kHodeQ+Euejx/r wxAXxJ1spgmWEOmSwurdFgmVgE9TAMa6AiOgDbGb3jxse6sSdmqY16j6buaSK3ThpihOSH GVIwNRDjoBq/kSoxop2W2iYfPuoY6aU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709281336; x=1740817336; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=L/oHwYBp57m19z3C6RvcmW7hmp890HYZJEwOnFdlmj0=; b=gVbThW/ohpmFSZDhAolX01D1nlQ0Qma9HK+YXE/AZ04n1h6aqeoR/B4W zD3hEh30jbVkIIH/s0lVRBrjDZFQ5vvWBuyBc+fRIHtA0KgYS2ZV1Wh72 vWBo45jBUdz2XvNphergabV+ixklN9/fESi88ELiXRkzV4s5S6d1F6dJO bP/+kfGzhkDsKGVUP0m19FfrkaLg1DG5kntXfBQSkNFYxTYUJ5cDoTUJo AHYZ6mO4aHXaNXzHwiCppluEz22bED4Jex5uq0IJnfbIaoKOjUHQPq3ZC jv4SzEaO4QO1k+Gw9fRkv9eJPnivljBHvpN3XiBI91zd9CpuSLTg36HgB Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="3656741" X-IronPort-AV: E=Sophos;i="6.06,195,1705392000"; d="scan'208";a="3656741" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2024 00:22:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,195,1705392000"; d="scan'208";a="8047412" Received: from binbinwu-mobl.ccr.corp.intel.com (HELO [10.125.242.247]) ([10.125.242.247]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2024 00:22:09 -0800 Message-ID: <7a90438a-6bb3-4e95-86a2-9ba199827675@linux.intel.com> Date: Fri, 1 Mar 2024 16:22:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v5 14/29] KVM: selftests: TDX: Add TDX IO reads test To: Sagi Shahar Cc: linux-kselftest@vger.kernel.org, Ackerley Tng , Ryan Afranji , Erdem Aktas , Isaku Yamahata , Sean Christopherson , Paolo Bonzini , Shuah Khan , Peter Gonda , Haibo Xu , Chao Peng , Vishal Annapurve , Roger Wang , Vipin Sharma , jmattson@google.com, dmatlack@google.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org References: <20231212204647.2170650-1-sagis@google.com> <20231212204647.2170650-15-sagis@google.com> From: Binbin Wu In-Reply-To: <20231212204647.2170650-15-sagis@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5B739C000F X-Stat-Signature: twiogto1wkh4t44jbyoefu17pe6fw5c7 X-Rspam-User: X-HE-Tag: 1709281335-227364 X-HE-Meta: U2FsdGVkX19eLT54clJYnCOAk43RnCPFXzh8wwU9Mk+F2O2hlfMWz6AVBrJneN7LCyHJEFNWQJVATpMm0Iwndttc4SWIT2oktxvxVhXQwu3z5SYGMY5vZ+a8UO2KBDijggy8x969FwQJG173JCliNB0F0bnaMWOurkq0pgdCXWIRWlrvyufSmqR8tfzZt5kEA2dfM+4NOBMsSgUOQjTlb3l6I12nPwOFrKV0s3lwH5bnK1XI6NrEoitx3r2ky219bEOcJE6ezO8qAbDNEPegSTbSPdM4XhQ4idXD4f05lYdRujy/PGu6u7XWgOtu+kVS3uyE89TkWrT5BUQt4n28eovj21k+2FeGk+pDbJMzs6mHdUwnFTlFioZAdfvbczxcyezxs+oa5L8yfx95N8E8NRWKNjiR9Z4jyXS7W7352OGbgRLmgzPMob4xIcixbkRxlOVZOtsIBMcxoC5w0leqWX6zsL7rdzjclgM1wTRlraHACq1ZLW6gLtqe1J2WwcoPZhbTo5khu0DfVZeKVbGbZOjAdJD6i/LK73X8wwuC0LXqRowM28d9t+dg+8vEQOHDnq3PJspVKbgyLBartps2LhelBm+WbtODLuviXb4VnXmJG5nJcr4nfVN8EDS+uokyOgCuag7fUcTTqeYoaymQEt6CJTJ+SxmJeLrOtz4UkSWbdNKdC7wRg336qnTTh7PXGfnOW80FVwCs7fxS/nDouHIGrSEniV4lbXXkI3qq9ObYHjr8r3EJaTiDVNQLqbnGISL/eNn2WfjuvUzAY9um6JkrYP/AQg0ORG4Cs9WHqNE0WqDBsZc+jCiF9oiDRo5Bthk8dAgSmr48EkVnFsG6eLC+Kz0LOpqKwI+whkydHNjl4XNvufhxEBKT7ZQXaSUWXfFsTAfGZv9p302wr0hGku8OMRN6f8zkMTtxt0J5ptQyVsI7dxOE4yoccCNrvDXk3Al0m8wMtjsnVvd8Gbq 6KLoTS57 oM56kYKUTJ/ZV2eiXtrRPSvg8rIqLH2lPRBHFZQB4HWAOtI9ljwdnR5Ja7Kk3gk1oyYg8pZOKONZw1SE2SdiMEwYueXUKtaEulG6zAkYpgC3/pey5sYDaNMQQAOaNSsv0PVOVqmgMmpwLCXpZzgZwT0Qgm8kXgNFyWf27gGsL4a0+zV/NHF7kXqTdXWUbMP5veX+I5KKjIZLMaOMBEw1OrTSrAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/13/2023 4:46 AM, Sagi Shahar wrote: > The test verifies IO reads of various sizes from the host to the guest. > > Signed-off-by: Sagi Shahar > Signed-off-by: Ackerley Tng > Signed-off-by: Ryan Afranji > --- > .../selftests/kvm/x86_64/tdx_vm_tests.c | 87 +++++++++++++++++++ > 1 file changed, 87 insertions(+) Reviewed-by: Binbin Wu > > diff --git a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c > index a2b3e1aef151..699cba36e9ce 100644 > --- a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c > +++ b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c > @@ -429,6 +429,92 @@ void verify_guest_writes(void) > printf("\t ... PASSED\n"); > } > > +#define TDX_IO_READS_TEST_PORT 0x52 > + > +/* > + * Verifies IO functionality by reading values of different sizes > + * from the host. > + */ > +void guest_io_reads(void) > +{ > + uint64_t data; > + uint64_t ret; > + > + ret = tdg_vp_vmcall_instruction_io(TDX_IO_READS_TEST_PORT, 1, > + TDG_VP_VMCALL_INSTRUCTION_IO_READ, > + &data); > + if (ret) > + tdx_test_fatal(ret); > + if (data != 0xAB) > + tdx_test_fatal(1); > + > + ret = tdg_vp_vmcall_instruction_io(TDX_IO_READS_TEST_PORT, 2, > + TDG_VP_VMCALL_INSTRUCTION_IO_READ, > + &data); > + if (ret) > + tdx_test_fatal(ret); > + if (data != 0xABCD) > + tdx_test_fatal(2); > + > + ret = tdg_vp_vmcall_instruction_io(TDX_IO_READS_TEST_PORT, 4, > + TDG_VP_VMCALL_INSTRUCTION_IO_READ, > + &data); > + if (ret) > + tdx_test_fatal(ret); > + if (data != 0xFFABCDEF) > + tdx_test_fatal(4); > + > + // Read an invalid number of bytes. > + ret = tdg_vp_vmcall_instruction_io(TDX_IO_READS_TEST_PORT, 5, > + TDG_VP_VMCALL_INSTRUCTION_IO_READ, > + &data); > + if (ret) > + tdx_test_fatal(ret); > + > + tdx_test_success(); > +} > + > +void verify_guest_reads(void) > +{ > + struct kvm_vm *vm; > + struct kvm_vcpu *vcpu; > + > + vm = td_create(); > + td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0); > + vcpu = td_vcpu_add(vm, 0, guest_io_reads); > + td_finalize(vm); > + > + printf("Verifying guest reads:\n"); > + > + td_vcpu_run(vcpu); > + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); > + TDX_TEST_ASSERT_IO(vcpu, TDX_IO_READS_TEST_PORT, 1, > + TDG_VP_VMCALL_INSTRUCTION_IO_READ); > + *(uint8_t *)((void *)vcpu->run + vcpu->run->io.data_offset) = 0xAB; > + > + td_vcpu_run(vcpu); > + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); > + TDX_TEST_ASSERT_IO(vcpu, TDX_IO_READS_TEST_PORT, 2, > + TDG_VP_VMCALL_INSTRUCTION_IO_READ); > + *(uint16_t *)((void *)vcpu->run + vcpu->run->io.data_offset) = 0xABCD; > + > + td_vcpu_run(vcpu); > + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); > + TDX_TEST_ASSERT_IO(vcpu, TDX_IO_READS_TEST_PORT, 4, > + TDG_VP_VMCALL_INSTRUCTION_IO_READ); > + *(uint32_t *)((void *)vcpu->run + vcpu->run->io.data_offset) = 0xFFABCDEF; > + > + td_vcpu_run(vcpu); > + TEST_ASSERT_EQ(vcpu->run->exit_reason, KVM_EXIT_SYSTEM_EVENT); > + TEST_ASSERT_EQ(vcpu->run->system_event.data[1], TDG_VP_VMCALL_INVALID_OPERAND); > + > + td_vcpu_run(vcpu); > + TDX_TEST_ASSERT_SUCCESS(vcpu); > + > + kvm_vm_free(vm); > + printf("\t ... PASSED\n"); > +} > + > int main(int argc, char **argv) > { > setbuf(stdout, NULL); > @@ -444,6 +530,7 @@ int main(int argc, char **argv) > run_in_new_process(&verify_td_cpuid); > run_in_new_process(&verify_get_td_vmcall_info); > run_in_new_process(&verify_guest_writes); > + run_in_new_process(&verify_guest_reads); > > return 0; > }