From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C09ECD1284 for ; Tue, 9 Apr 2024 11:02:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB5276B0092; Tue, 9 Apr 2024 07:02:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E65736B0093; Tue, 9 Apr 2024 07:02:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D058E6B0095; Tue, 9 Apr 2024 07:02:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B18176B0092 for ; Tue, 9 Apr 2024 07:02:14 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 65A374034B for ; Tue, 9 Apr 2024 11:02:14 +0000 (UTC) X-FDA: 81989704188.07.05211D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 1A07F160023 for ; Tue, 9 Apr 2024 11:02:11 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fsXpP5mA; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712660532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5EuvRYjhB2ByIJqrM8XsBqe7c9oo5XQaPdNDVkox+vI=; b=C4CP+a31T7c0wiYUY6fvub5eQIUV1EJg2OS1zxHVrZvUYpX8WlIvkC0W2nKe2yvuhWQVSk WCzit7KZS7XqrdW/xIkYeLm4ZbBrb43Wlr3EEwSmFBMxOgyphQC87WM74xL1dOD7qQ6fu7 OR6hYc/0pE1EfeUJrcp6ikYbDomlKck= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712660532; a=rsa-sha256; cv=none; b=MEYh137xP8zBEzN4w3INAZdrLQEAYaKVsxNtpNnbR9TKIssJEtNiRno2U2YMioD46uDzQn CKEejVpelK3U5g5Oj84Up5Zae3TTSz5sjfuxDgLyuZTUz8TkZPR9zzzopwhqbezlb7bpKA +BUdRAaRqBE5FHaolCOJlh538EtXHKQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fsXpP5mA; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712660531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5EuvRYjhB2ByIJqrM8XsBqe7c9oo5XQaPdNDVkox+vI=; b=fsXpP5mAzc5Ho+S+mRQFjrm0LeN6RpWcRxsi6+agVZK1n3ndjBtzq/QljrtCeQoyZ1pawc XhAprkLBlY8woic/Yi9YDlQpbDAcSHClUWdglTfGq3Vi8Isx1P4qisO9UZQMLifBaW3dQh aiYdDSRhvHavl1UUk4/rgcn93T0oRcI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-216-AWy28DyoOx2iPeZousJCMA-1; Tue, 09 Apr 2024 07:02:07 -0400 X-MC-Unique: AWy28DyoOx2iPeZousJCMA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4162bc2da3fso18791065e9.1 for ; Tue, 09 Apr 2024 04:02:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712660526; x=1713265326; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=5EuvRYjhB2ByIJqrM8XsBqe7c9oo5XQaPdNDVkox+vI=; b=FdOtLbX6QwjK5nyvoDKIEY1OFcwzsvliM/XqVR2IneLifZmonosFOZp8FKOTxc1P5v /M5L8RHjSLtln7YvlzBi+QNCWagDl1Ib35qF/7yXo6osEO/0d1vZuzmVXl5eT88zbisJ 2gz81Odc4Xmswj2qfaaMONv1WlN7l9CRSp8S8SXj4AohkIc3fQq45Z+poVy55AJU/6jL Gt9ePI04M2haRxgtN4A6/F2Jr4oUoBk/J4mu2CLNlXtrWZn0GBOieMOPv1w8uM8zY3TN pOhy31X7vhjHqMAwTXDF/Sev/cPGr4UxWO37PYjYCzVbEv/GUmpuegYCPHnJMXJ5Y+oN eJVw== X-Forwarded-Encrypted: i=1; AJvYcCUS91f40p0avZySSjwhKjociVvCcdNfDSDJ6DqlUZRTt3UhuU36eOAUTQJKuQpA5sX0ity/wYFZzF7HYWjalJ/uKnM= X-Gm-Message-State: AOJu0Ywbc/NCfz24tuCfI+agLJuxR43IM/13jNGNShS9R37mE62EeZtD V1Ld2OlQzwDXgWqE9+FAdTUf/KVN9tnnPd2y9AYMKAx5ooUwjK8aomJFGCp0NB9mXLB40CnZJtd WTrfn82rxw7hXnlBfjVWo66/uM0kbjGDp8VRo6ZvR03lM/mwj X-Received: by 2002:a05:600c:512a:b0:416:3317:5951 with SMTP id o42-20020a05600c512a00b0041633175951mr7239142wms.6.1712660526458; Tue, 09 Apr 2024 04:02:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnFcNFxAXoOVObPD2o30lZXdjv6GTG+xWvlEs15Bo+7jeLAg5j8PlkRre9DjPi/ol87m/44Q== X-Received: by 2002:a05:600c:512a:b0:416:3317:5951 with SMTP id o42-20020a05600c512a00b0041633175951mr7239130wms.6.1712660526034; Tue, 09 Apr 2024 04:02:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:be00:a285:bc76:307d:4eaa? (p200300cbc70abe00a285bc76307d4eaa.dip0.t-ipconnect.de. [2003:cb:c70a:be00:a285:bc76:307d:4eaa]) by smtp.gmail.com with ESMTPSA id j9-20020a05600c190900b004155387c08esm12420936wmq.27.2024.04.09.04.02.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 04:02:05 -0700 (PDT) Message-ID: <7a8d8005-3cec-4647-82b0-2d55d0ef34fc@redhat.com> Date: Tue, 9 Apr 2024 13:02:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 8/9] mm/ksm: Convert chain series funcs and replace get_ksm_page To: alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Izik Eidus , Matthew Wilcox , Andrea Arcangeli , Hugh Dickins , Chris Wright References: <20240409092826.1733637-1-alexs@kernel.org> <20240409092826.1733637-9-alexs@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240409092826.1733637-9-alexs@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1A07F160023 X-Rspam-User: X-Stat-Signature: 47ru3ama8zftq35wox5bnanuf6faeway X-Rspamd-Server: rspam03 X-HE-Tag: 1712660531-534467 X-HE-Meta: U2FsdGVkX1+pMEXVvLkJHSku5671JaNZxXvJDTfLvP/aUQNnuOm2gdL5cRyZ3NPiyfCYIQ/vluyTFTRCm6aUIC4xv18pOAkMtdOcgStI+rCI7AI5+ynN6/Bu+lO6MeNImqf/LFqOCU0BhmMDYNJdKeWpd5Sbio3BJ3taRBbMUDR2UcKchDK4BZiM1hAG83fXe2tqTnL+7OVmSA+R+0Wt08k8b50BgOnpCHbXQpuczzabaymkoH0jCsNDTGP+/QHi7lbG3H8huupbWbZSfsVMDv70niShlkhVqRPuPDk1/lgAkeDE5hTwqx1MI4mU1TxrvysHItzkgAqTHji+/U+bhHtvW9brGpUEZhiQmy5qZjbiJWPZxt+5v6xR/D0yhRWWqt4H3XFOaal6AbXJwQ+10tmUyh2mf4AKa7EjETY8S7KhESmQnAg8Z4MrL+YQlpLdOrWZ974Szmj9rSMCnuBvU/M4A/yicSTTTLT+hemBjIfmDdNo6lwaPR1+4Ay/nnz2GMZX6YmK8ycQQrH5iEMRxdEYqmwcqwOc2pWjt9tz9C0eYCGysEycV4NioQtoCIs9pKFGGJROFU400HAY2QSllO9q/D4eFUIAN00YMffJY66EuDyniC9VtayGMqbE6z1ylRxsg0eZUmZOtFPIb5Oowapj6Hp1BKfHggAvTCx+EU5IeS7Pvt/baxUvqWRyhW5+v4oQOi0kRwjrbpwDta5Fcmj8oBVphwLFGhNZxbzlVgsW+gHK2jWb/pldlqox/gD2hgqyC6c9w/cc0KD0cF4Vplmwj7P+AN7UUiRnheoGYPCrZ/erzmcRHtKcBJAO6GHvKeyGQFbz3q49s4NR1/kht2VLzBm6FDgVz5PMNKskuiSvnbYB7H9tO3YB+AdaeMQ8Ipo2ZmtxJeeYlizO0p9+ydI4TJNnrROp2ruieg+TfuSvfT2zwCeg2so82wXLMma/eN/tSu6KBF9B/c14QBw HPZX6W0i ASyff4zuWvZPEmk/sAa1ss2qghJQTIozBOc2V1eaDziK6InN/15zxy3W/6RinvW/zdBOzMilEmKcSyVYV8OoMuvWN+6dNRhRCsaRfrIbkMDbERLU1oD+7DOJw2jpm/+lXwOppPo/1ct6ctlL9FCvc1ukBDQBAchuG7F4ep+eFHQ0Re3WnV9Jwf1wGjl49kMbrIO+D2HX8CRcJl2TxzHtEeXuzeBlI2faivV24gC+85h8zjW4euy0AwFCQu3BFDD4OA/24t1KyoV4oQadAwRr9+r//vU91LcI3vJglcn7uQpVbKFdmRLWltUQ8+i2sjiE42yOE6K4I8+nVGyY8N5tDRD37FXW8AI3nySxTdcmh1HpydPqOWvDZpdp+ZV1EKQgga2DWM4U+VjzSTj6Viwgr5YOyOJIz589uPGPHYLwGytmA6DjX4evGKnQOQbhwRlkxFmOVQhVs16Ah1WPwRexTz+evUl7MydmIENmdvsxP1iSbxTZIwaevJRvFdVbQEM7mF1icnIYEDwoVthO9ag8fpKC0rrkVbjaZzuw+UN7+j+C4hCrT1SBW5MXLwlcCdGon05Cn5dnt4Bx0daVRkMZv0DIMhH0fVJAHitH+6AOgDv9ujxpT2OX6TuMR4FM8JNhvQP3HnhJfRWy/XKhXI2eVLCUtr8SNJ2oVnIyc4bxBDF6/SRiX6OBMsS6cHyUNQubIETvdCJd50wBFlZgV/orI7YifDMA9qH+78n7tJRw0I+0iyErUGnCM3Ote0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.04.24 11:28, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > In ksm stable tree all page are single, let's convert them to use and > folios as well as stable_tree_insert/stable_tree_search funcs. > And replace get_ksm_page() by ksm_get_folio() since there is no more > needs. > > It could save a few compound_head calls. > > Signed-off-by: Alex Shi (tencent) > Cc: Izik Eidus > Cc: Matthew Wilcox > Cc: Andrea Arcangeli > Cc: Hugh Dickins > Cc: Chris Wright > Reviewed-by: David Hildenbrand I don't recall giving that yet :) You could have kept some get_ksm_page()->ksm_get_folio() into a separate patch. i.e., "[PATCH v3 11/14] mm/ksm: remove get_ksm_page and related info" from your old series could have mostly stayed separately. [...] > /* > @@ -1829,7 +1821,7 @@ static __always_inline struct page *chain(struct ksm_stable_node **s_n_d, > * This function returns the stable tree node of identical content if found, > * NULL otherwise. > */ > -static struct page *stable_tree_search(struct page *page) > +static void *stable_tree_search(struct page *page) There is one caller of stable_tree_search() in cmp_and_merge_page(). Why the change from page* to void* ? I suspect cmp_and_merge_page() could similarly be converted to some degree to let kpage be a folio (separate patch). -- Cheers, David / dhildenb