From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 856DBC35274 for ; Mon, 18 Dec 2023 09:54:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09C4B8D0007; Mon, 18 Dec 2023 04:54:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04D7B8D0001; Mon, 18 Dec 2023 04:54:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E583F8D0007; Mon, 18 Dec 2023 04:54:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D0C808D0001 for ; Mon, 18 Dec 2023 04:54:51 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A23CD1603FD for ; Mon, 18 Dec 2023 09:54:51 +0000 (UTC) X-FDA: 81579479982.08.C5028D1 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf06.hostedemail.com (Postfix) with ESMTP id 274EA180019 for ; Mon, 18 Dec 2023 09:54:48 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of sunnanyong@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=sunnanyong@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702893289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SfOmpYWCxXYxRT5yX9g0qOPl6zqrsjkCTP7wo5ZhPeo=; b=af8dUbBYOqfLdyf3hLxjvYJdb0lM3YckiHVHphq9ICfG+87rsuCnT3pWJNNmOTxNp04zCK IEOKck1bCWbNSjhPUCxfgkDwn2sCueCHyeWX9QqOI+4hMv+xRqPVvaz2mPrVYeGDLq03E6 /i8yGvKb2iI3QE5ZZ63mY+MwtaQSW5U= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of sunnanyong@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=sunnanyong@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702893289; a=rsa-sha256; cv=none; b=iiTbOw+d0buUWqyYYPfydI2p3lPiGwwSzPeVZy4KNS3mdSZiC6blFGziL800cxQmwABQna z3H1fGjc4o4tI/zAmRgNyduFA9BDALU8ro6Q8EKcyBwSeNPcxfo+VXCp3ho/czZ8bF5j2D gtqwCHYPDfcCO/8Fjq4rghcxMpEc3ug= Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4StwCW2LZ7z1wnxH; Mon, 18 Dec 2023 17:54:31 +0800 (CST) Received: from kwepemm000003.china.huawei.com (unknown [7.193.23.66]) by mail.maildlp.com (Postfix) with ESMTPS id BB4431402E0; Mon, 18 Dec 2023 17:54:43 +0800 (CST) Received: from [10.174.179.79] (10.174.179.79) by kwepemm000003.china.huawei.com (7.193.23.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Dec 2023 17:54:42 +0800 Subject: Re: [PATCH 1/3] mm: HVO: introduce helper function to update and flush pgtable To: Kefeng Wang , , , , , , CC: , , , References: <20231214073912.1938330-1-sunnanyong@huawei.com> <20231214073912.1938330-2-sunnanyong@huawei.com> From: Nanyong Sun Message-ID: <7a86f31d-475a-133e-fb79-3a1d6147372a@huawei.com> Date: Mon, 18 Dec 2023 17:54:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.79] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm000003.china.huawei.com (7.193.23.66) X-Rspamd-Queue-Id: 274EA180019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7qaeimmjr8ci5i1t3deoimomxih68s9a X-HE-Tag: 1702893288-694187 X-HE-Meta: U2FsdGVkX1/UJzyBcBiUn3UcksqWT3binyHd0v5/asdDijXNGUJWkTd9/yoVxJ0dhGibUs/bbEHYdK2FU5EGcVXis24XAVq7Pee96tKPfEQgbc93UOoRG7Sx/3A8po0lmTw26q6Uyk1l1cbU+Syxl+bsGSfJ1kX8WSuOuY6WxZ2svjghs8xgrAyS0RPvmff1BXNCVgEX/WFvT+bhHOzAlln8ulgxh3CG3dBmR5Gg957wsZ6cUUPR7n/kHfRlWb7o7Qo+YrL7V7RHd8+wrTG83NUNRl4X1Hm4tvW7NB2xOINoAtVx3EzFyB0/+5ZuLLiQ2rds/KtAsIiYqA3jBigiKAFdJ7VXKQPo6WXxH9vEJuACi7I3IUb++2PJVDrxSfXNf4Hhc3eFCr7FLz0tJXbDRa3XTYQ3gcPel+un2PTcAlNqrUmMmosvZK39rrDTME2ny635ZRSTiWy5Z6vSeq/v9h8MNUSAB0LAt2xmA5i0rzAd+CaxUA8Ms8lDE49GMnIJFq14r5NVPlQFYsa37kUS5AV6oSYkaF0L54jqef7zjTfw5SzLCc3gmyb0bDaVfBHbr48IoQ5EC2sTWq+8qtW98FmErh9JsBlRn5RSJtwlR5EhAvCCL9GM+2aCwms1R59MWGhuIciAkGU2zi9kNWr5+4LSMqK4V2S0CddAhNy1hjfoJeasX0xgCNC7qwnF2HXJJv2fAESczRpZIpOnCa1GLJJoSxKZhHqnCFQVwVmzrH7yxDhuwwBDsQUD+hFRypsAqCLQX8850WYTpCda5DBxDo8cIjrqX0HZzqix4mx81M4iog+Ecri2T90cI3zUBhKdG2Cx7vh1+Pzjx9QrJhLOxHkzXlFC69by9AumXhaIBW7M/zke+7j/S48toq9jGLY17LCpXDXTiv3eEQDvy3wLTBLUQmqG0Dbx/I0Bu3+Kd1VvgAULntfjwKSJCzJ+5HmSG6eezvn19I8JjoYn3ad v/rXLLQS g3+52rpAD0u7hYd21c5mk13Wvso6GHXP+C8+iT2fIRPXSseJV7k6WmNnuvgubQXaiwVcJIcsZiU07Nj6NXRF3mrjTbRx9BdknwfLrehdTcx3leDU8Mz8s4FOPXfWHjCA6rTXaalpwMK+r0VUnOkcC61hoQmVzFBEn4NV1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/12/15 14:16, Kefeng Wang wrote: > > > On 2023/12/14 15:39, Nanyong Sun wrote: >> Add pmd/pte update and tlb flush helper function to update page >> table. This refactoring patch is designed to facilitate each >> architecture to implement its own special logic in preparation >> for the arm64 architecture to follow the necessary break-before-make >> sequence when updating page tables. >> >> Signed-off-by: Nanyong Sun >> --- >>   mm/hugetlb_vmemmap.c | 55 ++++++++++++++++++++++++++++++++++---------- >>   1 file changed, 43 insertions(+), 12 deletions(-) >> >> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c >> index 87818ee7f01d..49e8b351def3 100644 >> --- a/mm/hugetlb_vmemmap.c >> +++ b/mm/hugetlb_vmemmap.c >> @@ -45,6 +45,37 @@ struct vmemmap_remap_walk { >>       unsigned long        flags; >>   }; >>   +#ifndef vmemmap_update_pmd >> +static inline void vmemmap_update_pmd(unsigned long start, >> +                      pmd_t *pmd, pte_t *pgtable) > > pgtable ->  ptep Hi Kefeng， Thank you for your review on this patch set, I'll fix them and send out the v2 version later. > >> +{ >> +    pmd_populate_kernel(&init_mm, pmd, pgtable); >> +} >> +#endif >> + >> +#ifndef vmemmap_update_pte >> +static inline void vmemmap_update_pte(unsigned long addr, >> +                      pte_t *pte, pte_t entry) > > pte   -> ptep > entry -> pte > >> +{ >> +    set_pte_at(&init_mm, addr, pte, entry); >> +} >> +#endif > > .