From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F30A4C001DE for ; Tue, 25 Jul 2023 10:09:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 747A88D0001; Tue, 25 Jul 2023 06:09:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F7876B007B; Tue, 25 Jul 2023 06:09:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BE918D0001; Tue, 25 Jul 2023 06:09:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 48D766B0075 for ; Tue, 25 Jul 2023 06:09:14 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 00ABBC0D1D for ; Tue, 25 Jul 2023 10:09:13 +0000 (UTC) X-FDA: 81049711428.17.20DF1BB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id B43EB20010 for ; Tue, 25 Jul 2023 10:09:11 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NKzVAgxh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690279751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9SNXGmFxRnqmLKduKCutCSEqITPsC6EnMPmnNMtGpqA=; b=YLyjHpiDZxWpx5EIdX7h2qoF1XkyPd43OBzIfXbm8erngySDZE+Kg5JPsWi2wn1bXz1qFn n3v9CsCPAQNBB7+iEWR5IRxPMT5K5O6buSacqoBOGGZr7+RbdE4/WV4FAOH273fS2Hf2S5 D0Gttje38AMOChJluxRtOxT4nC7q4lI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NKzVAgxh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690279751; a=rsa-sha256; cv=none; b=gAOaRx93bHd5mj3oi7RmMW47kgU28QQpZkpdVeufFxcslkGC01E5bOPZQEhiQQofL6GsnJ qo5M0tIqH4oaXH/FGTUF2Z9YV1L89ee6KBFXYzSi6xGSGdfc8AWvowlbnT+C10QKzcy+/d wpEgd7sHnbHkF0hhz346hTOv6U2EYQ8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690279750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9SNXGmFxRnqmLKduKCutCSEqITPsC6EnMPmnNMtGpqA=; b=NKzVAgxhzpJblRjSe8hUNqUEnx8EtZvXQXUtmcuGURnY4GM7XbqpuA93ZJ6SHk4hEP8Qf6 sxZwMKw2gp8HDh5Em3AFKpRfUbubiu8kpdBisDqtaa7AhuLTZ95scImCjZhdAA4EOsCpxk pkNkodW98QQKrNTU6mQIjSTOkssa+CU= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-3uIIsZEROkCWEmBGcAkEaw-1; Tue, 25 Jul 2023 06:09:07 -0400 X-MC-Unique: 3uIIsZEROkCWEmBGcAkEaw-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2b701c82e83so41961691fa.1 for ; Tue, 25 Jul 2023 03:09:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690279746; x=1690884546; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9SNXGmFxRnqmLKduKCutCSEqITPsC6EnMPmnNMtGpqA=; b=GWws8txjcocVGSW3JW7yTy4n02vNwFY7KfdXQUqz36vMEG+JExPGu1J3SR5m57HNCd eXvSz6InurCDPav18S8TBUeZo3SpbSjgKFbCKivl8Qb7/3D0eSKMRpqoxiRWFNtPDE06 o1KiFINyfsD9Yk6g7JgG7mHbvQBTWV5nzBjVBNEPZno1n1M37EI3heZLnByzEshFnHQA RuARcbmI9neuxLoo24xx0qFz57msZ2jZK12yy5WT6pE/fLpVuEHd/hDxdPQPHtV3WefG GCWSbYtIT/n/Q5JB9ckV3i4zawUxdBwIBV7yzLPgAy56BIWSK02xGCV5lYLWep8+5B23 95JQ== X-Gm-Message-State: ABy/qLZ5tJ20Y1195UCFaMobo0ugj9R3MuuZZkxWrGHRINSqW3dWKfKB Ikzwv3jYmOKR8UIvG2yuGUeIiAailCw4LIBcS8qAdzZRBDSHnpEMvzAKEfucGGOGVmiaitIoEKp pqN2OjZ/sfEQ= X-Received: by 2002:a2e:9b18:0:b0:2b4:737c:e316 with SMTP id u24-20020a2e9b18000000b002b4737ce316mr8290982lji.14.1690279746114; Tue, 25 Jul 2023 03:09:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlFQODdJ2pJSJgBtgDO5NoCJ1Mp9aVOPiqr5L/+ITahpdOn6uSBK5VHpmuqnyfazcSnPfTGJgw== X-Received: by 2002:a2e:9b18:0:b0:2b4:737c:e316 with SMTP id u24-20020a2e9b18000000b002b4737ce316mr8290951lji.14.1690279745665; Tue, 25 Jul 2023 03:09:05 -0700 (PDT) Received: from ?IPV6:2003:cb:c73f:e900:3b0d:87a6:2953:20d1? (p200300cbc73fe9003b0d87a6295320d1.dip0.t-ipconnect.de. [2003:cb:c73f:e900:3b0d:87a6:2953:20d1]) by smtp.gmail.com with ESMTPSA id i7-20020a05600c290700b003fbd597bccesm15341720wmd.41.2023.07.25.03.09.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jul 2023 03:09:05 -0700 (PDT) Message-ID: <7a711faf-0e26-2a3c-eb9e-5b0084ff3810@redhat.com> Date: Tue, 25 Jul 2023 12:09:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 5/7] powerpc/book3s64/memhotplug: Enable memmap on memory for radix To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Michal Hocko , Vishal Verma References: <20230725100212.531277-1-aneesh.kumar@linux.ibm.com> <20230725100212.531277-6-aneesh.kumar@linux.ibm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230725100212.531277-6-aneesh.kumar@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B43EB20010 X-Stat-Signature: qujcn6w56zo6xytmourenu9cxfxkt1y8 X-Rspam-User: X-HE-Tag: 1690279751-958194 X-HE-Meta: U2FsdGVkX18EMCTPp3rD6hSVPzDfgo3fEZNhqtPoDxBJVzI99y1O4gwQhFQnqwN4tuCdQhzaW45NqRo4YGb7Ia4y6pTVl+GrR7toSUn4OyNJXkHWa8bZtMBTcSPH6cOjHITLBG7a/ab73GafM3ctvc8JMeOzABvHY2KX95wyWu8wo1GG/U0CgKv5fszEbAs2pleyFhqdj5KMjEf1AZH3I+vMVc/0EUtfPPTN7MQP+q31e0PsbojUS6eibidCLSmZoShrQZr3HAcWedyOJnOoyS27OSjvEzjaQKq0KJo7Hkar9BlCumkSkm0RNesrtpssj9DqADm0Qi+ScPIjmdu0fEoQoxDiB+Ncp6G0m/Hx6nJhH9QBpGrMTibaJu9GI7qwpCmRBk5sWon+TEdxYxxQtjqZaOXa4jpRjQom+oLMd4+PNbLJeLFYiGdS2n6FC4etYGf+qGknorSiH8WsE6ejEiIVB30z5TThxAbpolQ37r3yY3IJNcNAifdgWfarQjZnb10Ma9kvxNuPR6myuJdScnVArSeTHuRxxaM3FL7lU9Qcq0rYiV/qQlVQj163CDg04WfOombJjtqM1ZRN2Yn+s6NvcKTtBiaNdUzCqS7rB8F8LEow4pxCGly1YE2ffvqBAvyQanh/TD65kJWaOyzfLsisi2L3tvoVroC50ijtdZHRjW0EhP4HX4azctOONiB/kTYjvMIqj0IaQUjWrvFnHKKnpXPW0rmIDN/RWeklj+eSEhsfPv2bvUf0NAqNiV7MHVKWb0mI0nYLCw+Gs2NvxJL2m08B9139a6hXVyS2P12nFa237clBPKXgFtpI5B0ZTP2QgGKm6ETyB5RpemcKLUaq+/nihqMm9YTNcPqW32z4GQVWynF9b2D92X82InWiCenpQVt8mEUI0FvIxmkaSlf5Izl3VWV+qV9SwLQ07B2aeDYpeHJyJUpopctlfJ7JV4mdO1zRE8kneB9h3NU mqXiViRS QkD/gVpuRZ2NEJUcHpnxkBykHy2EUZBV4WCa+1NsptyxIt6WnvAA49KDbDqBTXp6iHyJEtCecs6VXy23sSZp+EEzib5zXwWoRO49fgnTRXsdFRVUDr98ZSqyucE78AvQI6qFZOjF0wkmLNjczV8OSdkRRkfvOSWNub6XRYukgfYjoi2zP5JqT6GEmRbPgSjCu3OPWkdQ1oAEFWKI9PAMgDRzIPx0d/ry5Wb3/yXpKUrQYWlD56CRs68CJJlJL1XEHZSpWxHL0m4pnsJfL0KD+JAjon69Os1M35THtfUXyV7n/PRsUl2llk2Cj1fPPaUwaEkTo5sh3mPkcOsojNZ1h/cpYAOBI8Gh3C6XfqLuHC3x0aObO2IhvQ4wfZVaX1LaagSy63V73JAIpdKagh3152hZ0kP35QYH+sD0R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > #endif /* CONFIG_PPC64 */ > > #endif /* __ASSEMBLY__ */ > diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/powerpc/platforms/pseries/hotplug-memory.c > index 9c62c2c3b3d0..1447509357a7 100644 > --- a/arch/powerpc/platforms/pseries/hotplug-memory.c > +++ b/arch/powerpc/platforms/pseries/hotplug-memory.c > @@ -617,6 +617,7 @@ static int dlpar_memory_remove_by_ic(u32 lmbs_to_remove, u32 drc_index) > > static int dlpar_add_lmb(struct drmem_lmb *lmb) > { > + mhp_t mhp_flags = MHP_NONE | MHP_MEMMAP_ON_MEMORY; MHP_NONE is a placeholder, so no need for that and ... > unsigned long block_sz; > int nid, rc; > > @@ -637,7 +638,7 @@ static int dlpar_add_lmb(struct drmem_lmb *lmb) > nid = first_online_node; > > /* Add the memory */ > - rc = __add_memory(nid, lmb->base_addr, block_sz, MHP_NONE); > + rc = __add_memory(nid, lmb->base_addr, block_sz, mhp_flags); ... this becomes rc = __add_memory(nid, lmb->base_addr, block_sz, MHP_MEMMAP_ON_MEMORY); With that Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb