From: David Hildenbrand <david@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linux-mm@kvack.org, akpm@linux-foundation.org,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
npiggin@gmail.com, christophe.leroy@csgroup.eu
Cc: Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@suse.com>,
Vishal Verma <vishal.l.verma@intel.com>
Subject: Re: [PATCH v5 5/7] powerpc/book3s64/memhotplug: Enable memmap on memory for radix
Date: Tue, 25 Jul 2023 12:09:04 +0200 [thread overview]
Message-ID: <7a711faf-0e26-2a3c-eb9e-5b0084ff3810@redhat.com> (raw)
In-Reply-To: <20230725100212.531277-6-aneesh.kumar@linux.ibm.com>
> #endif /* CONFIG_PPC64 */
>
> #endif /* __ASSEMBLY__ */
> diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/powerpc/platforms/pseries/hotplug-memory.c
> index 9c62c2c3b3d0..1447509357a7 100644
> --- a/arch/powerpc/platforms/pseries/hotplug-memory.c
> +++ b/arch/powerpc/platforms/pseries/hotplug-memory.c
> @@ -617,6 +617,7 @@ static int dlpar_memory_remove_by_ic(u32 lmbs_to_remove, u32 drc_index)
>
> static int dlpar_add_lmb(struct drmem_lmb *lmb)
> {
> + mhp_t mhp_flags = MHP_NONE | MHP_MEMMAP_ON_MEMORY;
MHP_NONE is a placeholder, so no need for that and ...
> unsigned long block_sz;
> int nid, rc;
>
> @@ -637,7 +638,7 @@ static int dlpar_add_lmb(struct drmem_lmb *lmb)
> nid = first_online_node;
>
> /* Add the memory */
> - rc = __add_memory(nid, lmb->base_addr, block_sz, MHP_NONE);
> + rc = __add_memory(nid, lmb->base_addr, block_sz, mhp_flags);
... this becomes
rc = __add_memory(nid, lmb->base_addr, block_sz, MHP_MEMMAP_ON_MEMORY);
With that
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-07-25 10:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 10:02 [PATCH v5 0/7] Add support for memmap on memory feature on ppc64 Aneesh Kumar K.V
2023-07-25 10:02 ` [PATCH v5 1/7] mm/hotplug: Simplify ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE kconfig Aneesh Kumar K.V
2023-07-25 10:02 ` [PATCH v5 2/7] mm/hotplug: Allow memmap on memory hotplug request to fallback Aneesh Kumar K.V
2023-07-25 10:02 ` [PATCH v5 3/7] mm/hotplug: Allow architecture to override memmap on memory support check Aneesh Kumar K.V
2023-07-25 10:02 ` [PATCH v5 4/7] mm/hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks Aneesh Kumar K.V
2023-07-25 18:06 ` David Hildenbrand
2023-07-26 4:25 ` Aneesh Kumar K.V
2023-07-26 9:04 ` David Hildenbrand
[not found] ` <9d1448d3-a43a-5305-68aa-d82111fe077a@linux.ibm.com>
2023-07-26 16:39 ` David Hildenbrand
2023-07-25 10:02 ` [PATCH v5 5/7] powerpc/book3s64/memhotplug: Enable memmap on memory for radix Aneesh Kumar K.V
2023-07-25 10:09 ` David Hildenbrand [this message]
2023-07-25 10:02 ` [PATCH v5 6/7] mm/hotplug: Embed vmem_altmap details in memory block Aneesh Kumar K.V
2023-07-26 9:41 ` David Hildenbrand
2023-07-26 10:31 ` Aneesh Kumar K.V
2023-07-26 16:43 ` David Hildenbrand
2023-07-25 10:02 ` [PATCH v5 7/7] mm/hotplug: Enable runtime update of memmap_on_memory parameter Aneesh Kumar K.V
2023-07-25 17:52 ` David Hildenbrand
2023-07-25 10:06 ` [PATCH v5 0/7] Add support for memmap on memory feature on ppc64 David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a711faf-0e26-2a3c-eb9e-5b0084ff3810@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox