From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5133FC433F5 for ; Sat, 19 Feb 2022 02:00:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 613DF6B0074; Fri, 18 Feb 2022 21:00:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59D126B0075; Fri, 18 Feb 2022 21:00:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43DEA6B0078; Fri, 18 Feb 2022 21:00:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 3223F6B0074 for ; Fri, 18 Feb 2022 21:00:17 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B98128249980 for ; Sat, 19 Feb 2022 02:00:16 +0000 (UTC) X-FDA: 79157874432.11.C584E1D Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf15.hostedemail.com (Postfix) with ESMTP id E1259A0006 for ; Sat, 19 Feb 2022 02:00:14 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4K0sD66bgpz9sjN; Sat, 19 Feb 2022 09:58:30 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sat, 19 Feb 2022 10:00:10 +0800 Subject: Re: [PATCH] kasan: update function name in comments To: Peter Collingbourne CC: Andrew Morton , , Andrey Konovalov , Marco Elver References: <20220219012433.890941-1-pcc@google.com> From: Miaohe Lin Message-ID: <7a6afd53-a5c8-1be3-83cc-832596702401@huawei.com> Date: Sat, 19 Feb 2022 10:00:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220219012433.890941-1-pcc@google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E1259A0006 X-Stat-Signature: p5ysx783yrsu6sc8w36stf7khyewjqf8 X-HE-Tag: 1645236014-116091 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/2/19 9:24, Peter Collingbourne wrote: > The function kasan_global_oob was renamed to kasan_global_oob_right, > but the comments referring to it were not updated. Do so. > > Link: https://linux-review.googlesource.com/id/I20faa90126937bbee77d9d44709556c3dd4b40be > Signed-off-by: Peter Collingbourne > Fixes: e5f4728767d2 ("kasan: test: add globals left-out-of-bounds test") This Fixes tag is unneeded. Except the above nit, this patch looks good to me. Thanks. Reviewed-by: Miaohe Lin > --- > lib/test_kasan.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index 26a5c9007653..a8dfda9b9630 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -780,7 +780,7 @@ static void ksize_uaf(struct kunit *test) > static void kasan_stack_oob(struct kunit *test) > { > char stack_array[10]; > - /* See comment in kasan_global_oob. */ > + /* See comment in kasan_global_oob_right. */ > char *volatile array = stack_array; > char *p = &array[ARRAY_SIZE(stack_array) + OOB_TAG_OFF]; > > @@ -793,7 +793,7 @@ static void kasan_alloca_oob_left(struct kunit *test) > { > volatile int i = 10; > char alloca_array[i]; > - /* See comment in kasan_global_oob. */ > + /* See comment in kasan_global_oob_right. */ > char *volatile array = alloca_array; > char *p = array - 1; > > @@ -808,7 +808,7 @@ static void kasan_alloca_oob_right(struct kunit *test) > { > volatile int i = 10; > char alloca_array[i]; > - /* See comment in kasan_global_oob. */ > + /* See comment in kasan_global_oob_right. */ > char *volatile array = alloca_array; > char *p = array + i; > >