From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FCBEC3DA64 for ; Sun, 28 Jul 2024 11:18:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5A396B0085; Sun, 28 Jul 2024 07:18:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0B716B0088; Sun, 28 Jul 2024 07:18:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F9536B0089; Sun, 28 Jul 2024 07:18:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7170F6B0085 for ; Sun, 28 Jul 2024 07:18:16 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2AC2E120241 for ; Sun, 28 Jul 2024 11:18:16 +0000 (UTC) X-FDA: 82388912592.29.E9C862C Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by imf30.hostedemail.com (Postfix) with ESMTP id DAFDF80005 for ; Sun, 28 Jul 2024 11:18:12 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=aculab.com; spf=pass (imf30.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722165490; a=rsa-sha256; cv=none; b=O8Jg9j2qHGhPY9lFHfe2PSudJUwFVsUWa/6K6Jud/fLIE1XIJAYFay8IuvhxOTzX1E0Kfx c7OSR1h0G2tFc0YxHLcIaKMdHK1BmWmNn0O9tl66ztSfhUyCTvW28mPZdiHYZtMYA6Tg35 LIO1RPgHH54qEzG460x1bLMQRXOIAAI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=aculab.com; spf=pass (imf30.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722165490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JahsBMuw2Y3G8azDmkPwf+CPC4x7+9JMtX0JKvXIyIM=; b=pVisbr9/693HBTnrAzaDp0srXhQcNlQQfzgy7A249vBdrevZzjmmAmWuzzKzPfCaL7jNnu GN1kC3SlYRSvDmHs6cNihAPKVKo97w57TZdnuVi+TChtMCEDWIx33EonGqtwUq0fukOhFJ 0Z6MiHw/CNgumfPAOB73ggvcNMHmGXA= Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-237-t68vUNQdNHix3gc58OU02A-1; Sun, 28 Jul 2024 12:18:03 +0100 X-MC-Unique: t68vUNQdNHix3gc58OU02A-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Sun, 28 Jul 2024 12:17:19 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Sun, 28 Jul 2024 12:17:19 +0100 From: David Laight To: 'Lorenzo Stoakes' CC: 'Linus Torvalds' , Jens Axboe , "linux-kernel@vger.kernel.org" , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" Subject: RE: [PATCH 0/7] minmax: reduce compilation time Thread-Topic: [PATCH 0/7] minmax: reduce compilation time Thread-Index: Adrd1UnD4d8H4E3lR3eDOQFKqPNnSwCBfkcCAAdYOfAAFX/+AAAkPNng Date: Sun, 28 Jul 2024 11:17:19 +0000 Message-ID: <7a5cf18b6141453988247cfa4d4dcd49@AcuMS.aculab.com> References: <23bdb6fc8d884ceebeb6e8b8653b8cfe@AcuMS.aculab.com> <902a9bf3-9404-44e8-9063-03da3168146a@lucifer.local> <137646a7-7017-490d-be78-5bd5627609c3@lucifer.local> <36aa2cad-1db1-4abf-8dd2-fb20484aabc3@lucifer.local> <40369e153bd447e5b597c31e7bc9a2b1@AcuMS.aculab.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: DAFDF80005 X-Rspamd-Server: rspam01 X-Stat-Signature: 9hmau6w6p7ip6agg7n4u7zk6mkh7guie X-HE-Tag: 1722165492-668598 X-HE-Meta: U2FsdGVkX1+ZcM3+MGo8xaUBrhSX2cEOjQorNcXmHQjWycjmG2/jTkDgNnn/yPssp+sn+o5IhcVi/z9kjVlOikopyqVN+3XjC2ll4qxLpEOFcsKmoedh7/dkG84tWFEnelkBSQsU/P0QEknTDfxWiaFYaJyby436XcXaDr0mzbt7unn7dxkjgBY3P2/UWGyiHlyllPtSGQcmS+ZBSs3ro/c3mHQ/DoXjOKmSB6rHUACNdQ3NmniyZD3gysA1G/YXBz8OtSUiHQsO/87YIzM+VKH5aBY/Hs9xY4ZbTlJzJFwTC1gnzUCkJOtgpDd8tru8VArDimmlNJ58z8xyaFafz0vnLsAxtIouOPYDEzI/ZT2SKJgXhah+px/HNcHoSUdn3sG2C3Yo5maxsoXJz8DK4A/ppNGu5bSRtNWzb0YTJ5VD9nlTfG5NxtM+AJVI0A3PDJVN2oc9NvXtIe2l5v4h7yNnsz5rhwaBib5QoIeHVpHHOI/DPNpWBvTYWbnwrD37eYHYDhOqrS70QUIqlLpuK5ctiOI3KPBiBx/7PbeyNOtiXNAAKkEA/t8BOy37NvvQ67xM4UDKxrM75wKJ/RcM6Gy3L3lKxKudc+E+LvRhedQMjRruJuY1JJKa4R+dNq4LXNmfJqJXQhKZx+zA1dHiZp44FF8RXjV8BaUcihQgGLo91SmcF/FmZ+3RWDh0zxCjIDwfJBKfcBEx9/57xliPkEFQbSaG5hv9xe1yXMgjoPknrMjFUx04s14ZyFLj2wH3A/GKrFsDaDR4SLHUb20udRYNmhFy/QgVkhTKoNuyHekHZCtXfu7W62EuHmo/tNcoCkm8kTuZa16z3bjSSEYwmT0acp54w2ugnS6YQf/lLAjzfHwB8Zjo1z5XGVdC6efgBAFuM5IoIgJjtgG9rjSAWdPvL7s9ix1moYlnhJgAmiM7/tHXGuCGNFWkvqeRSPQSK1KEZxqUxQnfvs4Dt3e tCKr1fK5 o0ElCqB7wttlo8IQArH4qNJNLKVH6WB8wMjC7ZaUH2JynI1tEVxaxb2QjOMrezDVrhDqwh2JlV51TIdjelTAyeZJuER2j7eesXtkO+G76cCVF9ghEPVvdhYrrVjnQUV1RQMj2ue63baFgAWpu8pV/9RvkxbgFbTXWY9I+KBtFYzthR/D5c4WgSeA1S6f+nHxvYrovOoFw0Sa+zeL6/GmxScMBFH+mrGXrhIICPS99196Reb+v7NGzsNG3h24euiC0lFXD/w8HVOPKSHW0GCNhwL2nXc1OjtBWlO4zNLuACefZNUvnsEz6D/ePcrFEr1CJRx2XoLSoktKfNv+9dvLBTB2ouMkRFD46bIJGK+qkjeHBATIoRTyzVXC+EJfpXByibeH+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Lorenzo Stoakes > Sent: 27 July 2024 19:59 >=20 > On Sat, Jul 27, 2024 at 08:08:39AM GMT, David Laight wrote: > > ... > > > and it will spit out > > > > > > Longest line is drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:113= 6 (2346kB) > > > ' ((((((pkt_size) + __builtin_choose_expr((sizeof(int) =3D=3D > > > sizeof(*(8 ? ((void *)((long)((__builtin_...' > > > > > > to tell me that we have that insane 2.2 *megabyte* line due to the > > > MVPP2_SKB_HEADROOM thing, and I should apply this patch: > > > > > > -#define MVPP2_SKB_HEADROOM min(max(XDP_PACKET_HEADROOM, NET_SKB_= PAD), 224) > > > +#define MVPP2_SKB_HEADROOM > > > MIN_T(int,MAX_T(int,XDP_PACKET_HEADROOM, NET_SKB_PAD), 224) > > > > > > to fix it. >=20 > Yeah sorry just saw you had already addresed this Linus... I just went wi= th a > clamp()_t in my patch. >=20 > > > > Or (if I've got is right): > > #define MVPP2_SKB_HEADROOM clamp(XDP_PACKET_HEADROOM, NET_SKB_PAD, 224) > > >=20 > I'm pretty sure you can clamp_t(int, ...) here safely based on usage. Why doesn't a plain clamp() work? The xxx_t() variants really shouldn't be used very often. =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)