From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD726C25B74 for ; Mon, 13 May 2024 15:37:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7CFE8D0006; Mon, 13 May 2024 11:37:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A05E78D0001; Mon, 13 May 2024 11:37:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 880948D0006; Mon, 13 May 2024 11:37:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 68B208D0001 for ; Mon, 13 May 2024 11:37:55 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D80BB1A0290 for ; Mon, 13 May 2024 15:37:54 +0000 (UTC) X-FDA: 82113778068.01.7DFEA07 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 880024001B for ; Mon, 13 May 2024 15:37:52 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dsOrTJhG; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715614672; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wJzejjZ7wyC0pvU1EsabLwRXWb+hBDMA4WAJxO+ZbbU=; b=Ocu4qvFTY3Pag6Y2mYBTpnhjuQmRVJHlPqTbY15xh2e+wVsk3LW3/1RxqliooX7srxW1+w NJY1ep4OA2Ytxz3S/kXBb1WTW5uHyzIz5ZRgwrWlSLZRCGJ6VnG9K/QwcTALnPqjDm6DMZ EQ0O69y+3JlrDpi8ijU0omBotn/1Jd0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dsOrTJhG; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715614672; a=rsa-sha256; cv=none; b=4yJ3ZWqkA7qtHONI0x6VGSWyyCbluPR5mUTDbVNbU4feZOoUFTeZ5rZ8hcnZD/1FC0Pgi5 jzygJoU0iPzTln6mk8+sq7AHgyYm6izOsQGiHw+Kv4BopNbo1dcueh62de0ug1id4kLWhI 2Tz+kMGcuDUV/ETtfveRkhhptEQxK8k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715614671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wJzejjZ7wyC0pvU1EsabLwRXWb+hBDMA4WAJxO+ZbbU=; b=dsOrTJhGH2uHGMEQnrrVJ0fKXbrBfC+dqaaf4t/vtVE3JBLbETg/9fb6Y373pE+X8//d9X okKG+l/lomel7YzL0mxzLUQ4EfqXw6H47FX+E3aUkQqDSN7nCGSGdT+eIN9QP8XmnSQyXq gjUHY2madMeTPfRWo06klOU0lchS4+E= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-kEXFC5JiM-K2wZ1Yyf-iWw-1; Mon, 13 May 2024 11:37:50 -0400 X-MC-Unique: kEXFC5JiM-K2wZ1Yyf-iWw-1 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-1ec4c65a091so36294365ad.3 for ; Mon, 13 May 2024 08:37:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715614669; x=1716219469; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wJzejjZ7wyC0pvU1EsabLwRXWb+hBDMA4WAJxO+ZbbU=; b=IoKG8V5jNHYGtn7EJ/FQTpzb7GkDe2NNS8gmpJ8PP2WHIbYn1IQXnQzTGHQXn1XQQb uOv/JBDdRzwmz+p6uEpMF6+ii5guPe1QaWQO4+/P3d9mkG1QmWFlU6ucvE5h4v4sQwlQ sTeCn/aFkHf/t0UA0vZfbxKrfhACR5NOd5xgvo6/o46xQAsamUZ0yZz08t6PS4QSU7RC 3Urdbd3SdUcO21h5Bato9en3aRddm9DP+EvYMyGRfNucQJPeZEY3P65AJaT6YWCc0AWO GIC72x7zPNPHUrNwW6P/rnT5+gvA1XrDPWt0h0oV/4N8bdWVl4HhcxDhLzaHoctBMydl zk4g== X-Gm-Message-State: AOJu0YxQzovPq+NSq9Qxo/FPO2PLp1ZFjcOvGar/W8NVEzPDTxu2cEQE dXTX1ug3Qzp5BfGkLj6Cpw+kLdcdn1bGsLaRSKcl0qGXiC0MnuHIwO8tXKxW5E2lJRZq+duNSnu DWs+rWk29AAPB26MypJOpwfixoYm0mReiNldDFlt4PKq/k0t1jnPnL+Rg X-Received: by 2002:a17:902:f693:b0:1e5:2883:6ff6 with SMTP id d9443c01a7336-1ef43c0c9e8mr122433835ad.11.1715614669016; Mon, 13 May 2024 08:37:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEIagRKbnk2PsYN6IJltSoikH3OKsV/glVRLpzmc1Uk0bbHIzQ2eLNRb+ZccYA4eZJoORARMg== X-Received: by 2002:a17:902:f693:b0:1e5:2883:6ff6 with SMTP id d9443c01a7336-1ef43c0c9e8mr122433565ad.11.1715614668469; Mon, 13 May 2024 08:37:48 -0700 (PDT) Received: from [172.21.1.2] ([50.204.89.31]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0c256587sm80346885ad.296.2024.05.13.08.37.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 May 2024 08:37:48 -0700 (PDT) Message-ID: <7a4d4992-4c8a-43b9-8c41-a938bc3cec67@redhat.com> Date: Mon, 13 May 2024 17:37:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/rmap: optimize folio_move_anon_rmap() To: Chen Taotao , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240512123555.8358-1-chentt10@chinatelecom.cn> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240512123555.8358-1-chentt10@chinatelecom.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 880024001B X-Stat-Signature: 5wzehx8zcmg753dkg54o1rjiccj6pime X-HE-Tag: 1715614672-952754 X-HE-Meta: U2FsdGVkX1+BxjPTIELlFGGOk1GsbVW9sNPSuJ4UpRX4FUbJygx+/xVPOEgzAxEPHNg2pbnMLSQuZEQKOkjB0e9POBl9pJsbylGXlydEFsktZ2q6O6gkPQVCT+hQRn/eUEPnpFjcQqUgP9RMXFlAqrEFobrJr2kfbS2copDC4X0lhfR4tJXW5MHSgut6yaiVroOMaoaBiJdpXgs6vD2P7EK7ZSOXNKZd7AIrEmdz7+s8NAkDv72ATdalt5paKnK9vh+la/EfUPHiDcQNaM6ibFYxDedcasA8xgdlfHaS2rj1k3gAXYl0AwlOlkhAx1cU2RtSZCQ1E8ftfHaAuUkMgQ7iEAmae7fNXRp84rL08Ktw5dFbXhCzUbsLfOn2K38DGh3t83I6rI0068CRjZigAF5zz5FQa7xy8fTvgoxjwuqEoq2az/If9DIvyY+vzCqYadEpaWWvoTdU6/ncbNIJO02thbjV9Pz6cuXUQe7aNZqnwXhw5ggwBF5PWdT4ByBLaf862Ie31zPH0pWVDkPB3wwQTzqTH0C1BRRfNeocAiSvEBdC/qvE+jjcpZTTsk//1f8iL69lTEg40q2l7DCJJeOE/TwWPIqz2ci/N1ExdYcDpN24WKGEvZlhoSzWzwPeQGioz9W4IAKjDLvXXOQ0yCmSAt3xYwlIxqofNod/4lMGHs/ORw6wt4KC7d5CZCuv19mUeVX26GxKZpMenrbULdVWd6WFP+LYpg3GMbS1lYlq57Qp/3C1rhX1wGkoIYikDyKJNJ8UR/gckJ/JYGahh3a6lRWBsB3wj8TdcY7jjBaSQeTUNSdNiXt/hutdycBwjkRbSQUx5DCU+WVaMYhlr6YNDFk+xKvd93XiLHVj/v8vDh9oVVkB6B+Ysw6pfrPWdI04D4omrafph2ewuhn6JapB40vbMW1Bos25nwoLufseLQHaK9oMEy8xpq3iy34zW/eOiyKXYIRXjG74BgM yncpxLBb zjauwrEUbSB3Yk6KoxxVYB54oxCSQbtv0QWZ2R0+CQUqijKR3NHBFGT6dUBn2lp3S0FX5eF2sVsW6yYEI9wEBmK610JZWwDBbwyeBU84kNlN+sFNNdcF+bjHj1lSzybJTbJ4SZBxPXRjHfu5APYL5MQEe984eDT59eP0qbUgbQ8FFExEXh1mljldaSgcFiIeyBPZ0PiMF79YM/JG1uxCyKgBBty5RGJrNTLm3dovVSIP2Ge6IT5UeWK55YrYjB4noakIYZC9yl0F6+/aiqy9hNrjVwTNq1lSWA0qq5EG1Uu6MxmFSOUM/cQOJVelEKfsiOfCilYQllYARVq7ZJxF/pJ1h/l9ZlRLoPDCv/lpGDfqMdsfpmu/iRNHtFOSacndsbpfjlnQVpw7mmkky1FF+nWKAUnNS/74xt/fibe2IGk6eR14euiiXlMY9VMc3bFXPdwxdr1zU9mqOa0USt+km0nI20GWLaedpHPEis6zFA6HEGR7AIvQvDy9Yc8vJfUXOzENUFodvRbtnLJb+S7rVV8oVzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.05.24 14:35, Chen Taotao wrote: > When a folio belongs exclusively to one process after a COW event, > folio_move_anon_rmap() always moves the folio into the anon_vma > belongs only to this process. > > However, if the folio already belongs to the anon_vma of the this > process, we don't need to move it again. In this case, we first > check if the folio already belongs to the anna_vma of the this > process, and only move it if it does not. > > The above changes may improve the performance of vm faults in some > scenarios, because the performance loss caused by WRITE_ONCE() is > much more than the performance loss caused by add a judgment. Please proof that by real numbers. I don't think it will make a real difference, and we likely don't want that change. -- Cheers, David / dhildenb