linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Brodsky <kevin.brodsky@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ryan Roberts <ryan.roberts@arm.com>,
	linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/mm: export symbols for lazy_mmu_mode KUnit tests
Date: Wed, 17 Dec 2025 18:37:46 +0100	[thread overview]
Message-ID: <7a26c273-ebe1-4b5a-8d6d-1b81cfa80656@arm.com> (raw)
In-Reply-To: <20251217093036.3231f9613ac8f9cf3943357f@linux-foundation.org>

On 17/12/2025 18:30, Andrew Morton wrote:
> On Wed, 17 Dec 2025 22:15:16 +0530 Ritesh Harjani (IBM) <ritesh.list@gmail.com> wrote:
>
>> ../arch/powerpc/mm/book3s64/hash_tlb.c:158:1: error: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_IF_KUNIT’ [-Werror=implicit-int]
>> ../arch/powerpc/mm/book3s64/hash_tlb.c:158:1: error: parameter names (without types) in function declaration [-Werror]
>>   AR      init/built-in.a
>> cc1: all warnings being treated as errors
>> make[6]: *** [../scripts/Makefile.build:287: arch/powerpc/mm/book3s64/hash_tlb.o] Error 1
>> make[5]: *** [../scripts/Makefile.build:556: arch/powerpc/mm/book3s64] Error 2
>>
>>
>> IMO, we will need the following header in hash_tlb.c
>>
>> +#include <kunit/visibility.h>

Ha strange it built fine for me without it... Maybe different config
options.

> Yeah, I already added Ritesh's patch which had this include, so I
> think we're all good now.

Great thanks both!

- Kevin


  reply	other threads:[~2025-12-17 17:37 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15 15:03 [PATCH v6 00/14] Nesting support for lazy MMU mode Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 01/14] powerpc/64s: Do not re-activate batched TLB flush Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 02/14] x86/xen: simplify flush_lazy_mmu() Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 03/14] powerpc/mm: implement arch_flush_lazy_mmu_mode() Kevin Brodsky
2025-12-16  5:14   ` Ritesh Harjani
2025-12-15 15:03 ` [PATCH v6 04/14] sparc/mm: " Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 05/14] mm: clarify lazy_mmu sleeping constraints Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 06/14] mm: introduce CONFIG_ARCH_HAS_LAZY_MMU_MODE Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 07/14] mm: introduce generic lazy_mmu helpers Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 08/14] mm: bail out of lazy_mmu_mode_* in interrupt context Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 09/14] mm: enable lazy_mmu sections to nest Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 10/14] arm64: mm: replace TIF_LAZY_MMU with is_lazy_mmu_mode_active() Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 11/14] powerpc/mm: replace batch->active " Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 12/14] sparc/mm: " Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 13/14] x86/xen: use lazy_mmu_state when context-switching Kevin Brodsky
2025-12-15 15:03 ` [PATCH v6 14/14] mm: Add basic tests for lazy_mmu Kevin Brodsky
2025-12-17  4:14   ` Andrew Morton
2025-12-17  9:26     ` Kevin Brodsky
2025-12-17 10:01       ` Ryan Roberts
2025-12-17 15:37         ` Kevin Brodsky
2025-12-17 15:46         ` Ritesh Harjani
2025-12-17 16:10           ` Kevin Brodsky
2025-12-17 16:38     ` [PATCH] powerpc/mm: export symbols for lazy_mmu_mode KUnit tests Kevin Brodsky
2025-12-17 16:45       ` Ritesh Harjani
2025-12-17 17:30         ` Andrew Morton
2025-12-17 17:37           ` Kevin Brodsky [this message]
2025-12-21 23:42       ` kernel test robot
2025-12-17 16:38     ` [PATCH] mm: Add basic tests for lazy_mmu - fix for powerpc Kevin Brodsky
2025-12-18 10:05     ` [PATCH] sparc/mm: export symbols for lazy_mmu_mode KUnit tests Kevin Brodsky
2025-12-15 16:52 ` [PATCH v6 00/14] Nesting support for lazy MMU mode Yeoreum Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a26c273-ebe1-4b5a-8d6d-1b81cfa80656@arm.com \
    --to=kevin.brodsky@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ritesh.list@gmail.com \
    --cc=ryan.roberts@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox