From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83EBAC83038 for ; Tue, 1 Jul 2025 08:27:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 175586B00A6; Tue, 1 Jul 2025 04:27:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 126686B00A7; Tue, 1 Jul 2025 04:27:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F089B6B00AC; Tue, 1 Jul 2025 04:27:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DA40D6B00A6 for ; Tue, 1 Jul 2025 04:27:33 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AC3B01A032E for ; Tue, 1 Jul 2025 08:27:33 +0000 (UTC) X-FDA: 83615016786.10.94EF352 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 3F0EBC0004 for ; Tue, 1 Jul 2025 08:27:31 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e+krFGMG; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751358451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PblRiGjccU8Bn/mbQjlfjXdXmpQtgP9DOCLVx78Z5kk=; b=i0+eQvMdu5tvu1gen4EjJL6TeTil1hG+jQBet1AE5dLX1qgrtBUSv4EDCJLvA9wELzxMdJ YNPiwjSW6oqKT+WwN9c4kwn2vY57zYGpMrhkLzJbCuEAq8y+8sSgAYqiE5OZPDuBF/1gGE R1dlboM8QUfBYgZUww0k/VlaSMO5WPE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e+krFGMG; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751358451; a=rsa-sha256; cv=none; b=KLVwTSJcB18UvD2mLjWAMMyxr1oaSoSTwnCC2wuVbIsH+wIpRRVUepW8FEqzf+f2vNvZsY LGx6Qu5sjyuyRF4iZY5HKmn/v/nhXECO+8nEMxXynHY+Hdbpxiatq3NkRu3GnTjd5BA/y0 KQwk7NZIXMQXNT5jin6+Ks+GRCNvP+U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751358450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PblRiGjccU8Bn/mbQjlfjXdXmpQtgP9DOCLVx78Z5kk=; b=e+krFGMG7fmvox4a/P26DyUJIPlpcLf05E6BBS+NKMAnrOk02Ugp8d25nH/cH3qB94bWCn MIVM0MAuMGJ376pgcHctVB1Ii4iwUY4u10FAuZG6adZeTrg//exiudy6btH2QBnNb6mUIC ost63AJhWop86jRGPSlDn61OgjkeXaA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-dNYmPsxIP9qQc8PJYId38w-1; Tue, 01 Jul 2025 04:27:29 -0400 X-MC-Unique: dNYmPsxIP9qQc8PJYId38w-1 X-Mimecast-MFC-AGG-ID: dNYmPsxIP9qQc8PJYId38w_1751358448 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a54a8a0122so2642983f8f.2 for ; Tue, 01 Jul 2025 01:27:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751358448; x=1751963248; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PblRiGjccU8Bn/mbQjlfjXdXmpQtgP9DOCLVx78Z5kk=; b=V2wdSDf8+32UzyP8f8dIrGUFJ30Pf0q59Gb10zpX/x7rtEuWVNqUZxrsrg1jonohQY xFGh8r3VYLCrv9SR4LXx23PFtohdUCf02ACRdcWCLoCWIYXcVgdJdWiImRtcW5dopYqq d0LvN5D3P/LBIxxvB0FI9o+ScofiDmdUsNH1e83YAyhfOk+irFT1T/91R27VnJ4sDuyz gHIA2RyPBYPtmp7HP5WeLUFE3utmr+6ZRs6q+Yb6g+ELdmJr4ZHPAKuUpu0wQhK4ai+F oUaq7VoZ6CuTmiIZ0bdebJnXmXFQ6z0+oAxFd3P1bKhKmySZAjDPtih892YgAa7squTt VXNg== X-Forwarded-Encrypted: i=1; AJvYcCWP1w+EsvdPXovv/a92rlLyh5YIxprpa/F2FHXmeHQO4dEeDahWAjWsczTNTaJzCA3OJl81Z4EcEg==@kvack.org X-Gm-Message-State: AOJu0YxlKKagZ1lp5C4dzdvAs6fh/3Ee8ByJ+iYXqVAOR0yd7WZ28X/B ozMB9uYWSYJuIHxiXbIo/4rKnYAXZ8aAP8jD+PeiW34zKensjVdhm14xUFUn+8e2mrGpqsWXmdh B2nAePzcqL8ohBVMWIsrRatzc15L21tW2MyzXOXQTsTBot/DD7pwm X-Gm-Gg: ASbGncuWcwO/12pqUAQtQgRKOMNMuTGGpbb06Qsycx8jedmPk/q2lKASJhVhji6wGCn wDxJqovj7OtAN/PpHcmw7wmwwPRG+jbv9DAQeBj6ZZITx+XzC7oLUYnAuA4XGx916CoK1uG/JLP E/D4PkOu8P7/okZ56kPczXjK8QwvsAXxCyGdkBJkn1zOV1O/5IWMA+9jIFA/eON5I85vc4FSShh IZ9hfbdie0PbM28h3oMJTnh74QCfCsh+l3yaPjy988wXm+OcTriNeFoeAPlscjTRRwFz+WVhi7F KbmoGsVddQNGE1OK0G2iWuLgm0MeOFr/sfTXvd3cDH0/wHFO2m3xE6Ku1uaSU8ZcfACh5iVoFh2 gkPmypPaDu2iz70fnyRmLJDKSTdHuvsHTZaOT+n8gvZDOY4Vm4w== X-Received: by 2002:adf:ea49:0:b0:3a5:2cb5:6429 with SMTP id ffacd0b85a97d-3a9001a2429mr10713698f8f.43.1751358448209; Tue, 01 Jul 2025 01:27:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiLSGjG1SoIniYOMAMRtKjuH1JQxFUi7zwrUP3ZsrTTfWnOXH6/VrqPd9s71VjBfuaf4xFvw== X-Received: by 2002:adf:ea49:0:b0:3a5:2cb5:6429 with SMTP id ffacd0b85a97d-3a9001a2429mr10713626f8f.43.1751358447701; Tue, 01 Jul 2025 01:27:27 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e52a35sm12732775f8f.57.2025.07.01.01.27.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 01:27:27 -0700 (PDT) Message-ID: <7a194ee3-f5c3-416e-8de2-d2beb32479a8@redhat.com> Date: Tue, 1 Jul 2025 10:27:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 06/29] mm/zsmalloc: make PageZsmalloc() sticky until the page is freed To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-7-david@redhat.com> <74894b3e-9a64-4600-aa3a-e212d2f63e1b@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <74894b3e-9a64-4600-aa3a-e212d2f63e1b@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BCRMeUJZtJ1FrZmjx0XGmGfxKd8r1z4aGKSN389JOOw_1751358448 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 57s3c349guad6id7e4htyzqaqaae34t4 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3F0EBC0004 X-Rspam-User: X-HE-Tag: 1751358451-424950 X-HE-Meta: U2FsdGVkX194z9BPQLebStPr9QRx4qdtyIwu4uAe8h5BUzeYIMPP/gdu7b0PW9Yajr1fnOKQHJ26PGdHRwNDfgZKlPGS+iToYdBw4j9aj/z9yLFglgXae8ai8CevgadIF+Z33I6kdOyfcTYgEFjFOT6Pc69smou2q6Nt5C1nftZzAvOSFSOhZtLKNcie8M2ojrRMvP0oywdUYL6CRBr1KEkwhttscNxqlm476KCSxjDU+oF2Yv7HX1ST4IsNjix3R51Fze3dCzdYjndZSEZPJQUACymcmVv6nsNRvCRz6UJheYSESPj2ZvqTxXPoFdjYLJnXbi2GSBriwLrh/eMvukf7pqMutnGUEhTgkfFmS90Di+cdlF/fSvwHJFyCmuTd+a9abUztGMUpGp7v6ltDAGUXur/PZwzApXdC/uyZexFuREF7SsKDovTVCKwY20lSdGkYsvgbxM5OCyJr1MX98VZY6OmvcOkmV2R8fn4CEt/vC3SjUbQl57l0QIp7nFU2Q2hdjSGzaHSW131Uof+YxehmVmhzhCSRzTEYmT5GpZvP/bPEkYl2MXMF/lW5R/KU/4NsIYYd6VjimJ40XirohKPBgg790KvhlDS66bYltHzRYYEykt0JB6gK+EEOSTg8+ev0LdBoCnlcmJGcPXIGnXlFZu5ho3GSdBEyKm0AgUoFHn0xsLu+VFm221S8WuMQTo5MxQxhVfIKLkwZ5DtLa6tjE6TlQdOLlLaBtbbKwXPRt+e+UmfPzKOkP4ilxxLfKEEd8ewc/WzR6InlPxGKANPf4cZn8DvHVWfdNANZckZgs1zSg1hddp/O+RF/Z9vsNultJZlAspNYdT70fg7jnZhSGa/qaWil/+Pct3oZMJFsDOEG2//Y7/HQtkE1YIWBZmW1rVlTJuVtzODVPrPkckZ3NPCPemQWKlnLR8L4fxrs9GE+SNNOljomVcRVP0aVUfT79+SK4VH4lJAm5c0 lgVoxmqL AlFQuO+4FNMdz+DFzfOMee89krle3VhDyPFB1TmMkpr54udfUNge+m2OWNqoJkyL269ghwAoke90Ygr8fnIBaY3K7+0ooAtiHw5FjhpRCoNFp3LNEHgSAR3QYRjpRcuVCkjdY9x9aHe2w609jPhiVCBzi2243J9r6LCT3y44ps39gPubS83iWOABtLwiAEelSP5ud2CdIOTxO8q58ig6YRYQ8401jCAZfD9F3L28fX0UPPJXE0G0tZZo/QMsCRHiQepD2tQSkh2/NkSMCebvcdj+4MCp0Ksy3rvfj4hejz8hGxv0fmt1q140V5UOvGTqdUFg9noTyBplTL599Aaxd05DrPbGNToofnqm3oPc++90ajzotC57/ezZB9TdE+gEKaWXimdLFTilp+0CzwFeWlun+3ZWT4zxJAQzz8fWZsJhfJlOwfs6zNUsGyC6LxIv2jrd0ocNmS7l8uEzMtqBI+Rc4NHbQd+gCnfJySsdEU7dTVUiG5Y9gGzWIrheVsKblsu04+YcN1q1BaNWmgA5fY0zFFC5FXFCRSKIpSoCkckeIgqmf3rUoMJgrW5rVgvt6OqUBx4I6oJXTaUkgUMBfqXilNkcaj/giD8DcpUUi3TiTe4W4oK/9IlvjdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.06.25 18:03, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 02:59:47PM +0200, David Hildenbrand wrote: >> Let the page freeing code handle clearing the page type. >> >> Acked-by: Zi Yan >> Reviewed-by: Sergey Senozhatsky >> Acked-by: Harry Yoo >> Signed-off-by: David Hildenbrand > > On basis of sanity of UINT_MAX thing: > > Reviewed-by: Lorenzo Stoakes > >> --- >> mm/zpdesc.h | 5 ----- >> mm/zsmalloc.c | 3 +-- >> 2 files changed, 1 insertion(+), 7 deletions(-) >> >> diff --git a/mm/zpdesc.h b/mm/zpdesc.h >> index 5cb7e3de43952..5763f36039736 100644 >> --- a/mm/zpdesc.h >> +++ b/mm/zpdesc.h >> @@ -163,11 +163,6 @@ static inline void __zpdesc_set_zsmalloc(struct zpdesc *zpdesc) >> __SetPageZsmalloc(zpdesc_page(zpdesc)); >> } >> >> -static inline void __zpdesc_clear_zsmalloc(struct zpdesc *zpdesc) >> -{ >> - __ClearPageZsmalloc(zpdesc_page(zpdesc)); >> -} >> - >> static inline struct zone *zpdesc_zone(struct zpdesc *zpdesc) >> { >> return page_zone(zpdesc_page(zpdesc)); >> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c >> index 7f1431f2be98f..f98747aed4330 100644 >> --- a/mm/zsmalloc.c >> +++ b/mm/zsmalloc.c >> @@ -880,7 +880,7 @@ static void reset_zpdesc(struct zpdesc *zpdesc) >> ClearPagePrivate(page); >> zpdesc->zspage = NULL; >> zpdesc->next = NULL; >> - __ClearPageZsmalloc(page); >> + /* PageZsmalloc is sticky until the page is freed to the buddy. */ >> } >> >> static int trylock_zspage(struct zspage *zspage) >> @@ -1055,7 +1055,6 @@ static struct zspage *alloc_zspage(struct zs_pool *pool, >> if (!zpdesc) { >> while (--i >= 0) { >> zpdesc_dec_zone_page_state(zpdescs[i]); > > Maybe for consistency put a > > /* PageZsmalloc is sticky until the page is freed to the buddy. */ > I'll add that inside free_zpdesc(), before the __free_page(). Thanks! -- Cheers, David / dhildenb