From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D3C9C02181 for ; Fri, 24 Jan 2025 11:16:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D4276B00A5; Fri, 24 Jan 2025 06:16:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 883D56B00A8; Fri, 24 Jan 2025 06:16:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FDBE280047; Fri, 24 Jan 2025 06:16:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 509266B00A5 for ; Fri, 24 Jan 2025 06:16:12 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BA9C7B14C4 for ; Fri, 24 Jan 2025 11:16:04 +0000 (UTC) X-FDA: 83042091048.25.E89820C Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf18.hostedemail.com (Postfix) with ESMTP id 496831C0015 for ; Fri, 24 Jan 2025 11:16:01 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=N4+h45rW; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=mQGBm671; spf=pass (imf18.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737717361; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Je5TIs0V0MSnTf3i5ZOiaB84F4D5tB+TzWgiTcxVEbA=; b=RDOy6LBsNm5JrGmMfXCKWjuUcJqm0t9UoEGrUmJVL1NM4/t+ZnyJ3ui8lmmqPaDJJq2f1y faq3XK1eInE7IP8CBW0Im5Eu7/LcyEncFy5N8PKD9Pm9fGVMUGd+TnRo++7bGZ4E+fzAPx 1KeRivFJNAlxGi5RwxECFWdS7u/IUPM= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=N4+h45rW; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=mQGBm671; spf=pass (imf18.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1737717361; a=rsa-sha256; cv=pass; b=MmurBnc01BX0Z9OvSLoU7yx85y7SAxO0L5BDcABVrONXzBHSkuzX445h2SsFrcwFkDv/9x ovS+1MqDozdEkO5cMWghNvg9NegDISh+SERV1TMa/l1GxUTh38rZY9Ni/MCL5lIHeNemIz CRJTwC/iBfnt4HO7n4F9CQkv6qhuov0= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50O8gImw001521; Fri, 24 Jan 2025 11:15:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=Je5TIs0V0MSnTf3i5Z OiaB84F4D5tB+TzWgiTcxVEbA=; b=N4+h45rWP7q7Z1sQ5kpUQBdrXsM1XmltRF CifEZqtYQAopqrSe+EkfJvvD5B+ZRvQJj/N9S9b491Yks5DB2tRQHX1oa+JxPDSP PTJZyo0lusU9ds38uztmWW96BV7ldudrkeD06lDEuYBCB+lc6YoMKA4qi/7VQ2VZ QzwEMLQnNy2EZOSBbRcGy7Xkpl3MHbgmaHf7pgNdxnNNOH/xCh2i700BtO/EG30j WUnTgbxxgVTxOADpK8cJDBkml8EV580gdHYsSssLqLnv0x5vs9QcTRDdCmEh5GiA /zLEZS35RbjSPIC+0g9ruNFR3uesoo45NKBM98Wu6hqf94Topnew== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44b06j4a35-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jan 2025 11:15:45 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50O9G8hh036648; Fri, 24 Jan 2025 11:15:44 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 44917tc5nj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jan 2025 11:15:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KHIyxi3MpaxIAz7pY65xTSoBiY6nQj/se0CEAsALgadPkMEoz1HpdY+KSfWt1NRaAdq7DSSjxdSte39EJ4BOPILPfqrI/+BQ+ig4gYUfHaHYY5tMrU81exSwcqaBRLqjcwjFyz4agsXXgbc2W86oNNXDJ2bzf4ol+LJ/Z5xUlwa7IPjdkaFTYQkMdO0yZB9yLWRvknqbTSA8pVfGRVfRLZWMDEMyT8zs7jAFH1N79EbIL7KmE1jQVYn5hySwevP6q38UFIoKgQO83TEe+ka3vpV0fwCdU1/DedxJtxdRUK5Je+tk/uob5WfHpxwtUXwpcIUVv6k+ST/8Aphieu+glQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Je5TIs0V0MSnTf3i5ZOiaB84F4D5tB+TzWgiTcxVEbA=; b=Zc9vvpBolMoJ2TOqbcmZP8Q5cEaEmuxFaYKxUeU0lZW12ywnT2zr/oAW/ZQ04QgneAzWh0th0H/2cSBL8gpMrElwxHpTMmpOZsMpVFxyXIuR6Odvf2wu8EZvrErzMO5njneW9yDvn4uIKxT01Elfd/4K+b1EiUCmBWgONxQ0s/V1QFUDo3QUum22wR9IJ+k9TxBLXO3HJ38ugluWrEkIMsWfO9uwwDVUhI+Me3KjU6D9KhGotJ4cvO61MlNcc9BTg5VliFtkX6H+/nKegx4PIb3kWZsniT+u6udRlzOGmDxa5Pjih4SPQeS90grJeS4lP2l1DtZmyWFqP4uUEFi3nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Je5TIs0V0MSnTf3i5ZOiaB84F4D5tB+TzWgiTcxVEbA=; b=mQGBm671Fxot25vwLGYpwL0MEmjdsLqSkusLdyghWL0MXaeKm13pqJAiggTDb7f9zBS56mwHuyQFEP+vpLhHRw7ogPDShtyrW/j3bkqAI+m0MZL4o6PckgjDDkYjYuawZ89a9hzfuhFvokCG/Gf5O/ZE5J13Qxt8XuI7FYb3sRo= Received: from MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) by PH0PR10MB5683.namprd10.prod.outlook.com (2603:10b6:510:148::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.16; Fri, 24 Jan 2025 11:15:42 +0000 Received: from MN2PR10MB3374.namprd10.prod.outlook.com ([fe80::eab5:3c8c:1b35:4348]) by MN2PR10MB3374.namprd10.prod.outlook.com ([fe80::eab5:3c8c:1b35:4348%3]) with mapi id 15.20.8377.009; Fri, 24 Jan 2025 11:15:40 +0000 Date: Fri, 24 Jan 2025 11:15:38 +0000 From: Lorenzo Stoakes To: "Liam R. Howlett" Cc: Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jann Horn , Peter Zijlstra , Michal Hocko , Peng Zhang Subject: Re: [PATCH] kernel/fork: Be more careful about dup_mmap() failures Message-ID: <7a16bf18-e193-4e0a-9e3b-83f609cb9e72@lucifer.local> References: <20250123205849.793810-1-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250123205849.793810-1-Liam.Howlett@oracle.com> X-ClientProxiedBy: LO4P123CA0269.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::22) To MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3374:EE_|PH0PR10MB5683:EE_ X-MS-Office365-Filtering-Correlation-Id: 3114760f-6560-43b2-0088-08dd3c686f94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?O1pU7nmWEs9d8GyXcwzbOKgAD5nOOD/Fogv5RItPQCefVktVCQOxRQXd0/SI?= =?us-ascii?Q?BWngxH/NARJ5+7f3d6eukU0cnHxR1V/FlE0jDWcyyIBvFNWWcEM75Yf3n+bp?= =?us-ascii?Q?jzQ4AvSTp/sDU4uJZXJ9K2mwO5Fns7R54PmwqZfQCY6uIiJDu5gdK8ByTjkZ?= =?us-ascii?Q?MU9cagsDPY5TaSk+p9b14jOBq4LzG+1KM840Nmr3hhLXGkA0El/3XHv7HvjU?= =?us-ascii?Q?3nf7x99f/AjUSFqSDqjPRnrYSGtYFvBrsaIk43lNfR+8Spe+VQtI8Sbr7u0P?= =?us-ascii?Q?c3pfuTDCoVEqi7HRAPEDa4h8dKstuoq+NJEDZnWTAgST83F+KDixIk9siGZS?= =?us-ascii?Q?elRzUFraHTvfkVAyJAp07A4GdBRLxIHwcOj40vl3GVZKouIRWvkx7G3uhNie?= =?us-ascii?Q?H/8Bs2InZQkeH/et35HTQJCpNIsjsk/QHWqKugDuW+PVS2RHzMnhEaBWR92a?= =?us-ascii?Q?6mKw+CxFvvGZkE4vHdpIVfs9d2Gdle5VmJeV0TPoBBbOzxugcYfXg5l6Xdj5?= =?us-ascii?Q?m/vMYpxUwcL+fQR/J7REpQJo3v4GyXp2fo5tgoQztK2OEUowon9AyiY4/odg?= =?us-ascii?Q?i8AQLUVLyZPyudI8pVKHV2Q+E2OGGFiPbFNnOX8AM2xCOQxRifba7f7L3iaK?= =?us-ascii?Q?xRkNoiyauds0m81pUQ4bBoZB0lscdTGhRVLLxgSdV/Tc3h1HqgId6Fb8Krlz?= =?us-ascii?Q?kFVtMpOgaD003AKUW+XC4DrzKd1b41Oh4UmpK7LsGNVk+/n29TJjwgXEubso?= =?us-ascii?Q?2Xon1tl8/L+px8BzcfE7g0xKNu+h812yg08OJfrPAABCjvl7MfmbpcH1qBip?= =?us-ascii?Q?vY9002lCbo6NP8piuO+6D7zPvMTCDP9YaW+aGQDqHmI9DKp7n4aaQzxQzN5z?= =?us-ascii?Q?6gn5x3J6TmOJam+ZVLHwqXf74ep0t3UbzCojXVwyobO4vVzgl+IuMW/3DXL3?= =?us-ascii?Q?B5V2BKk6+asqcA42pQ5SIx23OLvIeVU6nJIZ/aAZndnVVhyZUvhOHZSjjjdK?= =?us-ascii?Q?Hu7UJLepHBbl2Yw858UGNq4m3wz427e/m9vj15UfM7gTDEjnXtA+FP48f7MG?= =?us-ascii?Q?ZgQsGpbMk7M5yJF360DNDN6JZ3EMLXEgzibP7oKoUsXJocjUUBNkabewvDMz?= =?us-ascii?Q?R3YnSi54V1Y5aXoxsJe9/mwTWrh4Cuczpv5k4+692SfJDZ2pWCY63+sgUFEo?= =?us-ascii?Q?b3PriTgd9JzI5+RB05wJqxh2qqOrSYy/9It3vLiLp9+0Ah7fG4ieZFNXSdba?= =?us-ascii?Q?rAR6jKB8Ea/xcwWMsJFgpvmWsNvwJwD/Rp1gT8RmZEIABVGTdTgjQtc3pW48?= =?us-ascii?Q?wePfIkaJTE4F6hZw6tGomuG6IxX6yaqcggrsiaVNR0CpBWQXj4DSDUMIMpyW?= =?us-ascii?Q?f0eZVNXccNfIBqC7SFWY+gvkKrAyKCiHI/aB6YsO+u34H4NvVw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3374.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0xS831Wio1zQ2/ZUDllsdzHVSEiTc5/Z2cRSfmSdS1VWylatMZgP/DECCWdn?= =?us-ascii?Q?PsLqetCicUBwp00jXvCMXVQuL2aaLN+jbt/EQR54ArhL6HkPUZiyCv24k2q/?= =?us-ascii?Q?IkwkiEgsH9VqVyIg5p9NdDDQ3hit2YqlXbFul+4OQQu4DlV7x/nomWQwwer+?= =?us-ascii?Q?YoU/TsFOWor3R4pb+NTwTK8OG03vWOonYiUEVdz8V1IU/FFXd5xWhSwW/gM0?= =?us-ascii?Q?y9IVYEBTMkPKNVoZ4C7RqwPiizKmql0sh+JZk4Ercslaj4CjAHSjYJ2UMbxf?= =?us-ascii?Q?86W5SRj1HLZH0ncZhyLuU7vXEjXWEKnYtYf/p3bQrIBK6e86u2gXd7+v+rMZ?= =?us-ascii?Q?/zv93Q8GtdMLg22UXckpXNlJiTrTNSKNgXPmNxfnYNJMsQ7bQ9doHOSjt9dX?= =?us-ascii?Q?QNolSe2t6A+br41qn1brAEGBvMIfq46Lc2TbeDwe1X5hpF184l2o+I+l2By4?= =?us-ascii?Q?cF0dFemR7d6sU+nkCO0E1tlc1SMbaiTejRILEYGt/p+QOGCuThXag39XwYg6?= =?us-ascii?Q?QjrBWP6RXN0zc4X1KQmZ3wcrB+9KTZbgV90GMnWiCNOLd2/VFiqDs94MfD3K?= =?us-ascii?Q?1mFz7M7ZN6YlUKHQASuAaLPq5cKVo3BAZcP0gwpWw+dVGeEtaHjye4PWUt+p?= =?us-ascii?Q?YjOytI0jBF7qY0OXtsKQyLP1/z8zrY2Hj8QhwOxU6m9vtH9e8O1lFdzFRJ+y?= =?us-ascii?Q?7joky2327KzGMd6Zf4Dxs7++lqtPbacM0ueuIp5Hn2HByaJ0dFtBpzuae+oC?= =?us-ascii?Q?+Hh8xTL5H3V6cPOU7SxKINouO2EG/HEOjEy6cnxwTnMMpRA3XVA0YUQ+bDCk?= =?us-ascii?Q?ati0BzY3eW9BtCPIA0bVywbwLz8EkDpg9sin2MEk/YacNVR2szE0qlO6Lo17?= =?us-ascii?Q?exzAPzHIevrQfIk+v3pJY9UednyJ44Lfe3jQlmlFYX+vz6ORJeTmRbhNzhPz?= =?us-ascii?Q?1aMvRG9Nt62344bHnigpVmrgTQg13fFY1p14ykF55w726pEg+ZPc0SozBK2y?= =?us-ascii?Q?j4Ix07YhGk/Njw0BSs63sRWcLide4u+Go6kv5fcbmjBULthIO+8ZxwmkeFUJ?= =?us-ascii?Q?VDDn+B39chPRyxiqWH4KsNMYuWkwRNMiwRTmpwtof+KmiIf1VTYJ4r2zTJll?= =?us-ascii?Q?I+1NSqU2K70BQVhJN84gqv+97j2yiERSQ6YDxcMQdCYu0Tvg/OAliF2F98+z?= =?us-ascii?Q?bphBVm8mgemHfKpcA5186HneQmMfUm1RkF0XXS4hCzDF6VTGm8pJp0206An/?= =?us-ascii?Q?Rc67APXXyeeaXvQV057/FAuXa/4qLa5D42a9G4nOsugnz3p3zY0VUyCXjqx6?= =?us-ascii?Q?nuNscOGLd4wtZMbLx4DID+HbXwRSR1lV6is8UDEon17Jlifiq/WnisoHMaTT?= =?us-ascii?Q?fIUW04Zwib/s6m+pqIubHhZj6gh1LYuCnRWK9izlqzPIx2g6p8JsEqroq7sK?= =?us-ascii?Q?qXBpBEK7OpehS1fj3B0Zuu2i2pzqDtxlV2JvIDW8s8wm9c/ql+KEo3pOIfkN?= =?us-ascii?Q?6V6Xcaa9KyZ0k17SrM0dKVqepjgwIyMa0K6v7/J0f30fgqPmFh1IcUq9zCN2?= =?us-ascii?Q?MuNY+DZimcm1tjyelfXhedrU497u/xH4si3jl4pvME0lbUY56NTY3uljc9e+?= =?us-ascii?Q?Pg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: UfwXq80Tvh8yZE4BhRyL1ZCrzf2A/JMwEZbkViGLDTmm+EOfXECATyxlzHPstZDcJ1dccggSsgSqR1vB4NnQs9CfPkuf+wkJqynZivE3MOY4929WVb24yuTqpqkQ79/GB+QDu3c1ZVorY5VrGSsom9RfYYsM7vg9HN+vpRlsIpNAn+pVGkD5Bmd77BytVzZD0HKywfLejNRM3srtgDfZxnAjsk9Ye3aesKsG5BPjb65aK/qa7V7mZiIuwaXi/NCQ2jdALImfe7Jg+/BI0VOwiGldg4mxKUpa+Snpj32scnZnBM7TQIHYqsLytGqychbZDBQdzlt3XEJNF+ioBzyd+NMRJIq9NK5IYoTx9DwcIUNIdue5yTDFtQNSvvSDbDO9ugOQXgu/DyHJ0Q9LiK5CBsqKU1FjM+K5TOdmy8jUnE+aXQsRC4PrHjSUepmqv+hst6qc6OUml7qykhifCzouA3LNGf4kS6sXtrveQgKLwtiV5aXWXygCvlyyjLFhTHtrShoYF06VyhQgDlID9K0eb5R799dXc1Umfj6w3VCUixyF+AAExtBVtOxDcGh8572ZL3r4mx81WveafBMEyMeJtW2V2I2im9SyrQxuFqMj0mw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3114760f-6560-43b2-0088-08dd3c686f94 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3374.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2025 11:15:40.4773 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PkMRWVsHpz2+LIGXQ2BQ3JrwQc+3tOAD3+Hg4JyOjROB+wm3kALmIerMg0igl8d6FlFydF53PilIMQnHaBs49wlG2wxvZe4jCEmchnHrfU0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5683 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-24_04,2025-01-23_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501240081 X-Proofpoint-ORIG-GUID: fnWwW3VO2lD5Ow0c35DumMCd8BIead2U X-Proofpoint-GUID: fnWwW3VO2lD5Ow0c35DumMCd8BIead2U X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 496831C0015 X-Stat-Signature: j7z31xjwzwws3hp768sfkj9w4iywah4n X-Rspam-User: X-HE-Tag: 1737717361-138 X-HE-Meta: U2FsdGVkX1/FgSJLanZAVutKMSXidV3Cqe8epIudV8LEcRoP44EQoOHI9JEnGNhap2d8xIdSLJHhTsNnjV4obzuPU99Thucu4+Gf8wQeSDGGmUAERgnbP2xGOr42FjP7tLZ4GVi4d5CCdvdvSfclh/tbRIOXsmMXeioAsibpgPTp3+WwM916FdJ9EYfbSb49WPsX3Ib2izGXfU8mR6pZBLryDimF5C1VicXb4uC1vuLBaZSizzW+JnUDF4VQYYO3ksEVJmElQ+v4xSpL3e5hEmcEY2KwFDyn5yjKyU0tnlML0eYGWG2qxMtNGR6kozkPUut6DOzrsNgUZW8bEpmntC+RI9V8riA1VReE7vXD1tx7MQJSvuFMunUTmI6Cm4KTB8R8hl9g14MhxIarNasvFrjdcrAMOG2K7wCK/7W31nbB7S+Www3XbvM2wxjqvzWOorv3+YH0wOMmtvaJLuHRAtXV8KuTCXB6BOFe7Pci77zGbrn5cl1dXTs0N1d/PHWBvhXfKTcHNZMY03dh/UAQHu/aOCsDVrnjvsXzlUzB3Etsm98fC85iSPj5HBhKBRswAdmIcQf11SWGvhj9AD1IqhTv50rhOnorQcyQ+ayUoedNdVfwH22BPL0BWQitVi/JY6FHPuxC+MN0osn0Sptq6ArEe1JY6Vd58Fwk6YIUHMnSMCe/Gm/vgovRvCNgYNxpfYtD9rDU5FWxpIFsc/z/9vmdtHz/w57/oC9QG2puU+cQ/w3A3Gs9Jy3vTzriO5ilNvDVqGf45sUQ/RLrkIZaDbJDJ1tYjNbuqsnfgKyGF1kMvcUBnK3ZjVtSLglfLEDsXxT1NEtu0TK905rOhejn7p9zU4ADW2mARVpX1v4jD3Fft41hhnCnKdDhSScwfnd0TpE190Sjevly3VlsPzvZE3sLeX2g0j8SlO2KZ0UjduAQ4WtTbGjD+1bbXvEtlvZgULfrJ8ogzqKz0ZrrESz XkZRwJ8f 9sk0k8qZaEfVeHNlT/4N/ASBnleTrMF1gINm9zsEmt3lMSroXeC8iMAggrtU6/uQx3S5ng2J7IA1T787RYpVJ+ioqE8cR1THz7DCXOe9vBkcrBx4x3IK+Oxg7MLw/cIcJQkFjtgnSXnC6ZwlwTmJ/Oz0O2qISKT++R/hFiBG5QYiyCbGGrPQiyUDqlvu3/Oe8SJ53+WyrS8cUT1f3jo9XINZ0P2PdhuDb/U/kNdC0PgzsvIAYi2xtXVyIQ1edw5S2R1W18gTSTPH0YD8tdwwUHsG0UzisllxdqYoSRTZ8d8HBJQQ/79eXk7WwvpgtaP7P+h4ZkoYmO+n5aRcsbFt+n5gbA9Da7h5dzgKg/adM6dTR7tItGIzh3If0Ef1xyXGquaU6WxzPD4CNqD3lteACzHxEFwpmnoaOL+ENbDRjV+nvWqjRaoq873pCEx4LnPdBJOMfv3jF9acffwuaABzkBtqCYopGzcp+tbkWMdc16/Iwx5gnTHYpXvJgIsXhsSFVlSM5POWCPjbIOXNzmJL/ogoDWPsQKeV3PIDJdAHD4vKp4l47NmRfezNIvmHp2YVlXcfKEiTAe3SgQmgKdQp/1WyclkNFUfHbGAOWLMMg6HOERPCGz2pz+wi6ahm5EMwvHQs74UMiXSliHEPaUTz7xV+igZLVRvKnA9ppCLLcab2ERa95bfK4AwjS81A4oCliRh/JndSX4rb36/wqtJhnkM3CjZzg8ypKzEUhLw2JKyGtR68Fg1FTxAix4jiFiqpqON1NoCksd465o0Vv05yBVwbIwseCmedKtlGrLvQ6KpqrVrA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 23, 2025 at 03:58:49PM -0500, Liam R. Howlett wrote: > From: "Liam R. Howlett" > > In the even that there is a failure during dup_mmap(), the maple tree > can be left in an unsafe state for other iterators besides the exit > path. > > The unsafe state is created after the tree is cloned, but before the > vmas are replaced; if a vma allocation fails (for instance), then the > tree will have a marker (XA_ZERO_ENTRY) to denote where to stop > destroying vmas on the exit path. This marker replaces a vma in the > tree and may be treated as a pointer to a vma in iterators besides the > special case exit_mmap() iterator. Thanks for addresing this. In the original issue, the problem arose in vm_area_dup() which I tracked down to vma_iter_load() -> mas_walk() (see [0]). I'm not sure if your change would actually have addressed this? Would the MMF_UNSTABLE flag prevent this code path from being taken (if so where?), if not don't we need to add a check for this somewhere? [0]:https://lore.kernel.org/all/aa2c1930-becc-4bc5-adfb-96e88290acc7@lucifer.local/ > > All the locks are dropped before the exit_mmap() call, but the > incomplete mm_struct can be reached through (at least) the rmap finding > the vmas which have a pointer back to the mm_struct. > > Up to this point, there have been no issues with being able to find an > mm_sturct that was only partially initialised. Syzbot was able to make > the incomplete mm_struct fail with recent forking changes, so it has > been proven unsafe to use the mm_sturct that hasn't been initialised, as > referenced in the link below. > > Although 8ac662f5da19f ("fork: avoid inappropriate uprobe access to > invalid mm") fixed the uprobe access, it does not completely remove the > race. > > This patch sets the MMF_OOM_SKIP to avoid the iteration of the vmas on > the oom side (even though this is extremely unlikely to be selected as > an oom victim in the race window), and sets MMF_UNSTABLE to avoid other > potential users from using a partially initialised mm_struct. Good to have it set also I think. We were concerned that _somehow_ MMF_UNSTABLE might cause some issue in OOM, which was why when I first thought of this we decided maybe not just to be safe, but I am confident this will not be an issue as indicating that something is about to be torn down and is unstable when it is in fact unstable and about to be torn down is correct, plus I checked all the paths where this impacted and found no issues. And in any case, setting this flag avoids the problem...! > > Link: https://lore.kernel.org/all/6756d273.050a0220.2477f.003d.GAE@google.com/ > Fixes: d240629148377 ("fork: use __mt_dup() to duplicate maple tree in dup_mmap()") > Cc: Jann Horn > Cc: Lorenzo Stoakes > Cc: Peter Zijlstra > Cc: Michal Hocko > Cc: Peng Zhang > Signed-off-by: Liam R. Howlett > --- > kernel/fork.c | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/kernel/fork.c b/kernel/fork.c > index ded49f18cd95c..20b2120f019ca 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -760,7 +760,8 @@ static __latent_entropy int dup_mmap(struct mm_struct *mm, > mt_set_in_rcu(vmi.mas.tree); > ksm_fork(mm, oldmm); > khugepaged_fork(mm, oldmm); > - } else if (mpnt) { > + } else { > + > /* > * The entire maple tree has already been duplicated. If the > * mmap duplication fails, mark the failure point with > @@ -768,8 +769,18 @@ static __latent_entropy int dup_mmap(struct mm_struct *mm, > * stop releasing VMAs that have not been duplicated after this > * point. > */ > - mas_set_range(&vmi.mas, mpnt->vm_start, mpnt->vm_end - 1); > - mas_store(&vmi.mas, XA_ZERO_ENTRY); > + if (mpnt) { > + mas_set_range(&vmi.mas, mpnt->vm_start, mpnt->vm_end - 1); > + mas_store(&vmi.mas, XA_ZERO_ENTRY); > + /* Avoid OOM iterating a broken tree */ > + set_bit(MMF_OOM_SKIP, &mm->flags); > + } > + /* > + * The mm_struct is going to exit, but the locks will be dropped > + * first. Set the mm_struct as unstable is advisable as it is > + * not fully initialised. > + */ > + set_bit(MMF_UNSTABLE, &mm->flags); Do we still need to do this if !mpnt? Also 'mpnt' is in the running for the worst variable name in mm... > } > out: > mmap_write_unlock(mm); > -- > 2.43.0 >