From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1DEDC77B61 for ; Sat, 8 Apr 2023 04:42:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3CC3900002; Sat, 8 Apr 2023 00:42:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DED856B0074; Sat, 8 Apr 2023 00:42:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB562900002; Sat, 8 Apr 2023 00:42:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B67946B0072 for ; Sat, 8 Apr 2023 00:42:40 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8614CABD8F for ; Sat, 8 Apr 2023 04:42:40 +0000 (UTC) X-FDA: 80656978080.14.8CFCC72 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf22.hostedemail.com (Postfix) with ESMTP id 74F15C0002 for ; Sat, 8 Apr 2023 04:42:37 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680928958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kGN5KBwEkv52A29kPZC4Rx2ZaoV88Q1NfDIfRIJIUm8=; b=tsM5l9MDh7+bUNDZxE4UDHWgwbCva3D0d9I5Xca5xXebZap1cG/0WVy+AY+TDl6NXwpmgI E0Tm0Lt+JYdJ3pc4mrlKSyu+8U9d0q9TVAZWYTQyKMI6IpiHtZIZHfecWAmTPgRZp/axB8 /V6//WV6QUYAVgHwCaQ0i+MyJ4BoAPQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680928958; a=rsa-sha256; cv=none; b=k9WXhAmmS2yYogTXB9U+Ztojk/ufGf6tFPN1GQuA1vp6OzYY3NwWqiAOyOqvRNt+DclmXY z5aZ7z/+1clNFZIC8Jy7jWRmDbBuCs3hCxkkjkSJodyW774OH2LoCU/TCbm7fyc/Elxu/j k0AiPJMggsG/MM+MvdK89MG+BEsZNNk= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PtjHB4F8FzrZ6v; Sat, 8 Apr 2023 12:41:10 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sat, 8 Apr 2023 12:42:28 +0800 Message-ID: <7a127da3-9a53-962c-1096-562a03e39864@huawei.com> Date: Sat, 8 Apr 2023 12:42:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v5 1/6] userfaultfd: convert mfill_atomic_pte_copy() to use a folio Content-Language: en-US To: Mike Kravetz CC: , , , , , , , , References: <20230331093937.945725-1-zhangpeng362@huawei.com> <20230331093937.945725-2-zhangpeng362@huawei.com> <20230406213127.GB14244@monkey> From: "zhangpeng (AS)" In-Reply-To: <20230406213127.GB14244@monkey> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 74F15C0002 X-Stat-Signature: ncnjf3fyziwmpayo8u53uzqiyqppumjw X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680928957-641733 X-HE-Meta: U2FsdGVkX19lW8aNeFU2Z7+nPq3agItPCYFQmCMOvSSFe7kzpU3+nYHzJNG8Gt33cwzKPPeqXE3C0eQJMtlwiZ5TUG2P0IQqODnMdmrUQHvgIQk4beKttv9JSF+xn6zDNC0B+EKuoJyRQ2ovYcOboIc4uJiPfjHh8x3l6GC/Qipdl/+2T3WvmQXOZRs96utB+7llsSc2hqTtRPzBuFVyyzoPgcJvJ+M1NYWizklyPE/V7oZ3DL2e87vjY7Fi4K9T9IQeSZ5Wp+0663muZOG/6Y/F5Bm3fGWqlKuIzSGRhHBJyRBbp6xkXLd38nIKrmsQZdKV6q3YvI1SD2FdTnIIDKUzOvOQ7Mba1JDh9g5oqBytp0J0UWT/UZDs5Nl3MvQQf5CkrFKeaJlNE2ngTC5wFV0IiDbiT7cxfB99ee1BiJyINrV/KuOfdUPReQsJfYsDaErANb4GH4irZyvjqziCrvEbywYdG8VzHGJS4SGxo/1blPNQ3MWA6O1y7CH+vIPr4k2emzN3kCgRqaKEX7Ylcgg9bRyNyhCaE4E4qGwyP4EQY61+pYoqGNohzduHNRXlLExV6VT8MJ2XUESN8m7V9+oHxQrrlZQI4qM6ZzV1hF5gEbmkL/tbimUyQcEFIqAWP7as44Yyk0+pAQ2Z11a52AgkvFw4pI3ORLEeg8GyRStdacl/xxgl94oO6UVl4JjdovD9vi+G/1mdWimJg2Y7lSfUhlnONSrqDQBAW21NorawgFgwObtsExvE29BpuwuQvtZE0NZTrwzcL46tPEBhpvLTp/l4OIte97KqF0R0GXKYluLtRgYeBYzWdP9wYI5Hay8wYbQtiU2aggcuMOVfQF3vXG/6NR5Y6f0vbvfxO9hoV8SCLWXUzoSI/Wu5eZjYT9yN1+7MKYDWT+Jlv1TJVWPfv1rGhu1r1xwBhe/H89xwaXgUkaSTFxMG6+xNWz8id+8OZ96yXlQl/jijjUJ JLuiS1E8 QAGyADzUJWSaRScoKUgN7neS+YmA2HQkWwJkg5tGiQ5BzIkFZmOoeIgYNF3FXmNzczvha+/QmeoL8W5z2iI/6ttiUhvskF+qXVQGBpoxxVy3WNRXO5osSgpPaWbyF2AIioiykDugMlZ5ffEjiEUwZwaoXAarDJUPyjMuV5L+BoRr5d8aLDjv8T+zIb8BghX22K//GFgvNcHmB8FbIsR2TS50HC/XZNDKmsex+Bfdlwr/4Jd9W4XIEzj9l0M5Is/q60FFpiBGs7SmqL2lfPcHVpMFpZSYieDqOOqHjm/7s1ZexMWtM3zGmebi8i+Q8d7mmruuW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/4/7 5:31, Mike Kravetz wrote: > On 03/31/23 17:39, Peng Zhang wrote: >> From: ZhangPeng >> >> Call vma_alloc_folio() directly instead of alloc_page_vma() and convert >> page_kaddr to kaddr in mfill_atomic_pte_copy(). Removes several calls to >> compound_head(). >> >> Signed-off-by: ZhangPeng >> Reviewed-by: Sidhartha Kumar >> --- >> mm/userfaultfd.c | 33 +++++++++++++++++---------------- >> 1 file changed, 17 insertions(+), 16 deletions(-) > Looks good, > > Reviewed-by: Mike Kravetz > >> } else { >> - page = *pagep; >> + folio = page_folio(*pagep); >> + VM_BUG_ON_FOLIO(folio_test_large(folio), folio); >> *pagep = NULL; >> } > However, I am still unsure about the reason for adding the VM_BUG_ON_FOLIO > here. VM_BUG_ON_FOLIO was added to ensure that folio is a single-page folio. However, the folio corresponding to the foliop is always a single-page folio. We just don't need this check. I'll drop VM_BUG_ON_FOLIO. Thanks for your review. Best Regards, Peng