From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22909C54E58 for ; Mon, 18 Mar 2024 12:26:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80CED8D0002; Mon, 18 Mar 2024 08:26:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BD216B0089; Mon, 18 Mar 2024 08:26:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 636728D0002; Mon, 18 Mar 2024 08:26:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 545216B0088 for ; Mon, 18 Mar 2024 08:26:00 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2D42BA0413 for ; Mon, 18 Mar 2024 12:26:00 +0000 (UTC) X-FDA: 81910081680.03.593D919 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id E4122180009 for ; Mon, 18 Mar 2024 12:25:55 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GM3cmAkU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710764756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SqvGVh65KqbKTetTMf6WrYl8K7KtLN0mdgSBJqowmoc=; b=Ql6BqfWmkw5eaoPUbJlqw94JnPDBC5Aul6zdleGZjHIkTNJClvkyibhUOzfR4gE/Yq5iJi WaL5mNb3+oNkX9IvGU7HHgkUf3qJUbI2Jyv08KDw1KS2lnbOI2+PDna09lRqSfc+FQy6tB oKevm/x6j1sOgCqvcoeKCko99sbqH7c= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GM3cmAkU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710764756; a=rsa-sha256; cv=none; b=XVkjvzKtBV7uLopNPHXg5rDJIgyquVMdrBDxz/josV3dLb0AnqS6e+xsYXJrhQOmww1QRm 4hpCLMYsJyI9aU3BGOSd3akiCn03sRaq/Tepz248aXUZL7ZQpSxmymiXMjt7Fqio7XuKYX GBLcJGDvpFpcTLhEGjtwfgKnlYbT0dw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710764755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SqvGVh65KqbKTetTMf6WrYl8K7KtLN0mdgSBJqowmoc=; b=GM3cmAkUnIzE40PsDTAI1Jr6XedRERxRXax9jcKV4vEqrTfSPtxLBtB8JRkAe+cXl1wbnN 7z+frL45EK7UMNOg+XOU/evG8RNJuqS9hir8ysYaUl2wHbtV9poxvGXprXZOzcuHCIvHOP cxX7AZPdJ7dYuX0lm1/fLng+hPvCFEk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-t9s7CygIOp-TuTPd6-P7CQ-1; Mon, 18 Mar 2024 08:25:53 -0400 X-MC-Unique: t9s7CygIOp-TuTPd6-P7CQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33dbbe709ffso2348726f8f.2 for ; Mon, 18 Mar 2024 05:25:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710764752; x=1711369552; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SqvGVh65KqbKTetTMf6WrYl8K7KtLN0mdgSBJqowmoc=; b=lp+WdVgC0FsHFNiZQp79OQVPgcVAHjv3bkbjmDSWagr9TtBHSI3F4HrNEWrbmPNuWe AlBLkjkyHuE2RnJVJPTNmW5F2JLjj0uNsOGHJFZLLMeYMxlYuRB9+hgh5QGgUfjmvhOX orjKKDxKYpS0aaGjJfmVUiB5y8EADb89SkiTELgsAs9zeAcRJpUdKnwuFYXUwC9ujWAZ YmlDhMTs8Y5OnO8mwgRbGt2pLHsTSzT98ma2MqxkNAXhTo0Dzf2M5zpEN1Lat8YYbwph nWLg0MYGCz4SfCrKkqCOMzW3rm470yvLomauzbuvLndF9fhf0j3XzEjX4CsGWANf1gpo ikcQ== X-Forwarded-Encrypted: i=1; AJvYcCXfaXZA1TKQvXoSixTclSA1IPrRF9mRKIlx0MHfVs81g5fyXQBuvOTeSryDz6GQgQWcWwF6mBARv4XVhaQUV3LKvT4= X-Gm-Message-State: AOJu0YxLQnrWoa3m82PuGY4AvaXg2A7NIvGKlxTMOAWcAJbm9XL7Wx/i xzvllVImu8vAeNJ34PX8qTNIYXWmmxxz0ysBybeVSNpy3pMYnkyvbBmLpAdxiCO3jteBva9HGBp ANtbuF+fnz4tUU9kux4paIkir/3d61F24wqxMb6WzKk0Kk+fW X-Received: by 2002:adf:cd0c:0:b0:33e:c522:e3b9 with SMTP id w12-20020adfcd0c000000b0033ec522e3b9mr8748449wrm.36.1710764752678; Mon, 18 Mar 2024 05:25:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2Hx4zJB/q6S5B8pGBIOadGQ9g91TnCxrmkQyN4q9h6k7VBZxpM/MjeIOpkkHZ7VFYEHGlyg== X-Received: by 2002:adf:cd0c:0:b0:33e:c522:e3b9 with SMTP id w12-20020adfcd0c000000b0033ec522e3b9mr8748435wrm.36.1710764752260; Mon, 18 Mar 2024 05:25:52 -0700 (PDT) Received: from ?IPV6:2003:cb:c737:1f00:94ff:246b:30d0:686b? (p200300cbc7371f0094ff246b30d0686b.dip0.t-ipconnect.de. [2003:cb:c737:1f00:94ff:246b:30d0:686b]) by smtp.gmail.com with ESMTPSA id n16-20020adffe10000000b0033de2f2a88dsm9657147wrr.103.2024.03.18.05.25.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 05:25:51 -0700 (PDT) Message-ID: <7a0d7d0e-d241-4942-b6c1-e60d597b3dd6@redhat.com> Date: Mon, 18 Mar 2024 13:25:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/12] mm/ksm: catch tail page abnormal in page_stable_node To: alexs@kernel.org, kasong@tencent.com, Andrew Morton , "open list:MEMORY MANAGEMENT" , open list References: <20240318121443.3991104-1-alexs@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240318121443.3991104-1-alexs@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E4122180009 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: wro9588yfcatmkush9aoz5jzxmtsfprh X-HE-Tag: 1710764755-88595 X-HE-Meta: U2FsdGVkX1/YdAcgnUiINlE+t1TSooZLQZoOyL9hioH6/5Wz8W/0/1LFSeMZlsr5tfGBEsmmi1eGFF27KB00sn0dOSjhnXm8tl8Lvq4q9mLLxZM+g/Bmvz1blamUKk3p6sZxmQMOsJOw1UdA7vyu/QZ6AliyATojkkVCAefQMtNlnCdcyVEZVC6+hYLBZl9gwL32v7NXJoj/2PxSHlJwUV9J34F4YegLQn8AME0JlLE1dGTiQhJqPyB91LvJyT8la3LFdlFko91NhPB03qjje/qlo9QQ5G8BpUZM3j8wrdlOp2Bn/Q7qyolb3m3qV1WDtKEmp1t9D3xLYDZZXDmlRVKRBH87kuSH0K9dvfHeXJrl5GgBd6p59fEEGDuDkuBXbNJ3Zeg/rNdGgZ/muQbPnTNtlz+yJRkuIaQC4AjtRIMNjD5voOKVKyC6iSPWv1A/fq+wXkRNn6JJhHc5ZKxToJQhJ2r7pNB1KN+wg9iSJyQAmER2gj/rzfRGeTpUNbLAhGXyrHdcxtiC3IzK8dqvknUwXfw9ZlskdQZevYPsYbPIIQkolc/rqoLdhm+qBGF1zVh65VW7ZU/IFNwe9wSJ1fAxF646HcCiHL+UsJkc4Kbfp9G8L56i8WiIiRS2NTgcJvgAjrxDQ/xkhzT9MYSn5lGxISJfFOKo4iAApGhkXrtiLCAaDr4TgAUADlhoyXp7mcnZ7Yo3WjKd/dbk09NEUE0B/7xCBwan+Gw7aoyVHjlMuG7UKgO1fEioUPN2pU+ECGY8+TkLE7rOvAoanSJIFTTP2WV5Qejun4umF1hbKniPk+E2BcdVqva76Kw6P59my1noBtvzeBOlyM4xuMGRM73Dwh1mOCX2im+cDZoFaX+Wv2iGqyKFI1TZUX73k8FrN5PVFBl2tNUOYb7a9ycrW9cnuGue6oD+Ymzyopb3z1PEnuJNPjGumhAVEDG+FTST9RMOHFoFnLOeuhFd8Lq 8ns/kyCj xHxYU9BFukSSB17cuc4lSKroEIzgznrs5EnDkJKnLXYOUNu4clajhvRrGhn4W6gvfhtQ5nk9b5T1UjSdHNjCXXHZVmnvOcFGuc/f3Pq3O5gljgdm5hJbL0XPjDc7esCsYvbcXiwXeNkA+Yep0TZWrvQ17RIXbykewGkO18F0lz9gan/+CQtr8DnkrFPUeFrF9FGDyyDpWwfR4XQXP/xfzD55Tq27TOTWaHcs5eRr3YkXI3Th+DSvN29mmrv9Y4CO6KhCgf8aiOFR3KVZBZyplF3+Y+qP+vvFWXfvcyj3ysjrXezdKGvNkWQAxm5sKALTUEVw3ggn3+eTrd9rXwZD2DXeOOGTYQUyfY3U2mx1AtruG4Q86mmCfk5GfXaDDBsFQAccwJiL3IHW+gEmMCGaXnBRbHqM0z7HUuBDZeoU7x57YjMXD8hJudJxNiZNpK+lWdyLQkMvdYiDAKt1wBwq/3/i7EbBPxl6dMo6nL3vZI/6jabHcVKbaljbOFj0zbQW7YcfiTytjAYfLEK7fL2UR7jx/cZvBZmHjwoQ8JVKT02OzeibmCWArInhA0n7e7GzLlTj1jsC+QakwGkrbZmggBlcMvsyU1E8upwu+heCRPglzKv604C8BDjtP+ibAfmLprYwqwAlUDP3C4Ea835wFpE+YsoK5qgz75curbHO1lqfdivretrANp6o1QTeYoXeYOy4atceQ53DWMODLV2w7vM/V4FnFIKeYjGMgDK2P2w3p2dbvbv+DD/bt6D3x2m3wrrJohSPiSCS6FqFE1+aMCIH4iM4UZduM1qBKJxmI4f4yKS/B16seqTgwF97Kx/2kFR2WJdmBuhL1vZg3dNJIgywzwWB6jcSBeWtqe9n3DhknoSQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.03.24 13:14, alexs@kernel.org wrote: > From: Alex Shi > > commit 19138349ed59 ("mm/migrate: Add folio_migrate_flags()") change the > meaning of func page_stable_node() to check the compound head for tail > 'page' instead of tail page self. > But seems both semantics are same at results, the func always return NULL > for tail page. So adding a bug monitor here in case of abnormal. > > Signed-off-by: Alex Shi > Cc: Izik Eidus > Cc: Matthew Wilcox > Cc: Andrea Arcangeli > Cc: Hugh Dickins > Cc: Chris Wright > To: linux-kernel@vger.kernel.org > To: linux-mm@kvack.org > To: Andrew Morton > --- > mm/ksm.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 8c001819cf10..3ff469961927 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -1091,7 +1091,12 @@ static inline struct ksm_stable_node *folio_stable_node(struct folio *folio) > > static inline struct ksm_stable_node *page_stable_node(struct page *page) > { > - return folio_stable_node(page_folio(page)); > + struct ksm_stable_node *node; > + > + node = folio_stable_node(page_folio(page)); > + VM_BUG_ON_PAGE(PageTail(page) && node, page); I don't really understand why we would want this. Only KSM folios can have a node in the stable tree. KSM folios cannot be large folios. At that is precisely what folio_stable_node() checks. If we'd have a large folio identify as a KSM folio we'd be in much bigger trouble. Besides, I'm sure you read "22) Do not crash the kernel" in Documentation/process/coding-style.rst -- Cheers, David / dhildenb