From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1503FC7619A for ; Sat, 15 Apr 2023 15:44:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DC696B0072; Sat, 15 Apr 2023 11:44:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28CDB6B0075; Sat, 15 Apr 2023 11:44:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 155606B0078; Sat, 15 Apr 2023 11:44:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 019566B0072 for ; Sat, 15 Apr 2023 11:44:52 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B5BB314026C for ; Sat, 15 Apr 2023 15:44:52 +0000 (UTC) X-FDA: 80684048424.09.3621913 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf05.hostedemail.com (Postfix) with ESMTP id D02B9100014 for ; Sat, 15 Apr 2023 15:44:50 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=MuajMTgH; spf=pass (imf05.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681573490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/T49OfIgGjP3qZEDPGcEigiLih5H2RVNsPO16/ysbGo=; b=RpM8psY6NIkO8UirRyeOuA9asksv8rzku0A7vj6Uyzm/dB5RP1tCDj6TSty1kh9P9fxio5 AR3+hv2GLTCkTtqomkBhgz+j8KpHEmD/lGSJidy51QHBrm0FfNTpKRWqrXDlw+XIgg3bz5 BxNghfSO9EPR54RVyh+lj38rkmrA2CY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=MuajMTgH; spf=pass (imf05.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681573490; a=rsa-sha256; cv=none; b=f+l7VjRrDgS6DEVBg3c+l07BewGXzdrh+juWZvUlHDSKe12X1+hhwrmAmKvX0SxDCrp5mu EQibtujTlU9HagM72iBvR/WFAABI0+kKeUM9kJvfa0mo3Xdr28UCBOw8uF+fFEdNZNDYVo afoo8h3iVo6Rd7/EYLfQxoTLHstZ2jI= Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3f0a0c4e1ebso4697755e9.3 for ; Sat, 15 Apr 2023 08:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681573489; x=1684165489; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/T49OfIgGjP3qZEDPGcEigiLih5H2RVNsPO16/ysbGo=; b=MuajMTgHWznTOquxj3IAvkXyxmUsRwm8S1AfhJSixMdxGoBYZVjmqBe61bwP+nA0a1 AqTix4zisMYCkih7qnYADZuRpf8BoZQkiUOw2FH4aFa6Ass0xQQ6LVstu+GqB+M4Gb54 8sSAXL+5Ox8dXs1ZZOHY7UpTOQ0qGvJFoHHvR2tOjGxIK5OBkQUyb6Uyq4U9JU1pqePZ vkG/A7oFOtwwjsX0E+BqnoJRf+aEQROZsZwZayIgZwf0UEyClcyD/pgK7qRqONnjCOfe 18jCmcKbh7tlUU5Hwl0PZ3td/LrkVM1vltlbQ5aEjlrTLR7PsAeSGTyDqs6WuLVPfLXA fz4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681573489; x=1684165489; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/T49OfIgGjP3qZEDPGcEigiLih5H2RVNsPO16/ysbGo=; b=hL7gDc9+ItuR4FUbwktLSIOPXYzRB1VxUMqrGAtkEnemcZhhvjK8nGeAQlWsuniN9v 2NeXSOOrWRefXBk3Wi5zRcXEuLeK8CX3DJszPv2Q6juxNrQg8hs9pTXgZeUPZvDOpFqW w03H304ie1/8LuPVpoLJyir1+2KBrrE26PUccWaJhZIhvaHNNZ7GVXOJ5L0BCaHMvNBG fKNcw0XLbg0pLOQqUOl9S+1c96qDwi/CpQa+rH7RinIMuNeVXQG+twHBO+luu+D4YmTW jNqRdzNMCUlxt7fAs6+seO7DxKq90ChHsqrSwXFjZ/yw+8lmzvSIPqW+Mn6smcX2P/zP MtaA== X-Gm-Message-State: AAQBX9fgjHf6X06XnC42k0qPUZA+sgCM8UlYCE/GM+SU7CD9WJNgxcoH 88ZhT1ZqhnG/Ru8aC8LyOUY= X-Google-Smtp-Source: AKy350aiUHsQtkzjVsv891Fd4t/BD9r+D/7VqB5cACKtsd2R1LOtOxYZI0007p2aCAOEnkoMiXqkMQ== X-Received: by 2002:a5d:4604:0:b0:2f4:d01f:fd8c with SMTP id t4-20020a5d4604000000b002f4d01ffd8cmr1879251wrq.10.1681573488985; Sat, 15 Apr 2023 08:44:48 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id m4-20020a5d6a04000000b002f0442a2d3asm5995736wru.48.2023.04.15.08.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 08:44:48 -0700 (PDT) Date: Sat, 15 Apr 2023 16:44:47 +0100 From: Lorenzo Stoakes To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Andrea Arcangeli , Mike Kravetz , Nadav Amit , David Hildenbrand , Mike Rapoport , Axel Rasmussen , Leonardo Bras Soares Passos , Mike Rapoport Subject: Re: [PATCH v2 05/31] selftests/mm: Use TEST_GEN_PROGS where proper Message-ID: <7a053781-b56a-4366-bff9-d19971594043@lucifer.local> References: <20230412163922.327282-1-peterx@redhat.com> <20230412164218.328104-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230412164218.328104-1-peterx@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D02B9100014 X-Rspam-User: X-Stat-Signature: 4z53ujeweiqshkgth3xqwmksjwmgn4x6 X-HE-Tag: 1681573490-160510 X-HE-Meta: U2FsdGVkX18eDVIQsF02ZVZCTiYUQa3xKT+SVsQ5+ougE+KS8i9DgQFPr2LKbkdc5XVBd2FFNz0T1sB+Sn68aZAZ3EMEAkXJDfpHASddrM7vCng3q3BtZdmTY/72/x+9dLYwk87KvFdPssaW3QeCn0WLK4+3D6eUVcSmtSLZuE8Ht1ps1pBZCV3pQk3JgGZKF34amCKvgCdpN5CDuJp//Ss0SerPLKOpUG6L9ZqM0tlCWss2c2OCegsrzU0glX8C5JrLHUiWPcqTpV15tZM+VSwzIx8Nixrym88lh4+uGuVTCVpZqTT/ztfn2BL6kqJVrflHr/kAYEfXqkhlTyXXW6+HfIkHvaHT3785weIjl9vbpZDZZmVtxxcKa5JD4q72/yrVcq6BreDwxT+Ft9Eiyz+6o7T7Mi0GV1w0cX0hh08gDxTSbNRLJo4wDC2dKCssPXtAF+KXZ+Jv8GR95GtRqBGtyHjUqAZ7ayOljOfXxQ8hRXMYVIHVuxaaF4h4S/111XEfJZO/Q73MiHayqZvhmJ1cdO8PN+VrohXjuq/ymR+tKuIGAXZ/SrKNTAbau+t+zEVBOnC7z79ri2GLdlmF6yboBz1Vgp+zynuVYY5t6Fxn98xNyHSoVTcQn9sLFWluvGhPrN4oLk16I13hVgucbt/WG74xHjTct5s3GblYC3xBAgQ1XyRmOH/Z+beKRSH5hfbcirTtskndJcF7rZKGPhDrBuYV1LdA1P+MZEpGQ/Syi0AI4NkF+6j+F9Sl4P02A36Q4PTnRgVG+cxL5oT0MXQsQtzgftzdJBwRwj+A1ZgmQmlcCYKQ86BJpse71xvmctyxz/KEUMghsddKyXl8g0G9CA6OmbUoU/XzH+iwyaUUYU/rEMZnWGHgOigts2MCSy6kBPK8vbnHpndKA3FrKtFaSo2Eq2BkPR0zdMUW3P2eXGAdImeblBNjCCSWcqafEVedi+QXMAlvtZCtRw+ P1mka3zX M8OS1PW5g0nRdy0Zkld6XeKxM3WyhCHL5C6pZd+Pta8z3ZCtQfaTQB9WIxLBkYBEFS4A/VmZ8/9dFIyD0mqxfMZnX8S70uBfkXKv/QpnptLsKhvimeTb0qSLE/lFUbBpDh/0mKEAzQN83Qt7pyECVPfisCACmlu0PUb2okxPIMVmWyiOtBpGg+ujt9HX4wuJ9AGjrVMU6X8hYU6YC0UPceLZZ0PMJD0mxqsxdKotPB4O1Py+pJO9yCQizcvsmTfEZelOFywhI4kmeOfK6E7+5jnZ0X7kHO3xGx1TE0zyTthbMlOd2odS1cLtK4kNlJ+1YoKBTECq5AKQ8IOkJ6Iw1kVdIP3rZwQ4wuMPsWLvOcKx+ELtr06APjROfLWv2yyDOgmmM/OXS2ocD5tUPwqGYclvy9VgoAOgsMIYcenrw79vNO+zZS6G+lK3tuyIwX7/KcCDa4oUH+xJ5zP63QMd5l70Wx2ZMDrPYSqA/s7H9Y3pXeu8qOTbf4k+/uoPmWaPy/euZa5d6JRtZ2bgnX6XyYdYiOkkgoDatrLcGi8fRluIJ+qRc9nglKCK3aVR+thJJUfOBb7F/o7UaRb4SC25A8OQerKi6V2JfjNYKw2YLLLj58gU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 12, 2023 at 12:42:18PM -0400, Peter Xu wrote: > TEST_GEN_PROGS and TEST_GEN_FILES are used randomly in the mm/Makefile to > specify programs that need to build. Logically all these binaries should > all fall into TEST_GEN_PROGS. > > Replace those TEST_GEN_FILES with TEST_GEN_PROGS, so that we can reference > all the tests easily later. > > Reviewed-by: David Hildenbrand > Reviewed-by: Mike Rapoport (IBM) > Signed-off-by: Peter Xu > --- > tools/testing/selftests/mm/Makefile | 63 +++++++++++++++-------------- > 1 file changed, 32 insertions(+), 31 deletions(-) > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index 9d9822b4bf24..74988f5adc5f 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -31,35 +31,36 @@ MAKEFLAGS += --no-builtin-rules > > CFLAGS = -Wall -I $(top_srcdir) $(EXTRA_CFLAGS) $(KHDR_INCLUDES) > LDLIBS = -lrt -lpthread > -TEST_GEN_FILES = cow > -TEST_GEN_FILES += compaction_test > -TEST_GEN_FILES += gup_test > -TEST_GEN_FILES += hmm-tests > -TEST_GEN_FILES += hugetlb-madvise > -TEST_GEN_FILES += hugepage-mmap > -TEST_GEN_FILES += hugepage-mremap > -TEST_GEN_FILES += hugepage-shm > -TEST_GEN_FILES += hugepage-vmemmap > -TEST_GEN_FILES += khugepaged > + > +TEST_GEN_PROGS = cow > +TEST_GEN_PROGS += compaction_test > +TEST_GEN_PROGS += gup_test > +TEST_GEN_PROGS += hmm-tests > +TEST_GEN_PROGS += hugetlb-madvise > +TEST_GEN_PROGS += hugepage-mmap > +TEST_GEN_PROGS += hugepage-mremap > +TEST_GEN_PROGS += hugepage-shm > +TEST_GEN_PROGS += hugepage-vmemmap > +TEST_GEN_PROGS += khugepaged > TEST_GEN_PROGS = madv_populate This now results in TEST_GEN_PROGS being set to "cow compaction_test gup_test..." then here that is discarded and we start again from madv_populate meaning none of the prior tests get built. I notice this today when trying to build the gup_test :) I think this should be a += not an = (which made sense before as there were two different variables being assigned then). > -TEST_GEN_FILES += map_fixed_noreplace > -TEST_GEN_FILES += map_hugetlb > -TEST_GEN_FILES += map_populate > -TEST_GEN_FILES += memfd_secret > -TEST_GEN_FILES += migration > +TEST_GEN_PROGS += map_fixed_noreplace > +TEST_GEN_PROGS += map_hugetlb > +TEST_GEN_PROGS += map_populate > +TEST_GEN_PROGS += memfd_secret > +TEST_GEN_PROGS += migration > TEST_GEN_PROGS += mkdirty > -TEST_GEN_FILES += mlock-random-test > -TEST_GEN_FILES += mlock2-tests > -TEST_GEN_FILES += mrelease_test > -TEST_GEN_FILES += mremap_dontunmap > -TEST_GEN_FILES += mremap_test > -TEST_GEN_FILES += on-fault-limit > -TEST_GEN_FILES += thuge-gen > -TEST_GEN_FILES += transhuge-stress > -TEST_GEN_FILES += userfaultfd > +TEST_GEN_PROGS += mlock-random-test > +TEST_GEN_PROGS += mlock2-tests > +TEST_GEN_PROGS += mrelease_test > +TEST_GEN_PROGS += mremap_dontunmap > +TEST_GEN_PROGS += mremap_test > +TEST_GEN_PROGS += on-fault-limit > +TEST_GEN_PROGS += thuge-gen > +TEST_GEN_PROGS += transhuge-stress > +TEST_GEN_PROGS += userfaultfd > TEST_GEN_PROGS += soft-dirty > TEST_GEN_PROGS += split_huge_page_test > -TEST_GEN_FILES += ksm_tests > +TEST_GEN_PROGS += ksm_tests > TEST_GEN_PROGS += ksm_functional_tests > TEST_GEN_PROGS += mdwe_test > > @@ -77,24 +78,24 @@ CFLAGS += -no-pie > endif > > ifeq ($(CAN_BUILD_I386),1) > -TEST_GEN_FILES += $(BINARIES_32) > +TEST_GEN_PROGS += $(BINARIES_32) > endif > > ifeq ($(CAN_BUILD_X86_64),1) > -TEST_GEN_FILES += $(BINARIES_64) > +TEST_GEN_PROGS += $(BINARIES_64) > endif > else > > ifneq (,$(findstring $(MACHINE),ppc64)) > -TEST_GEN_FILES += protection_keys > +TEST_GEN_PROGS += protection_keys > endif > > endif > > ifneq (,$(filter $(MACHINE),arm64 ia64 mips64 parisc64 ppc64 riscv64 s390x sh64 sparc64 x86_64)) > -TEST_GEN_FILES += va_128TBswitch > -TEST_GEN_FILES += virtual_address_range > -TEST_GEN_FILES += write_to_hugetlbfs > +TEST_GEN_PROGS += va_128TBswitch > +TEST_GEN_PROGS += virtual_address_range > +TEST_GEN_PROGS += write_to_hugetlbfs > endif > > TEST_PROGS := run_vmtests.sh > -- > 2.39.1 >