From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A63F8C3DA42 for ; Mon, 8 Jul 2024 12:21:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2564C6B008C; Mon, 8 Jul 2024 08:21:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2066D6B0092; Mon, 8 Jul 2024 08:21:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 058346B0093; Mon, 8 Jul 2024 08:21:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DA6636B008C for ; Mon, 8 Jul 2024 08:21:20 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6ECCC1212CF for ; Mon, 8 Jul 2024 12:21:20 +0000 (UTC) X-FDA: 82316495520.28.75444D9 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf25.hostedemail.com (Postfix) with ESMTP id 18680A001F for ; Mon, 8 Jul 2024 12:21:16 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=lXx8Ujfp; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xAFfcdpI; spf=pass (imf25.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720441262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/5ehi6Nh0tc+9jy6u1JjcuVfvkFscZiO3Qi35yEQM1E=; b=0j1VGYfujPA3ZKsa++Kkdk4Ptr2g9d/5NRSVDBQa4T4YWCC2XWrjRqd1iM/KU9gc98uxVW AOiPURz04gP4xLqich1G0kzgfoPRQBYNUH5IE2mtE/vkiqYAB71jQxF2iJoy2LRfkNJIDj yQ6rNTSdtvrwNuM+vsmypaOziiiE5lk= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=lXx8Ujfp; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xAFfcdpI; spf=pass (imf25.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1720441262; a=rsa-sha256; cv=pass; b=VfrQ+t6zd1LljThyX1mTvJrF5ZoOOxOzGKtWhMCBxQsnrH1q5o3b4mHX3wo98Z8TtydwA2 wgw/AVXg58DqAWR22/Z8rhgoHwA1GFZk91prfP+gONJUoMm3ervn23atKDwBtmChzaH8gx MjLgsOS+hA6k3f4i5y5ante65pOxMzE= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4687fUPM004404; Mon, 8 Jul 2024 12:21:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=/5ehi6Nh0tc+9jy 6u1JjcuVfvkFscZiO3Qi35yEQM1E=; b=lXx8UjfpFiX5WFcVsqU1AyAZZviey9y d49myZGfSutstl4Wh9ianMat6r8vP5HViQjueIszdS400HS7hceAgqj0U8RySdic X19mmGpA2PZOPzT2/dISIPBkn0Qh0aUlrz3kYIvl8LBbiQ9g7UxBLWS0bu2d1dE3 1yxCOdHipw4yIdaHSoeMxxHA54aakaHT6zskwSDKeDMC9scX3bd4k7vC+Px5rRIB qJMkqIv2zxwLh+XGUbK8Owwm1fr7gH9w5xbT5y0MA9ruSvpCaLxSWmxNx/gs7JJI l1PxNSy9k6zE+RO36DQPzGghjDyZETLN2FRAx2ZDr6/CQOJ7Ho7Aq8w== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 406xfsjfys-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Jul 2024 12:21:10 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 468BZwM1014242; Mon, 8 Jul 2024 12:21:09 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 407txfahfh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Jul 2024 12:21:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gvfJiirYsAoJAjB7m7RHMvhsIyy7Fo4M2mkHuo6KgMdE8pcD1i1y8/LZVavE0BTjWLxEPEQAyFpqRAKc0L/bfhp1vgqoUCaJ85CACvi/JYO8MP9mczdyKwOuy5VR2EZD8bPslF8WJjZx8U3WLEZ2UVGwnW+vMo1BPinpzUMFlomAJEwJsm8UdwGn/3rKInSop3OkWgtiDfEXFvMev+UUC9d42lVbnw7E3aB6g/nQxUYXy2UJ0DZYc+c6O3gjQtzl0QWiEiFPh9M23PzGyOqvINoIym04GdAXBKta5340BogpuXXnLikP0EFoE4PZ9Jj1ZQomhcU1R3Imj/SZKkBOOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/5ehi6Nh0tc+9jy6u1JjcuVfvkFscZiO3Qi35yEQM1E=; b=hTCbMKBqLSbUCOz3spxbtiYQuln75Uq1n9kM59kzVcdEJAhoGcSLrF+0JQAQ10jJEjDophaDJC5Bl+r8mfEFMZqX2I843EVFTKXlV3pbvakR5ubU55ukEujtpVmlLh9qhcxPx0E9vLL0mwJ1pRNwFUDayvYkHVUXszxO0m2XTtEebhIBuH037P+Y6SIYq8sZB695KYAJhVOFVM+1yyZd5yOKHdqIQCYzx70DANhJyYDcFl1BPMsXjcl2+OaVqNLScPlVEH7CQQ20kP6lqNOsuDsnfQ9KAjpGTl4hG1YJ8FPR/uqwir+fS5PFFZagMV44uTA/LXLgCfGGIkXTh5/Uyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/5ehi6Nh0tc+9jy6u1JjcuVfvkFscZiO3Qi35yEQM1E=; b=xAFfcdpIZWYP77z5k3V1QnB2u9Hpfw93UwHbtI1QS43Cg0dOQ/dOMVEXYUi5LcEYfpHuDycWAav4BE7lDj+n7LXAZPcRBZSYog1rkPA/9z2PyNl90HywzWy348l/d3l4/nRMfZkJMZQbnWr10H2pami7eXgCuAtV+L2f7jmm/zM= Received: from SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) by CO1PR10MB4417.namprd10.prod.outlook.com (2603:10b6:303:93::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Mon, 8 Jul 2024 12:21:06 +0000 Received: from SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e]) by SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e%6]) with mapi id 15.20.7741.033; Mon, 8 Jul 2024 12:21:06 +0000 Date: Mon, 8 Jul 2024 13:21:01 +0100 From: Lorenzo Stoakes To: "Liam R. Howlett" Cc: linux-mm@kvack.org, Andrew Morton , Suren Baghdasaryan , Vlastimil Babka , Lorenzo Stoakes , Matthew Wilcox , sidhartha.kumar@oracle.com, "Paul E . McKenney" , Bert Karwatzki , Jiri Olsa , linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH v3 14/16] mm/mmap: Use PHYS_PFN in mmap_region() Message-ID: <7a0350b3-ea23-42d4-b2f7-4680d761c969@lucifer.local> References: <20240704182718.2653918-1-Liam.Howlett@oracle.com> <20240704182718.2653918-15-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240704182718.2653918-15-Liam.Howlett@oracle.com> X-ClientProxiedBy: LO4P123CA0115.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::12) To SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5613:EE_|CO1PR10MB4417:EE_ X-MS-Office365-Filtering-Correlation-Id: 7eea2ad5-d041-449b-7cf8-08dc9f4870fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9kloX7cFY9h/hA/+eFOQIGRO8624VHRJgzVDVaPHeqY5DMT1iWzQQbJMsrHk?= =?us-ascii?Q?HbD4dchzEuCb8JzSODu7+8eLsb9xRYbeTUHfRJNeBMcuuy8OnYvz3z3rYXJ7?= =?us-ascii?Q?cy9y9y77xnZJLNORZtFiJrEyNSoGOID/gZcfEjiNKrTnasV1RnDhZsxhge6C?= =?us-ascii?Q?EnLibNDBQSC0k4jpQifRdkvX2nnnqRHyCs+fu59nLyE6gtbKCA+x3qYSEfsj?= =?us-ascii?Q?cV3XKC3GK7lQ10Uw8ZUxC0+C07OFXDx1jvyuH1jb/7i/qNjM9sFiexo8RskO?= =?us-ascii?Q?fzgbcc6SreDkxHgLHVnhsELvbppt/V6s4B8IXP8MBN/SwQBQCm5/6FPyDT/s?= =?us-ascii?Q?bc5L4eK3yhWxTMMeRTneIXOa4kVmcKoJ7key7w9Sp+U1z2PqDan42jLRgSxz?= =?us-ascii?Q?4Xo3Up2d+YJ3RJHaFeWLA00Bj1xxmwsizZhzWYgdmuYat4667FYTIP5QsZOe?= =?us-ascii?Q?xmz0fj4LyrZoisnA74RO5k2RBYJ+MXn9tbJ/Q4Uqc1nUBYyqCUSotwR/QQBk?= =?us-ascii?Q?XXl1ZQKZxTtPbjdv4KeJIKRZM6mxZrkvRC0eFm5P5DOxnN4JsVmOBaI38+hj?= =?us-ascii?Q?q4khEEK1wTGLWVd0pi2Ho7PtgRjmuJ+dI/AAs5rd/QVL1GTpvNNK3sKVgLhf?= =?us-ascii?Q?MPu+LSEGPhVpjQZ2naPZZl4PCgEMjIY3SI2d+25SCVwHzNfBNegt+zRT3O2y?= =?us-ascii?Q?pT3Nh7WNTWPZGaeZmyIopubg3XXVLp9hHWeOKpU9JGWn1EbTwAa/ELNW0udA?= =?us-ascii?Q?HS0gxwlxensgig53pfCBJrTsVOK40gJehiRVaF7N0ySFHo7klhpXmQGN+pz4?= =?us-ascii?Q?nCTm+GGY+vj1T6MEj+vuWUkXG2TwDcqMg/WTqgrn+tsnf08JKzN1UkoYGg8m?= =?us-ascii?Q?1wn+8NfMhylzzGB9CILRI/OupnkRz5GdKH+Q2kdfxr0malLRZ5EhYyz8X9x0?= =?us-ascii?Q?u/xfFS2mNknS6AAfUF3FcvRHOtXN+L1rSepPwkA2cFkFGBviE1J7TGv8qk9a?= =?us-ascii?Q?yPMG8hS+QPDgvqglA+Tcmm97Z35AEUWTRaHCEC9v32zB13VII47TRFe0CTbh?= =?us-ascii?Q?PUgYP15DSsgtkX/E+4evh2ovuBbawL/71rjawWZdmzEb9eDPzKop5rRP9dLv?= =?us-ascii?Q?IIdflY7YdrEPSZepsTh4vvgWbft81jnVt0EvmQv3MfWvlKIDIMLEgy+8uuUy?= =?us-ascii?Q?I2vd8sf+sR+dht+cYH2du9kC6d+wBlRtsMs1qw7M9vJKHdDStOKSaDzKpGj/?= =?us-ascii?Q?2Knux3P5DwKvcoaYiWlaVMSaD/S6shqRBWHzHkqYTLRIHxvngtoWAcIH2fkw?= =?us-ascii?Q?EPXlUVYdNKvKHeUGGrSBGxYQIodxGMOF8Mruw4DLnQQ93Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB5613.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TcJ8CYz6ow7THVMhGemqgiywOKET2SNYYdBwkOGA9PIzs1092x4EnAyT6K05?= =?us-ascii?Q?IZeUebT+X/BhmW8env/0sYfhc9W2uuq+xFS95x4DaNuly8SHbgqys1S723Gg?= =?us-ascii?Q?fDsD+IrOnZs/6OmXZfF9Yn0A8SfPhEQYm8BQA7QfRplx9LRrLwzEgoCD2tb2?= =?us-ascii?Q?DHt9p8HICAd+PZbeC0nfpRZnlBiXgolaqZBRQrP/xDsS55UBKEVQoxXNmw9y?= =?us-ascii?Q?LSURpPvrV1s5AMif6QC6K/3HryedG3LA0E4fqowJGwmH98ZKmrUe2n+jIwm3?= =?us-ascii?Q?ZEnNLxFXJVFEu6gwgwJl3ycAeZVOZjzdanmMdUK5/+NLbTLu0/H/j+vu8cbT?= =?us-ascii?Q?6BcuRlDuvmWQJz39tMCc7lozmuBwRV15IUJf/Np5matej9dAVSSqHAn+knia?= =?us-ascii?Q?ognG3r7ZuLYp9Z58I6JSvdkbeQ4nUoZI7MVq7qkhbUAE/6QMehBlf9v/5CnM?= =?us-ascii?Q?YVy3mrUnvdcioD+MEVxOPHJG0C2Y/0dtBNMeotUzPrSK+uzJV7d/9cYNo95G?= =?us-ascii?Q?ChG0T7tpMoICMn9wjBJ5zyjBNL9VUHkegbHvDPblVU48XgcLSH5L8RGv8HrC?= =?us-ascii?Q?Vvaq5zXYqpPd3TaVvfD2jyIDmGs0I3XNywyyWoSWxRvEviAxzzqris9fRR8B?= =?us-ascii?Q?WJCLwIs79D5KznzDyzkyuLJeQKNISRVctIRYH66iOCh+yAmvFVw9dlmOvIBZ?= =?us-ascii?Q?4K8Yn1osXCBzOw+7AnXyk+Z5J4kY/pnlqCW1mAki9I0NAKvwOea+zDbsVSSr?= =?us-ascii?Q?17NZ/GAypbl7GhKhK49kdMa2QWKA+BFPlmYhZz1p3NQyekDKfgVLizpNmeko?= =?us-ascii?Q?ZkR6a5BC33lsCpG6zhWmiS69WIyQQmci4OIKf+CSrZ1UUPiIsRQuMzcq1XYx?= =?us-ascii?Q?vp0zTZRimyOO0k6vrp5+mbT9MoPT1e2XZvRwFlXqHlLW+tsH8cHcHpkYm6Cq?= =?us-ascii?Q?GvqIr/xAJ/kJRc477H9vNjyNYRJ2/FRYgfLSDrqkVNPrv9Aqh7D2neXpxijC?= =?us-ascii?Q?xyP0WyweeabVtXJAAOiwPhTfyKRr5sTvqXGrr66N/YtOB3+KPbbdKYcJayJz?= =?us-ascii?Q?rlBTBJfYB4pJQGYtD5FyWILq+5u70Oc0QdRtL5AQkjbYe6M3Co0tf9i78BC8?= =?us-ascii?Q?RVhAeHYFTwyx/LMCigsXXGEpOG1e5aiKQHqpHCY6dTA7FQDoXFYYVXZr1JmU?= =?us-ascii?Q?g/2cSc+c4S7rQDzPHqlOPXJQ33H7CRoDQ/4Grng6Zsja3r1W3vyScPj6y8oS?= =?us-ascii?Q?4roXpA5i2goNpPaQXkOIwjKFfxUGT5xpG6Nkgl9UEy7Hu4ap67fwZVXsR5oM?= =?us-ascii?Q?RlsUSFtD+s3gspljhiofP9/dI/utTUe9zNaZfwbbc76mY1EL2bA80YQzUeKE?= =?us-ascii?Q?A8Z3RE8ToQvdXEj/pkKU1UaA916i+gDn4DU3l8SpSCsTJx1BwvBVlnpSY91t?= =?us-ascii?Q?hoPf8Uyv9kuxmW40+CsCMPha/jedZHV9esZ9GnEbxVsD3L/YelyNPo3DRGYN?= =?us-ascii?Q?GOA2GcVbwpM6uOHmV9qtFfX208IaS+/jHSmJOS8flKc0SYbe50yHrymeXq20?= =?us-ascii?Q?vw8Iesdg10+D/k2PJJdpQWiswc9nJMFiOhjIduoUSRgfH4M4leMUiuONyWKm?= =?us-ascii?Q?qw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: vB/LJ4CsRvO7P/3x01WljNtsy8Jq/QvYkkIpIeGu1m7yM37FfrsAfj6quqvBfW2nQBKfs0fJjf/tsn9o7rB5LcIVVgif1cFtlO5EiZHPBhsiRQOuGjGfiYfVMHpNB2gtG/daBrB+LV3uraQiQOua15YCOgj6vlRZ3iUisY28UqYm4XDPoeivM9+Y77i6wEstPl4hlgXRum41bj6791dR7gnRZlAKs/kIBWbxcJNFhbi+de7H/6ucao1nAu0T1zhBtZ0sNiYTrihg46SbFZDRwgzu0Gu4idokQ7PiWQK4c0eu5M4Y5bWtG+MaeW6I9hF/QlwUaa/bG/T4RUBElOnNGWIji2vTmQZw6pS9Ti8jHsi5PEtsEPi7CxbRo/DecsNI+GEt6rXWaJO5JFoXpH82BVaQAurVLtCbE4ZdPq8fObmhUNk57HpK+ZcEsogTGLNugrxy1ZO/0n07iQ05DwEhunXO/zOCk7L+FdKz8MSIekerypbISRRWzNjXiyD27nDoqdghGjCOTPcqJq0aEhh0fvndqP1GMHelIwzlQ0t8QgBZJBzOA8OkhNibG2bsXWrM9TAQMwvdO3hEHqy/AwZ+HA9PQAn+tMB1bn7FKlPjxqU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7eea2ad5-d041-449b-7cf8-08dc9f4870fc X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5613.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2024 12:21:06.2563 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rzscyg4QeUsCSc+13lBk/LkPAHB/XmZE7k38EwvStIc+fODMvLrCeke39dfoMTTfMSsrqRZ1jNyH5r5swD1bHFZAPP5pAv0scjCZ6QSGFYk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4417 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-08_07,2024-07-05_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2406180000 definitions=main-2407080095 X-Proofpoint-ORIG-GUID: iDK_czWnIaEPq2ZYq0YUjJb0H_xLlCoc X-Proofpoint-GUID: iDK_czWnIaEPq2ZYq0YUjJb0H_xLlCoc X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 18680A001F X-Stat-Signature: jrjn9hba4s8kh55tr37jcjtmxc6m7xu3 X-HE-Tag: 1720441276-310747 X-HE-Meta: U2FsdGVkX1/JzTmFWJtI1FiZnztPeiv7of/qakvJVa9cCXrEnnYy2qDLy1qgzgZoIaE2dWyCV7YkKk0dOJv5J8aGL7Sa2dEaAFTeoNtOysNo6qhE0phhNFtW0mRMd8DIZzhzS+XUonWpm9YDEStK5qcNfp5y2vq1WAf7ieVC7br5D6C8Rs/fN4+XB+lKaECmR0NSIVcY4LN+YxrwcXYxc3XHRh5ForXwPfRfc5LgmqwZl5Y+t2bhTpJNpBi+/tH/dpJSb7K+JuhN/B5IUVb412HyX0IEV3ckyYMpyEUXLSM8/V+is7VKU2a6gN+cDRFSO9m0SrFkW+QKVzzjmWshqKWk2DLgS2Bqg8LJVKHxQ8dxDoxTy09mr3SVnwPj1gs0jm6jcKu60p1S4MON7AtO5ohRYqG1TcNtlBCahAc5QDjR1zyuks/qC2keT5bPOaBGnb4VUL4Pwn9uVAX+bSNgF9clnlYlbViUf/Kl8NNOi1QVvxYs5TYYb7reLGLM3bZs34c5J2wSib18hxqqEShVEqckTZbOuAGn7uhV6CxGEA7b+MSpKcOT0nDEpT+MFVFqevYgRWUnOgYbWfGdSF4o0GfwGTiWaaEgXWYzgY1si1WtzA+RmKxL8X3tpYBRrnQMQ/XfJYJU2OyAihImgHwE7a7kMyh9DIYzH+Qh0q2rRdzfWkwla5tcQ0BsPquSJyrYGzDU7N9oXco5nOffBstvGtLkwvTH0SRyZnNjBm+T+gHjSQxYWOyiQyIr2WvJORONjrRL0eaC+o14iQ3evwzf1ZrQxPoN6v19i7eWQYghuOO8DpI4gNzbDGhP3P7VJ6/4mCBBm0GQWkd6Ld2BnSz9X9Z04TSbJ20BwhjNjlK9vfp55azxOGr7x7UksJFjO+niYVnKaF28P+V/OpR7eD4YdlWm4HmLdrNrSpK7XaJAh0XjJy+9v4lONd1WepH7mD2ngyFHwl18qEJ81SrAHdJ DjRjk89q njU7XraxJkS5qN7iLUX2NbN/WTFRE0T4nF75sSRZgzrdT63wpYErYluc3y19MsDRfVm8ubp2RFao98vc4KfIdKUM9QXd57n/PirSceL7KVwwhuo8ONHo02i8K5+wHsq1zChZUXzPTn7U+mlCNKous8JRYUarhcMsoNiCoIZTe6z40NUaoIFLWkZcpu6jUaqkt3HKJ1RP4pleKfPxzRaRmGCEEfbtw2sKmRWj9VgGYR8/pQVmVNlC3CqWTUZ4n+tZqM6IMmsP6m9WEUSOetIkiNpG9Y2IYHNqkZvl30MueIZbO1pFMbD6f2ilA9Oc7HkHd0wwU1AcZpNNnZf0oXFyZiLlhK648kHLo9Ly9BXHwRZwR+Jp0BhdRJq69BJG8VzyfHo+aMYOYon8IUqC6EuxZMfDU3jzna0eqKjeLpD+HoTMkAVwxcMet0v+TfCwnOx42nyga3dsJE48hFqW/05e2VeoPR6dkjx7NfMPioRmazDkFoNMtK7eKYzwz4bDECeD0aNGcyyV3J8VbG6AsvPNanD3obto8VKe44MzdMxn/JjIRjhgsMUEHYTLcGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 02:27:16PM GMT, Liam R. Howlett wrote: > From: "Liam R. Howlett" > > Instead of shifting the length by PAGE_SIZE, use PHYS_PFN. Also use the > existing local variable everywhere instead of some of the time. > > Signed-off-by: Liam R. Howlett > --- > mm/mmap.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 0c334eeae8cd..b14da6bd257f 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -2935,7 +2935,7 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > struct mm_struct *mm = current->mm; > struct vm_area_struct *vma = NULL; > struct vm_area_struct *next, *prev, *merge; > - pgoff_t pglen = len >> PAGE_SHIFT; > + pgoff_t pglen = PHYS_PFN(len); > unsigned long charged = 0; > struct vma_munmap_struct vms; > struct ma_state mas_detach; > @@ -2955,7 +2955,7 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > * MAP_FIXED may remove pages of mappings that intersects with requested > * mapping. Account for the pages it would unmap. > */ > - if (!may_expand_vm(mm, vm_flags, (len >> PAGE_SHIFT) - nr_pages)) > + if (!may_expand_vm(mm, vm_flags, pglen - nr_pages)) > return -ENOMEM; > > if (unlikely(!can_modify_mm(mm, addr, end))) > @@ -2990,7 +2990,7 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > * Private writable mapping: check memory availability > */ > if (accountable_mapping(file, vm_flags)) { > - charged = len >> PAGE_SHIFT; > + charged = pglen; > charged -= nr_accounted; > if (security_vm_enough_memory_mm(mm, charged)) > goto abort_munmap; > @@ -3149,14 +3149,14 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > if (vms.nr_pages) > vms_complete_munmap_vmas(&vms, &mas_detach); > > - vm_stat_account(mm, vm_flags, len >> PAGE_SHIFT); > + vm_stat_account(mm, vm_flags, pglen); > if (vm_flags & VM_LOCKED) { > if ((vm_flags & VM_SPECIAL) || vma_is_dax(vma) || > is_vm_hugetlb_page(vma) || > vma == get_gate_vma(current->mm)) > vm_flags_clear(vma, VM_LOCKED_MASK); > else > - mm->locked_vm += (len >> PAGE_SHIFT); > + mm->locked_vm += pglen; > } > > if (file) > -- > 2.43.0 > Maybe I should literally look ahead before making comments :)) thanks for reading my mind and doing what I asked though! ;) However I don't think you've fixed the duplication of PHYS_PFN(vm_end - vm_start) in count_vma_pages_range() - still worth doing I think. Reviewed-by: Lorenzo Stoakes