From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88118CD5BAE for ; Thu, 5 Sep 2024 12:21:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19CB36B00E1; Thu, 5 Sep 2024 08:21:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 149A96B00E3; Thu, 5 Sep 2024 08:21:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2C9D6B00E9; Thu, 5 Sep 2024 08:21:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D30056B00E1 for ; Thu, 5 Sep 2024 08:21:20 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7AF8E81BF9 for ; Thu, 5 Sep 2024 12:21:20 +0000 (UTC) X-FDA: 82530594720.19.4578296 Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf21.hostedemail.com (Postfix) with ESMTP id 8EE0E1C001D for ; Thu, 5 Sep 2024 12:21:18 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qn2XqsEe; spf=pass (imf21.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725538783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RG+B9RQMt9wqZwEFGQtC9HihmbtSol0+CD88scwrr1g=; b=OX6F9IWnXav5WX8csQYKE2kb8ZTLC1oTmtuf/iKaj/yRCHQCwcQJv6UdrahKhcmlGca0H6 /Yc4i5ieTtMiaB4ZLqkRgp92U3EHc3K5zInQI4hEpBOp0wNUxSNU8545qjzGeIjmWV6Oub CCMd8NrGaJ1tNimkmLGopTrDTS22ZWk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725538783; a=rsa-sha256; cv=none; b=GAsiPYo/pXRkU5cPu27Hb0sBhDDVlxO1msIm/QikW0uFv3cW4rK8jPq4mzmFLvaVRkI5Gm HdysM60G6YCWOyO27sZLIn91VrLoFb+hZ4tBcpgVjlRebsOtGav60pysROAVgPSIunPSSz bA/ejdqrwY2cVHuzHy6m0L32UeLY4/A= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qn2XqsEe; spf=pass (imf21.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725538876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RG+B9RQMt9wqZwEFGQtC9HihmbtSol0+CD88scwrr1g=; b=qn2XqsEevTtNsm0C0CHtnQmRNmZ+AVm0hM6Uy5e3u/BOaVmtKVjJpC/c0EPxHY7wdVSgju 4dwEvwrBRPQycogduv5yry7QUbkmrGoUawtvZQ+t0uqSe0k35+sSKbVAwOxBxyj3bIsXqz qtdbnn5qyiTt19S2z5SyP1ZsF5TaLO4= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: [PATCH v3 11/14] mm: userfaultfd: move_pages_pte() use pte_offset_map_rw_nolock() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240904084022.32728-12-zhengqi.arch@bytedance.com> Date: Thu, 5 Sep 2024 20:20:30 +0800 Cc: David Hildenbrand , Hugh Dickins , Matthew Wilcox , "Vlastimil Babka (SUSE)" , Andrew Morton , Mike Rapoport , Vishal Moola , Peter Xu , Ryan Roberts , christophe.leroy2@cs-soprasteria.com, LKML , Linux Memory Management List , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Message-Id: <7FEBE447-2635-4BA9-83F1-89A3F0CB3BD6@linux.dev> References: <20240904084022.32728-1-zhengqi.arch@bytedance.com> <20240904084022.32728-12-zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 8EE0E1C001D X-Stat-Signature: 6acf87bxjtr7npi1fi3gnqwdj88w4op1 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725538878-853271 X-HE-Meta: U2FsdGVkX18AmJD1meDL5w+hrGlOsMQTbwK8lKzpLpIWOigXnrSOWNkMWzEYFW/44hvJqolUYQ2rUJEZgE+gj3To+f+JBaDhJqrGnOq8s77hofP/hb+udKG2vh8a53fvh6LJ3gqFKwV1AWQ7lbF5cT+ubGJwT9kkvV4UjKZssYeQV+Nkdmqnggmpel2RCazfaggW4Ew3LXaN21T4cCLkicoaprqGwenfpZhJVW0O5hS/KHGQftlLKVIYxRV43W4hwZ/BCewAAM5kUC+qAnRz+p2P3b7/jCZv2wNq2+jTdgqcc3vQYIuLfkj766sBC3Dks557DNf7/Yq2AZGONVBG5vFwfYkdGapkYULexdGiio7zsCEUFKh2QisWAQGoc5jIFE61eApSLQhDUVo8JBtT1QQnCYMeMDf8kFvTU487W44KSnbUK5kkRXtPMOQt+uZKdU8TmJppkCD3VnhZr+mfzN1wxf64f7YVBxfpx0eWVI5ujn7/Y8qznw/HTV3lCImyISqQbOwjP2JBFubCsE1ywsyuxMiXL266Ap53vM5xhCduBqDmky1ykANb8xsvG5kLbDlaJEby2IJfVAr5uzK+n5qCwgoVcUyFpi3/qvudfI5qODrl5QvXzUap4vUbvY1mi5Ut43IkNaKpT8ko5FsTTCv3JFDEBwrzDLi8W37RrSihIwzdu7ecfYTYduAfvBU80oeBZVUtCdsKnXYkGPIrDaw0kpdrXLrm0hMFSaZj5TjSKhsuS/4e9gpBCpp2nLzwG+942FjXTmqgS0lnFCjEaz4BFQVZ9JJ/z4vvcFVG4R+WHPEW4Nwd5Swg0WEiQaE+KpFiRhGnb7FL4A7I5duEauVScQaA6o/QcAYFReca/vMf9VlRYT3TR0lQruc6H3D8QelRKT2HOH+h434GCsadcd5FZqKGr7QOg32OADkDKsS0LT+orJVej4PzKJZ4l3vk4Yw+5tHC8iNbwWmGG4H VHve6h8K qwSkkLBtYAZXQ2szDYqDdUFnBS3tGHGR5ERtQsz36vNpRA7mVmc1jDaFAmAaB0WTq7G+vgP9Fm7g76KZnSLqBrEbbYjaZXFmuKUKZ4q4iOpYPqplmWRqvWbrpNDA9vsqJZcvbIm5XB5NnLCK7lSl6rkXV1BhiNCmvoEorYr5mN6R9kycJx9dYxenDiauLS1Sw5eO2Sbd7DrpNPpTxjrJeZLXmHhYsyZF9sthMdWE+ZU5MGYPN7V+j6+r+++fruuOWkBXfvuzcgpQzIC8Fkx6UvN00UDMC+90gw6+ILjcdAGn8iqd7umIkvVmk+UL4Xwut1mBEdOXXFSCK2q7TBGpvAgf0hjIvBUn4xauq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Sep 4, 2024, at 16:40, Qi Zheng wrote: > > In move_pages_pte(), we may modify the dst_pte and src_pte after acquiring > the ptl, so convert it to using pte_offset_map_rw_nolock(). But since we > already do the pte_same() check, there is no need to get pmdval to do > pmd_same() check, just pass a dummy variable to it. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Thanks.