From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE89AC4CED1 for ; Thu, 3 Oct 2019 09:05:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9DB7621783 for ; Thu, 3 Oct 2019 09:05:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="rQGq/Gkg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DB7621783 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3AC636B0007; Thu, 3 Oct 2019 05:05:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 335466B0008; Thu, 3 Oct 2019 05:05:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D6728E0003; Thu, 3 Oct 2019 05:05:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id E7E8D6B0006 for ; Thu, 3 Oct 2019 05:05:52 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 8072F483C for ; Thu, 3 Oct 2019 09:05:52 +0000 (UTC) X-FDA: 76001890944.24.coil86_50548f2b5de2c X-HE-Tag: coil86_50548f2b5de2c X-Filterd-Recvd-Size: 4977 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Oct 2019 09:05:51 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id u22so2486188qtq.13 for ; Thu, 03 Oct 2019 02:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=xWvjAJ+vmNMIpeEImL3eN8FbY3mh5BNsK1umkA/yuKA=; b=rQGq/GkgmPP0jTIUHjSC8C6/MU5ReIqGZzuX/UwCB/QPQrP0NRhll8Im3UdtgnegtL nQCUgQGybFYiMBt339er7ABesjSSw3Aehfcp3Xbud3/76ur/paF9kV3/z3aMv/M7WMhO yb+Uq+HZg8zXNIZJbBPO9ZmOrRFUv/9WtbWa6rf8GS2ubKrfn3lEM6Kp+6kiss9xexPw pK33gME4N3znz2EKdbkfEKDndziRVplRPIfDcJPi0fbGdzCnLLqKooB7jaiF5DC0MSRT bfrW29fGQtLDBCIaewDCpiPWg+FM82o80P2EdaeWdf0KsBKGFpxaFqJKmyeuN1e656F0 QAgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=xWvjAJ+vmNMIpeEImL3eN8FbY3mh5BNsK1umkA/yuKA=; b=rdU3uAhC8asNoKVtP3eq8IHh6DT9QrFLmub9rS1inKcokwFRxxbc3Csvb+Ots3EXCM gg+CsZEdK1RFFOnXqBLwZcxyVlstfPQgad/2+3zDURwdaR2gnN8jB8Rs5Mca3qiZr2yZ 0X7QyHfAxbqnC075ER6DzzgRHlYqIP/ZGmOsmzLnQBJxE0NIUaj1LsaRICvs2tSceoFP KN1ZBU/fNiQ7yXuxjuqKetK/9Iqgch6v55yUqgWpg7+Q0RCrKgDnxwMw2EOE9AgDLrOt sIhcAiRqIvpvbnUS2BHrftrJbjyOMLhITCus0erMhgPhi7/Ll65r29nUZICDmdYE54kh 9Lzw== X-Gm-Message-State: APjAAAX1YYrgU7qLK8wYpg78QvMYFRgWOMhIHKVQvP1sZ2NSzdMzdwUX 49xwCyNSkYBjxOB705H+PAPUjQ== X-Google-Smtp-Source: APXvYqx/K/TFKFb3HVfCLhcINgoNzkLVvgCx7hmM1H+WyJUczpaRihtkRlTjXZCGlfeUHw9JREKM0Q== X-Received: by 2002:ac8:4304:: with SMTP id z4mr8649614qtm.160.1570093551315; Thu, 03 Oct 2019 02:05:51 -0700 (PDT) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id c20sm829041qkm.11.2019.10.03.02.05.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2019 02:05:50 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages() Date: Thu, 3 Oct 2019 05:05:50 -0400 Message-Id: <7FA7CBE1-E0A9-40E2-B3CA-0896F6D491E5@lca.pw> References: <1570090257-25001-1-git-send-email-anshuman.khandual@arm.com> Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Vlastimil Babka , Oscar Salvador , Mel Gorman , Mike Rapoport , Dan Williams , Pavel Tatashin , linux-kernel@vger.kernel.org In-Reply-To: <1570090257-25001-1-git-send-email-anshuman.khandual@arm.com> To: Anshuman Khandual X-Mailer: iPhone Mail (17A844) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Oct 3, 2019, at 4:10 AM, Anshuman Khandual w= rote: >=20 > Having unmovable pages on a given pageblock should be reported correctly > when required with REPORT_FAILURE flag. But there can be a scenario where a= > reserved page in the page block will get reported as a generic "unmovable"= > reason code. Instead this should be changed to a more appropriate reason > code like "Reserved page". Isn=E2=80=99t this redundant as it dumps the flags in dump_page() anyway? >=20 > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Vlastimil Babka > Cc: Oscar Salvador > Cc: Mel Gorman > Cc: Mike Rapoport > Cc: Dan Williams > Cc: Pavel Tatashin > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > mm/page_alloc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 15c2050c629b..fbf93ea119d2 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -8206,8 +8206,10 @@ bool has_unmovable_pages(struct zone *zone, struct p= age *page, int count, >=20 > page =3D pfn_to_page(check); >=20 > - if (PageReserved(page)) > + if (PageReserved(page)) { > + reason =3D "Reserved page"; > goto unmovable; > + } >=20 > /* > * If the zone is movable and we have ruled out all reserved > --=20 > 2.20.1 >=20