From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 039E7C2D0F9 for ; Tue, 12 May 2020 20:07:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BB2BD20753 for ; Tue, 12 May 2020 20:07:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=amacapital-net.20150623.gappssmtp.com header.i=@amacapital-net.20150623.gappssmtp.com header.b="H5iBBvNa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB2BD20753 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amacapital.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 457AC9000F1; Tue, 12 May 2020 16:07:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40907900036; Tue, 12 May 2020 16:07:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 344849000F1; Tue, 12 May 2020 16:07:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 1E41C900036 for ; Tue, 12 May 2020 16:07:54 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DA4C249961F for ; Tue, 12 May 2020 20:07:53 +0000 (UTC) X-FDA: 76809152826.08.chair84_ab33a4657741 X-HE-Tag: chair84_ab33a4657741 X-Filterd-Recvd-Size: 4976 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 May 2020 20:07:53 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id j21so6674717pgb.7 for ; Tue, 12 May 2020 13:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amacapital-net.20150623.gappssmtp.com; s=20150623; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=rhtiEIBdzrHkDBisACwiSoBSZLTSxhAWeD0kG6AJCFU=; b=H5iBBvNakTJBq65S0nZntk6pa2kBI14r+JX5VeLNl0q/aSIb/oOQ5cr3B5ryhwWmRJ Qv5/d2wU1pzVzv+HpZXfwy4Il/mtIWoxr8hE6LRJ+3uD13CSwrYAQmP3CST8spjPid1g DbEQl/LlxgyBbFP2WkWeDCbufGZoDefL3Lgrh7iOORUEnZ1MWFSxG0WIYT8ZbZrDRRNM 24SAphwjXWQjnh72iqX+TLs4r9HVZe2WEXV9145cVwrnl5mSmCzFTDOe9o6QDbmSzE0R gc6C1T6ILCw0YUviirEtZPUWm3Ey/XSn9yVSH4YZGqM/2TV+ylRvb8iwgkEctkcbcmoa Cj/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=rhtiEIBdzrHkDBisACwiSoBSZLTSxhAWeD0kG6AJCFU=; b=TCwKx4ghytsgQMyAwgBjAFjvGxmTL3EQ1IGtLvNYGGmD8ZDps62uEvN0AlPa5n5DFR ukfWqVyhp4uNGN4FO4EsZ9fPUTO+zsth7t8djmPlswjoLqf7xAO/+kp7EZ84+aFUNVNG GxkzOJzLcc2c/r0hAKDF7d5VlYzWx9tDgELOWH4wL1y3bIgev+hYrwHVwn2Iva/3jDdj dFz9AZgUZqdl9XRF1fkeRZivfASSmtLtA4qsqWU3V9YPNiRiqn3Y/LLREzV24Ap4Ipn4 U8sL4mPh0unhJaLSc0r6oDZ6gCayh1RRR4aTaLsbmwCx+qMwFXuyon+cNy/y7O45KHkI /P9A== X-Gm-Message-State: AOAM531VjEhRzdHnFr8Z9+1V49swF+wk0jUaIemYb9S9Ao+h0WV3PtMn dW4bLP0uT7393vYCxK0oHc82Zw== X-Google-Smtp-Source: ABdhPJwYVudVGNEQY4Il1qQDZHj/08latFnDIYDe8ER9Rqo1bss5a2rLcmgYlaAvcJbIK4Yv5CGZ9g== X-Received: by 2002:a63:c04a:: with SMTP id z10mr8395941pgi.430.1589314072335; Tue, 12 May 2020 13:07:52 -0700 (PDT) Received: from ?IPv6:2601:646:c200:1ef2:a93f:12ed:b744:bd73? ([2601:646:c200:1ef2:a93f:12ed:b744:bd73]) by smtp.gmail.com with ESMTPSA id x132sm12819152pfc.57.2020.05.12.13.07.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2020 13:07:51 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Andy Lutomirski Mime-Version: 1.0 (1.0) Subject: Re: [RFC v4][PATCH part-1 0/7] ASI - Part I (ASI Infrastructure and PTI) Date: Tue, 12 May 2020 13:07:28 -0700 Message-Id: <7F322031-034E-4B36-A60F-663EAA4C99C9@amacapital.net> References: Cc: Alexandre Chartre , rkrcmar@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, konrad.wilk@oracle.com, jan.setjeeilers@oracle.com, liran.alon@oracle.com, junaids@google.com, graf@amazon.de, rppt@linux.vnet.ibm.com, kuzuno@gmail.com, mgross@linux.intel.com In-Reply-To: To: Dave Hansen X-Mailer: iPhone Mail (17E262) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On May 12, 2020, at 10:45 AM, Dave Hansen wrote: >=20 > =EF=BB=BFOn 5/4/20 7:49 AM, Alexandre Chartre wrote: >> This version 4 of the kernel Address Space Isolation (ASI) RFC. I have >> broken it down into three distinct parts: >>=20 >> - Part I: ASI Infrastructure and PTI (this part) >> - Part II: Decorated Page-Table >> - Part III: ASI Test Driver and CLI >>=20 >> Part I is similar to RFCv3 [3] with some small bug fixes. Parts II and II= I >> extend the initial patchset: part II introduces decorated page-table in >> order to provide convenient page-table management functions, and part III= >> provides a driver and CLI for testing ASI (using parts I and II). >=20 > These look interesting. I haven't found any holes in your methods, > although the interrupt depth tracking worries me a bit. I tried and > failed to do a similar thing with PTI in the NMI path, but you might > have just bested me there. :) >=20 > It's very interesting that you've been able to implement PTI underneath > all of this, and the "test driver" is really entertaining! >=20 > That said, this is working in some of the nastiest corners of the x86 > code and this is going to take quite an investment to get reviewed. I'm > not *quite* sure it's all worth it. >=20 > So, this isn't being ignored, I'm just not quite sure what to do with > it, yet. I=E2=80=99m going to wait until the dust settles on tglx=E2=80=99s big entry= rework before I look at this.=