From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA0E9C433DB for ; Fri, 15 Jan 2021 02:19:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0A22023AC0 for ; Fri, 15 Jan 2021 02:19:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A22023AC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 039DE8D0138; Thu, 14 Jan 2021 21:19:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2C3B8D00F0; Thu, 14 Jan 2021 21:19:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E69328D0138; Thu, 14 Jan 2021 21:19:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id D1D248D00F0 for ; Thu, 14 Jan 2021 21:19:57 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 94769363B for ; Fri, 15 Jan 2021 02:19:57 +0000 (UTC) X-FDA: 77706404034.14.elbow13_2803fbe2752b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 73D9018229818 for ; Fri, 15 Jan 2021 02:19:57 +0000 (UTC) X-HE-Tag: elbow13_2803fbe2752b X-Filterd-Recvd-Size: 4620 Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 02:19:56 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 14 Jan 2021 18:19:55 -0800 Received: from [10.2.57.75] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 15 Jan 2021 02:19:54 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" CC: Andrew Morton , Subject: Re: [PATCH] mm/debug: Improve memcg debugging Date: Thu, 14 Jan 2021 21:19:52 -0500 X-Mailer: MailMate (1.14r5757) Message-ID: <7E6A4334-D1D0-4FBC-93EE-185B7A87992D@nvidia.com> In-Reply-To: <20210114190200.1894484-1-willy@infradead.org> References: <20210114190200.1894484-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_MailMate_D7018CB2-AC18-41ED-BCA2-45A454C1D987_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1610677195; bh=/v7lGSo/3cK8h4EyzaVBndRzxtnnAfQVJaux+ZPMSkU=; h=From:To:CC:Subject:Date:X-Mailer:Message-ID:In-Reply-To: References:MIME-Version:Content-Type:X-Originating-IP: X-ClientProxiedBy; b=A0jABQvULqNiPkjdpiwmCptdJa8mItJbrjq/Mn+zzbaYuIBHengDZLobiASwfwRUN QvcRnzBwjP0a3fxFqOed5otllystjmph3G1TZt8mqXZSoIb2r1/5+7ulyCKyZ78fIv uG5euhwd/9J76347PJ4xtz5Uen8U9ZTrgjgZ3CyA9fDBs50QKgiL43Wo7a6RR+Vp8V gPLENG88spqyPKzx9ry7SBZ61rNKB3bNoUrUWsTEyaBWG6HxONUbCp2SDHKUMLmHkA poRVNkv5FdqIavhylcddfEOUl6DNdhouDTLtXm4X+X2jb6P/SHXs0qnrRzPZ+LYlW3 xZcw1VIWO9muQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=_MailMate_D7018CB2-AC18-41ED-BCA2-45A454C1D987_= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 14 Jan 2021, at 14:02, Matthew Wilcox (Oracle) wrote: > The memcg_data is only valid on the head page, not the tail pages. > Change the format and location of the printout within the dump to > match the other parts of struct page better. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/debug.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/debug.c b/mm/debug.c > index 8a40b3fefbeb..0bdda8407f71 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -110,6 +110,11 @@ void __dump_page(struct page *page, const char *re= ason) > head_compound_mapcount(head)); > } > } > + > +#ifdef CONFIG_MEMCG > + if (head->memcg_data) > + pr_warn("memcg:%lx\n", head->memcg_data); > +#endif > if (PageKsm(page)) > type =3D "ksm "; > else if (PageAnon(page)) > @@ -180,11 +185,6 @@ void __dump_page(struct page *page, const char *re= ason) > > if (reason) > pr_warn("page dumped because: %s\n", reason); > - > -#ifdef CONFIG_MEMCG > - if (!page_poisoned && page->memcg_data) > - pr_warn("pages's memcg:%lx\n", page->memcg_data); > -#endif > } > > void dump_page(struct page *page, const char *reason) > -- = > 2.29.2 LGTM. Reviewed-by: Zi Yan =E2=80=94 Best Regards, Yan Zi --=_MailMate_D7018CB2-AC18-41ED-BCA2-45A454C1D987_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJCBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmAA+8gPHHppeUBudmlk aWEuY29tAAoJEJ2yUfNrYfqKURMP+I/tAHLuAx/Tr2kmHDvx2I9slkzsP8z5wBUR wwGsAyPKEwe2fFEH3iupRRqAUWL82+kiQhf+F+5AR9V6pIIyQgKqAC37kCnZ+vHN luYL6tpfhK300atmTeMa0OWLJ1RHZ/zgNTaVC5b9eDwlS313X23no0X6AViYr5Tg 7dLJdnqBm+rB7Zmvticl8QgDtTB+vUNPZas7oEPnZyWnCqj3BicNexa6VDDxRq5v UTJvLs1Nl7eY8E0m4j7zG9pIO8VpfOAmn7Q8LvPoI/rej4jl68aYo8we9Xtth3Ev ILUqk87TQ+aOcJpVKSBHFQm4MFUEKtwcdPDpuyb1KgAZu1Z0m8Wcy0Vw6wAc5zeP FoVL+zxp1eO/+vzKUhay39hMXNUqnMIJBROyV2wQrEHrPPG7IBvwdeI985rc+RgJ 9lgrJAvVK1odDqKWcL/knTa8aIWGz5Mz4GlibtzB9KWDGwdkW4JExZ0I0EIk9Nfl iAUA98VYbQYyVWVMytyQgXMb2nIEdGdQ8tO2gNWU8S46EGr7Qxb1hwU66LhlN5oq yfhqgvz/rDuSKeR8qCgq4rKcvzVqEbnv3BLsnYhLor3yXbvjHjy/+IDGEsu4lK2Y R+N1IFI1zN9wowmqGu+Bjo7ExRZJm42ukAxfGRBWmjmJbZVSVXEHhokDe2I/XyPE WdnAjYc= =b+g/ -----END PGP SIGNATURE----- --=_MailMate_D7018CB2-AC18-41ED-BCA2-45A454C1D987_=--