From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 807B5E81811 for ; Tue, 26 Sep 2023 02:28:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 107F56B0183; Mon, 25 Sep 2023 22:28:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B80A6B0185; Mon, 25 Sep 2023 22:28:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE82A6B0186; Mon, 25 Sep 2023 22:28:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E3B8F6B0183 for ; Mon, 25 Sep 2023 22:28:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AB7C440DC1 for ; Tue, 26 Sep 2023 02:28:22 +0000 (UTC) X-FDA: 81277164444.06.CA73B88 Received: from out-203.mta0.migadu.com (out-203.mta0.migadu.com [91.218.175.203]) by imf29.hostedemail.com (Postfix) with ESMTP id C6EB0120013 for ; Tue, 26 Sep 2023 02:28:20 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TEhoScQT; spf=pass (imf29.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.203 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695695301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=24R2pLWXym7jBk3gQ8do08nmij8cuCrMpT9bPlzajlk=; b=ElBdid1WwKpanDFRDDXZMfsE30TFv+BGDJjt8g1h74y0UUiuNouyC+WskvHo4NzKqjpwdI kGfLwAgRrUNU3e3sY+Zv2uTJY1lSA8xp1Dvx4ryr3a+QmLk4cOq6Mo++MhYLRb7nj/4HUB Gr9ctuAaSM3AXgfotOgrcVIN8LnoKdk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695695301; a=rsa-sha256; cv=none; b=3oEja1dLx0M48X9xSBM7vxuiHGJ1vYBBs3/ee33/AsWY+EvCYrpdwdg3d6YExzAMg5jDR6 IgOqUTHv/l0xCYIYTU0Qy7KQq5D1RakbYpdNff8b9urIDwpjX50q1MGyUk9X/ilbjBS1KM cr3xQNagchNKMRY+tOws3ygQ5/Xzv7s= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TEhoScQT; spf=pass (imf29.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.203 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1695695298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=24R2pLWXym7jBk3gQ8do08nmij8cuCrMpT9bPlzajlk=; b=TEhoScQTWSZIipzs1D9pe1uyEHGfcmmtCj9ptoytsHPVwo6AiBuhJ1JR95a+JRUOSoFjS/ gHwT0E6TXXEd3Eln8SKeOPWdcqYTdIgFO/3Hicn4e6PpFMPb+a2x56VusG6YNCKPiU5YH1 wBmnoWDIzOB7cfm/8tl1kRC22cJrXAM= Mime-Version: 1.0 Subject: Re: [PATCH v6 4/8] hugetlb: perform vmemmap restoration on a list of pages X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230925234837.86786-5-mike.kravetz@oracle.com> Date: Tue, 26 Sep 2023 10:27:39 +0800 Cc: Linux-MM , LKML , Muchun Song , Joao Martins , Oscar Salvador , David Hildenbrand , Miaohe Lin , David Rientjes , Anshuman Khandual , Naoya Horiguchi , Barry Song <21cnbao@gmail.com>, Michal Hocko , Matthew Wilcox , Xiongchun Duan , Andrew Morton Content-Transfer-Encoding: 7bit Message-Id: <7DF23E7C-F039-44F4-8204-BA463534B09F@linux.dev> References: <20230925234837.86786-1-mike.kravetz@oracle.com> <20230925234837.86786-5-mike.kravetz@oracle.com> To: Mike Kravetz X-Migadu-Flow: FLOW_OUT X-Stat-Signature: dmxqkhthtn7b7jjayz7faky3cwbmgt7b X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C6EB0120013 X-Rspam-User: X-HE-Tag: 1695695300-28270 X-HE-Meta: U2FsdGVkX19eyJrtoTm1YT+NnxooehqMp7tHYl7pLMSFPsiTTUqZmTnjDqzf9iQSTc5YRF/uAGtuOC7+0GPVqxB31ecZt93puG/W4kNWQuriOPbO0NEfW6EQAzl5cnJNjPYlNJPy7wvVfn+FbSxCYaU7rI1PF5TEATkNaturZJ5ZUjYmqCCjUtWKX0ll3Du7wmhT8dovwpNtiBsn0bwSFhu4cUwNVQvXXbgxOYN389nL4oUAGYzV/Kj9SBggy1Qrj9k6QLli+CUYcdVnT08S9EfI2AeU9+6lnhNIipe56nRQwX5UADZaa04UcyHKCaO/O51c7riyy8HNGWGmByc5ncVzMSQir2qm+7skFYV+6W5Plh7JFuPPmbn01ci0e2jUodng1xvZFDPc4AXJgEBsUsx2PfmwRXU6adpT6o8zQ9S00hg5D7CBe47rr/fKFfauSr5oc9UgSlR0CtfS76KCUtDgdQkyHt/J34b1wHyT6ahl/23EP8R/ex5Pp1Xzn8VlCYNI9DNANJwzV3D/xEasTJhEujqh7mn5ApLP/Pvl+siOVw1NPUw/dVwnnA3cby707HaImj4KCxkRhg7Wvn1zOquNk+gRk2eh/GwX2HsEIcNmeUgCEToh4OslWm1ZwaZGpm5sv29krltuVQZSmmg6wP1uD0vlR9f+7srEjIMNSuTgmVmv13Aq68PsMssR0f2/lYwG+j/RsLVpU3QE3hhKUModDKylAwCqi8cHHRaWUwCE/RreQET4D3Nek/DW+B7pZsenQ+gOzEvbh6ML6RljvYYWYk6wIF7sPNqBgt5HaOBH2yBLaXjdLUlZMdyEXIadrAomPixRP3e/rfEroswEACWAys84TwPIQCwVsH/KKURfbQCLg50szu+fKll6H0LDWexp16IcARCpfaMiHiAz3WLuX4R3szc3+wZVA7xJQ3Zecy7a9BzA4SeCeL6g+VTBpLHIIayD2yiUomHw/f9 mwcaUU06 3t3WLJYbl0ylj+e4zqX/p88mJEiFM8F0GjgHU8kK9MxhKC7nr/c2tVkdW6Gy5kv1ALBVsbdhiMbKBPxvLwWHaovlCt3oRO34XgLVL48vv9yjT5s4uY8YwUH+ix4u9MUuNigaVvKe9j5AtKdWgz898HlDP/eRBo7VgQcN4DDiJzVayS9kekx8YclSotLaQ35m+7NOy83wcJ3fmruM0tnvP8U7fCMTTkCxkn4hv04hkgZkpoF3FI4DbAlcxYevhZQjMaKpy0OqAzow/GT7ORF9UHxtkqbduMWHE8H1r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Sep 26, 2023, at 07:48, Mike Kravetz wrote: > > The routine update_and_free_pages_bulk already performs vmemmap > restoration on the list of hugetlb pages in a separate step. In > preparation for more functionality to be added in this step, create a > new routine hugetlb_vmemmap_restore_folios() that will restore > vmemmap for a list of folios. > > This new routine must provide sufficient feedback about errors and > actual restoration performed so that update_and_free_pages_bulk can > perform optimally. > > Special care must be taken when encountering an error from > hugetlb_vmemmap_restore_folios. We want to continue making as much > forward progress as possible. A new routine bulk_vmemmap_restore_error > handles this specific situation. > > Signed-off-by: Mike Kravetz Thanks for your continue working on this. Reviewed-by: Muchun Song