From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F03C54E71 for ; Wed, 20 Mar 2024 01:30:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE5AD6B007B; Tue, 19 Mar 2024 21:30:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A95B76B0082; Tue, 19 Mar 2024 21:30:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 910736B0083; Tue, 19 Mar 2024 21:30:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 80F346B007B for ; Tue, 19 Mar 2024 21:30:08 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0ACC4160912 for ; Wed, 20 Mar 2024 01:30:08 +0000 (UTC) X-FDA: 81915686496.09.0CA26F8 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2087.outbound.protection.outlook.com [40.107.243.87]) by imf20.hostedemail.com (Postfix) with ESMTP id 3C1451C0015 for ; Wed, 20 Mar 2024 01:30:05 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=GRovnIgh; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf20.hostedemail.com: domain of ziy@nvidia.com designates 40.107.243.87 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710898205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6tKwk2TKFWfeRneDh+cBMsd0Bqutp3crQnh6TJaYILU=; b=LaXEjX6ep1h9IyySfm/xJBvrjk/F0UIm7YNGR7FUH2ztQ8Y0c1u3G4dPRyOltZkMkwQ3Jt 5JzOgeEfTLPv/qOlh96nHvYeuVG+rRKTFgkCxwAZ1sT6Vt3XlCIWC6F/UOTpKBKydH5sKh X5jT6qcE0BrQ4Dd87KsHTSG80abcUWo= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=GRovnIgh; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf20.hostedemail.com: domain of ziy@nvidia.com designates 40.107.243.87 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1710898205; a=rsa-sha256; cv=pass; b=qZbkC9cfIIkawZakoJ1UZV+YWhXpnxG6l9J76JDAegN1wNCgpLLLDNzQw8QRebLZFEItvF csWmJRa39gPQU3QaoxplhsDG+OcFdlWaiIG1gH5a+h+sYQagYPVXro9TNeCqlVeOGbalLF 9qRdUlEp0acQZSdWI6Eb1fa5fdDTEbA= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bBiJk+mHcegDVbZyCJnfl5NuYn9jlzl4yl4Ib1zSlXqmnVh0vUEKSU8jKdfaEHUmWV5bFsMiDkeLh3au9ivUaWe0wE3mqMTdRX5wnSEfuzVduEr1GJ0fWyotEVGa2JwX5VGml/yw4YK0KQRIAMIL841fQ2/gMqJ3ih4JIRweSY9yIuqrlzFe1/v+ezIsxwxPkGVcoI46FyScfDH9srieRYq/BNM/P0X00AvcEVCEzBma4W40RPYIYDwCccrxwttF87bz8iotGMP7UXI8Btn4IDRCEjwoLbDB9CHecVPjrsg3VwJQeCL7anT1jgI6E08+wjB4FetlLI/sqZinibTmgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6tKwk2TKFWfeRneDh+cBMsd0Bqutp3crQnh6TJaYILU=; b=gkT/8yqVMQnhfcLmZZjFeF18nI3PZnx6veibl+iLdTqFXohjykWM1jt36H+kC6xX8N5+2hXinCFA9efihQSGyqV3Iakse9luWKBdiIIH6fAnSuCjUlYR9qBGf6VbXlpzOlMYvAk8mSWgvHfN/Yo3C5RP+RyBSEVZJFJs4ybpaHzE/TPJsFQzXsUhHeB0xvulkMaPvH8H2/dcIybPiIbNxsdbn1AQg9nRXxELFXpTshMoulOOW0AC+I5If2xmIs77YYEywMZkbm+xZQ+CEkFcTNCjAoGjV77pAyOqsoH2viIemldQRFSEAJNPHPS6RD+pRSR8lnRlHewfnqoB4oyP/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6tKwk2TKFWfeRneDh+cBMsd0Bqutp3crQnh6TJaYILU=; b=GRovnIghgxBmkrOghThKmLxmL6Kb4UY4K1sAdRO5/3jfWSUSsiQD4tpoGG81E1GpNTUbEW0GOWd5KVP4b3MOs7ttzEmxVbOq/l93kW3BR+MKAzhdSCtxYBsm9QD1T36Z57D4HropA9GT+4Z+dPDw8b5+FXwtTa2ZXxLsuU/nhZqi/rYvXGt463x8hveyK9P8QHbgYCS1/hsenC82NEPZNt9yftaBx8QzG3duk+N72Txj0iriQlnPCadPWtDqMnV7p3E2R3e06iZJe8rUnciOOB/YEHtkvrs+9L9Ryzu/A+5nyzSOe82Avp0AeIsfyBwS2mGBDgFXC4Q4vYGiikWQAg== Received: from DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) by IA1PR12MB7685.namprd12.prod.outlook.com (2603:10b6:208:423::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27; Wed, 20 Mar 2024 01:30:02 +0000 Received: from DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::dc5c:2cf1:d5f5:9753]) by DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::dc5c:2cf1:d5f5:9753%6]) with mapi id 15.20.7386.025; Wed, 20 Mar 2024 01:30:02 +0000 From: Zi Yan To: "\"Matthew Wilcox (Oracle)\"" Cc: linux-mm@kvack.org, SeongJae Park , Andrew Morton , "\"Matthew Wilcox (Oracle)\"" , Yang Shi , Huang Ying , "\"Kirill A . Shutemov\"" , Ryan Roberts , Baolin Wang , "\"Yin, Fengwei\"" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm/migrate: split source folio if it is on deferred split list Date: Tue, 19 Mar 2024 21:30:00 -0400 X-Mailer: MailMate (1.14r6018) Message-ID: <7DE48248-2210-487D-82A0-5FE9F2C14871@nvidia.com> In-Reply-To: <28D1C313-8333-4F87-9B1D-47E77789A853@nvidia.com> References: <20240320010813.136765-1-sj@kernel.org> <28D1C313-8333-4F87-9B1D-47E77789A853@nvidia.com> Content-Type: multipart/signed; boundary="=_MailMate_B4C38DB9-84A7-4953-BB67-9D9F864827AE_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: MN2PR14CA0007.namprd14.prod.outlook.com (2603:10b6:208:23e::12) To DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5744:EE_|IA1PR12MB7685:EE_ X-MS-Office365-Filtering-Correlation-Id: bf000668-c89f-415c-cb2c-08dc487d43a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DiPBn4dK3iZPAcQ3QtVDe4FemKSKV7bEeWiATzBcgjpx4UGg/or7U4V0U48xSthNdlT7QPw5fat01C0nl7ymc1G4ZowtdKHaB/T/Zk68JM1I7NTcNbi78YKKwzetb7cpspC8GLV3mbNM/HlYCGfwVVsAfuygotTWpA0hNF9Z+kE5cowYx8GhV9QClUGmX1MgDVkUndfnUtypS+AQW47iuyjBhOtHhfUwljqNshtC05aj6hFUOMJ8Csqj2p0DEEe7A+Kkjx6QaPjRx3Lkr82izbIIMU41b/8AJQQ2wWgnkpXVERmWX4IBAmxgV1clbCKOAFY18EcTBgEj0aXkfig0NxVI6TYefx/8d+RfcanaZqA4Dsqa8prKKYFIYGYH9XSHrb+T8VJLVhZRzaEpuVazCLPKd911o93u96T90pBZG9sCleFS/aTIX+BKYf8wkcvX6mwU7MBu4pf1UkGLSVZwfCriUQhWwB5aVaa4cQ3g4BxS0+1x99oHxho5B/2VMIMi2NqSuRMx/HdSjrazMMieBchPnQNppTvaII5jK+xnh/9rOtG1NwDye98HpvNSC2kLkpVAtCUz1BprVXvy79RjtteqHj2yFxpKedCizN9rrnbAGv06p8nq/+9jbqnpVF7XAZPIkGBEh3dNc3YsYVe+OgcBRt4ae9z48SwzJYgVles= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB5744.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015)(7416005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?15cg+BemVk/wAAyVsUG6y04gf9wOm2nSUrpRNLdj6u5GJFienkH1ApNWtkzB?= =?us-ascii?Q?H5IJlBJrnJD5QGKJBJvBheQlUs0ujy7bntMIejMqYvoV+X0HbeDyfkfFi7Jg?= =?us-ascii?Q?pR/DESPncYJbnCQ5fmL6NBzj1tofR8a3tDvrdNfg76bMUkSxLly23hSNpQJ5?= =?us-ascii?Q?v3JYk2JYFohKWh6Xz2exyjlbWLNLa7tYUdSdZKdXMe5ZfDMIxMgnUCk3qMXa?= =?us-ascii?Q?Gu9tBceP2fLoO2PJn/chYpXoVBJMeauSgjIA+Ve2Y8fhf/6jbsdeFApo9uck?= =?us-ascii?Q?BYH0oo+B42M1QBi8xHbIlC/ZGwMewzGiUmC+Hm8sieqYjhCWA1REkURM2PUp?= =?us-ascii?Q?1XtH18owNjgaBYmHN3LKxfsl2CRHGRgn+pWXbytwEmyVVCwbiusX3XExr7Xw?= =?us-ascii?Q?0ju5XyqBz+ISyODV1NmIGlRyOIrtSbT0Su/2A/QoEwmRWKkjMrcJwaWOVZ0F?= =?us-ascii?Q?9Q5zwRVi3rRkm27t1Fd89w0/rFA71sDoXusw1Ulj6vx4QHmvLIBsygpHofXk?= =?us-ascii?Q?HJiRsrtGr6H1lGMzRd3lj1eJNc7AX4HBUK1UbSZT3hbK5r5EtXpdbm82hfyi?= =?us-ascii?Q?z6Q9Uzg8K+tZQeLyxhRp9zWy952ZeHfJDSqymiw44vfE6aVy974CxImAhV8P?= =?us-ascii?Q?fQCTUD5v9l/17TCCyZds5VpKJ2ew+wHiBghECbmxTHVJDwLdivA9M2aOvGiL?= =?us-ascii?Q?s+wixp+4yYmappNQh+ATxlDVNXuIiMnxHh2w5yJmxBadDd6p/u4euc2A0Hj/?= =?us-ascii?Q?ZDF5/7FCRn+giRe6AYdw+NIzZHouGZLFLN41kX7XYh+QbRf8hOmkGtbImSIR?= =?us-ascii?Q?SeFXlf3ioNL/Ic7DBwkFFHeTa9eCVJ0uk05Gwtc35bLPpx4QLQs1RVCAfVGY?= =?us-ascii?Q?c5qEgyoSHdeTu16XoSPcp1ZXYW8YZbK+NwkmbPYUuDJ+OJ7aJlNf4yCLJzfp?= =?us-ascii?Q?YVQsFMBKTS3sRQAMze8FHYRgftLnHvwGqt2vo40tbaoAE4o+D5f1rOKx7H7O?= =?us-ascii?Q?Rg1QsojShxuGXhnVe+ifW3XUa6zTkimY39nieu9Zxiu8WGuFMcOusS3uNSTG?= =?us-ascii?Q?l99Ca+2NvhjBof2QVNLLzDYIGgxr1d/VQuPJMbNwj8GFfOC6OvDrwE3OgZhH?= =?us-ascii?Q?vyZLus+EuCeE8gtF4EYjVawQVCXVgYGcQWbVxqn7ai1nF2AjgKxrXUVnOPPG?= =?us-ascii?Q?4h/tBmkaXRnMNZmJsMtvK+3Hua+iyWFWfeS6wtG/4DpfIGaz4po+1+bATtBP?= =?us-ascii?Q?eU+BDPFuKwvgHL1SoDPXYnETP/LlM05AkmcJfKNu8lbcCyEOiYFwfR/O2VsI?= =?us-ascii?Q?Ore2fZxz/sWI2CWu5CpD8IawEDdHbN+oBd5DsoapYL1SN07SnHd2xAvFUvlR?= =?us-ascii?Q?y/8bJgZra5mYqovTpHBfsm8D1KM+H57PoK5gdKfcwY8AW0H63eAwUSmY/1pO?= =?us-ascii?Q?jTkB1pzKMRiXi5UXB68EUimc14B+rFxdLN+wUg4BOjWMlO0Kj386vo9VMA+a?= =?us-ascii?Q?LZ2yZpKvdSt8hoElaQj3d0mJrNQ+uuvKaltso17btAePaRxSol3OgI0zANPN?= =?us-ascii?Q?8uHJM5MCWoviQ0+cbaE=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf000668-c89f-415c-cb2c-08dc487d43a3 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 01:30:02.3736 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ERfYLOdgctMwsEUaDDb1o2p5BRfNMDAQP0DimIBY1qYyODv+cSag0PO5cdSTdWI3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7685 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3C1451C0015 X-Stat-Signature: cz7pojjt8xwfdaecqh6gss85mb5rsqj1 X-Rspam-User: X-HE-Tag: 1710898205-289730 X-HE-Meta: U2FsdGVkX1957en04DYa+ZDQo9TPfV+O9NtNUySys/wUjD/sqSOLFWSaPBfwOunlma9JKoNzDqGWMnD3h7V6s3vdwIrm1usI+lUQbkjq3bS2iaZ/EurgL7dHRp9YmBqIgKUqzUqIvT5O/kpaUWVVrsvHfTdYVNH2SMgR1h2bLWVoqm/IL8Vv+hHYNqwrrpx9Q0naFPDnYqVkUfQiWEjow+Yrj+rfzGc4UUEFv2vyjoxhaz2EJIc89TlARVFy8Rx0fr7uUmERF0kvq553PFEm+VSVENmhFzhbblOo+oxim65WMairg/SMbWXPrjNbxZhDXwFqd6QTbBBqTx2Cykex8x/vBe04Viy4ehU63AN6XxF2S/ath8hsCK4sJd3HNgpzQmnrit5KfF3c46PDYCDHm7FQL5UZ/L5v39WK/aKwO221j0HurxDGg61cwo8qd7FBD+nBVXDi3fJqmyWK7PPPg0FjK9PRx0RpZQnwA8cg4A5JUbk3EOqU0XbryeGdq8dNBH3g4FzVmdvjE5qpSn398zIuJSREwdNYnrsOi44jHKm2V7+5qmxD28poQ01Oem/NR/tr1/lQtVM/EfBmBJc5KRQSZs6flSGQ6T6bw+bjV9VMX3xvBFCgmDimJoHLD/BNhqM9d77vYp6v0yWGGhxxCZKHJFL/JZnnSZLL8F0ImXfcvZ7mGSKB/C9hoIGASqi2lLLkY/Ud6vvMsxGUl2PtfZ4AcGPw+ZYP62BmZ1yFmWSklX9nLmOa5FNVRddTVdaZVvQpqhswI2VeL+PBgs6ogwmoYzuO/QWmqhGuw+PnTzTVLgUbx1UrL5Ly1V2wxaKy23lk4XTULxlhNkHcFIHI7TeMXVvxJxh/rpTCUcB2nAZ1MSD3rE4w0b49tucR1P9UEBOR9K6FCOWDJQ79XPEcOVo5c1Pdg3Vfx6WeeULGg0dgvnMiKHhvGZK2x+pX1V8YM0vTW9Yucs+H09/OJhv mUJQlL2c yee4EmHgPk4icagCxDrfDA2S6htw2ltW4jwC8atBqmMIRSuoMi+Q67JF6BD5JAsqgFdOh5BZv3kIb38+GDUleEToAtSpNj6ZKVFrUZ2L7SukCgswlOpwti0sNL0lZMFPRYBAWMP1+oP6/uuYhJFx1O+yGmuDEM92/YJFCqkSBSI6mrs9hrpC3DpMwhXaeZyy+3zpdb8Fm0zi8ycisF7oX2GLyHndF1JMNVdAQH6ursRPABvd1e1JGWa1RA+2NIBFKl2vTqkkRuGLEwspMdrQuta0lBseM7mFyr2z4LybkA/LYvBfaH3TPUKXEtzfZNlXGdQ0GdFnqmL2L3PY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --=_MailMate_B4C38DB9-84A7-4953-BB67-9D9F864827AE_= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Matthew, >>>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >>>> index 9859aa4f7553..c6d4d0cdf4b3 100644 >>>> --- a/mm/huge_memory.c >>>> +++ b/mm/huge_memory.c >>>> @@ -766,28 +766,6 @@ pmd_t maybe_pmd_mkwrite(pmd_t pmd, struct vm_ar= ea_struct *vma) >>>> return pmd; >>>> } >>>> >>>> -#ifdef CONFIG_MEMCG >>>> -static inline >>>> -struct deferred_split *get_deferred_split_queue(struct folio *folio= ) >>>> -{ >>>> - struct mem_cgroup *memcg =3D folio_memcg(folio); >>>> - struct pglist_data *pgdat =3D NODE_DATA(folio_nid(folio)); >>>> - >>>> - if (memcg) >>>> - return &memcg->deferred_split_queue; >>>> - else >>>> - return &pgdat->deferred_split_queue; >>>> -} >>>> -#else >>>> -static inline >>>> -struct deferred_split *get_deferred_split_queue(struct folio *folio= ) >>>> -{ >>>> - struct pglist_data *pgdat =3D NODE_DATA(folio_nid(folio)); >>>> - >>>> - return &pgdat->deferred_split_queue; >>>> -} >>>> -#endif >>>> - >>>> void folio_prep_large_rmappable(struct folio *folio) >>>> { >>>> if (!folio || !folio_test_large(folio)) >>>> diff --git a/mm/internal.h b/mm/internal.h >>>> index d1c69119b24f..8fa36e84463a 100644 >>>> --- a/mm/internal.h >>>> +++ b/mm/internal.h >>>> @@ -1107,6 +1107,29 @@ struct page *follow_trans_huge_pmd(struct vm_= area_struct *vma, >>>> unsigned long addr, pmd_t *pmd, >>>> unsigned int flags); >>>> >>>> +#ifdef CONFIG_MEMCG >>>> +static inline >>>> +struct deferred_split *get_deferred_split_queue(struct folio *folio= ) >>>> +{ >>>> + struct mem_cgroup *memcg =3D folio_memcg(folio); >>>> + struct pglist_data *pgdat =3D NODE_DATA(folio_nid(folio)); >>>> + >>>> + if (memcg) >>>> + return &memcg->deferred_split_queue; >>>> + else >>>> + return &pgdat->deferred_split_queue; >>>> +} >>>> +#else >>>> +static inline >>>> +struct deferred_split *get_deferred_split_queue(struct folio *folio= ) >>>> +{ >>>> + struct pglist_data *pgdat =3D NODE_DATA(folio_nid(folio)); >>>> + >>>> + return &pgdat->deferred_split_queue; >>>> +} >>>> +#endif >>> >>> I found this breaks the build when CONFIG_TRANSPARENT_HUGEPAGE is not= set, with >>> below error: >>> >>> .../lib/../mm/internal.h: In function 'get_deferred_split_queue':= >>> .../lib/../mm/internal.h:1127:22: error: 'struct pglist_data' has= no member named 'deferred_split_queue' >>> 1127 | return &pgdat->deferred_split_queue; >>> | ^~ >>> >>> Since the code was in hugepage.c, maybe the above chunk need to be wr= apped by >>> #ifdef CONFIG_TRANSPARENT_HUGEPAGE? I confirmed below change is fixi= ng the >>> build on my setup. >> >> Thanks. Will fix it in the next version. > > Actually, since get_deferred_split_queue() is used in mm/migrate.c, tha= t > part needs to be guarded by CONFIG_TRANSPARENT_HUGEPAGE as well. _deferred_list is not hidden behind CONFIG_TRANSPARENT_HUGEPAGE but its users are all behind CONFIG_TRANSPARENT_HUGEPAGE. Should it be moved as well? Or the other way around, moving _deferred_list users out? Large folios should work without THP, since they would be like THP withou= t PMD mappings, namely mTHP. But mTHP is considered a subset of THP. It see= ms confusing. Maybe hiding _deferred_list behind CONFIG_TRANSPARENT_HUGEPAGE= is better, or just do not change. -- Best Regards, Yan, Zi --=_MailMate_B4C38DB9-84A7-4953-BB67-9D9F864827AE_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmX6PBgPHHppeUBudmlk aWEuY29tAAoJEOJ/noEUByhUwvAP/2JgpkWmP8U9vrCQeYwVNj3CKIoDD/KtxVOl mAIEwAtehyKJjZyzUjuVNy2A6DUhn10BgLeQOT8HMHWX9jh2GmxOmoa6qEZ9ytlb tRrSO9JmDPlw/AZ5s3QNuzuaIl+kKgSJwInxDe5TJUQptQ8grN40q8gmSq4cHkRt 9wRtoj7cUOIw4DePDSibt1132BLa/F8/E+ARqPhZoh9z3MFrxfXfPQOlkCSk14d4 1RVkUgMNg+7Iw1jX2KXAWzAau3alZZ3vReiEC4snzMxHQ/mgCBti934tfHKlbD3l OxZEdVsBgWe4PbTd0hmNNivTYVQu8cit/XjbpbxwhC1g9CdGbQcP4bqCU7YnN2ZW Gtx7579TcrJxTWlRblMPT3ql+/98mXp/6YnpDM9f1BGWzAMXYjFStghzr+bCD2VN LcWDzU3z9lHSXOE1buvziIFWtWJpv40eQP6yxvo4hlm9pQrYb2s858RCnjJ2HOQl rC26wmIjjYxHLirl0cJK1PkRjcDzhPx16V2oOP2UQSO0MBNtxAyeZpMuB93/JEec Og9KPmyDkB9vFQc9fepjlJOueQ+2/ZA6a5YWAogyJ1I92I+32cnlNRr8TaFe82XL QScfQ1r2aBxOKk2PmdCh/ZjuPhy3Nnebw9BDenOIj7lJtPa3n379cLqJWc0YhQWV Lc/YfpEB =Ki9+ -----END PGP SIGNATURE----- --=_MailMate_B4C38DB9-84A7-4953-BB67-9D9F864827AE_=--