From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAEBDC83F34 for ; Thu, 17 Jul 2025 19:27:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77CAB8D000C; Thu, 17 Jul 2025 15:27:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72DE88D0009; Thu, 17 Jul 2025 15:27:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F4F18D000C; Thu, 17 Jul 2025 15:27:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4DA2D8D0009 for ; Thu, 17 Jul 2025 15:27:20 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CEC991D834A for ; Thu, 17 Jul 2025 19:27:19 +0000 (UTC) X-FDA: 83674740198.21.A0D37DC Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2077.outbound.protection.outlook.com [40.107.236.77]) by imf15.hostedemail.com (Postfix) with ESMTP id EF770A000B for ; Thu, 17 Jul 2025 19:27:16 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=SKxKy99v; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf15.hostedemail.com: domain of ziy@nvidia.com designates 40.107.236.77 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1752780437; a=rsa-sha256; cv=pass; b=ZPGshcpaPw4iaHGDLFqztcv4R037gR64pZPbFyyL6ipFHjmbiCBrEmwMZRF22tmTwQK8X0 igNIOyj4fls8z1ETiT5o5aN0z3jcuFqdA6BMhK7AQ+5N1t4PFpLOkX12bOOGYqviB840Jy i0FP7wBCl25ZzQi5nnnHoMavebAlCb4= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=SKxKy99v; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf15.hostedemail.com: domain of ziy@nvidia.com designates 40.107.236.77 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752780437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hMJ7YiOd+KDBv3p3OzhBgbEKXQo2wxmMbcpA2HAOs7o=; b=4rt+g3Y0xAQJQQ3pyGq+Xjm2PExfn8V5W82pj44WcpVgqRne3poNfUPL7lcNkY3mmJga+4 fMoRIOpMvdH/UIZu2SwUKhjfmw4JghrY3tcIdUCVX3W0ZeohWJNElXik4x7rjwronodWhs mQ92fm3degpVa0Rn5QzR6f4vIaC95Dc= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RmAtWg4iWyJEagLMBzlkfIMS5E2YqQK85zLlEBHN8lBVhfZg1pP2vDwKljQF8pL8X4FnLwrhyEL/vOZZXkQ7eCfDMa5PJvpsrD3ZbHIlanEppS5I7brY7Mcg4fWJ9dgD/QnjJmt1FMWgA3IVfGgTfVvTnp17r7ZTfI3cAJOj8ev5MAc3wHKJnxF/FDCFBBB5U0VpI2g186ucY0haGuxmjvLLj6Hzq0wIiXfp1N98khWFWXK2kX8BJ2z0u5EBMp8Wet+0UjSt//DsMk36E4xQ3a7Y+sSMDrix45ENqdQ938pMhytDP+hqCZgTghs17rNfRCwCZ3FOEywIY/MMVirebw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hMJ7YiOd+KDBv3p3OzhBgbEKXQo2wxmMbcpA2HAOs7o=; b=mRF/qeSfmMLyTQayLvjWBlC0rxhM3jsOb8oWD+SA5MK973TNkUDpEnO8pkoPH1XTy9OANU/gQJvOZgfoFI+2djM7yumbe1tTiBBQQSyzmyc1D4WkH5CxRZrtnKz4hAAhkx3XF8nAI0q71/x0U0m7GrgzOHyYDkzxThPhIBrLsT05ExnoPlFx2MtvTrAs7Bn+zbmOqoirYiyLYqN4xWj5rp4vYY48s4/ARdBN35XaRtPSW3TUOkRvtFdeU6g8VTCkPIhwOBhPy5/EJLzqjwqqTJhHVKJBKJGVG0j/V3se6X0ING6gmlH/s8gxwl49o/weKuiBVRoTQSak+CTqnUwchQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hMJ7YiOd+KDBv3p3OzhBgbEKXQo2wxmMbcpA2HAOs7o=; b=SKxKy99vtiDr7i5nPRQsIoWs0TKf4+xTEPdoNe4AExa+TNEdIn87pU9UcEZhatK6F2hpTJn7HjXVwtS3izV+o9Pup9qzdp1cF+hqx2SH52JNjxbLVbMpbDcQDwktDvbv4y9rx8RVIQ+Tt96i5ZioZAChNB9fn5Fvrx52BPJROzIvFObio4B1ghVe40SedLF21qoKzlfjQdpZJohUS8HSuqZcdeS/EZ9k75TFYBxJ2gV0noGJiQEtIZIyk5Z5iPRTHIYYHHzvHB/exRrTn26jXD+oZ8ZpFQlDhIlcOOd8hVc3tVKnqF2p5D+IDcDG3avBRYe4Fep29esmzez+1bXFRw== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by CYYPR12MB8921.namprd12.prod.outlook.com (2603:10b6:930:c7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.30; Thu, 17 Jul 2025 19:27:13 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%6]) with mapi id 15.20.8922.037; Thu, 17 Jul 2025 19:27:12 +0000 From: Zi Yan To: Dan Carpenter Cc: Lorenzo Stoakes , Andrew Morton , David Hildenbrand , Antonio Quartulli , linux-mm@kvack.org, Hugh Dickins , Kirill Shutemov , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/huge_memory: refactor after-split (page) cache code. Date: Thu, 17 Jul 2025 15:27:08 -0400 X-Mailer: MailMate (2.0r6272) Message-ID: <7CE81DF9-7ACD-4288-A246-BF7A8206CF80@nvidia.com> In-Reply-To: <57a80de0-c5f8-4fd9-9b4a-fea97fe6c533@suswa.mountain> References: <20250716171112.3666150-1-ziy@nvidia.com> <31D32C5B-6719-4E3D-880A-666044C4A48B@nvidia.com> <5464ABD7-C4C9-4BEF-9E5E-21F5A18C42D9@nvidia.com> <57a80de0-c5f8-4fd9-9b4a-fea97fe6c533@suswa.mountain> Content-Type: text/plain X-ClientProxiedBy: MN2PR20CA0016.namprd20.prod.outlook.com (2603:10b6:208:e8::29) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|CYYPR12MB8921:EE_ X-MS-Office365-Filtering-Correlation-Id: da1b7f61-c470-450a-6ce7-08ddc567ee2b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?HiY93bbSbCJeO+VO98LR4Kp1yVerBP0XeoHahOgBOvePjxrtNDMRL6sLqGxj?= =?us-ascii?Q?CSgckmqDa8/IpTRIj4Oq4yaOtI+qZH+ukbl3yug5Hcl4djZQ878Ekncm9k9D?= =?us-ascii?Q?RGHhi8YoxJc57L6nH9X0IPdSRnc/FhAtd2hVsT6prDfV0rJRRmEsJzNwQlMH?= =?us-ascii?Q?ItBGSWK5S8OBh1WbukCPDlIfHrd1NTNWZu+9LDM4+covZFCASNXQzOdHrnfL?= =?us-ascii?Q?8ADe3xTgfpz3M4rr8TsCeRmeRZmXVT4Opr+YO80JWU0ytwUcrD3Gx7PBJX/r?= =?us-ascii?Q?uLJg7enbKow32DMjU+bl38ZfKoCAPIZ7IbnLU6sAFS7uF2tMAgJ823RhPBRC?= =?us-ascii?Q?nUp7DpqgBkWBHRVeyYfjDeOaz1ms6r9rhOScz5djBug7pZrQkBNKTvbvHDlA?= =?us-ascii?Q?bruY6XiIz0U3VB1GV+pWY9IAPnz9p9UZ0YPP3twTycKvcI7BJxzK/vKfIxrA?= =?us-ascii?Q?I8Mz18bSAGMPvXmF/VTP0G2IyvEtc+P9Htb/kLLx+du1v8VmWau16hzXEoGt?= =?us-ascii?Q?h779nVpF0/eH3Us7C05dQghxUO0TwyCAGClQXP9NeC+zb8/pDeleZDW+LRcI?= =?us-ascii?Q?qwF8Bi/9SwORIwdtiKmxyapQSbEeFSMNp/1LqdVUjLIsTQAaqvfYO2nJNhix?= =?us-ascii?Q?vyTNB1RW0CrGIA7MzU/Mn5mcS5pIIjfUo9c/RTKJ3Nz79q1cd+OeTSrnpGPp?= =?us-ascii?Q?/6EwZGjN6na7jhb5zRIhKgj1+YPV4clhJHvXFJ+McleayKQV3tbyb5ky6VVO?= =?us-ascii?Q?iybV4FZOnBRuPr23jAggqdIpBusBa21Fb2Wk+fRJPNS6uQP8IttepA33ch9V?= =?us-ascii?Q?sANqfXIvBRRSRCLykXlz4ZYBV8c5nw0OukNs/4aN3gefUqHAPqQ57zafutXw?= =?us-ascii?Q?lrQkO/KpBPearjIFLDUnOak3rE+2nTqhSVUZ7pnr/mODZpDj/+eZbcSJAHh5?= =?us-ascii?Q?tBg4bsAzpvdBlCRE2pICflJ4yfWYRBDKmZcD5unZD6oAD4IQrIPxsBpiwk1W?= =?us-ascii?Q?noFJ7/P8dJt2kNQaWbl5yTOrugo0+HkmSg7y0EcYGAefWNRFDi+SZoxCENDY?= =?us-ascii?Q?/1dsBLEdM4DEa5+mhphQDAjykY3TAcsR68rjY5LTY2sXfKD3hrBqL1jA2e9y?= =?us-ascii?Q?Nt3+Ua/r/qMJfB/Mu/0lkke+9OlQ9XVBwr+Y5R4rWhNdYRd1m9gcznse3ouN?= =?us-ascii?Q?Pa+fD0j7y2Hj3XOMKfKHahL0/EP70fA5y2Zweuo8LKP0xbYBshzBlF5an4mf?= =?us-ascii?Q?Gt148848YW7N/UrFjjhDSIrvGKk4naliNN7lALc72sapIXMEjGm1+Dc599U7?= =?us-ascii?Q?tuYHKYAGHLLLqzkDyE3x5SDkUztBiJyGPiugnu9h0lKyItiatzRM4zStqkwX?= =?us-ascii?Q?hDB5iVH48zAAYNQ/NaxzzjESLYNJ7nhQQTtiYc/bQKfS2xrJe7ydZFcDv+8t?= =?us-ascii?Q?v8PepGh1sjU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Kc98rDVvd9vx4xXJRAf97lOkWG3Z50vYHQWSIc4s0NWOJ156NNHYXqCr3OHA?= =?us-ascii?Q?Km5ZjJF6Y9vxM3nAjAC0sDX+nAf3k7Rd7fR8JqQcUcrCDybK1LPXQ8Ey4+qb?= =?us-ascii?Q?/nUDJGtdufwH3MFDAMYRYJy5XTZyIg2KTGWfQ8pjcn/PSXVi1MlXeVUyDl4v?= =?us-ascii?Q?bjwVsulK3ndPDS7mvajr73fsPBN4tybGcx2XvY10ioo2UX3l2K6pYkfZJBA+?= =?us-ascii?Q?7CJ+1+PpSsx3/jH70H0RdsDuccWuuKLemCW+u+s29/MyGV1mhMn6G6pEEydt?= =?us-ascii?Q?hv5nh9Nbdph4RdCGZdTx9z1wAVdZbZtWmjcgxolAJPhj0xL8tdOXmUeOrMCm?= =?us-ascii?Q?p1hBvYeQJ/aoc+jxHFATzGVHs6/7QGuBEp7OdIPrR5H/q0r7ml/CTWjzDzsH?= =?us-ascii?Q?psw14srft3dUdYpKM6G3FslRz38sRWJpstT+GKWvzQVNJ2blj4/ZGOtQdfR9?= =?us-ascii?Q?cuIXL/seyjplLak46aaqJZVwS24corZgwsiOCcq0d7tDExv3OguRXlQ5yo7j?= =?us-ascii?Q?l8hLLs0vJmIxoc6uuCh3H9nl0BvJjYjrsFRlSdYilpeXEUSrxRyOcfpW6jWy?= =?us-ascii?Q?JuLjIgG+UWOx4t62mcWJI723qN1VHWfpLYt7Qe8JSLbYRke0wSLDo1b29LJu?= =?us-ascii?Q?ZakEAtMQPgYL45iYO7Axn6KoJy429QhMd9FNcw0uyw4vNi6SyY8Eh5k516sx?= =?us-ascii?Q?aCM8nTmMdFmFjwc0yiyTx+kelUCAJqcs855VLByLy5DlnYtSki55ma4EJaK3?= =?us-ascii?Q?MtzEPXO8BFhXghdGcsB7njYaxj8UTNefS1pH+QnaqIuOdIIs3z6YntOHJTJD?= =?us-ascii?Q?E4P/3I8G49pEBbMPG38S0XLEE3z8hqh+yvQg+CtOnJPTsqh5eBZ5FDEcK1Ia?= =?us-ascii?Q?OSUf4yaWlG42ZjXemRcoChrFMPajBCRjEECmIbauZO7Vlczgu+4cJA2QrmuN?= =?us-ascii?Q?okofBkphBqE8smvsfcg2zLxDJmKKBNuMxtJN+WAmhe4nfir1BJtzcrqkJBxH?= =?us-ascii?Q?7e5QrDzasBB6YblMKjNT36zU5F1wXFvpJbi9EfEFsGYxWs/XfhZDaWtIz2WX?= =?us-ascii?Q?pw8S8TxjMhH7mO/wt/mCp0vaCbVZfaG0ZaKENFq8QrVO2ZeYeDXepE4ZmbBD?= =?us-ascii?Q?odn4wHJRB3y2+mqWvsHtNXu5GCUfPrrHIY2tqPR0cSP5Q0jYK4L3fB7y/pD+?= =?us-ascii?Q?8vAC6R61uaNXHsYlc6NqcklrOhcmECMYU3F5oQl39kxh/htpNRZvnLNEIS2J?= =?us-ascii?Q?hRJADBDLHPAA4t3II9+QE9aSAxVdMcsl/q/Q14eWrAzo1xMZv4wzs+qoL9zG?= =?us-ascii?Q?jsGOPieiG1pf3ZU7gqhWVSBC5XFmWGSHJi3cDD1XlfvVFW5rf0az+i0qXR8h?= =?us-ascii?Q?WGzjqOubs1JaIbuSn6dgEZrnNFtham4XNRqKu81zYhU6qtRi0EGn4ZDZLsEz?= =?us-ascii?Q?7gxDUeVZi1ciJaDYPAgscBD9P72VeyaHKfDA8zZeLE+O82vjSb5nTOK0GsSW?= =?us-ascii?Q?YvRbOuBcX35nSFIGovd8nuXt3jqbRJGqcCjnf9SZdWAMVVv1mimqv6kta+5a?= =?us-ascii?Q?9bHVH86Sd+SRBYKTHYaevelsftIWeLxS90wmh976?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: da1b7f61-c470-450a-6ce7-08ddc567ee2b X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2025 19:27:12.5926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CMxrkfaJi/H/XKh6pmZ6vyPPdC4tZ5Ij161aaR+il6eV+Yy614CZux7OwNIfm+6U X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8921 X-Rspamd-Queue-Id: EF770A000B X-Stat-Signature: hxyo7e998ckhi6abf5dikdjcxdnffjdx X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1752780436-413795 X-HE-Meta: U2FsdGVkX1+BrbfNVw9CXsfmfPSK0JSj7gTwRiNw8Ml6kpIQKE9pPP5pOElPA9bJPV2fRWlQJuxdf3zeIHVjPq0rUkhJndUY7LWqDLCo8CqsWVGXZ1x31+qNd77Gglx7+HXDTwY6CM4NVH0qUWfcP6NJbcNdiqtiuOQ1fIh0MRdTwjnLByZA8L20ywH1zz9MK4rZe4poo/YEayM8dEc5g4wWI6Tg54t/jvzyZd2T1LPbSALtHbBjp4MN3DAE1J0c0Lt2MHvN5xrTHgh41INafBdM7DVjIiWG6KMx25LD+pWUsyXZyY5oYqWYbH84h2TvY7PGQKt0k7P3umtxHWIGHO0nZ1CKPjDFibBZLu87k+dReV4ff4BPJHNg6cKRELQ1I9o3smJES5qOtTxip4XeOrz6vVo4soECPQEP4YNflau+x/XYuFo7AqfhqmNXsGWxp2MZvMQGnz7SYvKh64Sf2LqSw3uRfC288QZt3mD7vktOniG5ihBKdLLk9Dtzz1rAzp5nvC8cMmkou22/KqdtcJhEzVF8alPO13dJ4fWFfww0EUFZvbSKWpWGfm3UtiXZ2KtvAbszM40zBlYPfezAV9B2gUVDGXmD9AOSHBMndO1EqYJBa+w4rVQO8cpBdrJ479X3su3jddAqLNJD3Jj7iCZURxECnYT/cPQJqNFwUHJEoDrW+ZQnhLW6IdFcyDfJuInQyBCU6IRK+RIRawjwvWszAqJCgYHoC5BzqVE++PYq0JOJGt+PB+7O18FX0CYgq8TNjtqytpvUsZvGsFqWXNE7NBrVyJRnPDE8r02Hi11zxMCx2Wuv+JDBgfcWckl1w3GYfNar8434V6K4ezcX1DjIUtxIOK7ryrie+QKbXzd2Bk2KSFhH+ZLMiP+1fIamv9dP4R9VxKS+ThIvs4on9jMDpdQuWiJOGL1zKUjNP7z9PbM7TkMRyr1Ot88OUJSBz5xlDKPVYx8e4ZKYnrx 8lV8aWJ2 wunzVOEZ1GxyUtgLCRrbVE8pZjYeO+kyqZcxIlMpFj+5XQ+C6MkMIOQOw+BqF2m/bVYX40DZFWxGGM09d9sQsABJ6qUQINxaHDaUVhzizA7tbQAOCttNe87rCWEIxRFQARvLHV+PpP8186dcxNHJjmx0jQS55+10s4YlPn/Y6YEmK03ptojjIeJ1cmGMZfsFIbMJJNFNy228o5rDsK/A0j1rRInU1Mz2gMMjs2GjqA8Nr2eFSEqz7++NmQFgqQjiJRjUYfwUlxji+nV8SMEn0FIABfAiP6GvmDNRniw+V5j+Uul8Oa2SwRx4y3HbYEHgLNJmPkgouvdYnJUQP5/a+bQVcBZF04cfWPvT6NS7YM9N6+pz62AOkeO7WdG8AugfUn2h+m2PjXQRfZRwYwwjhix3QsLhAVL6edQFkSCODBgUPtKi/sqIRzKxp39ozefDYAUSx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17 Jul 2025, at 15:22, Dan Carpenter wrote: > On Thu, Jul 17, 2025 at 11:45:13AM -0400, Zi Yan wrote: >> >>>> >>>> Since we no longer need to make new_folio->index >= end work for anon >>>> folios, can we drop the end = -1 in the if (is_anon) { ... } branch? >>> >>> Sure. >> >> A second thought on this one. If I remove end = -1, can static analysis >> tools understand that end is not used when a folio is anonymous? >> Probably, I can initialize end to -1 and remove end = -1 in is_anon >> branch. > > Smatch says that "if "mapping" is non-NULL then "end" is initialized" > and it doesn't trigger a warning. I don't know how the other checkers > handle it. Great. Thank you for running smatch for it. > > Btw, the only thing you really have to pay attention to is Clang because > we treat build warnings as failure. You're always free to ignore other > checkers. Good to know. I will compile my code using clang to get a sense on how checkers will react to my changes. Thank you for the information. Best Regards, Yan, Zi