From: Zi Yan <ziy@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
linux-kernel@vger.kernel.org,
Naoya Horiguchi <naoya.horiguchi@linux.dev>
Subject: Re: [PATCH] mm: migrate: use thp_order instead of HPAGE_PMD_ORDER for new page allocation.
Date: Mon, 04 Apr 2022 14:37:41 -0400 [thread overview]
Message-ID: <7CA80FB2-9F72-486C-A5AD-D3E6D415EDAE@nvidia.com> (raw)
In-Reply-To: <20220404112802.4c07585b7b7e420342c9b0fb@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
On 4 Apr 2022, at 14:28, Andrew Morton wrote:
> On Mon, 4 Apr 2022 12:53:25 -0400 Zi Yan <zi.yan@sent.com> wrote:
>
>> From: Zi Yan <ziy@nvidia.com>
>>
>> With folios support, it is possible to have other than HPAGE_PMD_ORDER
>> THPs, in the form of folios, in the system. Use thp_order() to correctly
>> determine the source page order during migration.
>
> Changelog doesn't describe the end user visible effects of the bug.
> And it really should, because
>
>> Link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinux-mm%2F20220404132908.GA785673%40u2004%2F&data=04%7C01%7Cziy%40nvidia.com%7Cbf27ebf19d8a49a9b4b008da1668dc09%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637846936880192108%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=pgvzV3wv6icqkMaWY2koB9X4VqlPMaSHeB8r7%2Fv1938%3D&reserved=0
>
> it fixes a kernel crash!
Thank you for adding the information.
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
prev parent reply other threads:[~2022-04-04 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 16:53 Zi Yan
2022-04-04 18:28 ` Andrew Morton
2022-04-04 18:37 ` Zi Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7CA80FB2-9F72-486C-A5AD-D3E6D415EDAE@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=naoya.horiguchi@linux.dev \
--cc=naoya.horiguchi@nec.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox