From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF47C54FB3 for ; Mon, 2 Jun 2025 17:00:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE7026B0300; Mon, 2 Jun 2025 13:00:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E98B96B0302; Mon, 2 Jun 2025 13:00:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D37FE6B0303; Mon, 2 Jun 2025 13:00:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AAB3F6B0300 for ; Mon, 2 Jun 2025 13:00:07 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3395EC0D67 for ; Mon, 2 Jun 2025 17:00:07 +0000 (UTC) X-FDA: 83511073254.02.0C49FE6 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2089.outbound.protection.outlook.com [40.107.94.89]) by imf02.hostedemail.com (Postfix) with ESMTP id 3FB0D8000A for ; Mon, 2 Jun 2025 17:00:02 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=csW27FLs; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf02.hostedemail.com: domain of ziy@nvidia.com designates 40.107.94.89 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748883604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UUrqyZM7nxwdce6+sD2NXsoI0Swj/MtgEWal5D+m9wk=; b=GC+o3En9aA3KTsOn6IyZREqoS8ZJCZgYuCG2Dp8MJhV99k2yEI8r8+XiMPnmhhWHzpt8/1 mr6uv0kPGxZvXReSOcqjQKGMs0h67Z2YSwFs82/kY0LS5bRyfHF8+bg7dn5Yi+4IhfIZ++ 4uc5O1bNRcIzPx3mANtIGlylO+pbMzA= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=csW27FLs; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf02.hostedemail.com: domain of ziy@nvidia.com designates 40.107.94.89 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1748883604; a=rsa-sha256; cv=pass; b=Pg08P9/9PjlUezyhfcgLTKd7ec1pVO0CLdkmwU0o4nMotcX7xG4leP6+y++rryPnJn+w/r X/FjlZ5qCbvfXnsOO9BlF00Q21S41oEfclSlyDbCLmlgDhufJaH9IuLsbW8MxzwiEayncC icWV2vli6gkq3ZAs8z8aQRjZpLUgX6s= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ylQ4XZTVMJeqxdvZK72/CMUDSUXGB7vx2EX4McZMY0YxzrfvN69WG/TVQhMY+WeFItQ1c5XF+1E7zgGVAYYVGIbAMQnx65vigAh3MKUaer4WHkNVhPG+YimjAtvU0t7B02TXGKJMVM+Hf7AFDx9TybHDYDFZmO+xIrPdmshcphiRyEviZ0+jmscoKSu5nZf9snb+7SxUqo/lHoXIqjnL0r4iOZc03Bd8Dx65X2srU4jHkiz5XNn7yf1gjOEucft5zs4N4f/Jir0DKRtxh7FRl52cMd3Kf0FhQCbGMUoaGQuEk8iovwdGZ+w0tJMehsLEvTIPqFostMj3UdijmR179A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UUrqyZM7nxwdce6+sD2NXsoI0Swj/MtgEWal5D+m9wk=; b=y11dfLAXKJ5cv0herTFdvQacTdd47Lbjt8GQC5nippD0Dk1J3b+Fvl1USKXDXaJizxOwVAtSRc2g8gn+LRm4TWqBJNHNOdPzfgng2ITZVHJM6t4BmsEt5XYsUPiCrCW61Fi+uhAz6UnVETLCrUPy037DxO07//axjfR5QX6NiPQgSGSvhnVsYqf+fkg+ro/mQ5j7zdyYGHyXePwXNps9hR5X3C3BlUfejRTO1M/8TmLlcsvOCHFM4mMfgEBf/vYb0nTlnQDbWEjbZ9hiIirPnsIpjzJTA9ZdeK9a6PkEyQcpJDTNV6ITFhwrCumoJfppVjweCI03znsKoDXiNWi6UQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UUrqyZM7nxwdce6+sD2NXsoI0Swj/MtgEWal5D+m9wk=; b=csW27FLsM75VNPumTjZx+0gtHuxTBR3Og40s8JsCyRlngxCfHZcj2JA7u48HvH/QfDxZEIFyOB1Ns0l89hTdpDrribxT1fMh2CL6g+uZ1Z2YS7sq+gcZUlgW8JYybfz1Gj2IMH7SPvhbp4MhAOn/cmZBHyk3hLTVeDyGew9caBKwjPyagNsrmqxAm5+OYsFvSsnsCv9+FSCJkpcZzYXwTU4M60hEMx7LU/imseExTt/l5E+P1iR76JISkhWagc9UE7SLJ3RyHLD4scbIwoXKKjccFqYSQ4KHbN6dNV2uAPFTOu476g5JCRgRPWf6dXWWaUdYjrkAr6HAHDF6LzrjNw== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by SA1PR12MB8742.namprd12.prod.outlook.com (2603:10b6:806:373::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8792.33; Mon, 2 Jun 2025 16:59:58 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8792.034; Mon, 2 Jun 2025 16:59:58 +0000 From: Zi Yan To: David Hildenbrand , Johannes Weiner , Vlastimil Babka , Cc: Andrew Morton , Oscar Salvador , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , , Zi Yan Subject: Re: [PATCH v7 6/6] mm/page_isolation: remove migratetype parameter from more functions. Date: Mon, 02 Jun 2025 12:59:56 -0400 X-Mailer: MailMate (2.0r6255) Message-ID: <7BD9FB05-4125-4EA8-841D-9D08907D01D5@nvidia.com> In-Reply-To: <20250602151807.987731-7-ziy@nvidia.com> References: <20250602151807.987731-1-ziy@nvidia.com> <20250602151807.987731-7-ziy@nvidia.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR01CA0055.prod.exchangelabs.com (2603:10b6:208:23f::24) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|SA1PR12MB8742:EE_ X-MS-Office365-Filtering-Correlation-Id: 84838f14-e059-4243-a0b6-08dda1f6e832 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XskbN8TG0dSkV2A2JiVPFi6gtZlRa9kcWY35laxT+36s50vgQom0a9aXCHke?= =?us-ascii?Q?gynmCM3UMT/m6aE3V1TXquFuPAhytjw78Mvb4Y4XGYvFlq4BYDnqMFSil5o0?= =?us-ascii?Q?nR5APtbXhgKB/AVfo0bRmyDSGxHhqn81VWgRQhF+VzzmdBmsf6V9gZiwi7Wy?= =?us-ascii?Q?5y1n5pNGb/HQ/1wdKlAyyzB84kqQedMYQbiT+8T0AEeugliPKvfqZxlAWF95?= =?us-ascii?Q?zSdfK2/K+RoOkAhzayy81B/vuepjAq6EE/5hoR7TTKxtjeWPWcyC5fwAzCzt?= =?us-ascii?Q?IUvMlVkodXHny0pd68fbJajqVnWJG2RTpKbuP5+IMQ9cxSKzDYS0v1tmDDOc?= =?us-ascii?Q?HihcazA4H7uPOpRBk0MOjaQdhnkiLngzWmMchXioL0jLqczbgB3aRljRVonR?= =?us-ascii?Q?G6PaAORjlO+2YFX4os8VzT/GL+z5YveU8gz55iYGg4/vibcunDANIfJVQCMv?= =?us-ascii?Q?7/+dJaV56eV5aIHqsCiLzpQzU5Q3nM1nNKZ23jus28xNU+0JOMgEbp0ZpHSg?= =?us-ascii?Q?9VP24Xrj1kb/sdWR3VgYTxOO3Jg5dlwXtI8K4hzCFo4YxmBlky3O0Jj4N7bw?= =?us-ascii?Q?CeUyZ1n6r95zpdqiRxjk8scSYL4o4UzuSQQBp3sc7q9Soprz/BgN7odLiWRH?= =?us-ascii?Q?y9l2wvw06hfemCnO7+HBEwr0GL/GUXnkhsQCwnuOuPibUHX6JSJeoNv9fvfa?= =?us-ascii?Q?nT1+XoQsjTjwxvKK7L5cKOkZZMCffTtLOggYpMVIoG6aTyoqUdcO+4WYt3DV?= =?us-ascii?Q?PPxHW/1B+GJz0MUotlKIUrRSRJDOYKkUGEx5rK0V623+jkJisLsagQDJlHux?= =?us-ascii?Q?HdyipoPO1TB/P3c5iacheNiRX9Y5i7Pyo2Z0EWONvInGw8JVlMg+R6rPT/jS?= =?us-ascii?Q?Eeo5h4ty7UfIfR2H9cV4evM876PJMtG0gPHhQtUcpxBcCRivPLBKPJQLqQxQ?= =?us-ascii?Q?SA89tnI3aPe6QYKzyGDiwVa5QndU4nPudfciBCPKvy38gkL126d5rnxEMuiT?= =?us-ascii?Q?GnYo5pvGDr2ggh9wjQJ5sRE+6RTWBN4iJHXIu0suVoVwyvyOhJ1RaDZ85ylF?= =?us-ascii?Q?RCS4vMRh/eRyzk10B5hHjiDnQvkdkGoGsIWob8mJ73Ft/FjkeHIaU41HRCCI?= =?us-ascii?Q?DYXGowIxF3pjd1cwBYSVdsiN3abplmNFoDowsT7Qc4kb571q1QS4gAXko+d+?= =?us-ascii?Q?2G39yDH5uNj2oRMx16U8Lb0VOVbI7DtXf0NrTFEZ5uIqxhF64US+DJL1+t6w?= =?us-ascii?Q?gq8mGOuTrionIxz+LckVWl+hY3/8gZyMvgU1Se5inUUEawHgPUP3GFDsOZBq?= =?us-ascii?Q?ALtQcSDtSYT45AxzsmG12Qr7Y0GlvLUEmNOHslbdI7eHXg7Ojx7P08mn9GHz?= =?us-ascii?Q?d9VUAY4nL8hZAdNA9epd6BkCe9rNVhzEHRAsjInaY0OQ0mn5dqkYY7Gzc7vw?= =?us-ascii?Q?/OsPRNGH/cg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5t1UNx06xYfHKfBFQNFDUxQ/7dlf8Ci1+yvEBaHKcqlVUSvZmS3S3kz3WoZI?= =?us-ascii?Q?7RmNx4yWHjcx+vebU9bxXRjFnC/eVtWX78Iwhx1aM3WS78uSabmk0eN9K5Mz?= =?us-ascii?Q?+C+NcrIDh7uYr3O8LGQ6OlMpMq/DL6h4vvVbYJdcxRzvVDv3GjbLxOH7PFBa?= =?us-ascii?Q?R6HQoBZRuWxfZWs9aJoWi9VI4PUrSYatlQJp6dCJiwFMFTtQMHKrrwDVdMnt?= =?us-ascii?Q?qELLUHcoE8DyJ7vmYzACi0Tf+6zfOxBNEg3Ftu3ZxinG9s848S5vN+N439Zh?= =?us-ascii?Q?mKAqj1bkllaaMUOl3butP62c/vmxyK3HbUCypkjynHsS7Y6OxQedEU5SwdSV?= =?us-ascii?Q?4syC8M/0xdaOp+6vPFHyUkxg/etMhG9sjRrlPgoc51BOWYtryJCN6YLIAgq2?= =?us-ascii?Q?G0KrYyuGSd02kBP6kgOky6c+8KaXjfT4m+vyYCJ0lAE6mt1qog/bV8SbBiGA?= =?us-ascii?Q?LqzPytTdYJ/9N8QPdafFptHKArPeGBSAn/Sn4UKwfmPkKctcAXfh4HpAE7BW?= =?us-ascii?Q?UyrlMGTWcYVSKJU2iPHQ1RyfrpyHqpmbdLDjqfiWoKPHKUrACSwRw1MDcjBV?= =?us-ascii?Q?AnQuNBHbAztZuey0ViG90swIzhZKY5RkXOuEvRqX7qOLHwUV5jb4QbzbvcWM?= =?us-ascii?Q?/y3xMDa5KQE/qMYkeBmb55jpX831uICyL2EsAcfnHxNZgLXHahNO20qa2/iM?= =?us-ascii?Q?XBd+B1t91Uvxsm1P5yhIrai7gM113eDXPzEH2L9WGiC4yihNYVPpz3kqW1IG?= =?us-ascii?Q?X58Rrbp/+zxNbXo1SgGD30WJ9V64SACQwQV2RoYdroYvY0pfo7sVX+pYRg++?= =?us-ascii?Q?I+8Qu9cotiy4/Omaf5sOso4PMO5rGgnrlJxIb2y31ijHC90DjRASRStawYFP?= =?us-ascii?Q?C4NR6DgVm65OIP+WaEe8qqiGvtrwpIehB8zpp8c58Syurwi1nyaiWLzTycMq?= =?us-ascii?Q?QeG++GjVqhuPVTsY381PM9svDFVOUiIgaLtmZIhBW1y2ugrYpeqdmztp+LOJ?= =?us-ascii?Q?O74iTgyHuhh+UC7yv6kELNXVTxL9IpvlSA+90jT2cHUDc4i52/RuczmPYibn?= =?us-ascii?Q?pbTT7KcBz/IMhAFb5Vq0odlsJS2HKpoGH+wdzpLlwooU+ZIRcpmrrhL06Gfd?= =?us-ascii?Q?X82It8cpEwq8UccipPPpquDvYmuPf9K5daNeAQwiEJuWDqAYxlot47S9ye2Z?= =?us-ascii?Q?ndHINTbAS1hWF+10rN1ZbjY8UNk+IpUXad8Jtu2UXIYTFnN6+82zFjFBoG0L?= =?us-ascii?Q?LPCsx8qZb4aTYBNCslhRyZu/HoT4lhMVfqmnFGlS3r9w906409FnOQI3zGME?= =?us-ascii?Q?eHjAcayqx9sZy4PZyDGF21Emtb+iWi1PO/BMQ2h1Gu8ijkRcw2pfEbsWNGRr?= =?us-ascii?Q?tphLq74XU2HNJWYxqUy7bsOqqWMe9Iokz0xI0W/pOoDq2tyqoSo/gHu2oRmv?= =?us-ascii?Q?XkqagoviWj0O2pTWyuA1jHmV6AEVW7yBRYmEFJk7cNjXBpb0zsElLND1E3BF?= =?us-ascii?Q?IYD2qcDAfYFzdX/1JuUBQf1dOc1kO5kvVzH00Y4oSk5PzqS2j0ukXKxQCMKk?= =?us-ascii?Q?zcPw/wyBQAa/XhmV29Hs/d02HFJznpKPqdMY9o6Q?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84838f14-e059-4243-a0b6-08dda1f6e832 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2025 16:59:58.7191 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pehExhmKySsHUt9A2VdfUo1X3ppqmODctVNS14C9pPLkbD3dT6avaQ7ImPBkMIvC X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8742 X-Rspam-User: X-Stat-Signature: b4ssqwhrmdky1nqcq5ymwm75ip7myara X-Rspamd-Queue-Id: 3FB0D8000A X-Rspamd-Server: rspam11 X-HE-Tag: 1748883602-76984 X-HE-Meta: U2FsdGVkX1+BbRz6FI6UYrOqR6QsW8IbjQJEX8pzZIYp0Pjqj/SzQ9TabFOHmwCe5S06m/2wq8OqWbi6Hh9G5Z5QUDLxiAdjlcSYSC6SRcM9wt3iw7/wxgMrD3UCkKQPD+tIkQ3lSwvTmR4ybu0UIDj9cq51fBZebBBnCPvjvWk4ofvRxmNgtVtkQt1o9hRUuyFppCHO0weBhXOSL4t/Nio0IBuNyxMh2OZZRPz1SReEcOcdZYW1ks0yBO9E0losNtbLPj9NFP+6IsW07o9mHVdqNeK72ysOwaDUbi7EukXg1j8zfNaWS9CNm9XIocv//RZLATuXyELThfcJ0Yjcp9ycXYaqLDhRaSb931OI4hAg472OaX5Ul9zADRfmx7w8pnpfv+uAAf84Su496dTzQg3/i0YVufpq7gLjvjsE4N380wdCF6OUcivE4wxQ0d7ih9E1tKQbc37hA8ROlc24HyGTftiHPKHByE5YafAGvitSN6ZpVQbhO67qRRMpSdPObQDLgQNPPWiYZ62b7tRVUseKgvcrhjHtZJlFDv7LkEv0HNhblMw5TSbN+V2kMkIsvxQgY4jiNrlnjOAL00DrOo/PRY0YB0WULkdW5B04Lj2w39qfiVCI8iyDjA3zfZVW81rmC+XLQRucfszC56AW7idTbrP6I6+02+5Gy5sntSER5mEFKORaz5T+qGoeLZH4D8fGGstwSzQu8Hk697tyGDv7w6kGQX6qHWSJXXWaCKk7/yG3UGOQtLqw+jyMUEOQFf3eXkKyQdw+1y7o1r6cePLbTrZ1jG1Qgkdkeis8ECv1+5Q6Y4C0jAh6msjrhi/woNYutWoISYGoalOWXEUlRXKeAzZ5jKQpJSmZfBRRHe3jKKAsfPIlDqxSKBjmoFAaYEqbuc8kI6npp9qmocDeZZZlK5nFw52klD0ODalk9fPDpSZavmkKQOAW2hOYOhIKPm5by6Z8eE4CeeVeMm3 OI/q5Zzm T/2BT66encCb2mBru8tDtdbsB7QTY8fjEP8Hy/7nCdubOAGA8c7I0uEFLC4vQNKWl/lxIcwNEd+5pbPTYx31KWCKRXKgx8UyECU+FzUt5ugkCq5vvjHuhQtKq/GM/C0U1CEn7LXz8gSqVJREDA2GQChTD5XfOs9X1OCFVt/8xLw5thqmlIOV2a+nvJt0EMnkOTdVZpaVKkMnSv98wt1HjuprP/mxaWNZWykdg2MJDDmBj3OddriS81izW0/eRueOO/3ay3dcMfY/ntO2yMbpL/BaQW00OCUWTkkxp8t2A5kDxwfAcZNU4zaXcMaC8z2k5sY2CvS7RX+iWjAChltNdsfnplW1IieNaKZW4IuTXsLGAhRp9pfJb9R5a94OQu56Vw0wr+mBd+yboWlyLeBwzKDcpnGO8DeZMf42Vq2kdtR/MFC/ArnpsaOQhv3ouOEjBNtpuv+PUsViwolHb1n4NkpbatuLLhJc/lwIUAXQTw4kB+Ic= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2 Jun 2025, at 11:18, Zi Yan wrote: > migratetype is no longer overwritten during pageblock isolation, > start_isolate_page_range(), has_unmovable_pages(), and > set_migratetype_isolate() no longer need which migratetype to restore > during isolation failure. > > For has_unmoable_pages(), it needs to know if the isolation is for CMA > allocation, so adding PB_ISOLATE_MODE_CMA_ALLOC provide the information= =2E > At the same time change isolation flags to enum pb_isolate_mode > (PB_ISOLATE_MODE_MEM_OFFLINE, PB_ISOLATE_MODE_CMA_ALLOC, > PB_ISOLATE_MODE_OTHER). Remove REPORT_FAILURE and check > PB_ISOLATE_MODE_MEM_OFFLINE, since only PB_ISOLATE_MODE_MEM_OFFLINE > reports isolation failures. > > alloc_contig_range() no longer needs migratetype. Replace it with > PB_ISOLATE_MODE_CMA_ALLOC to tell if an allocation is for CMA. So does > __alloc_contig_migrate_range(). This paragraph should be changed to: alloc_contig_range() no longer needs migratetype. Replace it with a newly defined acr_flags_t to tell if an allocation is for CMA. So does __alloc_contig_migrate_range(). Add ACR_OTHER (set to 0) to indicate other cases. > > Signed-off-by: Zi Yan > Reviewed-by: Vlastimil Babka > --- > drivers/virtio/virtio_mem.c | 4 +- > include/linux/gfp.h | 18 ++++++++- > include/linux/page-isolation.h | 7 +--- > include/trace/events/kmem.h | 14 ++++--- > mm/cma.c | 3 +- > mm/memory_hotplug.c | 6 +-- > mm/page_alloc.c | 27 ++++++------- > mm/page_isolation.c | 70 +++++++++++++++-------------------= > 8 files changed, 79 insertions(+), 70 deletions(-) > The fixup to restore acr_flags_t: =46rom d0205580ab70aaf93f3f7c04b53dc595ee387bac Mon Sep 17 00:00:00 2001 From: Zi Yan Date: Mon, 2 Jun 2025 12:53:58 -0400 Subject: [PATCH] restore acr_flags_t. Signed-off-by: Zi Yan --- drivers/virtio/virtio_mem.c | 4 ++-- include/linux/gfp.h | 21 +++++---------------- include/linux/page-isolation.h | 15 +++++++++++++++ include/trace/events/kmem.h | 12 ++++++------ mm/cma.c | 3 +-- mm/page_alloc.c | 24 ++++++++++++------------ 6 files changed, 41 insertions(+), 38 deletions(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index 535680a54ff5..6bce70b139b2 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c @@ -1243,8 +1243,8 @@ static int virtio_mem_fake_offline(struct virtio_me= m *vm, unsigned long pfn, if (atomic_read(&vm->config_changed)) return -EAGAIN; - rc =3D alloc_contig_range(pfn, pfn + nr_pages, - PB_ISOLATE_MODE_OTHER, GFP_KERNEL); + rc =3D alloc_contig_range(pfn, pfn + nr_pages, ACR_OTHER, + GFP_KERNEL); if (rc =3D=3D -ENOMEM) /* whoops, out of memory */ return rc; diff --git a/include/linux/gfp.h b/include/linux/gfp.h index 17b92888d6de..95065cec85e5 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -423,25 +423,14 @@ static inline bool gfp_compaction_allowed(gfp_t gfp= _mask) extern gfp_t vma_thp_gfp_mask(struct vm_area_struct *vma); #ifdef CONFIG_CONTIG_ALLOC -/* - * Pageblock isolation modes: - * PB_ISOLATE_MODE_MEM_OFFLINE - isolate to offline (!allocate) memory - * e.g., skip over PageHWPoison() pages and - * PageOffline() pages. Unmovable pages will be - * reported in this mode. - * PB_ISOLATE_MODE_CMA_ALLOC - isolate for CMA allocations - * PB_ISOLATE_MODE_OTHER - isolate for other purposes - */ -enum pb_isolate_mode { - PB_ISOLATE_MODE_MEM_OFFLINE, - PB_ISOLATE_MODE_CMA_ALLOC, - PB_ISOLATE_MODE_OTHER, -}; + +typedef unsigned int __bitwise acr_flags_t; +#define ACR_OTHER ((__force acr_flags_t)0) // other allocations +#define ACR_CMA ((__force acr_flags_t)BIT(0)) // allocate for CMA /* The below functions must be run on a range from a single zone. */ extern int alloc_contig_range_noprof(unsigned long start, unsigned long = end, - enum pb_isolate_mode isol_mode, - gfp_t gfp_mask); + acr_flags_t alloc_flags, gfp_t gfp_mask); #define alloc_contig_range(...) alloc_hooks(alloc_contig_range_noprof(= __VA_ARGS__)) extern struct page *alloc_contig_pages_noprof(unsigned long nr_pages, gf= p_t gfp_mask, diff --git a/include/linux/page-isolation.h b/include/linux/page-isolatio= n.h index 7ed60a339a02..3e2f960e166c 100644 --- a/include/linux/page-isolation.h +++ b/include/linux/page-isolation.h @@ -38,6 +38,21 @@ static inline void set_pageblock_isolate(struct page *= page) } #endif +/* + * Pageblock isolation modes: + * PB_ISOLATE_MODE_MEM_OFFLINE - isolate to offline (!allocate) memory + * e.g., skip over PageHWPoison() pages and + * PageOffline() pages. Unmovable pages will be + * reported in this mode. + * PB_ISOLATE_MODE_CMA_ALLOC - isolate for CMA allocations + * PB_ISOLATE_MODE_OTHER - isolate for other purposes + */ +enum pb_isolate_mode { + PB_ISOLATE_MODE_MEM_OFFLINE, + PB_ISOLATE_MODE_CMA_ALLOC, + PB_ISOLATE_MODE_OTHER, +}; + void __meminit init_pageblock_migratetype(struct page *page, enum migratetype migratetype, bool isolate); diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h index e0bcbc43a548..efffcf578217 100644 --- a/include/trace/events/kmem.h +++ b/include/trace/events/kmem.h @@ -312,9 +312,9 @@ TRACE_EVENT(mm_alloc_contig_migrate_range_info, unsigned long nr_migrated, unsigned long nr_reclaimed, unsigned long nr_mapped, - enum pb_isolate_mode isol_mode), + acr_flags_t alloc_flags), - TP_ARGS(start, end, nr_migrated, nr_reclaimed, nr_mapped, isol_mode), + TP_ARGS(start, end, nr_migrated, nr_reclaimed, nr_mapped, alloc_flags),= TP_STRUCT__entry( __field(unsigned long, start) @@ -322,7 +322,7 @@ TRACE_EVENT(mm_alloc_contig_migrate_range_info, __field(unsigned long, nr_migrated) __field(unsigned long, nr_reclaimed) __field(unsigned long, nr_mapped) - __field(enum pb_isolate_mode, isol_mode) + __field(acr_flags_t, alloc_flags) ), TP_fast_assign( @@ -331,13 +331,13 @@ TRACE_EVENT(mm_alloc_contig_migrate_range_info, __entry->nr_migrated =3D nr_migrated; __entry->nr_reclaimed =3D nr_reclaimed; __entry->nr_mapped =3D nr_mapped; - __entry->isol_mode =3D isol_mode; + __entry->alloc_flags =3D alloc_flags; ), - TP_printk("start=3D0x%lx end=3D0x%lx isol_mode=3D%d nr_migrated=3D%lu n= r_reclaimed=3D%lu nr_mapped=3D%lu", + TP_printk("start=3D0x%lx end=3D0x%lx alloc_flags=3D%d nr_migrated=3D%lu= nr_reclaimed=3D%lu nr_mapped=3D%lu", __entry->start, __entry->end, - __entry->isol_mode, + __entry->alloc_flags, __entry->nr_migrated, __entry->nr_reclaimed, __entry->nr_mapped) diff --git a/mm/cma.c b/mm/cma.c index 23aa35193122..9ee8fad797bc 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -822,8 +822,7 @@ static int cma_range_alloc(struct cma *cma, struct cm= a_memrange *cmr, pfn =3D cmr->base_pfn + (bitmap_no << cma->order_per_bit); mutex_lock(&cma->alloc_mutex); - ret =3D alloc_contig_range(pfn, pfn + count, - PB_ISOLATE_MODE_CMA_ALLOC, gfp); + ret =3D alloc_contig_range(pfn, pfn + count, ACR_CMA, gfp); mutex_unlock(&cma->alloc_mutex); if (ret =3D=3D 0) { page =3D pfn_to_page(pfn); diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 02a0f5621d10..c12442fdb579 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6695,12 +6695,12 @@ static void alloc_contig_dump_pages(struct list_h= ead *page_list) /* * [start, end) must belong to a single zone. - * @isol_mode: using pb_isolate_mode filter the type of migration in + * @alloc_flags: using acr_flags_t to filter the type of migration in * trace_mm_alloc_contig_migrate_range_info. */ static int __alloc_contig_migrate_range(struct compact_control *cc, unsigned long start, unsigned long end, - enum pb_isolate_mode isol_mode) + acr_flags_t alloc_flags) { /* This function is based on compact_zone() from compaction.c. */ unsigned int nr_reclaimed; @@ -6772,7 +6772,7 @@ static int __alloc_contig_migrate_range(struct comp= act_control *cc, putback_movable_pages(&cc->migratepages); } - trace_mm_alloc_contig_migrate_range_info(start, end, isol_mode, + trace_mm_alloc_contig_migrate_range_info(start, end, alloc_flags, total_migrated, total_reclaimed, total_mapped); @@ -6843,7 +6843,7 @@ static int __alloc_contig_verify_gfp_mask(gfp_t gfp= _mask, gfp_t *gfp_cc_mask) * alloc_contig_range() -- tries to allocate given range of pages * @start: start PFN to allocate * @end: one-past-the-last PFN to allocate - * @isol_mode: allocation information used for pageblock isolation + * @alloc_flags: allocation information * @gfp_mask: GFP mask. Node/zone/placement hints are ignored; only some= * action and reclaim modifiers are supported. Reclaim modifiers * control allocation behavior during compaction/migration/reclaim. @@ -6860,7 +6860,7 @@ static int __alloc_contig_verify_gfp_mask(gfp_t gfp= _mask, gfp_t *gfp_cc_mask) * need to be freed with free_contig_range(). */ int alloc_contig_range_noprof(unsigned long start, unsigned long end, - enum pb_isolate_mode isol_mode, gfp_t gfp_mask) + acr_flags_t alloc_flags, gfp_t gfp_mask) { unsigned long outer_start, outer_end; int ret =3D 0; @@ -6875,9 +6875,9 @@ int alloc_contig_range_noprof(unsigned long start, = unsigned long end, .alloc_contig =3D true, }; INIT_LIST_HEAD(&cc.migratepages); - - if (isol_mode =3D=3D PB_ISOLATE_MODE_MEM_OFFLINE) - return -EINVAL; + enum pb_isolate_mode mode =3D (alloc_flags & ACR_CMA) ? + PB_ISOLATE_MODE_CMA_ALLOC : + PB_ISOLATE_MODE_OTHER; gfp_mask =3D current_gfp_context(gfp_mask); if (__alloc_contig_verify_gfp_mask(gfp_mask, (gfp_t *)&cc.gfp_mask)) @@ -6904,7 +6904,7 @@ int alloc_contig_range_noprof(unsigned long start, = unsigned long end, * put back to page allocator so that buddy can use them. */ - ret =3D start_isolate_page_range(start, end, isol_mode); + ret =3D start_isolate_page_range(start, end, mode); if (ret) goto done; @@ -6920,7 +6920,7 @@ int alloc_contig_range_noprof(unsigned long start, = unsigned long end, * allocated. So, if we fall through be sure to clear ret so that * -EBUSY is not accidentally used or returned to caller. */ - ret =3D __alloc_contig_migrate_range(&cc, start, end, isol_mode); + ret =3D __alloc_contig_migrate_range(&cc, start, end, alloc_flags); if (ret && ret !=3D -EBUSY) goto done; @@ -6954,7 +6954,7 @@ int alloc_contig_range_noprof(unsigned long start, = unsigned long end, outer_start =3D find_large_buddy(start); /* Make sure the range is really isolated. */ - if (test_pages_isolated(outer_start, end, isol_mode)) { + if (test_pages_isolated(outer_start, end, mode)) { ret =3D -EBUSY; goto done; } @@ -6997,7 +6997,7 @@ static int __alloc_contig_pages(unsigned long start= _pfn, { unsigned long end_pfn =3D start_pfn + nr_pages; - return alloc_contig_range_noprof(start_pfn, end_pfn, PB_ISOLATE_MODE_OT= HER, + return alloc_contig_range_noprof(start_pfn, end_pfn, ACR_OTHER, gfp_mask); } -- = 2.47.2 Best Regards, Yan, Zi